)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"58a1a1fe083979ae12d512785d499b0be255ebf9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if [ \"$DEVSTACK_GATE_VIRT_DRIVER\" \u003d\u003d \"ironic\" ]; then"},{"line_number":116,"context_line":"        echo \"VIRT_DRIVER\u003dironic\" \u003e\u003elocalrc"},{"line_number":117,"context_line":"        echo \"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue\" \u003e\u003elocalrc"},{"line_number":118,"context_line":"        echo \"IRONIC_VM_LOG_DIR\u003d$BASE/$LOCALRC_OLDNEW/ironic-bm-logs\" \u003e\u003elocalrc"},{"line_number":119,"context_line":"        echo \"DEFAULT_INSTANCE_TYPE\u003dbaremetal\" \u003e\u003elocalrc"},{"line_number":120,"context_line":"    fi"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7adec928_e836e302","line":118,"updated":"2014-05-08 14:05:12.000000000","message":"there isn\u0027t good default in devstack for this?","commit_id":"85032b222e948ca1e7d5644a919c7ded3b29fb69"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"1f0bca3f50d7112cb1b417ee32751ef4369c5aa7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if [ \"$DEVSTACK_GATE_VIRT_DRIVER\" \u003d\u003d \"ironic\" ]; then"},{"line_number":116,"context_line":"        echo \"VIRT_DRIVER\u003dironic\" \u003e\u003elocalrc"},{"line_number":117,"context_line":"        echo \"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue\" \u003e\u003elocalrc"},{"line_number":118,"context_line":"        echo \"IRONIC_VM_LOG_DIR\u003d$BASE/$LOCALRC_OLDNEW/ironic-bm-logs\" \u003e\u003elocalrc"},{"line_number":119,"context_line":"        echo \"DEFAULT_INSTANCE_TYPE\u003dbaremetal\" \u003e\u003elocalrc"},{"line_number":120,"context_line":"    fi"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7adec928_9f4d9075","line":118,"in_reply_to":"7adec928_e836e302","updated":"2014-05-08 18:35:54.000000000","message":"Default in devstack is $IRONIC_DATA_DIR/logs/. Happy to keep the default and have cleanup_host() check /opt/stack/data/ironic/logs/, but thought being explicit about it would be more reliable in case $DEST changed in the future.","commit_id":"85032b222e948ca1e7d5644a919c7ded3b29fb69"}],"functions.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5ec4c95b80539f622d88a5788ac772d0c6dd404a","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    # Copy Ironic nodes console logs if they exist"},{"line_number":519,"context_line":"    if [ -d $BASE/new/ironic-bm-logs ] ; then"},{"line_number":520,"context_line":"      sudo cp -r $BASE/new/ironic-bm-logs/*.log $BASE/logs"},{"line_number":521,"context_line":"    fi"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # Copy tempest config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_e52fdc86","line":520,"updated":"2014-06-17 01:37:40.000000000","message":"if these are vm logs, and not the ironic service itself, I think they should go in a dedicated subdirectory","commit_id":"56b2c347d5ae588935fdfd82eae875c44fd0b4f2"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2b525830d8266b3da834a35fc4875f2adfb3882c","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    # Copy Ironic nodes console logs if they exist"},{"line_number":519,"context_line":"    if [ -d $BASE/new/ironic-bm-logs ] ; then"},{"line_number":520,"context_line":"      sudo cp -r $BASE/new/ironic-bm-logs/*.log $BASE/logs"},{"line_number":521,"context_line":"    fi"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # Copy tempest config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_e266e0ed","line":520,"in_reply_to":"1ae5cdf2_d05d3717","updated":"2014-06-17 11:39:26.000000000","message":"If you can do the copy without the glob, I\u0027ll accept that argument. Otherwise I do really think it should be in a subdir.","commit_id":"56b2c347d5ae588935fdfd82eae875c44fd0b4f2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"679692903fe3e514cc205c7d886223dad4ada8c8","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    # Copy Ironic nodes console logs if they exist"},{"line_number":519,"context_line":"    if [ -d $BASE/new/ironic-bm-logs ] ; then"},{"line_number":520,"context_line":"      sudo cp -r $BASE/new/ironic-bm-logs/*.log $BASE/logs"},{"line_number":521,"context_line":"    fi"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # Copy tempest config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_d05d3717","line":520,"in_reply_to":"1ae5cdf2_e52fdc86","updated":"2014-06-17 05:54:14.000000000","message":"it is indeed the log of the VM which Ironic is managing, not logs from the service. However, rhere is only one log file per VM, regardless of the number of instances / deploys tested on that VM, and devstack is only preparing one VM for Ironic to use today.\n\nI don\u0027t really see a reason to put a single file in a separate log dir. At some point in the future we might test parallel deployments... to maybe two or three nodes at once. Either way, premature optimization like this often leads to cruft, so I\u0027m going to suggest leaving this in the common log dir until such time as ironic generates more than one such log file.","commit_id":"56b2c347d5ae588935fdfd82eae875c44fd0b4f2"}]}