)]}'
{"functions.sh":[{"author":{"_account_id":6609,"name":"Elizabeth K. Joseph","email":"lyz@princessleia.com","username":"lyz"},"change_message_id":"1b1e67a478f3191b14e62a37e9179cd8015fb671","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    sudo mv $BASE/logs/rabbitmq/startup_log \\"},{"line_number":481,"context_line":"       $BASE/logs/rabbitmq/startup_log.txt"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    # Remove duplicate logs"},{"line_number":484,"context_line":"    sudo rm $BASE/logs/*.*.txt"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    if [ -d $BASE/old ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_ab780af3","side":"PARENT","line":483,"updated":"2014-05-13 20:17:38.000000000","message":"Do we want to keep this comment?","commit_id":"299ce250a1cd58d3fea6b96aafff3be590a4daeb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"166a14ab23cfd2bee4643f029ade18ff19ae39c9","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    sudo mv $BASE/logs/rabbitmq/startup_log \\"},{"line_number":481,"context_line":"       $BASE/logs/rabbitmq/startup_log.txt"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    # Remove duplicate logs"},{"line_number":484,"context_line":"    sudo rm $BASE/logs/*.*.txt"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    if [ -d $BASE/old ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_0f50875d","side":"PARENT","line":483,"in_reply_to":"7adec928_ab780af3","updated":"2014-05-21 04:45:14.000000000","message":"I think we can get rid of duplicates but in another change","commit_id":"299ce250a1cd58d3fea6b96aafff3be590a4daeb"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ed7c28aa6374703b2b1e9de592cae4785cce65fc","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    # copy all log files, but note that devstack creates a shortened"},{"line_number":424,"context_line":"    # symlink without timestamp (foo.log -\u003e foo.2014-01-01-000000.log)"},{"line_number":425,"context_line":"    # for each log to latest log.  Thus we just copy the symlinks to"},{"line_number":426,"context_line":"    # avoid excessively long file-names."},{"line_number":427,"context_line":"    find $BASE/new/screen-logs -type l -print0 | \\"},{"line_number":428,"context_line":"        xargs -0 -I {} sudo cp {} $NEWLOGTARGET"},{"line_number":429,"context_line":"    sudo cp $BASE/new/devstacklog.txt $NEWLOGTARGET/"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_bf10be4e","line":426,"updated":"2014-05-20 10:54:09.000000000","message":"I\u0027d rather leave this change out of the rename patch","commit_id":"82458b49e6194ee4977ff4886bc1b2b43ce64135"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"166a14ab23cfd2bee4643f029ade18ff19ae39c9","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    # copy all log files, but note that devstack creates a shortened"},{"line_number":424,"context_line":"    # symlink without timestamp (foo.log -\u003e foo.2014-01-01-000000.log)"},{"line_number":425,"context_line":"    # for each log to latest log.  Thus we just copy the symlinks to"},{"line_number":426,"context_line":"    # avoid excessively long file-names."},{"line_number":427,"context_line":"    find $BASE/new/screen-logs -type l -print0 | \\"},{"line_number":428,"context_line":"        xargs -0 -I {} sudo cp {} $NEWLOGTARGET"},{"line_number":429,"context_line":"    sudo cp $BASE/new/devstacklog.txt $NEWLOGTARGET/"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_6c5f5976","line":426,"in_reply_to":"7adec928_bf10be4e","updated":"2014-05-21 04:45:14.000000000","message":"Done","commit_id":"82458b49e6194ee4977ff4886bc1b2b43ce64135"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ed7c28aa6374703b2b1e9de592cae4785cce65fc","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    sudo chown -R jenkins:jenkins $BASE/logs/"},{"line_number":479,"context_line":"    sudo chmod a+r $BASE/logs/"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    # rename all .log files to .txt for indexing"},{"line_number":482,"context_line":"    for file in $(find $BASE/logs/* -type f -name \"*.log\")"},{"line_number":483,"context_line":"    do"},{"line_number":484,"context_line":"        sudo mv ${file} ${file/.log/.txt}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_bf37dee1","line":481,"updated":"2014-05-20 10:54:09.000000000","message":"can we pull rename into a function? I\u0027d rather not put the for loops inline if possible.","commit_id":"82458b49e6194ee4977ff4886bc1b2b43ce64135"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"166a14ab23cfd2bee4643f029ade18ff19ae39c9","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    sudo chown -R jenkins:jenkins $BASE/logs/"},{"line_number":479,"context_line":"    sudo chmod a+r $BASE/logs/"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    # rename all .log files to .txt for indexing"},{"line_number":482,"context_line":"    for file in $(find $BASE/logs/* -type f -name \"*.log\")"},{"line_number":483,"context_line":"    do"},{"line_number":484,"context_line":"        sudo mv ${file} ${file/.log/.txt}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7adec928_ec00c937","line":481,"in_reply_to":"7adec928_bf37dee1","updated":"2014-05-21 04:45:14.000000000","message":"I found this becomes a mess.  Note the renames below are different with the bash replacement; you end up trying to pass this in as a argument and to my mind it is confusing for no reason.  also it\u0027s closer to what people are probably expecting as it\u0027s in the bash faq for renaming (http://mywiki.wooledge.org/BashFAQ/030).\n\nbut I had another read through this and i think the next review will make things clearer","commit_id":"82458b49e6194ee4977ff4886bc1b2b43ce64135"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cc26ef86ce6863a28c8658daed44b7a0f686367b","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    # firstly, rename all .log files to .txt files"},{"line_number":494,"context_line":"    for f in $(find $BASE/logs -name \"*.log\"); do"},{"line_number":495,"context_line":"        sudo mv $f ${f/.log/.txt}"},{"line_number":496,"context_line":"    done"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    # append .txt to all config files"},{"line_number":499,"context_line":"    # (there are some /etc/swift .builder and .ring files that get"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7adec928_e9fd0270","line":496,"updated":"2014-05-21 18:07:11.000000000","message":"Slightly worried that this for loop won\u0027t handle log files with whitespace in their names. In practice I don\u0027t think this is an actual problem and this is a handy way to do the rename.","commit_id":"6f038452f4a7e628c7da5295c609cb3b8cc613d0"}]}