)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3e75a112296cf97f91bb77526a5784c495bc7ea0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# Most of the work of this script is done in functions so that we may"},{"line_number":23,"context_line":"# easily redirect their stdout / stderr to log files."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"GIT_BASE\u003d${GIT_BASE:-https://git.openstack.org}"},{"line_number":26,"context_line":"GIT_BRANCH\u003d${GIT_BRANCH:-master}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"source $WORKSPACE/devstack-gate/functions.sh"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_34199dd7","line":25,"updated":"2015-02-04 19:13:01.000000000","message":"this seems reasonable","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3e75a112296cf97f91bb77526a5784c495bc7ea0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# easily redirect their stdout / stderr to log files."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"GIT_BASE\u003d${GIT_BASE:-https://git.openstack.org}"},{"line_number":26,"context_line":"GIT_BRANCH\u003d${GIT_BRANCH:-master}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"source $WORKSPACE/devstack-gate/functions.sh"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_540a9179","line":26,"updated":"2015-02-04 19:13:01.000000000","message":"i think this will require far too much complexity to be mantainable","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8dbac1782b7e8229d8a45f86890e615b529591b4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# easily redirect their stdout / stderr to log files."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"GIT_BASE\u003d${GIT_BASE:-https://git.openstack.org}"},{"line_number":26,"context_line":"GIT_BRANCH\u003d${GIT_BRANCH:-master}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"source $WORKSPACE/devstack-gate/functions.sh"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_284cda9d","line":26,"in_reply_to":"da86d52c_540a9179","updated":"2015-02-04 21:08:40.000000000","message":"Can you elaborate on that?","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3e75a112296cf97f91bb77526a5784c495bc7ea0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # Since we\u0027re early in the script, we need to update the d-g"},{"line_number":111,"context_line":"        # copy in the workspace, not $DEST, which is what will be"},{"line_number":112,"context_line":"        # updated later."},{"line_number":113,"context_line":"        setup_project openstack-infra/devstack-gate $GIT_BRANCH"},{"line_number":114,"context_line":"        cd $WORKSPACE"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        re_exec_devstack_gate"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_740f9588","line":113,"updated":"2015-02-04 19:13:01.000000000","message":"devstack-gate has no other branches","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8dbac1782b7e8229d8a45f86890e615b529591b4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # Since we\u0027re early in the script, we need to update the d-g"},{"line_number":111,"context_line":"        # copy in the workspace, not $DEST, which is what will be"},{"line_number":112,"context_line":"        # updated later."},{"line_number":113,"context_line":"        setup_project openstack-infra/devstack-gate $GIT_BRANCH"},{"line_number":114,"context_line":"        cd $WORKSPACE"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        re_exec_devstack_gate"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_4306511e","line":113,"in_reply_to":"da86d52c_740f9588","updated":"2015-02-04 21:08:40.000000000","message":"Indeed. The purpose of GIT_BRANCH is to support a system where the development branch is not called master, but for instance, my_master. At HP to keep an up-to-date copy of OpenStack master branch in our internal master branch of each repo. master is readonly, and my_master is used for development. We run our dsvm tests using d-g from my_master only.","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"8469892a05cc219af00f63ed43e7d1ee458229c0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""},{"line_number":219,"context_line":"    else # master"},{"line_number":220,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/icehouse\""},{"line_number":221,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"$GIT_BRANCH\""},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"    if [ \"$DEVSTACK_GATE_GRENADE_PARTIAL_NCPU\" -eq \"1\" ]; then"},{"line_number":224,"context_line":"        export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba7be1f8_3667bd4e","line":221,"updated":"2015-02-25 19:57:28.000000000","message":"Do you test upgrades from stable/icehouse to my_master?  Why not my_stable/icehouse to my_master?  Even if HP does the first thing and that works in that case, why not support the other if this is really about genericising things?\n\nIt seems that what we really need to do is pull this logic out of code and into configuration.  Perhaps we need a program like test-matrix.py (perhaps that program itself, or just another one like it) that can read a mapping of grenade base branch names and produce old/new branch names as output.  Then this long if statement can collapse into an invocation of that program, OpenStack can have one config file, and HP can use a local config file with its branch names.","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3e75a112296cf97f91bb77526a5784c495bc7ea0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""},{"line_number":219,"context_line":"    else # master"},{"line_number":220,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/icehouse\""},{"line_number":221,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"$GIT_BRANCH\""},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"    if [ \"$DEVSTACK_GATE_GRENADE_PARTIAL_NCPU\" -eq \"1\" ]; then"},{"line_number":224,"context_line":"        export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_9427a911","line":221,"updated":"2015-02-04 19:13:01.000000000","message":"I don\u0027t see how this is going to do what you intend.  If you can\u0027t use \u0027master\u0027 with grenade, how will you be able to use \u0027stable/icehouse\u0027.  This would need to become unmaintainably complex.","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8298d1607af9d8d46198952e1376ad68504f649e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""},{"line_number":219,"context_line":"    else # master"},{"line_number":220,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/icehouse\""},{"line_number":221,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"$GIT_BRANCH\""},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"    if [ \"$DEVSTACK_GATE_GRENADE_PARTIAL_NCPU\" -eq \"1\" ]; then"},{"line_number":224,"context_line":"        export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba7be1f8_d154abcb","line":221,"in_reply_to":"ba7be1f8_3667bd4e","updated":"2015-02-25 20:13:02.000000000","message":"We do use a customized features.yaml internally, and I find very useful the fact that the configuration is condensed in one configuration file.\n\nWe could use the list of supported stable branches from features.yaml, and to have a python script building GRENADE_*_BRANCH variables.","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"8dbac1782b7e8229d8a45f86890e615b529591b4","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""},{"line_number":219,"context_line":"    else # master"},{"line_number":220,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/icehouse\""},{"line_number":221,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"$GIT_BRANCH\""},{"line_number":222,"context_line":"    fi"},{"line_number":223,"context_line":"    if [ \"$DEVSTACK_GATE_GRENADE_PARTIAL_NCPU\" -eq \"1\" ]; then"},{"line_number":224,"context_line":"        export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_432d7194","line":221,"in_reply_to":"da86d52c_9427a911","updated":"2015-02-04 21:08:40.000000000","message":"Again, this is only about generalizing the name of the development branch.","commit_id":"537a2926745a2acbacfa682295f06fa44c42716a"}]}