)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f139bc42a62300a6f068c5c9e773c4823fde81e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc4a7b30_baaa7e25","updated":"2026-08-21 12:28:12.000000000","message":"Hey @gouthampravi@gmail.com thanks for doing this. I was planning to help but I\u0027m glad you had the opportunity to provide the fix for the cephfs use case.\nOverall the patch looks good to me, and I like the fact we can have a parameter to pass the application.\nI have a few nits that are just very small implementation details, but if you like this version I\u0027m ok with it.","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"}],"devstack/lib/cephadm":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f139bc42a62300a6f068c5c9e773c4823fde81e3","unresolved":true,"context_lines":[{"line_number":425,"context_line":"    local MODE\u003d$2"},{"line_number":426,"context_line":"    # Application to enable on each pool: \"rbd\" for RBD-backed services"},{"line_number":427,"context_line":"    # (Cinder, Glance, Nova) or \"cephfs\" for CephFS data pools (Manila)."},{"line_number":428,"context_line":"    local APP\u003d$3"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    [ \"${#POOLS[@]}\" -eq 0 ] \u0026\u0026 return;"},{"line_number":431,"context_line":"    # return if mode is not valid (only replicated and erasure are supported)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a829ea4_f002f255","line":428,"updated":"2026-08-21 12:28:12.000000000","message":"nit, maybe we can use \"application\" as variable name? (not blocking of course)\n\nWondering if this could be local APP\u003d{$3:-rbd}, so we can keep backward compatibility without changing anything here and it will only takes effect if we pass `cephfs` as application to `add_pools`","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f139bc42a62300a6f068c5c9e773c4823fde81e3","unresolved":true,"context_lines":[{"line_number":431,"context_line":"    # return if mode is not valid (only replicated and erasure are supported)"},{"line_number":432,"context_line":"    [ \"$MODE\" \u003d \"replicated\" ] || [ \"$MODE\" \u003d \"erasure\" ] || return"},{"line_number":433,"context_line":"    # the caller must state which application the pools serve"},{"line_number":434,"context_line":"    [ -n \"$APP\" ] || return"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    if [ \"$MODE\" \u003d \"erasure\" ]; then"},{"line_number":437,"context_line":"        _ensure_ec_profile"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4ed8454f_172dcf8b","line":434,"updated":"2026-08-21 12:28:12.000000000","message":"depending on my previous comment this might not be required","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f139bc42a62300a6f068c5c9e773c4823fde81e3","unresolved":true,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"},{"line_number":1048,"context_line":"        add_pools POOLS_REPLICATED \"replicated\" \"rbd\""},{"line_number":1049,"context_line":"        add_pools POOLS_EC \"erasure\" \"rbd\""},{"line_number":1050,"context_line":"        add_pools POOLS_EC_CEPHFS \"erasure\" \"cephfs\""},{"line_number":1051,"context_line":"        create_keys"},{"line_number":1052,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"61b222dd_a71a574b","line":1049,"updated":"2026-08-21 12:28:12.000000000","message":"if we `default` to rbd via `local application\u003d${$3:-\"rbd\"} we don\u0027t need to explicity pass rbd as it would be the default.","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9e4cd412de21251f02a997b3ef7c2d6e5921cbf","unresolved":true,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"},{"line_number":1048,"context_line":"        add_pools POOLS_REPLICATED \"replicated\" \"rbd\""},{"line_number":1049,"context_line":"        add_pools POOLS_EC \"erasure\" \"rbd\""},{"line_number":1050,"context_line":"        add_pools POOLS_EC_CEPHFS \"erasure\" \"cephfs\""},{"line_number":1051,"context_line":"        create_keys"},{"line_number":1052,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dc988679_19c1d41f","line":1049,"in_reply_to":"61b222dd_a71a574b","updated":"2026-08-21 17:07:19.000000000","message":"explicit is better than implicit, no? :) \n\nI did think of that initially, and then i thought - what\u0027s the big deal, let\u0027s be declarative of what these pools will be used for here.","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b9fad51120f47b01ce53e615b0e0e9799ad7f4fe","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"},{"line_number":1048,"context_line":"        add_pools POOLS_REPLICATED \"replicated\" \"rbd\""},{"line_number":1049,"context_line":"        add_pools POOLS_EC \"erasure\" \"rbd\""},{"line_number":1050,"context_line":"        add_pools POOLS_EC_CEPHFS \"erasure\" \"cephfs\""},{"line_number":1051,"context_line":"        create_keys"},{"line_number":1052,"context_line":"    fi"},{"line_number":1053,"context_line":"    enable_services"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"afeb8fe9_5d26989c","line":1050,"updated":"2026-08-21 12:29:24.000000000","message":"+1, in line w/ https://docs.ceph.com/en/reef/rados/operations/pools/#associating-a-pool-with-an-application","commit_id":"c8ff0c7676e3fe28fbdc61935541a7174389ada9"}]}