)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~1016614","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Ie1bbedd4d143c416671e067ac90252301a38cdca","project":"openstack/devstack-plugin-ceph","branch":"master","hashtags":[],"change_id":"Ie1bbedd4d143c416671e067ac90252301a38cdca","subject":"Allow opting out of rbd_default_data_pool for Cinder","status":"NEW","created":"2026-11-20 06:18:47.000000000","updated":"2026-11-20 08:58:12.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c631d3f59aab39651978f59598f720c33084cfe5","_number":1016614,"virtual_id_number":1016614,"owner":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-11-20 08:58:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-20 08:58:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"630e700e4601e4281fbc897397e8eeca957822b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2026-11-20 06:18:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"694e97f8b16730167227ebe8ff98cb051382fff2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2026-11-20 06:28:59.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e7eed03ccb7ba57cd5dc69334e4af1f6b349cc1f","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2026-11-20 06:31:23.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c631d3f59aab39651978f59598f720c33084cfe5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-20 08:58:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/771d290d9836452e974f645934083d8c\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/70575fcbdb2642128a53430a6ee7c378 : SUCCESS in 1h 24m 30s\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/083aad5778ec4a878af17d02f029d2be : SUCCESS in 1h 47m 39s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/17bd761e197344faa76f51ae835150e7 : SUCCESS in 28m 24s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f1a29f6e06ee47bdbbfaa5f1b07d3bda : SUCCESS in 45m 23s\n- devstack-plugin-ceph-multinode-cephfs-nfs-cephadm https://zuul.opendev.org/t/openstack/build/e7c6571755a742fab1663d9d3958ed59 : FAILURE in 2h 26m 37s (non-voting)\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/5cbace83115149dc9dd45f9469e005dd : FAILURE in 18m 40s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs-standalone https://zuul.opendev.org/t/openstack/build/46b7ecdca5914296a2a4268149dc9bc7 : FAILURE in 1h 00m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b27275a84b74ee2b92fd452f35db4c0 : SUCCESS in 3m 06s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/de9d86fae7d94936a900b2d75c8a7f53 : SUCCESS in 2m 31s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c0a94bb1aa373917787520de2d6102f9c638b7e3","revisions":{"c9e8cda19ee84d553adbce0fc9574da0836f4b85":{"kind":"REWORK","_number":1,"created":"2026-11-20 06:18:47.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/14/1016614/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/14/1016614/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/1"}}},"commit":{"parents":[{"commit":"599852f10f0d47e0a568a1da652099e25749f7b3","subject":"Set RBD EC data pool defaults for services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/599852f10f0d47e0a568a1da652099e25749f7b3"}]}],"author":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2026-11-16 05:35:44.000000000","tz":330},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2026-11-20 06:18:45.000000000","tz":330},"subject":"Allow opting out of rbd_default_data_pool for Cinder","message":"Allow opting out of rbd_default_data_pool for Cinder\n\nWhen CINDER_EC_ENABLE is on, _set_ec_data_pool_defaults sets\nrbd_default_data_pool on the Cinder metadata pool. librbd then places\nimage data in the EC pool.\n\nThat is the right default for a job that just wants volume data\nin the EC pool, but it masks whether drivers rbd_data_pool\noption is doing the placement.\n\nAdd CINDER_EC_SET_POOL_DEFAULT, defaulting to True so existing jobs are\nunchanged. Set it to False to leave the pool default unset and let the\nCinder driver option do the placement rbd_data_pool option.\n\nChange-Id: Ie1bbedd4d143c416671e067ac90252301a38cdca\nSigned-off-by: Amit Uniyal \u003cauniyal@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c9e8cda19ee84d553adbce0fc9574da0836f4b85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c9e8cda19ee84d553adbce0fc9574da0836f4b85"}]},"branch":"refs/heads/master"},"c0a94bb1aa373917787520de2d6102f9c638b7e3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-11-20 06:28:59.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/14/1016614/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/14/1016614/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/14/1016614/2"}}},"commit":{"parents":[{"commit":"599852f10f0d47e0a568a1da652099e25749f7b3","subject":"Set RBD EC data pool defaults for services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/599852f10f0d47e0a568a1da652099e25749f7b3"}]}],"author":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2026-11-16 05:35:44.000000000","tz":330},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2026-11-20 06:27:50.000000000","tz":330},"subject":"Allow opting out of rbd_default_data_pool for Cinder","message":"Allow opting out of rbd_default_data_pool for Cinder\n\nWhen CINDER_EC_ENABLE is on, _set_ec_data_pool_defaults sets\nrbd_default_data_pool on the Cinder metadata pool. librbd then places\nimage data in the EC pool.\n\nThat is the right default for a job that just wants volume data\nin the EC pool, but it masks whether drivers rbd_data_pool\noption is doing the placement.\n\nAdd CINDER_EC_SET_POOL_DEFAULT, defaulting to True so existing jobs are\nunchanged. Set it to False to leave the pool default unset and let the\nCinder\u0027s driver option do the placement.\n\nCinder job cinder-plugin-ceph-tempest-datapool needs this, without it\nthe job passes whether or not driver passes data-pool\n\nChange-Id: Ie1bbedd4d143c416671e067ac90252301a38cdca\nSigned-off-by: Amit Uniyal \u003cauniyal@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c0a94bb1aa373917787520de2d6102f9c638b7e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c0a94bb1aa373917787520de2d6102f9c638b7e3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
