)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"42004fa27bf34e9476dbb9b7d66f2c453f34b5e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Ceph versions \u003e\u003d 9.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the devstack ceph plugin frequently uses installation,"},{"line_number":10,"context_line":"configuration, startup, and shutdown commands that do not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_0e4e046f","line":7,"updated":"2016-06-22 17:28:00.000000000","message":"9.2?","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0caa967a2b23a1b79f3dcdb136561ea655938f4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Ceph versions \u003e\u003d 9.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the devstack ceph plugin frequently uses installation,"},{"line_number":10,"context_line":"configuration, startup, and shutdown commands that do not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_993f9c86","line":7,"in_reply_to":"3aaa91ec_0e4e046f","updated":"2016-06-23 16:46:12.000000000","message":"You guys tell me as I am confused.  On the one hand there are some pre-existing checks in the code for \u003e\u003d 9.2 (and I\u0027ve mimiced these).  On the other hand, I read http://docs.ceph.com/docs/master/release-notes/#upgrading-from-hammer as indicating that the change to run by default as ceph-user rather than as root is post-hammer, i.e. \u003e\u003d 9.4.\n\nI guess it would still work to chown to ceph as of \u003e\u003d9.2 b/c root could work with ceph-owned files anyways.\n\nSo I agree that I should reconcile the commit message and the version test but I\u0027ll rely on you ceph deveopers to tell me exactly what the cutoff point is.","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"eb5a2790e08128f1be176d1a9a40780fa31e36d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Ceph versions \u003e\u003d 9.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the devstack ceph plugin frequently uses installation,"},{"line_number":10,"context_line":"configuration, startup, and shutdown commands that do not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_e841a8aa","line":7,"in_reply_to":"3aaa91ec_88e0e4fb","updated":"2016-06-23 18:24:07.000000000","message":"That was dumb, but I guess it\u0027s not the first time I\u0027ve been off by an order of magnitude!\n\nThanks for your patience and for explaining.","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"024fa62eae68b1b5d4f466da5db91a4b2cab7f4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 07:24:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Ceph versions \u003e\u003d 9.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the devstack ceph plugin frequently uses installation,"},{"line_number":10,"context_line":"configuration, startup, and shutdown commands that do not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_88e0e4fb","line":7,"in_reply_to":"3aaa91ec_993f9c86","updated":"2016-06-23 18:19:06.000000000","message":"Hammer is 0.94 and not 9.4.\nPost-Hammer releases are Infernalis, Jewel, Kraken, ...\nThe numbering jumped from 0.94(Hammer) to 9.2 (Infernalis, the first post Hammer release). I guess this is what confused you?\n\nAnd as per here, http://docs.ceph.com/docs/master/release-notes/#id1809\n\"MAJOR CHANGES FROM HAMMER\nGeneral:\nCeph daemons are now managed via systemd (with the exception of Ubuntu Trusty, which still uses upstart).\nCeph daemons run as ‘ceph’ user instead root.\nOn Red Hat distros, there is also an SELinux policy.\"","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"}],"devstack/lib/ceph":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0caa967a2b23a1b79f3dcdb136561ea655938f4c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        # the user \"ceph\" is the owner of files within the ${CEPH_DATA_DIR}."},{"line_number":308,"context_line":"        # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":309,"context_line":"        # is not yet up."},{"line_number":310,"context_line":"        if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":311,"context_line":"            sudo chown -R ceph. ${CEPH_DATA_DIR}"},{"line_number":312,"context_line":"        fi"},{"line_number":313,"context_line":"        sudo initctl emit ceph-mon id\u003d$(hostname)"},{"line_number":314,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_f9ece0f4","line":311,"range":{"start_line":310,"start_character":8,"end_line":311,"end_character":48},"updated":"2016-06-23 16:46:12.000000000","message":"Should we be chacking for \u003e\u003d 9.4 based on http://docs.ceph.com/docs/master/release-notes/#upgrading-from-hammer  ?","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"6920626ac84a23f29f6ba869926e4062e1a6c1d2","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    else"},{"line_number":315,"context_line":"        # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":316,"context_line":"        # is not yet up."},{"line_number":317,"context_line":"        if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":318,"context_line":"            sudo systemctl enable ceph-mon@$(hostname)"},{"line_number":319,"context_line":"            sudo systemctl start ceph-mon@$(hostname)"},{"line_number":320,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_76c172e4","line":317,"updated":"2016-06-22 11:41:32.000000000","message":"I think we should instead have a flag that check the init system and then does the proper start/stop sequences.\nSomething like if is_systemd then...\n\nYou can use:\ngrep -qs systemd /proc/1/comm","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0caa967a2b23a1b79f3dcdb136561ea655938f4c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    else"},{"line_number":315,"context_line":"        # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":316,"context_line":"        # is not yet up."},{"line_number":317,"context_line":"        if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":318,"context_line":"            sudo systemctl enable ceph-mon@$(hostname)"},{"line_number":319,"context_line":"            sudo systemctl start ceph-mon@$(hostname)"},{"line_number":320,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_f967c0b4","line":317,"in_reply_to":"3aaa91ec_76c172e4","updated":"2016-06-23 16:46:12.000000000","message":"Done","commit_id":"bc7cfa9ecae33e72eb36adcc4b3f442176bff839"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":294,"context_line":"EOF"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    # bootstrap the ceph monitor"},{"line_number":297,"context_line":"    # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":298,"context_line":"    # is not yet up."},{"line_number":299,"context_line":"    if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":300,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/tmp/keyring.mon.$(hostname)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_1431c605","line":297,"updated":"2016-06-23 12:38:33.000000000","message":"Not sure if this comment is useful as it refers to something we used to do (checking the version via the mon) but no one knows what we used to do :)","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":294,"context_line":"EOF"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    # bootstrap the ceph monitor"},{"line_number":297,"context_line":"    # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":298,"context_line":"    # is not yet up."},{"line_number":299,"context_line":"    if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":300,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/tmp/keyring.mon.$(hostname)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_398f882b","line":297,"in_reply_to":"3aaa91ec_1431c605","updated":"2016-06-23 21:25:24.000000000","message":"Happy to remove it :-)  I think I\u0027ll always just test with cli rather than mon unless there\u0027s a compelling reason to sometimes do the latter.","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"5442c0f7fcefcc13f04174795b6fa01a559bd981","unresolved":false,"context_lines":[{"line_number":294,"context_line":"EOF"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    # bootstrap the ceph monitor"},{"line_number":297,"context_line":"    # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":298,"context_line":"    # is not yet up."},{"line_number":299,"context_line":"    if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":300,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/tmp/keyring.mon.$(hostname)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_9c978a39","line":297,"in_reply_to":"3aaa91ec_1431c605","updated":"2016-06-23 17:04:49.000000000","message":"Yes, I don\u0027t think it\u0027s necessary to check for the Ceph CLI version initially and MON version later (done in line 369) once the MON is up . They wouldn\u0027t differ when the Ceph cluster is running locally as the plugin installs Ceph packages of the same version. Maybe we can just check for the Ceph CLI version everywhere?","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":298,"context_line":"    # is not yet up."},{"line_number":299,"context_line":"    if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":300,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/tmp/keyring.mon.$(hostname)"},{"line_number":301,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/mon/ceph-$(hostname)"},{"line_number":302,"context_line":"        sudo ceph-mon -c ${CEPH_CONF_FILE} --setuser ceph --setgroup ceph \\"},{"line_number":303,"context_line":"            --mkfs -i $(hostname) \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_f4023a0a","line":300,"updated":"2016-06-23 12:38:33.000000000","message":"perhaps you can use \"ceph.\" instead of ceph:ceph?","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":298,"context_line":"    # is not yet up."},{"line_number":299,"context_line":"    if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":300,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/tmp/keyring.mon.$(hostname)"},{"line_number":301,"context_line":"        sudo chown ceph:ceph ${CEPH_DATA_DIR}/mon/ceph-$(hostname)"},{"line_number":302,"context_line":"        sudo ceph-mon -c ${CEPH_CONF_FILE} --setuser ceph --setgroup ceph \\"},{"line_number":303,"context_line":"            --mkfs -i $(hostname) \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_39e4a8df","line":300,"in_reply_to":"3aaa91ec_f4023a0a","updated":"2016-06-23 21:25:24.000000000","message":"Sure.","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        OSD_ID\u003d$(sudo ceph -c ${CEPH_CONF_FILE} osd create)"},{"line_number":369,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":370,"context_line":"            sudo mkdir -p ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"},{"line_number":371,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"},{"line_number":372,"context_line":"            sudo ceph-osd -c ${CEPH_CONF_FILE} --setuser ceph --setgroup ceph -i ${OSD_ID} --mkfs"},{"line_number":373,"context_line":"        else"},{"line_number":374,"context_line":"            sudo mkdir -p ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_8fa6430e","line":371,"updated":"2016-06-23 12:38:33.000000000","message":"ditto","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        OSD_ID\u003d$(sudo ceph -c ${CEPH_CONF_FILE} osd create)"},{"line_number":369,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":370,"context_line":"            sudo mkdir -p ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"},{"line_number":371,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"},{"line_number":372,"context_line":"            sudo ceph-osd -c ${CEPH_CONF_FILE} --setuser ceph --setgroup ceph -i ${OSD_ID} --mkfs"},{"line_number":373,"context_line":"        else"},{"line_number":374,"context_line":"            sudo mkdir -p ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_7901106a","line":371,"in_reply_to":"3aaa91ec_8fa6430e","updated":"2016-06-23 21:25:24.000000000","message":"Done","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            mon \u0027allow profile osd \u0027 osd \u0027allow *\u0027 | \\"},{"line_number":379,"context_line":"            sudo tee ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/keyring"},{"line_number":380,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":381,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/keyring"},{"line_number":382,"context_line":"        fi"},{"line_number":383,"context_line":"        # ceph\u0027s init script is parsing ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/"},{"line_number":384,"context_line":"        # and looking for a file \u0027upstart\u0027 or \u0027sysinitv\u0027"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_efb54731","line":381,"updated":"2016-06-23 12:38:33.000000000","message":"ditto","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            mon \u0027allow profile osd \u0027 osd \u0027allow *\u0027 | \\"},{"line_number":379,"context_line":"            sudo tee ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/keyring"},{"line_number":380,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":381,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/keyring"},{"line_number":382,"context_line":"        fi"},{"line_number":383,"context_line":"        # ceph\u0027s init script is parsing ${CEPH_DATA_DIR}/osd/ceph-${OSD_ID}/"},{"line_number":384,"context_line":"        # and looking for a file \u0027upstart\u0027 or \u0027sysinitv\u0027"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_d9fac474","line":381,"in_reply_to":"3aaa91ec_efb54731","updated":"2016-06-23 21:25:24.000000000","message":"Done","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        # create a MDS"},{"line_number":399,"context_line":"        sudo mkdir -p ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}"},{"line_number":400,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":401,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}"},{"line_number":402,"context_line":"        fi"},{"line_number":403,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create mds.${MDS_ID} \\"},{"line_number":404,"context_line":"            mon \u0027allow profile mds \u0027 osd \u0027allow rw\u0027 mds \u0027allow\u0027 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_0f92539e","line":401,"updated":"2016-06-23 12:38:33.000000000","message":"ditto","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        # create a MDS"},{"line_number":399,"context_line":"        sudo mkdir -p ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}"},{"line_number":400,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":401,"context_line":"            sudo chown ceph:ceph ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}"},{"line_number":402,"context_line":"        fi"},{"line_number":403,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create mds.${MDS_ID} \\"},{"line_number":404,"context_line":"            mon \u0027allow profile mds \u0027 osd \u0027allow rw\u0027 mds \u0027allow\u0027 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_b9f7f889","line":401,"in_reply_to":"3aaa91ec_0f92539e","updated":"2016-06-23 21:25:24.000000000","message":"Done","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            mon \u0027allow profile mds \u0027 osd \u0027allow rw\u0027 mds \u0027allow\u0027 \\"},{"line_number":405,"context_line":"            -o ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/keyring"},{"line_number":406,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":407,"context_line":"            sudo chown ceph:ceph /var/lib/ceph/mds/ceph-${MDS_ID}/keyring"},{"line_number":408,"context_line":"        fi"},{"line_number":409,"context_line":"        if [[ $INIT_SYSTEM \u003d\u003d \u0027upstart\u0027 ]] ; then"},{"line_number":410,"context_line":"            sudo touch ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/upstart"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_ef8c2781","line":407,"updated":"2016-06-23 12:38:33.000000000","message":"ditto","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            mon \u0027allow profile mds \u0027 osd \u0027allow rw\u0027 mds \u0027allow\u0027 \\"},{"line_number":405,"context_line":"            -o ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/keyring"},{"line_number":406,"context_line":"        if [[ $(echo $(_get_ceph_version mon) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":407,"context_line":"            sudo chown ceph:ceph /var/lib/ceph/mds/ceph-${MDS_ID}/keyring"},{"line_number":408,"context_line":"        fi"},{"line_number":409,"context_line":"        if [[ $INIT_SYSTEM \u003d\u003d \u0027upstart\u0027 ]] ; then"},{"line_number":410,"context_line":"            sudo touch ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/upstart"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_99331c62","line":407,"in_reply_to":"3aaa91ec_ef8c2781","updated":"2016-06-23 21:25:24.000000000","message":"Done","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":412,"context_line":"            sudo systemctl enable ceph-mds@${MDS_ID}"},{"line_number":413,"context_line":"            sudo systemctl start  ceph-mds@${MDS_ID}"},{"line_number":414,"context_line":"                sudo touch ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/sysvinit"},{"line_number":415,"context_line":"        fi"},{"line_number":416,"context_line":"    fi"},{"line_number":417,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_cfc5eb8e","line":414,"updated":"2016-06-23 12:38:33.000000000","message":"aren\u0027t you missing a \u0027else\u0027 for sysvinit?","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":412,"context_line":"            sudo systemctl enable ceph-mds@${MDS_ID}"},{"line_number":413,"context_line":"            sudo systemctl start  ceph-mds@${MDS_ID}"},{"line_number":414,"context_line":"                sudo touch ${CEPH_DATA_DIR}/mds/ceph-${MDS_ID}/sysvinit"},{"line_number":415,"context_line":"        fi"},{"line_number":416,"context_line":"    fi"},{"line_number":417,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_191f2cb8","line":414,"in_reply_to":"3aaa91ec_cfc5eb8e","updated":"2016-06-23 21:25:24.000000000","message":"Yes :D\n\nThanks.","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            sudo service ceph-mds-all stop \u003e /dev/null 2\u003e\u00261"},{"line_number":765,"context_line":"        fi"},{"line_number":766,"context_line":"    elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":767,"context_line":"        sudo systemctl stop ceph-mon.target"},{"line_number":768,"context_line":"        sudo systemctl stop ceph-osd.target"},{"line_number":769,"context_line":"        if is_ceph_enabled_for_service manila; then"},{"line_number":770,"context_line":"            sudo systemctl stop ceph-mds.target"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_cffa0bbd","line":767,"updated":"2016-06-23 12:38:33.000000000","message":"why not ceph-mon@$(hostname)?","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            sudo service ceph-mds-all stop \u003e /dev/null 2\u003e\u00261"},{"line_number":765,"context_line":"        fi"},{"line_number":766,"context_line":"    elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":767,"context_line":"        sudo systemctl stop ceph-mon.target"},{"line_number":768,"context_line":"        sudo systemctl stop ceph-osd.target"},{"line_number":769,"context_line":"        if is_ceph_enabled_for_service manila; then"},{"line_number":770,"context_line":"            sudo systemctl stop ceph-mds.target"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_d92764c8","line":767,"in_reply_to":"3aaa91ec_cffa0bbd","updated":"2016-06-23 21:25:24.000000000","message":"See next remark.","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"1354350c7455d0f94311d8887de4cde87dcce688","unresolved":false,"context_lines":[{"line_number":765,"context_line":"        fi"},{"line_number":766,"context_line":"    elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":767,"context_line":"        sudo systemctl stop ceph-mon.target"},{"line_number":768,"context_line":"        sudo systemctl stop ceph-osd.target"},{"line_number":769,"context_line":"        if is_ceph_enabled_for_service manila; then"},{"line_number":770,"context_line":"            sudo systemctl stop ceph-mds.target"},{"line_number":771,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_cfe84be5","line":768,"updated":"2016-06-23 12:38:33.000000000","message":"does ceph-osd.target stop all the running osds?","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a732a5f51cff1fbe52b2e7babb484b9d1a16e8a7","unresolved":false,"context_lines":[{"line_number":765,"context_line":"        fi"},{"line_number":766,"context_line":"    elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":767,"context_line":"        sudo systemctl stop ceph-mon.target"},{"line_number":768,"context_line":"        sudo systemctl stop ceph-osd.target"},{"line_number":769,"context_line":"        if is_ceph_enabled_for_service manila; then"},{"line_number":770,"context_line":"            sudo systemctl stop ceph-mds.target"},{"line_number":771,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_3c06561d","line":768,"in_reply_to":"3aaa91ec_cfe84be5","updated":"2016-06-23 21:25:24.000000000","message":"I think start and stop with the targets is supposed to work but I guess that is more fragile (relies on more systemd stuff in the application having been set up just right) than explicitly starting and stopping the mon, osds, and mds.  We don\u0027t want devstack runs to fail for the wrong, mysterious reasons so I\u0027ll be explicit.","commit_id":"5baba647e0cbef4e5b4e94f9b2b9987548893303"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e74d6c00fba10203d5df7f77315cad1f4a2df803","unresolved":false,"context_lines":[{"line_number":670,"context_line":"}"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"function install_ceph {"},{"line_number":673,"context_line":"    install_package ceph-common"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    RUN_AS\u003d$(_run_as_ceph_or_root)"},{"line_number":676,"context_line":"    echo \"ceph daemons will run as $RUN_AS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_587067dc","line":673,"updated":"2016-06-24 10:43:24.000000000","message":"you\u0027re installing hammer version (instead of jewel) of Ceph CLI for the manila-ceph setup.\n\nFrom the devstack log of the manila-ceph CI run.\n\"\"\"\n_run_as_ceph_or_root:173 :   ceph_version\u003d0.94\n_run_as_ceph_or_root:174 :   echo 0.94 \u0027\u003e\u003d\u0027 9.2\n_run_as_ceph_or_root:174 :   bc -l\n_run_as_ceph_or_root:174 :   [[ 0 \u003d\u003d 1 ]]\n_run_as_ceph_or_root:177 :   echo root\n\"\"\"\n\nMove the RUN_AS check to the end of the function. And doesn\u0027t ceph common package get installed without this explicit instruction.\n\nPlease see lines 682, 683. Make sure we install only after REPOS are setup correctly, i.e., after line 729 here.","commit_id":"23b0edff8548c04439b7fa7f298d2872f3647dbd"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"82e95ef0eaec18fbfd5a39a94b724d195c8fb061","unresolved":false,"context_lines":[{"line_number":670,"context_line":"}"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"function install_ceph {"},{"line_number":673,"context_line":"    install_package ceph-common"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    RUN_AS\u003d$(_run_as_ceph_or_root)"},{"line_number":676,"context_line":"    echo \"ceph daemons will run as $RUN_AS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_9bc3e988","line":673,"in_reply_to":"3aaa91ec_587067dc","updated":"2016-06-24 11:00:48.000000000","message":"The above line is not needed. Installing \u0027ceph\u0027 should also install \u0027ceph-common\u0027.\n\nMove the RUN_AS check after line 737, and not 729, or even better start of configure_ceph()?","commit_id":"23b0edff8548c04439b7fa7f298d2872f3647dbd"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c0700f6f2ef68137081d6718f554b56cef5a3925","unresolved":false,"context_lines":[{"line_number":670,"context_line":"}"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"function install_ceph {"},{"line_number":673,"context_line":"    install_package ceph-common"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    RUN_AS\u003d$(_run_as_ceph_or_root)"},{"line_number":676,"context_line":"    echo \"ceph daemons will run as $RUN_AS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_bb9865c1","line":673,"in_reply_to":"3aaa91ec_587067dc","updated":"2016-06-24 10:53:57.000000000","message":"Yes, I see this in the test run.\n\nThanks!","commit_id":"23b0edff8548c04439b7fa7f298d2872f3647dbd"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e190e1d15a5c87b2f08b6879f74f45669ea29294","unresolved":false,"context_lines":[{"line_number":670,"context_line":"}"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"function install_ceph {"},{"line_number":673,"context_line":"    install_package ceph-common"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    RUN_AS\u003d$(_run_as_ceph_or_root)"},{"line_number":676,"context_line":"    echo \"ceph daemons will run as $RUN_AS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_8653906a","line":673,"in_reply_to":"3aaa91ec_9bc3e988","updated":"2016-06-24 11:38:23.000000000","message":"I was thinking that I needed in the non-ubuntu case to distinguish between (1) the traditional case where we would install ceph, and then libcephfs1 if manila is enabled, and (2) the new case where we didn\u0027t want to install the whole ceph package if manila wasn\u0027t enabled since it includes libcephfs1 and ceph-mds already.  But it\u0027s probably fine to just install the whole ceph package in every case even if we don\u0027t run manila, so I can just move the RUN_AS check to the start of configure_ceph() as you suggest.","commit_id":"23b0edff8548c04439b7fa7f298d2872f3647dbd"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e190e1d15a5c87b2f08b6879f74f45669ea29294","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            # for their distro (if available) from download.ceph.com and then do"},{"line_number":724,"context_line":"            # stack.sh`"},{"line_number":725,"context_line":"            CEPH_PACKAGES\u003d\"ceph\""},{"line_number":726,"context_line":"            if is_ceph_enabled_for_service manila; then"},{"line_number":727,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} libcephfs1\""},{"line_number":728,"context_line":"            fi"},{"line_number":729,"context_line":"        fi"},{"line_number":730,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_8676f0d4","line":727,"range":{"start_line":726,"start_character":1,"end_line":727,"end_character":59},"updated":"2016-06-24 11:38:23.000000000","message":"looks like we don\u0027t need this extra step anymore since libcephfs1 is included in ceph package anyways","commit_id":"23b0edff8548c04439b7fa7f298d2872f3647dbd"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b4011ccd3f9ac701821e3d4e0e9c6c74fd0bd577","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        sudo touch \\"},{"line_number":448,"context_line":"             ${CEPH_DATA_DIR}/radosgw/ceph-radosgw.$(hostname)/{upstart,done}"},{"line_number":449,"context_line":"    elif [[ $INIT_SYSTEM \u003d\u003d \u0027systemd\u0027 ]] ; then"},{"line_number":450,"context_line":"        sudo systemctl enable ceph-radosgw.$(hostname)"},{"line_number":451,"context_line":"        sudo systemctl start ceph-radosgw.$(hostname)"},{"line_number":452,"context_line":"    else"},{"line_number":453,"context_line":"        sudo touch \\"},{"line_number":454,"context_line":"             ${CEPH_DATA_DIR}/radosgw/ceph-radosgw.$(hostname)/{sysvinit,done}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3aaa91ec_2fd42cbb","line":451,"range":{"start_line":450,"start_character":0,"end_line":451,"end_character":53},"updated":"2016-06-24 13:31:41.000000000","message":"This fails - probably should be \u0027ceph-radosgw@$(hostname) or something along that line.","commit_id":"84987f9ddf3e5a2069f83e1c6ca851e6b5c80991"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"5aedfe851d77652aa46effeecd63a8276c060396","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":299,"context_line":"        # is not yet up."},{"line_number":300,"context_line":"        if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":301,"context_line":"            sudo chown -R ceph. ${CEPH_DATA_DIR}"},{"line_number":302,"context_line":"        fi"},{"line_number":303,"context_line":"        sudo initctl emit ceph-mon id\u003d$(hostname)"},{"line_number":304,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3aaa91ec_d58cfcd8","side":"PARENT","line":301,"updated":"2016-06-30 19:17:37.000000000","message":"wondering if this \u0027chown\u0027 is needed only for upstart and sysvinit ? wouldn\u0027t the lines additions 323, 324, and 325 make this change redundant as they do for systemd? Or maybe since we do this chown -R anyway, do we need lines 323, 324, 325, i.e., the pre-changes state?","commit_id":"28ae5aeae317eebd14398227074042f523b7ed6c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8c78b3dcea579ee58af6caa541219a137e20dd59","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        # Check CLI version instead of mon daemon version as the mon daemon"},{"line_number":299,"context_line":"        # is not yet up."},{"line_number":300,"context_line":"        if [[ $(echo $(_get_ceph_version cli) \u0027\u003e\u003d\u0027 9.2 | bc -l) \u003d\u003d 1 ]]; then"},{"line_number":301,"context_line":"            sudo chown -R ceph. ${CEPH_DATA_DIR}"},{"line_number":302,"context_line":"        fi"},{"line_number":303,"context_line":"        sudo initctl emit ceph-mon id\u003d$(hostname)"},{"line_number":304,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3aaa91ec_1205ef12","side":"PARENT","line":301,"in_reply_to":"3aaa91ec_d58cfcd8","updated":"2016-06-30 23:38:07.000000000","message":"I\u0027ll study this a bit more and perhaps simplify if possible.\n\nHere my thinking is that only upstart and sysvinit are explicitly creating files to do their init setup, whereas systemd involves \u0027sudo systemctl\u0027 calls that presumably the needed without any extra commands.\n\nIf I\u0027m missing a good simplification here that you think will work, just push a new patch-set up onto this review and we\u0027ll put you on as co-author.","commit_id":"28ae5aeae317eebd14398227074042f523b7ed6c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf83dde81f783b2a29e83034c1793189844b138b","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        fi"},{"line_number":784,"context_line":"        # if mon is dead or unhealthy we won\u0027t get the list"},{"line_number":785,"context_line":"        # of osds but should continue anyways."},{"line_number":786,"context_line":"        ids\u003d$(sudo ceph -c ${CEPH_CONF_FILE} osd ls 2\u003e/dev/null --conect-timeout 5)"},{"line_number":787,"context_line":"        for id in $ids; do"},{"line_number":788,"context_line":"            sudo systemctl stop ceph-osd@$id"},{"line_number":789,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3aaa91ec_23570727","line":786,"range":{"start_line":786,"start_character":64,"end_line":786,"end_character":80},"updated":"2016-06-30 21:01:58.000000000","message":"--connect-timeout","commit_id":"a261561bc598b8126c5623fb81b1ba083e399cd1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8c78b3dcea579ee58af6caa541219a137e20dd59","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        fi"},{"line_number":784,"context_line":"        # if mon is dead or unhealthy we won\u0027t get the list"},{"line_number":785,"context_line":"        # of osds but should continue anyways."},{"line_number":786,"context_line":"        ids\u003d$(sudo ceph -c ${CEPH_CONF_FILE} osd ls 2\u003e/dev/null --conect-timeout 5)"},{"line_number":787,"context_line":"        for id in $ids; do"},{"line_number":788,"context_line":"            sudo systemctl stop ceph-osd@$id"},{"line_number":789,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3aaa91ec_f2ff83ff","line":786,"range":{"start_line":786,"start_character":64,"end_line":786,"end_character":80},"in_reply_to":"3aaa91ec_23570727","updated":"2016-06-30 23:38:07.000000000","message":"Good eye!  Thanks!","commit_id":"a261561bc598b8126c5623fb81b1ba083e399cd1"}]}