)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"afeec9775999bc512904ca41064f2c1cc962f7ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Defaults"},{"line_number":28,"context_line":"# --------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-luminous}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Deploy a Ceph demo container instead of a non-containerized version"},{"line_number":33,"context_line":"CEPH_CONTAINERIZED\u003d$(trueorfalse False CEPH_CONTAINERIZED)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_3edcc3e2","line":30,"updated":"2019-03-14 11:04:23.000000000","message":"I\u0027m not sure that we want to change this for the stable branches, maybe we need to find a way to make this more flexible.\n\nAlso, for bionic we should be installing the distro version of ceph anyway, so I think the current issue has a different cause.","commit_id":"cc6963db613d3b1b062cf8847fe8bee845d03255"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75f4d53ca00d3acd967637086b72af8a1885b852","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Defaults"},{"line_number":28,"context_line":"# --------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-luminous}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Deploy a Ceph demo container instead of a non-containerized version"},{"line_number":33,"context_line":"CEPH_CONTAINERIZED\u003d$(trueorfalse False CEPH_CONTAINERIZED)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_fb6ac87e","line":30,"in_reply_to":"5fc1f717_3edcc3e2","updated":"2019-03-14 13:49:25.000000000","message":"Hmm, I forgot this project was branchless.\n\nAnother option might be setting the variable into the devstack localrc on all nodes via the zuul job configuration? Because the job definitions are now branch specific, or should be.","commit_id":"cc6963db613d3b1b062cf8847fe8bee845d03255"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"afeec9775999bc512904ca41064f2c1cc962f7ea","unresolved":false,"context_lines":[{"line_number":130,"context_line":"# /etc/apt/sources.list.available.d/ which will include the ceph package"},{"line_number":131,"context_line":"# mirror. If this file exists we can link to it in /etc/apt/sources.list.d/"},{"line_number":132,"context_line":"# to enable it."},{"line_number":133,"context_line":"APT_REPOSITORY_FILE\u003d\"/etc/apt/sources.list.available.d/ceph-deb-hammer.list\""},{"line_number":134,"context_line":"# If the package mirror file doesn\u0027t exist, fetch from here"},{"line_number":135,"context_line":"APT_REPOSITORY_ENTRY\u003d\"\\"},{"line_number":136,"context_line":"    deb http://download.ceph.com/debian-${CEPH_RELEASE} $(lsb_release -sc) main\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_fee15b9c","line":133,"updated":"2019-03-14 11:04:23.000000000","message":"This would probably also need changing.","commit_id":"cc6963db613d3b1b062cf8847fe8bee845d03255"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"afeec9775999bc512904ca41064f2c1cc962f7ea","unresolved":false,"context_lines":[{"line_number":968,"context_line":"        elif [[ $os_CODENAME \u003d~ bionic ]]; then"},{"line_number":969,"context_line":"            # Ceph Luminous is available in Ubuntu bionic natively, no need to set up"},{"line_number":970,"context_line":"            # any additional repos"},{"line_number":971,"context_line":"            true"},{"line_number":972,"context_line":"        elif [ -f \"$APT_REPOSITORY_FILE\" ]; then"},{"line_number":973,"context_line":"            # Opt into Openstack CI provided package repo mirror"},{"line_number":974,"context_line":"            if [ -f \"/etc/apt/sources.list.d/$(basename $APT_REPOSITORY_FILE)\" ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_5e02ef3e","line":971,"updated":"2019-03-14 11:04:23.000000000","message":"But we don\u0027t apply the additional repo on bionic at all.","commit_id":"cc6963db613d3b1b062cf8847fe8bee845d03255"}]}
