)]}'
{"manila/post_test_hook.sh":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a74e1f8b47698da4bc3990455cdd5d7d5f7ae6ee","unresolved":false,"context_lines":[{"line_number":155,"context_line":"export MANILA_TEMPEST_CONCURRENCY\u003d${MANILA_TEMPEST_CONCURRENCY:-12}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"sudo -H -u $USER tempest list-plugins"},{"line_number":158,"context_line":"if [[ $ZUUL_BRANCH !\u003d \"stable/pike\" ]]; then"},{"line_number":159,"context_line":"    sudo -H -u $USER tempest run -r $MANILA_TESTS --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":160,"context_line":"else"},{"line_number":161,"context_line":"    sudo -H -u $USER tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_850f71de","line":158,"range":{"start_line":158,"start_character":6,"end_line":158,"end_character":18},"updated":"2019-03-28 13:40:47.000000000","message":"Is $ZUUL_BRANCH always defined when this script is called?\n\n(I guess so, since we do this at line 73, too...)","commit_id":"ca34ab98f83037071fd07167596800c95cb1bcd1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"755c79f3700ca94984dd8fce51d35b164768b780","unresolved":false,"context_lines":[{"line_number":155,"context_line":"export MANILA_TEMPEST_CONCURRENCY\u003d${MANILA_TEMPEST_CONCURRENCY:-12}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"sudo -H -u $USER tempest list-plugins"},{"line_number":158,"context_line":"if [[ $ZUUL_BRANCH !\u003d \"stable/pike\" ]]; then"},{"line_number":159,"context_line":"    sudo -H -u $USER tempest run -r $MANILA_TESTS --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":160,"context_line":"else"},{"line_number":161,"context_line":"    sudo -H -u $USER tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_d87d60b2","line":158,"range":{"start_line":158,"start_character":6,"end_line":158,"end_character":18},"in_reply_to":"5fc1f717_850f71de","updated":"2019-03-28 14:34:17.000000000","message":"Yeah and empirically, it works.  In branches past pike we still are running tempest via line 159 and for pike we are running it via line 161.  The latter was tested in a review mentioned in comments earlier and the former is tested in the jobs for this patch since they run on master.","commit_id":"ca34ab98f83037071fd07167596800c95cb1bcd1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc3fe77b8b7ce2ddb7e58d861f492c0374d88d03","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"sudo -H -u $USER tempest list-plugins"},{"line_number":158,"context_line":"if [[ $ZUUL_BRANCH !\u003d \"stable/pike\" ]]; then"},{"line_number":159,"context_line":"    sudo -H -u $USER tempest run -r $MANILA_TESTS --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":160,"context_line":"else"},{"line_number":161,"context_line":"    sudo -H -u $USER tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":162,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_43eb2bdb","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":91},"updated":"2020-03-19 01:12:51.000000000","message":"but what is issue on running tempest on venv. remember tempest run on system can cause upper-constarint conflcits because tempest is bracnhless and use master version with master constraint for all supported stable branches. and debugging those constarint issues is not easy, it took almost 2-3 weeks to stablize these things on stable branch while py2 drop cases. \n\nI will strongly recommend to use vnev always and all the tempest plugin can be installed in vnenv. That is what the main idea behind separating the tempest plugins from project in-tree.","commit_id":"ca34ab98f83037071fd07167596800c95cb1bcd1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc3fe77b8b7ce2ddb7e58d861f492c0374d88d03","unresolved":false,"context_lines":[{"line_number":158,"context_line":"if [[ $ZUUL_BRANCH !\u003d \"stable/pike\" ]]; then"},{"line_number":159,"context_line":"    sudo -H -u $USER tempest run -r $MANILA_TESTS --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":160,"context_line":"else"},{"line_number":161,"context_line":"    sudo -H -u $USER tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"},{"line_number":162,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_e32d7746","line":161,"range":{"start_line":161,"start_character":25,"end_line":161,"end_character":37},"updated":"2020-03-19 01:12:51.000000000","message":"this is deprecated env and can cause issues with py2 drop things[1].  let\u0027s use \u0027all\u0027 tox env\n\nsudo -H -u $USER tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY\n\n[1] https://bugs.launchpad.net/tempest/+bug/1862240","commit_id":"ca34ab98f83037071fd07167596800c95cb1bcd1"}]}