)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~655472","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Iea948bcc43315286e5c130485728152d4710bfcb","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"disable-ssh-validation","hashtags":[],"change_id":"Iea948bcc43315286e5c130485728152d4710bfcb","subject":"Disable [validation]/run_validation in tempest.conf","status":"MERGED","created":"2019-04-24 15:31:44.000000000","updated":"2019-07-03 20:17:18.000000000","submitted":"2019-07-03 20:17:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655472-1562185038478-dfe5b5ea","meta_rev_id":"fee598e91958c18c4a177915176b0d81e7984fe7","_number":655472,"virtual_id_number":655472,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2019-07-03 20:17:18.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-25 00:16:01.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":2,"date":"2019-05-28 13:18:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-07-03 20:10:39.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-04-24 17:51:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-07-03 20:09:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-07-03 20:09:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-24 17:51:28.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-05-28 13:18:52.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2019-07-03 20:09:32.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-07-03 20:10:39.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-07-03 20:17:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ca002a1c6c3c36f484229f369ce3f72149562e5e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-24 15:31:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b37ab74d7544b2dec2f9000fa66e3fbdba74aafd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 16:52:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest http://logs.openstack.org/72/655472/1/check/devstack-plugin-ceph-tempest/4b97ada/ : SUCCESS in 1h 14m 53s (non-voting)\n- devstack-plugin-ceph-tempest-py3 http://logs.openstack.org/72/655472/1/check/devstack-plugin-ceph-tempest-py3/2100c95/ : SUCCESS in 1h 11m 28s (non-voting)\n- openstack-tox-bashate http://logs.openstack.org/72/655472/1/check/openstack-tox-bashate/cdbede5/ : SUCCESS in 3m 40s\n- manila-tempest-minimal-dsvm-cephfs-native-centos-7 http://logs.openstack.org/72/655472/1/check/manila-tempest-minimal-dsvm-cephfs-native-centos-7/3974a08/ : SUCCESS in 31m 44s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs-centos-7 http://logs.openstack.org/72/655472/1/check/manila-tempest-minimal-dsvm-cephfs-nfs-centos-7/b320c0f/ : SUCCESS in 34m 19s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-native http://logs.openstack.org/72/655472/1/check/manila-tempest-minimal-dsvm-cephfs-native/72c8d27/ : SUCCESS in 28m 11s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs http://logs.openstack.org/72/655472/1/check/manila-tempest-minimal-dsvm-cephfs-nfs/9e38a0b/ : SUCCESS in 27m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"10abfa50b16f7c979fbcf571518b64f8124237b6","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-24 17:51:28.000000000","message":"Patch Set 1: Code-Review+1\n\nI was about to NACK this due to various volume tests using SSH to write and then verify the written data however AFAICT none of these appear to actually care what [validation]/run_validation is set to in tempest.conf:\n\nhttps://opendev.org/openstack/tempest/src/commit/682965e392575a3f7ce0a15e397f691eec188c3f/tempest/scenario/test_volume_migrate_attached.py#L96-L131\n\nAs a result I think this change is valid for now. I\u0027ll look into correcting this in openstack/tempest but I\u0027m not sure we want to disable these storage specific validations outright, maybe by introducing another [validation]/run_storage_validation configurable.","accounts_in_message":[],"_revision_number":1},{"id":"356dceeb0c48a3aee102c896ae65b3703f9d2b45","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-25 00:16:01.000000000","message":"Patch Set 1:\n\nWorks: http://logs.openstack.org/72/655472/1/check/devstack-plugin-ceph-tempest/4b97ada/controller/logs/tempest_conf.txt.gz\n\nhttp://logs.openstack.org/72/655472/1/check/devstack-plugin-ceph-tempest-py3/2100c95/controller/logs/tempest_conf.txt.gz","accounts_in_message":[],"_revision_number":1},{"id":"b6bb24042842c56d5a7b14b2c404b72a33473c6b","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2019-05-28 13:18:42.000000000","message":"Patch Set 1:\n\n\u003e I was about to NACK this due to various volume tests using SSH to\n \u003e write and then verify the written data however AFAICT none of these\n \u003e appear to actually care what [validation]/run_validation is set to\n \u003e in tempest.conf:\n \u003e \n \u003e https://opendev.org/openstack/tempest/src/commit/682965e392575a3f7ce0a15e397f691eec188c3f/tempest/scenario/test_volume_migrate_attached.py#L96-L131\n \u003e \n \u003e As a result I think this change is valid for now. I\u0027ll look into\n \u003e correcting this in openstack/tempest but I\u0027m not sure we want to\n \u003e disable these storage specific validations outright, maybe by\n \u003e introducing another [validation]/run_storage_validation\n \u003e configurable.\n\nYeah, run_validation check is not used in scenario tests except server basic scenario test. we added run_validation because of the ssh stability but now it is enabled by default. I am not sure we want to control the storage ssh based on config option if test objective is that only. But we can see case by case.","accounts_in_message":[],"_revision_number":1},{"id":"7f416d15f63240ca6731aa66afbc2d6b69e5e0da","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2019-05-28 13:18:52.000000000","message":"Patch Set 1: Code-Review+2\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"2d2e574ff2eb4fd6c26547f50306f8bc520c51ac","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-07-03 20:09:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f0177193d0086b8fea5539b22c7e2e8bb9edd3ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 20:09:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f8714f80d158adba5ded801786fe6d141d8c08df","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-07-03 20:10:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f8b57daa3406d6c2d556f736e5e5a2a1b12b8834","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 20:17:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3e4460a8e1d59510b28a4e8736dfb5ff78b542bb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 20:17:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-bashate http://logs.openstack.org/72/655472/1/gate/openstack-tox-bashate/c23ce37/ : SUCCESS in 2m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4a4481995303d97b5f646c6d3d008fbb3eab554e","revisions":{"4a4481995303d97b5f646c6d3d008fbb3eab554e":{"kind":"REWORK","_number":1,"created":"2019-04-24 15:31:44.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/72/655472/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/72/655472/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/72/655472/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/72/655472/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/72/655472/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/72/655472/1"}}},"commit":{"parents":[{"commit":"29510701eb2e92ffafb1627464610f284ffb462a","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/29510701eb2e92ffafb1627464610f284ffb462a"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-24 15:28:43.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-24 15:28:43.000000000","tz":-240},"subject":"Disable [validation]/run_validation in tempest.conf","message":"Disable [validation]/run_validation in tempest.conf\n\nDevstack and tempest default to enable ssh validation in\na lot of API tests which can fail intermittently:\n\n  http://status.openstack.org/elastic-recheck/#1808010\n\nAlso see bug 1802971.\n\nSince a ceph backend for storage shouldn\u0027t really have\nany impact on whether or not ssh is going to work in a\ntempest run, this change disables it in the\ndevstack-plugin-ceph-tempest jobs which should make the\njob faster and more stable.\n\nChange-Id: Iea948bcc43315286e5c130485728152d4710bfcb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/4a4481995303d97b5f646c6d3d008fbb3eab554e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/4a4481995303d97b5f646c6d3d008fbb3eab554e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}