)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"adb28528b95d9a7011f6767a954ee8d62760dfa8","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    local ceph_version"},{"line_number":462,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":463,"context_line":"    if [[ $(echo $ceph_version \u0027\u003e\u003d\u0027 11.1 | bc -l) \u003d\u003d 1 ]] ; then"},{"line_number":464,"context_line":"        sudo ceph-create-keys --cluster ceph --id $(hostname)"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    # wait for the admin key to come up"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_c19853c1","side":"PARENT","line":464,"updated":"2019-07-31 13:48:36.000000000","message":"we could keep this up to (and including) mimic then (13.x)","commit_id":"1221819b6ceec3330f9a15a8c4a194ed9a27953f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f0813b4bb0d23dfac9c885af2f5ed9139a6344ec","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    --create-keyring --gen-key -n client.admin --cap mon \u0027allow *\u0027 \\"},{"line_number":427,"context_line":"    --cap osd \u0027allow *\u0027 --cap mds \u0027allow *\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    # gen bootstrap-osd keyring, gen a client.bootstrap-osd user and add user to keyring"},{"line_number":430,"context_line":"    sudo ceph-authtool ${CEPH_DATA_DIR}/bootstrap-osd/ceph.keyring \\"},{"line_number":431,"context_line":"    --create-keyring --gen-key -n client.bootstrap-osd \\"},{"line_number":432,"context_line":"    --cap mon \u0027profile bootstrap-osd\u0027"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_2ea11647","line":429,"updated":"2019-07-31 13:32:51.000000000","message":"this should not be necessary because we download the one created by the cluster automatically down on line 480","commit_id":"2a9259ffa90f5418ac897fd6ee2fff949900b8d7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5ccda3de6ab9fe4359179b18f89eeadfbe56315a","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    --create-keyring --gen-key -n client.admin --cap mon \u0027allow *\u0027 \\"},{"line_number":427,"context_line":"    --cap osd \u0027allow *\u0027 --cap mds \u0027allow *\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    # gen bootstrap-osd keyring, gen a client.bootstrap-osd user and add user to keyring"},{"line_number":430,"context_line":"    sudo ceph-authtool ${CEPH_DATA_DIR}/bootstrap-osd/ceph.keyring \\"},{"line_number":431,"context_line":"    --create-keyring --gen-key -n client.bootstrap-osd \\"},{"line_number":432,"context_line":"    --cap mon \u0027profile bootstrap-osd\u0027"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_4e325212","line":429,"in_reply_to":"7faddb67_2ea11647","updated":"2019-07-31 13:36:52.000000000","message":"This was added for mimic. I understand nautilus creates keys automatically. Still, ceph auth get key command fails with \"Error ENOENT: failed to find client.bootstrap-mds in keyring\".","commit_id":"2a9259ffa90f5418ac897fd6ee2fff949900b8d7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9034fbb295697764a2cb417baf7b72cc4a05aba7","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Enable snapshots in CephFS."},{"line_number":834,"context_line":"    sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} mds set allow_new_snaps true \\"},{"line_number":835,"context_line":"        --yes-i-really-mean-it"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Make manila\u0027s libcephfs client a root user."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7faddb67_eb3bdacd","line":834,"updated":"2019-08-01 13:03:11.000000000","message":"Another bug, will fix in a separate patch set","commit_id":"29b44be54653739ab3be4091191ca51015d049e0"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9034fbb295697764a2cb417baf7b72cc4a05aba7","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"}"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"function setup_packages_for_manila_on_fedora_family {"},{"line_number":1117,"context_line":"    # sudo yum -y remove centos-release-ceph-jewel"},{"line_number":1118,"context_line":"    configure_repo_ceph \"yum\" \"luminous\" \"${DISTRO_TYPE}\" \"${RELEASE}\""},{"line_number":1119,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1120,"context_line":"        configure_repo_nfsganesha \"yum\" \"ceph_luminous\" \"${DISTRO_TYPE}\" \"${RELEASE}\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7faddb67_2b1ed25e","line":1117,"updated":"2019-08-01 13:03:11.000000000","message":"Another bug, will fix in a separate patch set","commit_id":"29b44be54653739ab3be4091191ca51015d049e0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"64e4d5c8ec78f84f48a372968ecf7f07d7f4b148","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    local ceph_version"},{"line_number":470,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    if [[ $(echo $ceph_version \u0027\u003e\u003d\u0027 14.0 | bc -l) \u003d\u003d 1 ]] ; then"},{"line_number":473,"context_line":"        for key in bootstrap-{mds,osd,rgw}; do"},{"line_number":474,"context_line":"            sudo ceph auth get client.$key -o ${CEPH_DATA_DIR}/$key/ceph.keyring"},{"line_number":475,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7faddb67_45d2e801","line":472,"range":{"start_line":472,"start_character":43,"end_line":472,"end_character":48},"updated":"2019-08-05 19:06:43.000000000","message":"devstack has a vercmp function, not sure why we are doing this this way.","commit_id":"cbdcb8c10adce03d32c8eb92b31ea5ffb6ab235c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9af16ecb550da21086edfb4c727ac734dda0bb7d","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    local ceph_version"},{"line_number":470,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    if [[ $(echo $ceph_version \u0027\u003e\u003d\u0027 14.0 | bc -l) \u003d\u003d 1 ]] ; then"},{"line_number":473,"context_line":"        for key in bootstrap-{mds,osd,rgw}; do"},{"line_number":474,"context_line":"            sudo ceph auth get client.$key -o ${CEPH_DATA_DIR}/$key/ceph.keyring"},{"line_number":475,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7faddb67_c5bfb85e","line":472,"range":{"start_line":472,"start_character":43,"end_line":472,"end_character":48},"in_reply_to":"7faddb67_45d2e801","updated":"2019-08-06 21:12:02.000000000","message":"I don\u0027t know either, how new is that function? Maybe we can file a bug an fix it altogether in a follow up patch?","commit_id":"cbdcb8c10adce03d32c8eb92b31ea5ffb6ab235c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"1f53fbe546489b3426c5e368bd82c204ff869223","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    local ceph_version"},{"line_number":470,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    if [[ $(echo $ceph_version \u0027\u003e\u003d\u0027 14.0 | bc -l) \u003d\u003d 1 ]] ; then"},{"line_number":473,"context_line":"        for key in bootstrap-{mds,osd,rgw}; do"},{"line_number":474,"context_line":"            sudo ceph auth get client.$key -o ${CEPH_DATA_DIR}/$key/ceph.keyring"},{"line_number":475,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7faddb67_730bee2a","line":472,"range":{"start_line":472,"start_character":43,"end_line":472,"end_character":48},"in_reply_to":"7faddb67_60f0f5fe","updated":"2019-08-08 17:04:01.000000000","message":"Let\u0027s do the vercmp fixes throughout as a followup patch.\n\nIt would be great not to do this piping through ``bc`` nonsense :)","commit_id":"cbdcb8c10adce03d32c8eb92b31ea5ffb6ab235c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d8c719ca5d0815075cdf92d63edd4ccae5f3cfb5","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    local ceph_version"},{"line_number":470,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    if [[ $(echo $ceph_version \u0027\u003e\u003d\u0027 14.0 | bc -l) \u003d\u003d 1 ]] ; then"},{"line_number":473,"context_line":"        for key in bootstrap-{mds,osd,rgw}; do"},{"line_number":474,"context_line":"            sudo ceph auth get client.$key -o ${CEPH_DATA_DIR}/$key/ceph.keyring"},{"line_number":475,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7faddb67_60f0f5fe","line":472,"range":{"start_line":472,"start_character":43,"end_line":472,"end_character":48},"in_reply_to":"7faddb67_c5bfb85e","updated":"2019-08-08 13:58:57.000000000","message":"Will see if this works:\n    https://review.opendev.org/#/c/675340/","commit_id":"cbdcb8c10adce03d32c8eb92b31ea5ffb6ab235c"}]}