)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"71fb4499a62f9a2cfe3c2d03185fdd7e3ba89948","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"    fi"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    if [ -n \"${repo_file_name}\" ]; then"},{"line_number":1018,"context_line":"        curl -L https://shaman.ceph.com/api/repos/nfs-ganesha/next/latest/${distro_type}/${distro_release}/flavors/${ganesha_flavor}/repo | \\"},{"line_number":1019,"context_line":"            sudo tee ${repo_file_name}"},{"line_number":1020,"context_line":"    fi"},{"line_number":1021,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_45d68fc5","line":1018,"updated":"2019-11-20 21:56:31.000000000","message":"This currently fails with ceph nautilus and ubuntu bionic since there is no build available","commit_id":"969b9fdecebf2e3e36d490ce15f3e43d444948da"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dcbb09a3c37fc285b1e905d3f4d3dee5e5923eb","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"        sudo systemctl start ceph-mon@$(hostname)"},{"line_number":1256,"context_line":"        local ceph_version"},{"line_number":1257,"context_line":"        ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":1258,"context_line":"        if vercmp \"$ceph_version\" \"\u003e\u003d\" \"12.1\"; then"},{"line_number":1259,"context_line":"            sudo systemctl start ceph-mgr@${MGR_ID}"},{"line_number":1260,"context_line":"            # use `tell mgr` as the mgr might not have been activated"},{"line_number":1261,"context_line":"            # yet to register the python module commands."}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_b4a5934a","line":1258,"range":{"start_line":1258,"start_character":8,"end_line":1258,"end_character":51},"updated":"2020-05-15 08:08:12.000000000","message":"If you assume \u003e\u003d luminous, this condition should always be true","commit_id":"d2389350ee800ce7ded559b3ffd9cb1ff2fad065"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cdeb96fa6e7e9c27f3692a9b0d45dc9213229ab2","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"        sudo systemctl start ceph-mon@$(hostname)"},{"line_number":1256,"context_line":"        local ceph_version"},{"line_number":1257,"context_line":"        ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":1258,"context_line":"        if vercmp \"$ceph_version\" \"\u003e\u003d\" \"12.1\"; then"},{"line_number":1259,"context_line":"            sudo systemctl start ceph-mgr@${MGR_ID}"},{"line_number":1260,"context_line":"            # use `tell mgr` as the mgr might not have been activated"},{"line_number":1261,"context_line":"            # yet to register the python module commands."}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ff570b3c_c776efa4","line":1258,"range":{"start_line":1258,"start_character":8,"end_line":1258,"end_character":51},"in_reply_to":"3fa7e38b_b4a5934a","updated":"2020-05-15 08:11:06.000000000","message":"Humm, that comment was outdated, ignore.","commit_id":"d2389350ee800ce7ded559b3ffd9cb1ff2fad065"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"021ced9f34ab2968a6e03cfeebdfa2cf66accb79","unresolved":false,"context_lines":[{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"## Local variables:"},{"line_number":1299,"context_line":"## mode: shell-script"},{"line_number":1300,"context_line":"## End:"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1fa4df85_e805b015","side":"PARENT","line":1300,"range":{"start_line":1300,"start_character":7,"end_line":1300,"end_character":7},"updated":"2020-03-12 15:36:16.000000000","message":"This is why bashate is failing btw.\n\n/home/zuul/src/opendev.org/openstack/devstack-plugin-ceph/devstack/lib/ceph:1351:1: E004 File did not end with a newline\n\nhttps://zuul.opendev.org/t/openstack/build/5898e6743b8043df9cf77f60fc1655e1/log/job-output.txt#523","commit_id":"299e958635077c7f0823b91fcfd55a78439139c2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6e4538da1d1d2f6c0a3eb053e7f905e23d037e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Defaults"},{"line_number":28,"context_line":"# --------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-luminous}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Deploy a Ceph demo container instead of a non-containerized version"},{"line_number":33,"context_line":"CEPH_CONTAINERIZED\u003d$(trueorfalse False CEPH_CONTAINERIZED)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"1fa4df85_b18b6e66","line":30,"range":{"start_line":30,"start_character":29,"end_line":30,"end_character":37},"updated":"2020-05-20 05:23:05.000000000","message":"any reason to not default this to nautilus? \n\nOr test different versions based on different versions of openstack?\n\ni.e, if $ZUUL_BRANCH is not master/train, use luminious, else use nautilus?","commit_id":"5caaa1bb27995e32b601c460e1a4cbad86f1cb3f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a156b5270198b9280bd47b8c81e8c93e3ba0f23f","unresolved":false,"context_lines":[{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1107,"context_line":"        configure_repo_ceph \"apt\" \"nautilus\" \"ubuntu\" \"$os_CODENAME\""},{"line_number":1108,"context_line":"        configure_repo_nfsganesha \"apt\" \"ceph_master\" \"ubuntu\" \"$os_CODENAME\""},{"line_number":1109,"context_line":"        CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} ceph-mds libcephfs2 nfs-ganesha nfs-ganesha-ceph\""},{"line_number":1110,"context_line":"        if python3_enabled; then"},{"line_number":1111,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-cephfs\""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3f4c43b2_78685686","line":1108,"updated":"2020-04-20 11:00:33.000000000","message":"s/ceph_master/ceph_nautilus/\nwill be better.\n\nI triggered a build for ceph nautilus flavor and it\u0027s available for Ubuntu Bionic distro\nhttps://shaman.ceph.com/api/search/?project\u003dnfs-ganesha\u0026distros\u003dubuntu/bionic\u0026flavor\u003dceph_nautilus\u0026sha1\u003dlatest\n\nWe need to make sure that the nautilus flavor builds are auto-generated.","commit_id":"2db10383a0d2abe2ffbc3ebaff0fc905bf330022"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4005d70e1de034beb9b2740e70009b95d81eae55","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            sudo ln -s $APT_REPOSITORY_FILE \"/etc/apt/sources.list.d/$(basename $APT_REPOSITORY_FILE)\""},{"line_number":1132,"context_line":"        else"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"            # the gate requires that we use mirrored package repositories for"},{"line_number":1135,"context_line":"            # reliability, so the most recent ceph packages are mirrored and"},{"line_number":1136,"context_line":"            # configured in $APT_REPOSITORY_FILE.  The gate environment will"},{"line_number":1137,"context_line":"            # ensure that this file is present, so if it doesn\u0027t exist we\u0027re"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"1f493fa4_a0dcd918","side":"PARENT","line":1134,"updated":"2020-04-21 20:46:00.000000000","message":"Not sure if this is really needed anymore","commit_id":"a7876566b4aea02fdf9f41189f1991249d25bbaa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"808d3251b82978f7852e9936e4fcf1285a603215","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        if is_ceph_enabled_for_service manila; then"},{"line_number":1172,"context_line":"            setup_packages_for_manila_on_fedora_family"},{"line_number":1173,"context_line":"        fi"},{"line_number":1174,"context_line":"                "},{"line_number":1175,"context_line":"        if [ \"$ENABLE_CEPH_RGW\" \u003d \"True\" ]; then"},{"line_number":1176,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} ceph-radosgw\""},{"line_number":1177,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"1f493fa4_c5ff60a8","line":1174,"updated":"2020-04-22 16:46:51.000000000","message":"bashate: E001 Trailing Whitespace","commit_id":"6b5c139f82a021bf703f8e7eb23eb556706f2c2c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7e55e9f8f711cf59c64a257c1f90051971ab7958","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"        install_package software-properties-common"},{"line_number":1064,"context_line":"        install_package ${CEPH_PACKAGES}"},{"line_number":1065,"context_line":"    elif is_fedora; then"},{"line_number":1066,"context_line":"        if ! [[ $os_VENDOR \u003d~ Fedora ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (29|30|31) ]]; then"},{"line_number":1067,"context_line":"            die $LINENO \"Need Fedora 29 or newer to setup Manila with CephFS driver\""},{"line_number":1068,"context_line":"        elif ! [[ $os_VENDOR \u003d~ CentOS ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (7|8) ]]; then"},{"line_number":1069,"context_line":"            die $LINENO \"Need Centos 7 or newer to setup Manila with CephFS driver\""}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"1f493fa4_ffb95be9","line":1066,"updated":"2020-05-04 21:48:56.000000000","message":"This is not working with f31","commit_id":"a03105fdbb1033e6b7683535e7abab8e7c8ff1b3"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7e55e9f8f711cf59c64a257c1f90051971ab7958","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"    elif is_fedora; then"},{"line_number":1066,"context_line":"        if ! [[ $os_VENDOR \u003d~ Fedora ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (29|30|31) ]]; then"},{"line_number":1067,"context_line":"            die $LINENO \"Need Fedora 29 or newer to setup Manila with CephFS driver\""},{"line_number":1068,"context_line":"        elif ! [[ $os_VENDOR \u003d~ CentOS ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (7|8) ]]; then"},{"line_number":1069,"context_line":"            die $LINENO \"Need Centos 7 or newer to setup Manila with CephFS driver\""},{"line_number":1070,"context_line":"        fi"},{"line_number":1071,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"1f493fa4_5fce8f83","line":1068,"updated":"2020-05-04 21:48:56.000000000","message":"This is not working with Centos 7 or Centos 8","commit_id":"a03105fdbb1033e6b7683535e7abab8e7c8ff1b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8c996c56087bc9d317a39858dbbd373ee9f3bce2","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"    if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":1101,"context_line":"        setup_packages_for_iscsi"},{"line_number":1102,"context_line":"    fi"},{"line_number":1103,"context_line":"}"},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"# start_ceph() - Start running processes, including screen"},{"line_number":1106,"context_line":"function start_ceph {"}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"1f493fa4_202ec442","line":1103,"updated":"2020-05-07 16:45:43.000000000","message":"bashate: E040 Syntax error: syntax error near unexpected token `}\u0027","commit_id":"862cb387b4a3417c1c8f92250038a6e8bced9141"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"65c8211b7b8ff52d01ed8defada1ac3b7b887f99","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"    if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":1103,"context_line":"        setup_packages_for_iscsi"},{"line_number":1104,"context_line":"    fi"},{"line_number":1105,"context_line":"}"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"# start_ceph() - Start running processes, including screen"},{"line_number":1108,"context_line":"function start_ceph {"}],"source_content_type":"application/x-shellscript","patch_set":30,"id":"1f493fa4_8b08992d","line":1105,"updated":"2020-05-07 17:53:01.000000000","message":"bashate: E040 Syntax error: syntax error near unexpected token `}\u0027","commit_id":"1195d7b4301a2aefbe45538025f7873e78dad3a7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6e4538da1d1d2f6c0a3eb053e7f905e23d037e5","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-nautilus}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE_STABLE\u003d${CEPH_RELEASE_STABLE:-luminous}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-ceph_nautilus}"},{"line_number":34,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_d45be6f2","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":52},"updated":"2020-05-20 05:23:05.000000000","message":"So this is used only in case of ubuntu xenial to override the CEPH_RELEASE?\n\nWhy don\u0027t we get rid of this, and error out if CEPH_RELEASE !\u003d luminous on Xenial?","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9fd9c43e889fe160ec8ef1c68d46aa499f09a7b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-nautilus}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE_STABLE\u003d${CEPH_RELEASE_STABLE:-luminous}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-ceph_nautilus}"},{"line_number":34,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_d8e30604","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":52},"in_reply_to":"ff570b3c_d45be6f2","updated":"2020-05-20 21:42:34.000000000","message":"So yes, it might sound confusing using this variable name, I thought it was convenient to keep two different versions for stability. We will default to luminous for xenial (which is used in CI for queens and rocky) and use nautilus for bionic (which is used in CI for stein, train, ussuri and master). We probably can enhance this at some point. I expect to be able to test with octopus in the near future. Maybe then we can do something smarter.","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6e4538da1d1d2f6c0a3eb053e7f905e23d037e5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE_STABLE\u003d${CEPH_RELEASE_STABLE:-luminous}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-ceph_nautilus}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Deploy a Ceph demo container instead of a non-containerized version"},{"line_number":36,"context_line":"CEPH_CONTAINERIZED\u003d$(trueorfalse False CEPH_CONTAINERIZED)"}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_5467d6b7","line":33,"range":{"start_line":33,"start_character":35,"end_line":33,"end_character":48},"updated":"2020-05-20 05:23:05.000000000","message":"For Xenial, you\u0027ll need to set this to luminous too...","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9fd9c43e889fe160ec8ef1c68d46aa499f09a7b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE_STABLE\u003d${CEPH_RELEASE_STABLE:-luminous}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-ceph_nautilus}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Deploy a Ceph demo container instead of a non-containerized version"},{"line_number":36,"context_line":"CEPH_CONTAINERIZED\u003d$(trueorfalse False CEPH_CONTAINERIZED)"}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_b80d72e9","line":33,"range":{"start_line":33,"start_character":35,"end_line":33,"end_character":48},"in_reply_to":"ff570b3c_5467d6b7","updated":"2020-05-20 21:42:34.000000000","message":"Done, added a GANESHA_RELEASE_STABLE","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9dcbb09a3c37fc285b1e905d3f4d3dee5e5923eb","unresolved":false,"context_lines":[{"line_number":393,"context_line":"function configure_ceph {"},{"line_number":394,"context_line":"    local count\u003d0"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    echo \"ceph daemons will run as ceph\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    initial_configure_ceph"},{"line_number":399,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_270ecb31","line":396,"updated":"2020-05-15 08:08:12.000000000","message":"Nit: since this is hardcoded now, I\u0027d say you could drop this line completely","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6e4538da1d1d2f6c0a3eb053e7f905e23d037e5","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"            die $LINENO \"Supported for CentOS 7 and 8. Not supported for other releases.\""},{"line_number":1075,"context_line":"        fi"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"        install_package jq"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"$os_VENDOR\" \"$os_RELEASE\""},{"line_number":1080,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_544eb637","line":1077,"range":{"start_line":1077,"start_character":8,"end_line":1077,"end_character":26},"updated":"2020-05-20 05:23:05.000000000","message":"this is common, perhaps add it at the top?","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9fd9c43e889fe160ec8ef1c68d46aa499f09a7b","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"            die $LINENO \"Supported for CentOS 7 and 8. Not supported for other releases.\""},{"line_number":1075,"context_line":"        fi"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"        install_package jq"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"$os_VENDOR\" \"$os_RELEASE\""},{"line_number":1080,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"ff570b3c_b8b452f3","line":1077,"range":{"start_line":1077,"start_character":8,"end_line":1077,"end_character":26},"in_reply_to":"ff570b3c_544eb637","updated":"2020-05-20 21:42:34.000000000","message":"Yes, we should avoid dup.","commit_id":"6c344fdaccc56112264dff96a43e6ea3a4c37d74"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"881d4c67fe64b38682c40008833b1d3ce6582545","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":273,"context_line":"function check_os_support_ceph {"},{"line_number":274,"context_line":"    if [[ ${DISTRO} \u003d~ (f29|f30|f31) ]]; then"},{"line_number":275,"context_line":"        return"},{"line_number":276,"context_line":"    fi"},{"line_number":277,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_98f4eef2","line":274,"updated":"2020-05-20 21:31:45.000000000","message":"No f32? Also, f29 is out of support, and f30 will be out of support in a week:\n\nhttps://fedoraproject.org/wiki/End_of_life","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9fd9c43e889fe160ec8ef1c68d46aa499f09a7b","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":273,"context_line":"function check_os_support_ceph {"},{"line_number":274,"context_line":"    if [[ ${DISTRO} \u003d~ (f29|f30|f31) ]]; then"},{"line_number":275,"context_line":"        return"},{"line_number":276,"context_line":"    fi"},{"line_number":277,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_b897323a","line":274,"in_reply_to":"ff570b3c_98f4eef2","updated":"2020-05-20 21:42:34.000000000","message":"Just included the versions I tested, I can try running this on f32 and remove f29 and f30","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"881d4c67fe64b38682c40008833b1d3ce6582545","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    if [[ ! ${DISTRO} \u003d~ (bionic|xenial|centos7) ]]; then"},{"line_number":279,"context_line":"        echo \"WARNING: your distro $DISTRO does not provide \\"},{"line_number":280,"context_line":"            (at least) the Luminous release. \\"},{"line_number":281,"context_line":"            Please use Ubuntu Xenial or Fedora 29 (and higher)\""},{"line_number":282,"context_line":"        if [[ \"$FORCE_CEPH_INSTALL\" !\u003d \"yes\" ]]; then"},{"line_number":283,"context_line":"            die $LINENO \"If you wish to install Ceph on this distribution \\"},{"line_number":284,"context_line":"                anyway run with FORCE_CEPH_INSTALL\u003dyes, \\"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_f8c7ea94","line":281,"updated":"2020-05-20 21:31:45.000000000","message":"I guess Fedora 29 should be replaced by centos7","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9fd9c43e889fe160ec8ef1c68d46aa499f09a7b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    if [[ ! ${DISTRO} \u003d~ (bionic|xenial|centos7) ]]; then"},{"line_number":279,"context_line":"        echo \"WARNING: your distro $DISTRO does not provide \\"},{"line_number":280,"context_line":"            (at least) the Luminous release. \\"},{"line_number":281,"context_line":"            Please use Ubuntu Xenial or Fedora 29 (and higher)\""},{"line_number":282,"context_line":"        if [[ \"$FORCE_CEPH_INSTALL\" !\u003d \"yes\" ]]; then"},{"line_number":283,"context_line":"            die $LINENO \"If you wish to install Ceph on this distribution \\"},{"line_number":284,"context_line":"                anyway run with FORCE_CEPH_INSTALL\u003dyes, \\"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_38ab2275","line":281,"in_reply_to":"ff570b3c_f8c7ea94","updated":"2020-05-20 21:42:34.000000000","message":"Good catch","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"881d4c67fe64b38682c40008833b1d3ce6582545","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    if [ \"${package_manager}\" \u003d \"apt-get\" ]; then"},{"line_number":892,"context_line":"        repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":893,"context_line":"    # FIXME(vkmc) When Centos8 land we would be able to generalize this"},{"line_number":894,"context_line":"    # to use dnf. Right now yum works on latest Fedora versions and dnf"},{"line_number":895,"context_line":"    # does not work on CentOS, so we fallback to yum"},{"line_number":896,"context_line":"    elif [ \"${package_manager}\" \u003d \"yum\" ]; then"},{"line_number":897,"context_line":"        repo_file_name\u003d\"/etc/yum.repos.d/ext-ceph.repo\""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_385322e4","line":894,"updated":"2020-05-20 21:31:45.000000000","message":"I think you can removed this comment, because the repository directory is the same for yum and dnf.\nAlso, as far as I know the official package manager interface on CentOS 8 is still yum (even though it\u0027s dnf in disguise), but I\u0027d need to check.","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"768b4abf7cb55e6254e62bb12daba0b3718f7f84","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    if [ \"${package_manager}\" \u003d \"apt-get\" ]; then"},{"line_number":892,"context_line":"        repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":893,"context_line":"    # FIXME(vkmc) When Centos8 land we would be able to generalize this"},{"line_number":894,"context_line":"    # to use dnf. Right now yum works on latest Fedora versions and dnf"},{"line_number":895,"context_line":"    # does not work on CentOS, so we fallback to yum"},{"line_number":896,"context_line":"    elif [ \"${package_manager}\" \u003d \"yum\" ]; then"},{"line_number":897,"context_line":"        repo_file_name\u003d\"/etc/yum.repos.d/ext-ceph.repo\""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_713c88e0","line":894,"in_reply_to":"ff570b3c_385322e4","updated":"2020-05-22 15:31:03.000000000","message":"Yes. It\u0027s still yum for CentOS 8.","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"881d4c67fe64b38682c40008833b1d3ce6582545","unresolved":false,"context_lines":[{"line_number":933,"context_line":"    local repo_file_name\u003d\"\""},{"line_number":934,"context_line":"    if [ \"${package_manager}\" \u003d \"apt-get\" ]; then"},{"line_number":935,"context_line":"        repo_file_name\u003d\"/etc/apt/sources.list.d/ext-nfs-ganesha.list\""},{"line_number":936,"context_line":"    # FIXME(vkmc) When Centos8 land we would be able to generalize this"},{"line_number":937,"context_line":"    # to use dnf. Right now yum works on latest Fedora versions and dnf"},{"line_number":938,"context_line":"    # does not work on CentOS, so we fallback to yum"},{"line_number":939,"context_line":"    elif [ \"${package_manager}\" \u003d \"yum\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_f8752a65","line":936,"updated":"2020-05-20 21:31:45.000000000","message":"See above.","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"881d4c67fe64b38682c40008833b1d3ce6582545","unresolved":false,"context_lines":[{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        install_package ${CEPH_PACKAGES}"},{"line_number":1073,"context_line":"    elif is_fedora; then"},{"line_number":1074,"context_line":"        if ! [[ $os_VENDOR \u003d~ Fedora ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (29|30|31) ]]; then"},{"line_number":1075,"context_line":"            die $LINENO \"Supported for Fedora 29, 30 and 31. Not supported for other releases.\""},{"line_number":1076,"context_line":"        elif ! [[ $os_VENDOR \u003d~ CentOS ]] \u0026\u0026 [[ $os_RELEASE \u003d~ (7) ]]; then"},{"line_number":1077,"context_line":"            die $LINENO \"Supported for CentOS 7. Not supported for other releases.\""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_18fc5eb3","line":1074,"updated":"2020-05-20 21:31:45.000000000","message":"See above for the supported releases","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"768b4abf7cb55e6254e62bb12daba0b3718f7f84","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"        sudo systemctl disable ceph-mds@${MDS_ID}"},{"line_number":1150,"context_line":"        if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1151,"context_line":"            sudo systemctl stop nfs-ganesha"},{"line_number":1152,"context_line":"            sudo systemctl disable nfs-ganesha"},{"line_number":1153,"context_line":"        fi"},{"line_number":1154,"context_line":"    fi"},{"line_number":1155,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_0669778a","line":1152,"updated":"2020-05-22 15:31:03.000000000","message":"let\u0027s stop nfs-ganesha and then ceph-mds. Reverse order in which we start the services.","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"768b4abf7cb55e6254e62bb12daba0b3718f7f84","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"        sudo systemctl disable ceph-osd@$id"},{"line_number":1162,"context_line":"    done"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"    sudo systemctl stop ceph-mon@$(hostname)"},{"line_number":1165,"context_line":"    sudo systemctl disable ceph-mon@$(hostname)"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"    # In nautilus we have the new ceph-crash service for monitoring"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff570b3c_069a176d","line":1164,"updated":"2020-05-22 15:31:03.000000000","message":"I guess this was supposed to stop ceph-mgr service, i.e.,\nsudo systemctl stop ceph-mgr@${MGR_ID}\n\nYou also stop ceph-mon service at line 1182.","commit_id":"1710596c11bc0ad91bb7d4d0383fbc4f42a65773"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"abf8996c89f6ac39d5f448ecbbd61c363cffd976","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    local repo_type\u003d\"${5:-latest}\""},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    local repo_file_name\u003d\"\""},{"line_number":891,"context_line":"    if [ \"${package_manager}\" \u003d \"apt-get\" ]; then"},{"line_number":892,"context_line":"        repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":893,"context_line":"    elif [ \"${package_manager}\" \u003d \"yum\" ]; then"},{"line_number":894,"context_line":"        repo_file_name\u003d\"/etc/yum.repos.d/ext-ceph.repo\""}],"source_content_type":"application/x-shellscript","patch_set":34,"id":"ff570b3c_5f466a23","line":891,"updated":"2020-05-26 17:03:45.000000000","message":"I didn\u0027t notice it before: why change to apt-get?","commit_id":"f57de5a01c09a99eeebedeef10c74f16e6ff2722"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"function setup_packages_for_manila_on_fedora_family {"},{"line_number":1016,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1017,"context_line":"\tif [[ $os_VENDOR \u003d~ Fedora ]]; then"},{"line_number":1018,"context_line":"            # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1019,"context_line":"            # we need to stick to CentOS 8 packages"},{"line_number":1020,"context_line":"            configure_repo_nfsganesha \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_2a08798f","line":1017,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E002 Tab indents","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"function setup_packages_for_manila_on_fedora_family {"},{"line_number":1016,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1017,"context_line":"\tif [[ $os_VENDOR \u003d~ Fedora ]]; then"},{"line_number":1018,"context_line":"            # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1019,"context_line":"            # we need to stick to CentOS 8 packages"},{"line_number":1020,"context_line":"            configure_repo_nfsganesha \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_8aff0566","line":1017,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            die $LINENO \"Supported for CentOS 7 and 8. Not supported for other releases.\""},{"line_number":1079,"context_line":"        fi"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"\tif [[ $os_VENDOR \u003d~ Fedora ]]; then"},{"line_number":1082,"context_line":"\t    # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_6a027171","line":1081,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E002 Tab indents","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            die $LINENO \"Supported for CentOS 7 and 8. Not supported for other releases.\""},{"line_number":1079,"context_line":"        fi"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"\tif [[ $os_VENDOR \u003d~ Fedora ]]; then"},{"line_number":1082,"context_line":"\t    # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_caf8dd7d","line":1081,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"\t    # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_aaf3e99e","line":1085,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E002 Tab indents","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"\t    # NOTE(vkmc) shaman currently does not build for Fedora"},{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_0af3f59f","line":1085,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_eaede1b7","line":1086,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E002 Tab indents","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"\t    # we need to stick to CentOS 8 packages"},{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_4a2a0de7","line":1086,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""},{"line_number":1090,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_2a2d19fd","line":1087,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E002 Tab indents","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6c10ff735a51959a21c13dae52fb05a8cd1632f","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" \"centos\" \"8\""},{"line_number":1085,"context_line":"\telse"},{"line_number":1086,"context_line":"\t    configure_repo_ceph \"yum\" \"$CEPH_RELEASE\" $os_VENDOR $os_RELEASE"},{"line_number":1087,"context_line":"\tfi"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""},{"line_number":1090,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"ff570b3c_8a34254c","line":1087,"updated":"2020-05-27 18:31:08.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"9b2e19752dd4b9021e06a41f20236fae8728483e"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e5c4b9cbf62fe3ef4811ed7e17337d1570afa693","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        sudo systemctl disable ceph-osd@$id"},{"line_number":1167,"context_line":"    done"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    sudo systemctl stop ceph-mgr@$(hostname)"},{"line_number":1170,"context_line":"    sudo systemctl disable ceph-mgr@$(hostname)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"    # In nautilus we have the new ceph-crash service for monitoring"}],"source_content_type":"application/x-shellscript","patch_set":37,"id":"ff570b3c_76b35b4e","line":1169,"updated":"2020-05-29 09:18:07.000000000","message":"need to stop and disable ceph-mgr@${MGR_ID} instead.","commit_id":"ec04c441193d96c18eb779ff65033953fdd5591f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"653a6f84aa8e8ce1fda50e4ccb62fff5ced9683f","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    if [[ ! ${DISTRO} \u003d~ (focal|bionic|xenial|f31|f32) ]]; then"},{"line_number":278,"context_line":"        echo \"WARNING: your distro $DISTRO does not provide \\"},{"line_number":279,"context_line":"            (at least) the Luminous release. \\"},{"line_number":280,"context_line":"            Please use Ubuntu Xenial, Ubuntu Bionic, Fedora 31 or Fedora 32\""},{"line_number":281,"context_line":"        if [[ \"$FORCE_CEPH_INSTALL\" !\u003d \"yes\" ]]; then"},{"line_number":282,"context_line":"            die $LINENO \"If you wish to install Ceph on this distribution \\"},{"line_number":283,"context_line":"                anyway run with FORCE_CEPH_INSTALL\u003dyes, \\"}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_7f686720","line":280,"range":{"start_line":280,"start_character":51,"end_line":280,"end_character":52},"updated":"2020-06-18 19:22:12.000000000","message":"or Fossa","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"653a6f84aa8e8ce1fda50e4ccb62fff5ced9683f","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        -o ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":729,"context_line":"    sudo chown ${STACK_USER}:$(id -g -n $whoami) \\"},{"line_number":730,"context_line":"        ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":731,"context_line":"    # Enable snapshots in CephFS."},{"line_number":732,"context_line":"    sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} fs set ${CEPHFS_FILESYSTEM} allow_new_snaps true \\"},{"line_number":733,"context_line":"        --yes-i-really-mean-it"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    # Make manila\u0027s libcephfs client a root user."},{"line_number":736,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client.${MANILA_CEPH_USER} \"client mount uid\" \"0\""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_df509360","line":733,"range":{"start_line":731,"start_character":0,"end_line":733,"end_character":30},"updated":"2020-06-18 19:22:12.000000000","message":"This isn\u0027t required for nautilus+, it is enabled by default - see:\n\nhttps://docs.ceph.com/docs/nautilus/dev/cephfs-snapshots/#creating-a-snapshot","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a3eb2aa111796d18e5d765e11a04678bdca5252e","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        -o ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":729,"context_line":"    sudo chown ${STACK_USER}:$(id -g -n $whoami) \\"},{"line_number":730,"context_line":"        ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":731,"context_line":"    # Enable snapshots in CephFS."},{"line_number":732,"context_line":"    sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} fs set ${CEPHFS_FILESYSTEM} allow_new_snaps true \\"},{"line_number":733,"context_line":"        --yes-i-really-mean-it"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    # Make manila\u0027s libcephfs client a root user."},{"line_number":736,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client.${MANILA_CEPH_USER} \"client mount uid\" \"0\""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_ed4fa68f","line":733,"range":{"start_line":731,"start_character":0,"end_line":733,"end_character":30},"in_reply_to":"bf51134e_c6dba718","updated":"2020-06-19 10:49:30.000000000","message":"Yes.","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4cdb8616ed37afaa766298efac294864c62cb30f","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        -o ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":729,"context_line":"    sudo chown ${STACK_USER}:$(id -g -n $whoami) \\"},{"line_number":730,"context_line":"        ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":731,"context_line":"    # Enable snapshots in CephFS."},{"line_number":732,"context_line":"    sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} fs set ${CEPHFS_FILESYSTEM} allow_new_snaps true \\"},{"line_number":733,"context_line":"        --yes-i-really-mean-it"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    # Make manila\u0027s libcephfs client a root user."},{"line_number":736,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client.${MANILA_CEPH_USER} \"client mount uid\" \"0\""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_c6dba718","line":733,"range":{"start_line":731,"start_character":0,"end_line":733,"end_character":30},"in_reply_to":"bf51134e_df509360","updated":"2020-06-19 03:12:19.000000000","message":"We need this for Luminous, right?","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7029400a529dea84a56d36196d096adbda355384","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        -o ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":729,"context_line":"    sudo chown ${STACK_USER}:$(id -g -n $whoami) \\"},{"line_number":730,"context_line":"        ${CEPH_CONF_DIR}/ceph.client.${MANILA_CEPH_USER}.keyring"},{"line_number":731,"context_line":"    # Enable snapshots in CephFS."},{"line_number":732,"context_line":"    sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} fs set ${CEPHFS_FILESYSTEM} allow_new_snaps true \\"},{"line_number":733,"context_line":"        --yes-i-really-mean-it"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    # Make manila\u0027s libcephfs client a root user."},{"line_number":736,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client.${MANILA_CEPH_USER} \"client mount uid\" \"0\""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_b19fc45d","line":733,"range":{"start_line":731,"start_character":0,"end_line":733,"end_character":30},"in_reply_to":"bf51134e_ed4fa68f","updated":"2020-06-19 13:26:57.000000000","message":"Ok, so let\u0027s keep it for Luminous then, I can submit a follow up patch to check version and execute or not this option","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"40db01e116d86bfeb62e3fd92367a802a0e4266d","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    install_package jq"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    if is_ubuntu; then"},{"line_number":1027,"context_line":"        if ! [[ $os_CODENAME \u003d~ (xenial|bionic) ]]; then"},{"line_number":1028,"context_line":"            die $LINENO \"Supported for Ubuntu Xenial or Bionic. Not supported for other releases.\""},{"line_number":1029,"context_line":"        fi"},{"line_number":1030,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_a31dc5be","line":1027,"range":{"start_line":1027,"start_character":46,"end_line":1027,"end_character":47},"updated":"2020-06-19 02:46:27.000000000","message":"Add \u0027|focal\u0027","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"40db01e116d86bfeb62e3fd92367a802a0e4266d","unresolved":false,"context_lines":[{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    if is_ubuntu; then"},{"line_number":1027,"context_line":"        if ! [[ $os_CODENAME \u003d~ (xenial|bionic) ]]; then"},{"line_number":1028,"context_line":"            die $LINENO \"Supported for Ubuntu Xenial or Bionic. Not supported for other releases.\""},{"line_number":1029,"context_line":"        fi"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # NOTE(vkmc) Dependencies for setting up repos"}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"bf51134e_23609532","line":1028,"range":{"start_line":1028,"start_character":53,"end_line":1028,"end_character":62},"updated":"2020-06-19 02:46:27.000000000","message":", Bionic or Focal","commit_id":"795ef28137d32f1151cacbba2ada7247cf8e53a8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"158da63bc80c7f23c0bbefa8a6bab6b438e8c635","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"osd pool default size\" \"${CEPH_REPLICAS}\""},{"line_number":426,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"rbd default features\" \"${CEPH_RBD_DEFAULT_FEATURES}\""},{"line_number":427,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_client\" \"10\""},{"line_number":428,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_ms\" \"1\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    # bootstrap the ceph monitor"},{"line_number":431,"context_line":"    sudo ceph-mon -c ${CEPH_CONF_FILE} --mkfs -i $(hostname) \\"}],"source_content_type":"application/x-shellscript","patch_set":42,"id":"bf51134e_c11c03c3","line":428,"range":{"start_line":428,"start_character":42,"end_line":428,"end_character":52},"updated":"2020-06-22 20:56:50.000000000","message":"Does this work?\n    https://docs.ceph.com/docs/nautilus/rados/troubleshooting/log-and-debug/#boot-time\nand\n    https://docs.ceph.com/docs/nautilus/rados/configuration/ceph-conf/#config-file-section-names\n\n...seem to show \"debug_ms\" for CLI operations and \"debug ms\" in config files.","commit_id":"5bfcd102355d5e1289712452ce6fb240f050d2c6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d2658df57cef6417742b112f74a5906f46a4696f","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"osd pool default size\" \"${CEPH_REPLICAS}\""},{"line_number":426,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"rbd default features\" \"${CEPH_RBD_DEFAULT_FEATURES}\""},{"line_number":427,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_client\" \"10\""},{"line_number":428,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_ms\" \"1\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    # bootstrap the ceph monitor"},{"line_number":431,"context_line":"    sudo ceph-mon -c ${CEPH_CONF_FILE} --mkfs -i $(hostname) \\"}],"source_content_type":"application/x-shellscript","patch_set":42,"id":"bf51134e_4ba577a1","line":428,"range":{"start_line":428,"start_character":42,"end_line":428,"end_character":52},"in_reply_to":"bf51134e_c11c03c3","updated":"2020-06-25 16:34:36.000000000","message":"Yes, it does work. debug_ms sets debugs info for the messenger subsystem, and you can enable this for any daemon or client you want to debug. Basically we are picking up all ceph sent/received messages that involves the client.","commit_id":"5bfcd102355d5e1289712452ce6fb240f050d2c6"}]}