)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~694330","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~I43de36ab570af40bc837d859568f5428c167f083","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"drop-python2-support","hashtags":[],"change_id":"I43de36ab570af40bc837d859568f5428c167f083","subject":"Install \u0027python3-\u0027 variants of packages in \u0027install_ceph_remote\u0027","status":"MERGED","created":"2019-11-14 15:27:37.000000000","updated":"2019-11-20 13:29:31.000000000","submitted":"2019-11-15 16:06:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"694330-1573834003625-ee4c743d","meta_rev_id":"5475f8426db211714d3e5e855139702fb398ddbf","_number":694330,"virtual_id_number":694330,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"date":"2019-11-14 15:34:28.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-15 16:06:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-11-14 15:36:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2019-11-15 15:31:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2019-11-15 15:57:54.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-11-14 17:26:09.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"date":"2019-11-14 18:23:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-11-15 15:57:54.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-14 15:36:14.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-11-14 17:26:09.000000000","updated_by":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"reviewer":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"state":"REVIEWER"},{"updated":"2019-11-14 18:23:40.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-11-15 15:31:06.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2019-11-15 15:57:54.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2019-11-15 16:06:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e27b05c6febccb455ff274cb970c4dfd5caca895","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-14 15:27:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb89ff6fe860fd845689a4acaa39d7c74b86eef3","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-14 15:32:07.000000000","message":"Patch Set 1:\n\nAs noted on IRC, we\u0027ve a WIP patch in nova to prove it fixed things for us. Compare https://review.opendev.org/#/c/692374/4 (broken) with https://review.opendev.org/#/c/694281/1 (our local version of that same fix)","accounts_in_message":[],"_revision_number":1},{"id":"0c43e72a293f6b89d483cb66bdc1aed64f330092","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-14 15:34:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"988ffe74768885df244140b5d17968a1a3f130eb","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-11-14 15:36:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"054da63e927e07b29d4a6a4c9d42f5d6d1e33092","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 17:16:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/d613e7b1bdda4a17867cc55076e7e92e : RETRY_LIMIT in 4m 24s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/4a9f0d9b6bcf42739bf2841b0e211c92 : SUCCESS in 1h 04m 24s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/1f0f5df8fc94402d9a65955e8f130f96 : SUCCESS in 3m 15s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/0af46cb2c6194fedb4d055f978d29ca8 : SUCCESS in 26m 33s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/8f67e186cb3548f0bd43557acc426144 : SUCCESS in 1h 34m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a5971f8db37da848a943c4d1d442349e0e54eea5","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-11-14 18:23:40.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"704c72478e784df73979b670265023d17ef7722d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 19:42:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/cd8d17c377644b71a17f47157f45b815 : SUCCESS in 1h 02m 05s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/c47b75f4af7c41fc8adc36ac17ed1ef7 : SUCCESS in 1h 15m 08s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/204d9734d8e348b68c504ac226147572 : SUCCESS in 2m 30s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/79fd1e52f9964458a4aa081e7df4c528 : SUCCESS in 35m 07s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/550807f9853d487d8ac4713bb7a0909e : FAILURE in 1h 09m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2a699459bdb80b1e131bb83fb18fe6787bdad3c0","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-11-15 15:31:06.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"fc6faf3e91003955ac24a9f42c1a87c6793bd5ae","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2019-11-15 15:57:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"03c481f661fb4bb4695f4613afd5375a3e157956","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-15 15:58:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b91ca4ae561159e6c0f0036df0cee5d9abf8f0b7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-15 16:06:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/caf38c58660942a899d9d69d4350b672 : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1},{"id":"262a655759a6ea35211d14700f57d300c376154f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-15 16:06:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"323f2411ef7f79ecb1f1be12ee654b96017849ab","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-11-20 11:54:12.000000000","message":"Patch Set 1:\n\nIt seems this change breaks nova-live-migration job on stable/pike https://bugs.launchpad.net/nova/+bug/1853280","accounts_in_message":[],"_revision_number":1},{"id":"3dac8e9b3212ccb3b42fa61441dfc89caf2e4930","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-20 13:29:31.000000000","message":"Patch Set 1:\n\nThere\u0027s a follow-up to this here [1]. Turns out it is necessary to hide things behind a python3_enabled flag\n\n[1] https://review.opendev.org/#/c/695191/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3a36c1c6d27d7fad2f1349369b86f5113d6a0011","revisions":{"3a36c1c6d27d7fad2f1349369b86f5113d6a0011":{"kind":"REWORK","_number":1,"created":"2019-11-14 15:27:37.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/30/694330/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/30/694330/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/30/694330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/30/694330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/30/694330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/30/694330/1"}}},"commit":{"parents":[{"commit":"1c9e3e772e555589d6a31b718dd9d7eda6cfa63b","subject":"Manila: clean pools unconditionally","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/1c9e3e772e555589d6a31b718dd9d7eda6cfa63b"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-11-14 15:21:53.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-11-14 15:27:16.000000000","tz":0},"subject":"Install \u0027python3-\u0027 variants of packages in \u0027install_ceph_remote\u0027","message":"Install \u0027python3-\u0027 variants of packages in \u0027install_ceph_remote\u0027\n\nPreviously, this command would simply install the \u0027ceph-common\u0027 package,\nwhich includes a number of Python dependencies. Unfortunately, these\npackages are the \u0027python-\u0027 variants [1] and there doesn\u0027t appear to be a\n\u0027ceph-common-python3\u0027 package or similar to install the \u0027python3-\u0027\nvariants. As a result, we need to install the \u0027python3-\u0027 variants\nmanually to ensure consumers of the plugin (like nova) can switch to\nPython 3 in their tests.\n\nWe don\u0027t bother hiding this behind the \u0027python3_enabled\u0027 function or\n\u0027USE_PYTHON3\u0027 variable since (a) these packages can happily coexist, (b)\nprojects should be switching to Python 3 now, and (c) using these would\nrequire sourcing additional, otherwise unnecessary devstack libraries\njust to use this simple function.\n\n[1] https://packages.ubuntu.com/bionic/ceph-common\n\nChange-Id: I43de36ab570af40bc837d859568f5428c167f083\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/3a36c1c6d27d7fad2f1349369b86f5113d6a0011"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/3a36c1c6d27d7fad2f1349369b86f5113d6a0011"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
