)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~695191","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~I890a1e673fde212218eff4fcf82f7941b3283e5f","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"drop-py27-support","hashtags":[],"change_id":"I890a1e673fde212218eff4fcf82f7941b3283e5f","subject":"Only install python3 packages if necessary","status":"MERGED","created":"2019-11-20 13:19:44.000000000","updated":"2019-11-21 08:10:15.000000000","submitted":"2019-11-20 15:16:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"695191-1574263000176-a496186d","meta_rev_id":"1701cfa4e7cc527e253576254cebe213a27cd394","_number":695191,"virtual_id_number":695191,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-20 15:16:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"all":[{"value":2,"date":"2019-11-20 14:33:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2019-11-20 15:05:49.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":1,"date":"2019-11-20 13:22:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-11-20 15:05:49.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-20 13:22:30.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-11-20 14:33:15.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-11-20 15:05:49.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2019-11-20 15:16:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b03c1288554c7d2ee30f7cd63389f320ad58a0f5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-20 13:19:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"227373eeef65009da2213ea7ee00d76d6272a229","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-11-20 13:22:30.000000000","message":"Patch Set 1: Code-Review+1\n\nthanks!","accounts_in_message":[],"_revision_number":1},{"id":"757dec7537a584587ec0cd9bf0a2b88b35eef26a","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-11-20 14:33:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"12a2c599e35ee5fd808ecf918a20042e1ac5262f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-20 14:44:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/00f1640685f84971b4d7b933df8b158b : SUCCESS in 1h 08m 33s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/a26f668008f24a4787373f396433c807 : SUCCESS in 1h 10m 10s (non-voting)\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/31a2f02fe39d4c51a73dcd6046448d8d : SUCCESS in 2m 31s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/f8df4fe4d55f4c6baf5e7e1c510a933f : SUCCESS in 26m 41s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/0c9480ba31d7437b83e31ae9fe156e89 : SUCCESS in 1h 17m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"691fdfbc26130f2d784be25a5b1fcfa1d05158ed","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2019-11-20 15:05:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a7467950b08ca45b9ec6539983d6fd9a9d4ca657","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-20 15:06:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8c9da14f2466d121306ddda1a1435a2b5ed4e39d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-20 15:16:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/8562f1149a574e199e54eee9110678e6 : SUCCESS in 4m 14s","accounts_in_message":[],"_revision_number":1},{"id":"6d0fc8adabb3182d7d91af488fa4391bed60b02a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-20 15:16:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"f42f6e1e8333bec0d716696217b38462b38b5a9c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-11-21 08:10:15.000000000","message":"Patch Set 1:\n\nIt fixed the nova-live-migration job issue. Thanks again!","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"856dbe5280d8887dd3905c3d565be176ccb9e3bb","revisions":{"856dbe5280d8887dd3905c3d565be176ccb9e3bb":{"kind":"REWORK","_number":1,"created":"2019-11-20 13:19:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/91/695191/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/91/695191/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/91/695191/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/91/695191/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/91/695191/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/91/695191/1"}}},"commit":{"parents":[{"commit":"ee8cc0e9d464f5d5da3c0e5db94b7dd866a86bed","subject":"Merge \"Use vercmp\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/ee8cc0e9d464f5d5da3c0e5db94b7dd866a86bed"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-11-20 13:11:06.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-11-20 13:19:23.000000000","tz":0},"subject":"Only install python3 packages if necessary","message":"Only install python3 packages if necessary\n\nIn change I43de36ab570af40bc837d859568f5428c167f083, we started\ninstalling the \u0027python3-\u0027 variants of the \u0027python-\u0027 packages installed\nby the \u0027ceph-common\u0027 package in \u0027install_ceph_remote\u0027. In that change,\nwe made the assertion that we didn\u0027t need to \"both hiding this behind\nthe \u0027python3_enabled\u0027 function or \u0027USE_PYTHON3\u0027 variable since (a) these\npackages can happily coexist, (b) projects should be switching to Python\n3 now, and (c) using these would require sourcing additional, otherwise\nunnecessary devstack libraries just to use this simple function\".\nHowever, this didn\u0027t take into account the fact that this plugin is not\nversioned. This means *any* job that uses this plugin, including things\nlike stable/pike, will now attempt to install the \u0027python3-\u0027 packages.\nSince the base OS on stable/pike, Xenial (16.04), doesn\u0027t actually\nprovide these \u0027python3-\u0027 variants, the command will always fail.\n\nStart hiding the command behind a \u0027use_python3\u0027 function call. Hopefully\nby time we drop Python 2 support here we won\u0027t have maintained branches\nusing Xenial. If we do, we\u0027ll need to branch or something like that.\n\nChange-Id: I890a1e673fde212218eff4fcf82f7941b3283e5f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1853280\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/856dbe5280d8887dd3905c3d565be176ccb9e3bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/856dbe5280d8887dd3905c3d565be176ccb9e3bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}