)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~724931","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Id5dedf496b355362031deefab1573d052fc72a66","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"fix-stable-attach-encrypted-volumes","hashtags":[],"change_id":"Id5dedf496b355362031deefab1573d052fc72a66","subject":"Enable encrypted volume attachment on non-master branch","status":"MERGED","created":"2020-05-01 21:11:02.000000000","updated":"2020-05-21 23:23:52.000000000","submitted":"2020-05-21 22:59:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"724931-1590101978787-a134e064","meta_rev_id":"6c01a0ae736c2b302791ef5654813f3f82d2f038","_number":724931,"virtual_id_number":724931,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-21 22:59:38.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2020-05-21 22:50:57.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2020-05-21 20:31:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2020-05-21 22:50:57.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-19 23:27:03.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-05-19 23:27:46.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-05-19 23:27:50.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-05-21 20:31:41.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2020-05-21 22:50:57.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"},{"updated":"2020-05-21 22:59:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3b186325728ee4a73657229eac1628ec1a4d8a43","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-05-01 21:11:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1897b225ce589034e8506d58e45b188b61c86ee2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-01 22:23:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/09e590b84e2e404abcfbe30e5686429b : SUCCESS in 1h 06m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b890e7d85f44098a552b4c3e215cdb1 : SUCCESS in 3m 46s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/d91afc4b05fa4198a77f4ccdea8097d0 : SUCCESS in 2m 40s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/5f61becbd56a4709abb849d86b778b72 : SUCCESS in 26m 00s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/80ef7eb9a22545d8860530a2e2e82c9f : SUCCESS in 1h 10m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3e1252c9ffe4e5689356339a202d4173859c52e4","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2020-05-07 10:45:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a9a1e7cbd2c2c92853ff84f240d395ce255c3225","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-05-20 21:39:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a29968f74409157f018fafa40540818d303c6342","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-05-20 21:57:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7527bd4ffb6702356eabd6f6cf5ac0c97f1487a2","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-05-20 23:12:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"af958c1fc65ee130ab1428edcb0398c6726da9da","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-05-20 23:56:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e1f67c06f1dd3346d4a355717d5643e9359987c4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-21 01:27:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/4ef2c0d86dd14c8ebe29225b059a5efa : SUCCESS in 1h 00m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a97d454b27874169beafa6db5f5337a4 : SUCCESS in 3m 19s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/bc20367358da407899cebed0f8648d4c : SUCCESS in 3m 05s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/83a052b5eb4e48229fe7cedd34bfd9db : SUCCESS in 27m 06s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/449b5388fbe347a99d3e838fee0e2392 : SUCCESS in 1h 23m 40s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"524f33acb100e10cac51c06e378effb05baeec08","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-05-21 20:31:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"afe9ebb4fbf42e6458658ae7499f9d372db9364f","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2020-05-21 22:50:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLooks good, thanks Luigi","accounts_in_message":[],"_revision_number":2},{"id":"d1fc2361af59751d13e7b36a78eea26fc09e19c4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-21 22:51:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a3d43544f22e9ed6c34d4460743ae13e1af4815c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-21 22:59:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"bc6fc860d6521a82776a081980929b145225086f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-21 22:59:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b12ae90df8f4a708c17266dbe1aefe5 : SUCCESS in 3m 24s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/29de434c163d4161ac7273ffc90aa947 : SUCCESS in 3m 12s","accounts_in_message":[],"_revision_number":2},{"id":"4bbfcb9bf3047e82f898d42be30134da8f4cca6d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-21 23:01:10.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/868bc49f0896421a899927a922d930c5 : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":2},{"id":"b95f6150b4a4811bb34964789fe171eb95050867","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-05-21 23:03:51.000000000","message":"Patch Set 2:\n\nShouldn\u0027t devstack-plugin-ceph-tempest-py3 be part of the gate queue too?","accounts_in_message":[],"_revision_number":2},{"id":"3ac33651e93e7827944e1dc408e9ac58559f20b7","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-05-21 23:04:09.000000000","message":"Patch Set 2:\n\nWe also need the jobs to test against the stable branches.","accounts_in_message":[],"_revision_number":2},{"id":"7e7f69e042b109b6b7dc7f3f1abe08c65e2ded3c","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-05-21 23:21:11.000000000","message":"Patch Set 2:\n\n\u003e Shouldn\u0027t devstack-plugin-ceph-tempest-py3 be part of the gate\n \u003e queue too?\n\n+1, please add. i think we missed that while making it voting.","accounts_in_message":[],"_revision_number":2},{"id":"14da512e7d0c8a6b503d423bc8691210e1c74e42","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-05-21 23:23:52.000000000","message":"Patch Set 2:\n\n\u003e We also need the jobs to test against the stable branches.\n\nwe can add\n\n \u003e We also need the jobs to test against the stable branches.\n\nI added those but as part of experimental which is enough here\n - https://review.opendev.org/#/c/668223/4\n- we need to update those for ussuri and remove rocky one.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3987d1d673379a340fa8b345ae0484f83b2b97fb","revisions":{"d85bc9bd53ea2f0dbbbe87a9a1cb2b25dda6eb75":{"kind":"REWORK","_number":1,"created":"2020-05-01 21:11:02.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/31/724931/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/31/724931/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/1"}}},"commit":{"parents":[{"commit":"c1fc88670c0cd1ffa6d13779427c506f5feddb10","subject":"Skip rescue BFV instance tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c1fc88670c0cd1ffa6d13779427c506f5feddb10"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-05-01 21:05:17.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-05-01 21:05:17.000000000","tz":120},"subject":"Enable encrypted volume attachment on non-master branch","message":"Enable encrypted volume attachment on non-master branch\n\nImplement an old TODO item, but in the other way: instead of\nenabling the feature on certain branches, disable it on the old\nbranches (anything still open before queens, driverfixes or stable)\nand rely on the default value (True) otherwise.\n\nChange-Id: Id5dedf496b355362031deefab1573d052fc72a66\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/d85bc9bd53ea2f0dbbbe87a9a1cb2b25dda6eb75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/d85bc9bd53ea2f0dbbbe87a9a1cb2b25dda6eb75"}]},"branch":"refs/heads/master"},"3987d1d673379a340fa8b345ae0484f83b2b97fb":{"kind":"REWORK","_number":2,"created":"2020-05-20 23:56:49.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/31/724931/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/31/724931/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/31/724931/2"}}},"commit":{"parents":[{"commit":"c1fc88670c0cd1ffa6d13779427c506f5feddb10","subject":"Skip rescue BFV instance tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/c1fc88670c0cd1ffa6d13779427c506f5feddb10"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-05-20 23:55:58.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2020-05-20 23:55:58.000000000","tz":120},"subject":"Enable encrypted volume attachment on non-master branch","message":"Enable encrypted volume attachment on non-master branch\n\nImplement an old TODO item, but in the other way: instead of\nenabling the feature on certain branches, disable it on the old\nbranches (anything still open - even EM - before queens)\nand rely on the default value (True) otherwise.\n\nChange-Id: Id5dedf496b355362031deefab1573d052fc72a66\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/3987d1d673379a340fa8b345ae0484f83b2b97fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/3987d1d673379a340fa8b345ae0484f83b2b97fb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}