)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~735078","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~I5e64438a1a5f84dc3ff18d81adce8896d6e275bb","project":"openstack/devstack-plugin-ceph","branch":"master","hashtags":[],"change_id":"I5e64438a1a5f84dc3ff18d81adce8896d6e275bb","subject":"Add description for configure the iscsi-gateway.cfg","status":"ABANDONED","created":"2020-06-11 08:25:32.000000000","updated":"2020-08-28 08:40:41.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d47488bd9f9b55692049c22a3351ce4aecc18f1a","_number":735078,"virtual_id_number":735078,"owner":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-06-18 09:20:41.000000000","_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-11 09:35:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-06-16 17:57:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},{"value":2,"date":"2020-06-16 16:46:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"date":"2020-06-18 09:16:20.000000000","_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-11 09:35:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-16 16:46:40.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2020-06-16 17:57:58.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2020-06-18 09:16:20.000000000","updated_by":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"reviewer":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"state":"REVIEWER"}],"messages":[{"id":"05ef20416a70455a3252d6982c084ccafe781ce5","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2020-06-11 08:25:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6be2ebc556ba542d52d495138171aeb86d383d79","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-11 09:35:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/05d4a38e21c24889bceb78064dc2d0c3 : SUCCESS in 1h 01m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af16f49165cd498db5fd1ed5b14190e9 : SUCCESS in 5m 56s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/665c5cf0cfb74f0397f1620527863753 : SUCCESS in 5m 40s\n- manila-tempest-minimal-dsvm-cephfs-native https://zuul.opendev.org/t/openstack/build/86f6a5f28495460cb8f4476730a7b6ce : SUCCESS in 28m 47s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://zuul.opendev.org/t/openstack/build/90a84d020f114bdaaca99b32f6234ff8 : SUCCESS in 1h 07m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a21eab77e3a10682e7555221f5f5d665d8bf5b6b","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-06-16 16:46:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"11cf82c5cc97e287578fa400021ffe5f2848296d","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2020-06-16 17:57:58.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e5b9bd66bc3b0cf921df1dece58c18e4afdc121b","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2020-06-18 09:16:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c91c08f9e15ffadac244be199985cd733fa758a","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2020-06-18 09:20:41.000000000","message":"Patch Set 1:\n\nHi @hemna,\n\nJust have a test for \"change from localhost to HOST_IP\", and I still got error:\nThe first gateway defined must be the local machine.\nAnd dig into the code on ceph-iscsi, it show that:\n\nlocal_gw \u003d this_host()\ncurrent_gateways \u003d [tgt.name for tgt in self.children]\nif gateway_name !\u003d local_gw and len(current_gateways) \u003d\u003d 0:\n     self.logger.error(\"The first gateway defined must be the local \"\n                              \"machine\")\n     return\n\nI can see that the function this_host() is very important, And the gateway_name is the parameters we set as HOST_NAME which by default is localhost.\n\nFor this_host(), it will call socket.getfqdn(), \nhttps://docs.python.org/2/library/socket.html#socket.getfqdn. Usually if we run devstack, we will do a process to modify /etc/hosts, see - \u003e\nhttps://opendev.org/openstack/devstack/src/branch/master/stack.sh#L331\n\nAfter this modification to /etc/hosts, it can guarantee that the socket.getfqdn() will return \u0027localhost\u0027, if you do not set more entries to the /etc/hosts.\n\nFor my env, after a fresh running devstack, the /etc/hosts:\n127.0.0.1 localhost ubuntu-focal-devstack\n127.0.1.1 ubuntu-focal-devstack\n\n# The following lines are desirable for IPv6 capable hosts\n::1     ip6-localhost ip6-loopback\nfe00::0 ip6-localnet\nff00::0 ip6-mcastprefix\nff02::1 ip6-allnodes\nff02::2 ip6-allrouters\n\nand socket.getfqdn()\n\u0027localhost\u0027.","accounts_in_message":[],"_revision_number":1},{"id":"d47488bd9f9b55692049c22a3351ce4aecc18f1a","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2020-08-28 08:40:41.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"657e2119e76ca0263b309d9ef1d0160e86c63a9f","revisions":{"657e2119e76ca0263b309d9ef1d0160e86c63a9f":{"kind":"REWORK","_number":1,"created":"2020-06-11 08:25:32.000000000","uploader":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"ref":"refs/changes/78/735078/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/78/735078/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/78/735078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/78/735078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/78/735078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/78/735078/1"}}},"commit":{"parents":[{"commit":"d17b8c1cd875621a0cec5562b0c12d1d78cbfe5d","subject":"Merge \"Update stable jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/d17b8c1cd875621a0cec5562b0c12d1d78cbfe5d"}]}],"author":{"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","date":"2020-06-11 08:21:09.000000000","tz":480},"committer":{"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","date":"2020-06-11 08:21:09.000000000","tz":480},"subject":"Add description for configure the iscsi-gateway.cfg","message":"Add description for configure the iscsi-gateway.cfg\n\nEspecially the HOST_IP and HOSTNAME mapping relationship.\n\nChange-Id: I5e64438a1a5f84dc3ff18d81adce8896d6e275bb\nSigned-off-by: Kevin Zhao \u003ckevin.zhao@linaro.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/657e2119e76ca0263b309d9ef1d0160e86c63a9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/657e2119e76ca0263b309d9ef1d0160e86c63a9f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}