)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"c12ff65b23907db201a9ba45306e0b68c55177e1","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"        cmake -Dwith-glfs\u003dfalse -Dwith-qcow\u003dfalse -DSUPPORT_SYSTEMD\u003don -DCMAKE_INSTALL_PREFIX\u003d/usr"},{"line_number":1021,"context_line":"        sudo make install"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        pip_install rtslib-fb"},{"line_number":1024,"context_line":"        pip_install configshell-fb"},{"line_number":1025,"context_line":"        pip_install targetcli-fb"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"        if [ ! -d /etc/target ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_551474a0","line":1024,"range":{"start_line":1023,"start_character":8,"end_line":1024,"end_character":34},"updated":"2020-06-18 09:25:16.000000000","message":"These 2 packages are also needed to be installed in focal I think.","commit_id":"f27f884b20702f16c9c3ffb5f7603ea6734474e7"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d85a4a3c6ac484ba29e13af1b657393756b72683","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"        cmake -Dwith-glfs\u003dfalse -Dwith-qcow\u003dfalse -DSUPPORT_SYSTEMD\u003don -DCMAKE_INSTALL_PREFIX\u003d/usr"},{"line_number":1021,"context_line":"        sudo make install"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        pip_install rtslib-fb"},{"line_number":1024,"context_line":"        pip_install configshell-fb"},{"line_number":1025,"context_line":"        pip_install targetcli-fb"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"        if [ ! -d /etc/target ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_52362d54","line":1024,"range":{"start_line":1023,"start_character":8,"end_line":1024,"end_character":34},"in_reply_to":"bf51134e_551474a0","updated":"2020-06-19 09:36:36.000000000","message":"Focal has python3-configshell-fb and python3-rtslib-fb. Because ceph-iscsi package depends on these packages, we only need to install ceph-iscsi in Focal.","commit_id":"f27f884b20702f16c9c3ffb5f7603ea6734474e7"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"c12ff65b23907db201a9ba45306e0b68c55177e1","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        fi"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":1133,"context_line":"            if python3_enabled; then"},{"line_number":1134,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-pyparsing python-kmodpy python3-pyudev\""},{"line_number":1135,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python3-urwid\""},{"line_number":1136,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-netifaces python3-crypto python3-requests python3-flask\""},{"line_number":1137,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-openssl python3-rpm open-iscsi\""},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-pyparsing python-kmodpy python-pyudev\""},{"line_number":1140,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python-urwid python-rados python-rbd\""},{"line_number":1141,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1142,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl python-rpm open-iscsi\""},{"line_number":1143,"context_line":"            fi"},{"line_number":1144,"context_line":"        fi"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"        # Update package repo."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_9583accc","line":1143,"range":{"start_line":1133,"start_character":10,"end_line":1143,"end_character":14},"updated":"2020-06-18 09:25:16.000000000","message":"if in focal, \nthose packages will not needed. The dependencies will be automatically solved by apt","commit_id":"f27f884b20702f16c9c3ffb5f7603ea6734474e7"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d85a4a3c6ac484ba29e13af1b657393756b72683","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        fi"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":1133,"context_line":"            if python3_enabled; then"},{"line_number":1134,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-pyparsing python-kmodpy python3-pyudev\""},{"line_number":1135,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python3-urwid\""},{"line_number":1136,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-netifaces python3-crypto python3-requests python3-flask\""},{"line_number":1137,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python3-openssl python3-rpm open-iscsi\""},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-pyparsing python-kmodpy python-pyudev\""},{"line_number":1140,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python-urwid python-rados python-rbd\""},{"line_number":1141,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1142,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl python-rpm open-iscsi\""},{"line_number":1143,"context_line":"            fi"},{"line_number":1144,"context_line":"        fi"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"        # Update package repo."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_d2223d00","line":1143,"range":{"start_line":1133,"start_character":10,"end_line":1143,"end_character":14},"in_reply_to":"bf51134e_9583accc","updated":"2020-06-19 09:36:36.000000000","message":"Yes, you are right, will update the patch soon. Maybe it is good to handle all the iscsi package in one place setup_packages_for_iscsi.","commit_id":"f27f884b20702f16c9c3ffb5f7603ea6734474e7"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0043eb2b855dfb2d0535178ad6ce4dd11b946cd6","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-pyparsing python-kmodpy python-pyudev\""},{"line_number":1124,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python-urwid python-rados python-rbd\""},{"line_number":1125,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1126,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl python-rpm open-iscsi\""},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"                # The packages needed to build tcmu-runner, since there is no"},{"line_number":1129,"context_line":"                # ubuntu package prior to focal yet."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_65b323ea","line":1126,"updated":"2020-06-29 13:47:49.000000000","message":"focal has packages for tcmu-runner, targetcli-fb and ceph-iscsi.","commit_id":"180eca945141c0b48603ae26dd3863f40fe57720"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"f3c610b7e0b979ba44d7464568ecf687ed9cc389","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-pyparsing python-kmodpy python-pyudev\""},{"line_number":1124,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-gobject python-urwid python-rados python-rbd\""},{"line_number":1125,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1126,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl python-rpm open-iscsi\""},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"                # The packages needed to build tcmu-runner, since there is no"},{"line_number":1129,"context_line":"                # ubuntu package prior to focal yet."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_9b084f2e","line":1126,"in_reply_to":"bf51134e_65b323ea","updated":"2020-06-30 04:02:17.000000000","message":"On Focal, ceph-iscsi already depends on other required packages. Here it only need to install ceph-iscsi and targetcli-fb packages.\n\nlinaro@j13-r120-t32-09:~$ apt depends ceph-iscsi\nceph-iscsi\n  PreDepends: init-system-helpers (\u003e\u003d 1.54~)\n  Depends: python3-configshell-fb\n  Depends: python3-cryptography\n  Depends: python3-distutils\n  Depends: python3-flask\n  Depends: python3-netifaces\n  Depends: python3-openssl\n  Depends: python3-rados\n  Depends: python3-rbd\n  Depends: python3-requests\n  Depends: python3-rtslib-fb\n  Depends: tcmu-runner (\u003e\u003d 1.4.0)\n  Depends: \u003cpython3:any\u003e\n    python3","commit_id":"180eca945141c0b48603ae26dd3863f40fe57720"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a5b66949ebe7a9dac3fcf29f5dc6873b4226269e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"CEPH_ISCSI_MINIMUM_GATEWAYS\u003d${CEPH_ISCSI_MINIMUM_GATEWAYS:-1}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# gwcli requires a pool named rbd"},{"line_number":127,"context_line":"CEPH_ISCSI_POOL\u003d${CEPH_ISCSI_POOL:-$CINDER_CEPH_POOL}"},{"line_number":128,"context_line":"CEPH_ISCSI_POOL_PG\u003d${CEPH_ISCSI_POOL_PG:-8}"},{"line_number":129,"context_line":"TCMU_RUNNER_REPO\u003d\"https://github.com/open-iscsi/tcmu-runner.git\""},{"line_number":130,"context_line":"TARGETCLI_REPO\u003d\"https://github.com/open-iscsi/targetcli-fb.git\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_b89ce75b","line":127,"updated":"2020-07-06 14:35:17.000000000","message":"This breaks export LUNs.  There MUST be a ceph pool named \u0027rbd\u0027 in order for rbd-target-api to work properly when exporting a LUN.  This broke ceph-iscsi support.","commit_id":"51ac559fe6005dc9a1e70f25bef7fae4e9815592"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4342971f1f4f33bac2b463cf9bbe04180f5cf6f6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"CEPH_ISCSI_MINIMUM_GATEWAYS\u003d${CEPH_ISCSI_MINIMUM_GATEWAYS:-1}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# gwcli requires a pool named rbd"},{"line_number":127,"context_line":"CEPH_ISCSI_POOL\u003d${CEPH_ISCSI_POOL:-$CINDER_CEPH_POOL}"},{"line_number":128,"context_line":"CEPH_ISCSI_POOL_PG\u003d${CEPH_ISCSI_POOL_PG:-8}"},{"line_number":129,"context_line":"TCMU_RUNNER_REPO\u003d\"https://github.com/open-iscsi/tcmu-runner.git\""},{"line_number":130,"context_line":"TARGETCLI_REPO\u003d\"https://github.com/open-iscsi/targetcli-fb.git\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_180face1","line":127,"in_reply_to":"bf51134e_34aba289","updated":"2020-07-08 11:59:28.000000000","message":"Ceph-iscsi isn\u0027t using that pool to create volumes, it\u0027s used to store metadata.  If the \u0027rbd\u0027 pool doesn\u0027t exist, it can\u0027t work.","commit_id":"51ac559fe6005dc9a1e70f25bef7fae4e9815592"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"70276de3fab49786d67a719b3f2a100a0dab8390","unresolved":false,"context_lines":[{"line_number":124,"context_line":"CEPH_ISCSI_MINIMUM_GATEWAYS\u003d${CEPH_ISCSI_MINIMUM_GATEWAYS:-1}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# gwcli requires a pool named rbd"},{"line_number":127,"context_line":"CEPH_ISCSI_POOL\u003d${CEPH_ISCSI_POOL:-$CINDER_CEPH_POOL}"},{"line_number":128,"context_line":"CEPH_ISCSI_POOL_PG\u003d${CEPH_ISCSI_POOL_PG:-8}"},{"line_number":129,"context_line":"TCMU_RUNNER_REPO\u003d\"https://github.com/open-iscsi/tcmu-runner.git\""},{"line_number":130,"context_line":"TARGETCLI_REPO\u003d\"https://github.com/open-iscsi/targetcli-fb.git\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_34aba289","line":127,"in_reply_to":"bf51134e_b89ce75b","updated":"2020-07-08 02:23:16.000000000","message":"I thought cinder should be use the same pool as ceph-iscsi.\nhttps://github.com/openstack/devstack/blob/991b1f13f0aed578dccec2e761be69005357444f/lib/cinder_backends/ceph#L49\nAnd ceph-iscsi now support configuring pool now, not just hardcode to \"rbd\".\nhttps://ceph.io/community/new-in-nautilus-ceph-iscsi-improvements/","commit_id":"51ac559fe6005dc9a1e70f25bef7fae4e9815592"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8005b810f2d3c27ca27d952c51c05514d4360a6f","unresolved":false,"context_lines":[{"line_number":959,"context_line":"    fi"},{"line_number":960,"context_line":"}"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"function setup_packages_for_iscsi {"},{"line_number":963,"context_line":"    CWD\u003d$(pwd)"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"    # We have to install the following required packages for ceph-iscsi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_40ce342d","line":962,"updated":"2020-07-09 13:51:02.000000000","message":"This should get removed as openstack won\u0027t support projects that require packages installed with git clone.","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"3ef2b26b6ddae5207242124a09ad334d66c25369","unresolved":false,"context_lines":[{"line_number":959,"context_line":"    fi"},{"line_number":960,"context_line":"}"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"function setup_packages_for_iscsi {"},{"line_number":963,"context_line":"    CWD\u003d$(pwd)"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"    # We have to install the following required packages for ceph-iscsi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_0451e2d9","line":962,"in_reply_to":"bf51134e_40ce342d","updated":"2020-07-10 09:00:54.000000000","message":"Done","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8005b810f2d3c27ca27d952c51c05514d4360a6f","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            # Only Ubuntu Focal have the required packages. Using distro provided"},{"line_number":1063,"context_line":"            # packages might be more stable for CI."},{"line_number":1064,"context_line":"            if [[ $os_CODENAME \u003d~ focal ]]; then"},{"line_number":1065,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} ceph-iscsi targetcli-fb \""},{"line_number":1066,"context_line":"            else"},{"line_number":1067,"context_line":"                die $LINENO \"For ubuntu, ceph iscsi only support focal now\""},{"line_number":1068,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_c04524b6","line":1065,"updated":"2020-07-09 13:51:02.000000000","message":"missing open-iscsi and tcmu-runner","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"87bff70cd5c8ef98270607eade358e99670a2ec6","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            # Only Ubuntu Focal have the required packages. Using distro provided"},{"line_number":1063,"context_line":"            # packages might be more stable for CI."},{"line_number":1064,"context_line":"            if [[ $os_CODENAME \u003d~ focal ]]; then"},{"line_number":1065,"context_line":"                CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} ceph-iscsi targetcli-fb \""},{"line_number":1066,"context_line":"            else"},{"line_number":1067,"context_line":"                die $LINENO \"For ubuntu, ceph iscsi only support focal now\""},{"line_number":1068,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_b0b95316","line":1065,"in_reply_to":"bf51134e_c04524b6","updated":"2020-07-10 04:02:36.000000000","message":"ceph-iscsi depends on tcmu-runner. Install ceph-iscsi should be enough.\nstack@j13-r120-t32-09:~$ apt depends ceph-iscsi |grep tcmu-runner\n  Depends: tcmu-runner (\u003e\u003d 1.4.0)\n\nAnd open-iscsi initiator tool is installed in n-cpu already.\nhttps://github.com/openstack/devstack/blob/64ae08383a137d8b7fd18a8d8bc5c0fc191a186d/files/debs/n-cpu#L7","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8005b810f2d3c27ca27d952c51c05514d4360a6f","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1095,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl iscsi-initiator-utils\""},{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"            setup_packages_for_iscsi"},{"line_number":1098,"context_line":"        fi"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        install_package ${CEPH_PACKAGES}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_c0736415","line":1097,"updated":"2020-07-09 13:51:02.000000000","message":"this has to be after install_package","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"87bff70cd5c8ef98270607eade358e99670a2ec6","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-netifaces python-crypto python-requests python-flask\""},{"line_number":1095,"context_line":"            CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} python-openssl iscsi-initiator-utils\""},{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"            setup_packages_for_iscsi"},{"line_number":1098,"context_line":"        fi"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        install_package ${CEPH_PACKAGES}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_1038ff9d","line":1097,"in_reply_to":"bf51134e_c0736415","updated":"2020-07-10 04:02:36.000000000","message":"Yes, you are right, will fix it.","commit_id":"c98f7c1ad0204800f221d70099c35d6d0f54f547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b962a9f552e685fd51d09358a2227769cdabc4b0","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_user\" \"$CEPH_ISCSI_API_USER\""},{"line_number":566,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_password\" \"$CEPH_ISCSI_API_PASSWORD\""},{"line_number":567,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_port\" \"$CEPH_ISCSI_API_PORT\""},{"line_number":568,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_host\" \"$CEPH_ISCSI_API_HOST\""},{"line_number":569,"context_line":"}"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"function _configure_ceph_iscsi {"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_de6de3cc","side":"PARENT","line":568,"updated":"2020-08-05 13:48:14.000000000","message":"this should not be removed.","commit_id":"819f3995afba5d854eedac1c52871c441799457c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bb973708166d6a3cf860286f8c1ef11fc857e041","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_user\" \"$CEPH_ISCSI_API_USER\""},{"line_number":566,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_password\" \"$CEPH_ISCSI_API_PASSWORD\""},{"line_number":567,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_port\" \"$CEPH_ISCSI_API_PORT\""},{"line_number":568,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_host\" \"$CEPH_ISCSI_API_HOST\""},{"line_number":569,"context_line":"}"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"function _configure_ceph_iscsi {"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_8115cb9e","side":"PARENT","line":568,"in_reply_to":"9f560f44_de6de3cc","updated":"2020-08-05 19:09:55.000000000","message":"actually, this is fine.  nm.","commit_id":"819f3995afba5d854eedac1c52871c441799457c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ba56dbf18227ebae66597eb707c99b40c57404bb","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"trusted_ip_list\" \"$HOST_IP,localhost\""},{"line_number":564,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"cluster_name\" \"ceph\""},{"line_number":565,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"gateway_keyring\" \"ceph.client.admin.keyring\""},{"line_number":566,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"prometheus_host\" \"$CEPH_ISCSI_API_HOST\""},{"line_number":567,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_secure\" \"false\""},{"line_number":568,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_user\" \"$CEPH_ISCSI_API_USER\""},{"line_number":569,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_password\" \"$CEPH_ISCSI_API_PASSWORD\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_3e5e9f11","line":566,"updated":"2020-08-05 13:49:29.000000000","message":"why are you setting the prometheus_host to ceph iscsi api host ip address?","commit_id":"478b61632be5f8d36824cb11b89a7f6ca396823c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bb973708166d6a3cf860286f8c1ef11fc857e041","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"trusted_ip_list\" \"$HOST_IP,localhost\""},{"line_number":564,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"cluster_name\" \"ceph\""},{"line_number":565,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"gateway_keyring\" \"ceph.client.admin.keyring\""},{"line_number":566,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"prometheus_host\" \"$CEPH_ISCSI_API_HOST\""},{"line_number":567,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_secure\" \"false\""},{"line_number":568,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_user\" \"$CEPH_ISCSI_API_USER\""},{"line_number":569,"context_line":"    iniset -sudo ${CEPH_ISCSI_GATEWAY_CFG} config \"api_password\" \"$CEPH_ISCSI_API_PASSWORD\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_414613c2","line":566,"in_reply_to":"9f560f44_3e5e9f11","updated":"2020-08-05 19:09:55.000000000","message":"ignore.","commit_id":"478b61632be5f8d36824cb11b89a7f6ca396823c"}]}