)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5d05c5b17560180bb08f7755d030456665bdba6","unresolved":false,"context_lines":[{"line_number":970,"context_line":""},{"line_number":971,"context_line":"    if is_ubuntu; then"},{"line_number":972,"context_line":"        local distro_release\u003d\"bionic\""},{"line_number":973,"context_line":"\tlocal ganesha_release\u003d\"$GANESHA_RELEASE\""},{"line_number":974,"context_line":"        local ceph_release\u003d\"$CEPH_RELEASE\""},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f560f44_8f3549de","line":973,"updated":"2020-09-03 12:57:03.000000000","message":"Indentation is off here.","commit_id":"0b915123ea4faadb402c9afd8c6296e1d5d2f250"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5d05c5b17560180bb08f7755d030456665bdba6","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"},{"line_number":977,"context_line":"            distro_release\u003d\"xenial\""},{"line_number":978,"context_line":"\t    ganesha_release\u003d\"$GANESHA_RELEASE_STABLE\""},{"line_number":979,"context_line":"            ceph_release\u003d\"$CEPH_RELEASE_STABLE\""},{"line_number":980,"context_line":"        fi"},{"line_number":981,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f560f44_ef34c5e0","line":978,"updated":"2020-09-03 12:57:03.000000000","message":"^","commit_id":"0b915123ea4faadb402c9afd8c6296e1d5d2f250"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":995,"context_line":"    local distro_release\u003d\"$4\""},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"    if is_ubuntu; then"},{"line_number":998,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"},{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_f211f354","line":1000,"range":{"start_line":998,"start_character":8,"end_line":1000,"end_character":12},"updated":"2020-09-09 17:20:03.000000000","message":"xenial is not supported, we can drop this","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":995,"context_line":"    local distro_release\u003d\"$4\""},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"    if is_ubuntu; then"},{"line_number":998,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"},{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_084d583a","line":1000,"range":{"start_line":998,"start_character":8,"end_line":1000,"end_character":12},"in_reply_to":"9f560f44_121467e8","updated":"2020-09-09 18:45:28.000000000","message":"yes, our stable branches are using xenial so we need to stick to it for a while","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42b74ab65ee069d1445c175a6a3e9b146c261ad2","unresolved":false,"context_lines":[{"line_number":995,"context_line":"    local distro_release\u003d\"$4\""},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"    if is_ubuntu; then"},{"line_number":998,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"},{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_121467e8","line":1000,"range":{"start_line":998,"start_character":8,"end_line":1000,"end_character":12},"in_reply_to":"9f560f44_f211f354","updated":"2020-09-09 17:30:19.000000000","message":"This repository is branchless, and xenial is the OS in stable rocky and queens branches","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_7227a3b7","line":1002,"range":{"start_line":1002,"start_character":25,"end_line":1002,"end_character":31},"updated":"2020-09-09 17:20:03.000000000","message":"bionic?","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42b74ab65ee069d1445c175a6a3e9b146c261ad2","unresolved":false,"context_lines":[{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_d2d82f80","line":1002,"range":{"start_line":1002,"start_character":18,"end_line":1002,"end_character":31},"updated":"2020-09-09 17:30:19.000000000","message":"non xenial releases of ubuntu","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":999,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/nfs-ganesha/${ganesha_release}/${ceph_release}/ ${distro_release} main\""},{"line_number":1000,"context_line":"        else"},{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_68833457","line":1002,"range":{"start_line":1002,"start_character":18,"end_line":1002,"end_character":31},"in_reply_to":"9f560f44_d2d82f80","updated":"2020-09-09 18:45:28.000000000","message":"Yes, bionic and above, good catch","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23909a67083e7ad42baf0acf1744bc232072e7cf","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"},{"line_number":1006,"context_line":"    elif is_fedora; then"},{"line_number":1007,"context_line":"        dnf_add_repository_nfsganesha ${ganesha_release} ${ceph_release}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_f2261316","line":1004,"range":{"start_line":1004,"start_character":55,"end_line":1004,"end_character":70},"updated":"2020-09-09 17:45:49.000000000","message":"We ignore \"ganesha_release\" here... \n\nI wonder if anyone cares about the Ganesha release versions.. \nCan we just ask, what versions of ganesha are compatible with Ceph versions and just use the highest version supported and disallow configuring it?","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ce869e826b070daf4df4253b9a8a637da68424a7","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"},{"line_number":1006,"context_line":"    elif is_fedora; then"},{"line_number":1007,"context_line":"        dnf_add_repository_nfsganesha ${ganesha_release} ${ceph_release}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_2f3821ec","line":1004,"range":{"start_line":1004,"start_character":55,"end_line":1004,"end_character":70},"in_reply_to":"9f560f44_684b3486","updated":"2020-09-09 20:51:32.000000000","message":"Yes, let\u0027s stick to 2.7","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"018903c6cc0f046956e060ed7843f476bddaf8ed","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"},{"line_number":1006,"context_line":"    elif is_fedora; then"},{"line_number":1007,"context_line":"        dnf_add_repository_nfsganesha ${ganesha_release} ${ceph_release}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_684b3486","line":1004,"range":{"start_line":1004,"start_character":55,"end_line":1004,"end_character":70},"in_reply_to":"9f560f44_a8eeec1d","updated":"2020-09-09 19:05:55.000000000","message":"So we can remove the config option then?\n\nWe can stick with Ganesha 2.7 for luminous and nautilus (only two versions we care about testing right now).","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"            # FIXME(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1002,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1003,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":1004,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":1005,"context_line":"        fi"},{"line_number":1006,"context_line":"    elif is_fedora; then"},{"line_number":1007,"context_line":"        dnf_add_repository_nfsganesha ${ganesha_release} ${ceph_release}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_a8eeec1d","line":1004,"range":{"start_line":1004,"start_character":55,"end_line":1004,"end_character":70},"in_reply_to":"9f560f44_f2261316","updated":"2020-09-09 18:45:28.000000000","message":"Yes, I just stick with the version we were were using. In shaman, for ceph_nautilus, it defaults to nfs-ganesha-2.7","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"# Usage: cleanup_repo_nfsganesha"},{"line_number":1015,"context_line":"function cleanup_repo_nfsganesha {"},{"line_number":1016,"context_line":"    if is_ubuntu; then"},{"line_number":1017,"context_line":"        if [[ $os_CODENAME \u003d~ (xenial) ]]; then"},{"line_number":1018,"context_line":"            sudo apt-add-repository -r -y \"deb https://download.ceph.com/nfs-ganesha/${GANESHA_RELEASE_STABLE}/${CEPH_RELEASE_STABLE}/ xenial main\""},{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_32188b74","line":1018,"range":{"start_line":1017,"start_character":0,"end_line":1018,"end_character":147},"updated":"2020-09-09 17:20:03.000000000","message":"xenial is not supported, we can drop this","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            sudo apt-add-repository -r -y \"deb https://download.ceph.com/nfs-ganesha/${GANESHA_RELEASE_STABLE}/${CEPH_RELEASE_STABLE}/ xenial main\""},{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1022,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-libntirpc-1_7-bionic.list"},{"line_number":1023,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-nfs-ganesha-2_7-bionic.list"},{"line_number":1024,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_1215873d","line":1021,"range":{"start_line":1021,"start_character":25,"end_line":1021,"end_character":31},"updated":"2020-09-09 17:20:03.000000000","message":"bionic?","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"42b74ab65ee069d1445c175a6a3e9b146c261ad2","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            sudo apt-add-repository -r -y \"deb https://download.ceph.com/nfs-ganesha/${GANESHA_RELEASE_STABLE}/${CEPH_RELEASE_STABLE}/ xenial main\""},{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1022,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-libntirpc-1_7-bionic.list"},{"line_number":1023,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-nfs-ganesha-2_7-bionic.list"},{"line_number":1024,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_b223fb57","line":1021,"range":{"start_line":1021,"start_character":18,"end_line":1021,"end_character":31},"updated":"2020-09-09 17:30:19.000000000","message":"non xenial releases of ubuntu","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            sudo apt-add-repository -r -y \"deb https://download.ceph.com/nfs-ganesha/${GANESHA_RELEASE_STABLE}/${CEPH_RELEASE_STABLE}/ xenial main\""},{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1022,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-libntirpc-1_7-bionic.list"},{"line_number":1023,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-nfs-ganesha-2_7-bionic.list"},{"line_number":1024,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_88f32809","line":1021,"range":{"start_line":1021,"start_character":18,"end_line":1021,"end_character":31},"in_reply_to":"9f560f44_b223fb57","updated":"2020-09-09 18:45:28.000000000","message":"ditto","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23909a67083e7ad42baf0acf1744bc232072e7cf","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1022,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-libntirpc-1_7-bionic.list"},{"line_number":1023,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-nfs-ganesha-2_7-bionic.list"},{"line_number":1024,"context_line":"        fi"},{"line_number":1025,"context_line":"    elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_52189fd1","line":1022,"range":{"start_line":1022,"start_character":76,"end_line":1022,"end_character":92},"updated":"2020-09-09 17:45:49.000000000","message":"*\n\nto be safe for focal?","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        else"},{"line_number":1020,"context_line":"            # NOTE(vkmc) We need to use community ppa\u0027s because there is no build available"},{"line_number":1021,"context_line":"            # for ubuntu xenial for nfs-ganesha-2.7. Remove this when they provide the build in download.ceph.com"},{"line_number":1022,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-libntirpc-1_7-bionic.list"},{"line_number":1023,"context_line":"            sudo rm -rf /etc/apt/sources.list.d/nfs-ganesha-ubuntu-nfs-ganesha-2_7-bionic.list"},{"line_number":1024,"context_line":"        fi"},{"line_number":1025,"context_line":"    elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_e8490432","line":1022,"range":{"start_line":1022,"start_character":76,"end_line":1022,"end_character":92},"in_reply_to":"9f560f44_52189fd1","updated":"2020-09-09 18:45:28.000000000","message":"sure thing","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        else"},{"line_number":1037,"context_line":"            configure_repo_nfsganesha \"apt-get\" \"$GANESHA_RELEASE\" \"$CEPH_RELEASE\" \"$os_CODENAME\""},{"line_number":1038,"context_line":"        fi"},{"line_number":1039,"context_line":"        CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} libntirpc1 nfs-ganesha nfs-ganesha-ceph\""},{"line_number":1040,"context_line":"    fi"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"    if python3_enabled; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_52037f0d","line":1039,"range":{"start_line":1039,"start_character":40,"end_line":1039,"end_character":50},"updated":"2020-09-09 17:20:03.000000000","message":"weeeird - is not it pulled in by others?","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        else"},{"line_number":1037,"context_line":"            configure_repo_nfsganesha \"apt-get\" \"$GANESHA_RELEASE\" \"$CEPH_RELEASE\" \"$os_CODENAME\""},{"line_number":1038,"context_line":"        fi"},{"line_number":1039,"context_line":"        CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} libntirpc1 nfs-ganesha nfs-ganesha-ceph\""},{"line_number":1040,"context_line":"    fi"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"    if python3_enabled; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_48d63051","line":1039,"range":{"start_line":1039,"start_character":40,"end_line":1039,"end_character":50},"in_reply_to":"9f560f44_52037f0d","updated":"2020-09-09 18:45:28.000000000","message":"No, in fact the nfs-ganesha community indicates we need to get the repo and install this library separately. It caught my attention too, but that\u0027s how it is.","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"function setup_packages_for_manila_on_fedora_family {"},{"line_number":1048,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1049,"context_line":"        # NOTE(vkmc) el7 packages work on Fedora"},{"line_number":1050,"context_line":"        configure_repo_nfsganesha \"dnf\" \"$GANESHA_RELEASE\" \"$CEPH_RELEASE\" \"el7\""},{"line_number":1051,"context_line":"        CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} nfs-ganesha nfs-ganesha-ceph\""},{"line_number":1052,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_1700d901","line":1049,"range":{"start_line":1049,"start_character":8,"end_line":1049,"end_character":48},"updated":"2020-09-09 17:20:03.000000000","message":"ditto from below","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"function setup_packages_for_manila_on_fedora_family {"},{"line_number":1048,"context_line":"    if [ $MANILA_CEPH_DRIVER \u003d\u003d \u0027cephfsnfs\u0027 ]; then"},{"line_number":1049,"context_line":"        # NOTE(vkmc) el7 packages work on Fedora"},{"line_number":1050,"context_line":"        configure_repo_nfsganesha \"dnf\" \"$GANESHA_RELEASE\" \"$CEPH_RELEASE\" \"el7\""},{"line_number":1051,"context_line":"        CEPH_PACKAGES\u003d\"${CEPH_PACKAGES} nfs-ganesha nfs-ganesha-ceph\""},{"line_number":1052,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_08b8b80e","line":1049,"range":{"start_line":1049,"start_character":8,"end_line":1049,"end_character":48},"in_reply_to":"9f560f44_1700d901","updated":"2020-09-09 18:45:28.000000000","message":"ditto from below :)","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3be50b336fd330f8fbb486f0f8e8a2e9fbe4185","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"            die $LINENO \"Supported for Fedora 31 and 32. Not supported for other releases.\""},{"line_number":1098,"context_line":"        fi"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        # NOTE(vkmc) el7 packages work on Fedora"},{"line_number":1101,"context_line":"        configure_repo_ceph \"dnf\" \"$CEPH_RELEASE\" \"el7\""},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_9714e94e","line":1100,"range":{"start_line":1100,"start_character":21,"end_line":1100,"end_character":48},"updated":"2020-09-09 17:20:03.000000000","message":"this is super suspicious","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"92f29c52a7199c6d6dd2de7f3c7c419763c56e9f","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"            die $LINENO \"Supported for Fedora 31 and 32. Not supported for other releases.\""},{"line_number":1098,"context_line":"        fi"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        # NOTE(vkmc) el7 packages work on Fedora"},{"line_number":1101,"context_line":"        configure_repo_ceph \"dnf\" \"$CEPH_RELEASE\" \"el7\""},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        CEPH_PACKAGES\u003d\"ceph\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_28bbfc0e","line":1100,"range":{"start_line":1100,"start_character":21,"end_line":1100,"end_character":48},"in_reply_to":"9f560f44_9714e94e","updated":"2020-09-09 18:45:28.000000000","message":"There are no builds for Fedora, in download.ceph.com you only get rpms built for el7 or el8 and those are the ones rpm based distros are using","commit_id":"b3ddce3c419a0961d59c6389b2c4b547f40b5100"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e5366920338c32a27351855c6ec7231aaecb64a4","unresolved":false,"context_lines":[{"line_number":994,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/libntirpc-1.7"},{"line_number":995,"context_line":"            sudo add-apt-repository -y ppa:nfs-ganesha/nfs-ganesha-2.7"},{"line_number":996,"context_line":"        fi"},{"line_number":997,"context_line":"    elif is_fedora; then"},{"line_number":998,"context_line":"        dnf_add_repository_nfsganesha ${ganesha_release} ${ceph_release}"},{"line_number":999,"context_line":"    fi"},{"line_number":1000,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f560f44_12dd8240","line":997,"updated":"2020-09-09 21:11:18.000000000","message":"bashate: E040 Syntax error: syntax error near unexpected token `elif\u0027","commit_id":"9163611b30952b6eca92c9473e2ab5a1e9078e06"}]}