)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"42129df00d759ce4f207a2b574be9fbefa48a60a","unresolved":true,"context_lines":[{"line_number":842,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"    # Fetch keyring if not already installed."},{"line_number":845,"context_line":"    if [[! is_ceph_enabled_for_service cinder \u0026\u0026 ! -f ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring ]]; then"},{"line_number":846,"context_line":"        sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":847,"context_line":"            auth get-or-create client.${CINDER_CEPH_USER} \\"},{"line_number":848,"context_line":"            mon \"allow r\" \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0efee571_53702062","line":845,"updated":"2021-01-08 17:09:56.000000000","message":"This appears to break the ceph-native and ceph-nfs jobs at devstack install.  They have nova enabled (for scenario testing I think) but don\u0027t require cinder so that service is disabled.  When import_libvirt_secret_ceph runs it tries to install a client.cinder key anyways and now that breaks.\n\nSee e.g.\n\nhttps://zuul.opendev.org/t/openstack/build/97c3e4a2f6dd489e89034322a94cd9ee/log/controller/logs/devstacklog.txt#19187","commit_id":"02c565ccd0ebc147a82453391e2e2976d10916e4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1932de524cd89cd13d28c2d1e5d54ba76069e096","unresolved":true,"context_lines":[{"line_number":827,"context_line":"function configure_ceph_nova {"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    # Skip pool creation when using a remote ceph cluster"},{"line_number":830,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d\u003d \"False\" ]]; then"},{"line_number":831,"context_line":"        sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} osd pool create \\"},{"line_number":832,"context_line":"            ${NOVA_CEPH_POOL} ${NOVA_CEPH_POOL_PG} ${NOVA_CEPH_POOL_PGP}"},{"line_number":833,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"d16412dc_2153b614","line":830,"range":{"start_line":830,"start_character":29,"end_line":830,"end_character":34},"updated":"2021-02-20 15:11:49.000000000","message":"Huh? It should be \"True\" I think (based on the commit message and my sixth sense).","commit_id":"c3738e8b232f395f7d604f8083989535fa88a85d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"896944c423c423d3c57e4bf9d8b213b80c24b578","unresolved":true,"context_lines":[{"line_number":827,"context_line":"function configure_ceph_nova {"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    # Skip pool creation when using a remote ceph cluster"},{"line_number":830,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d\u003d \"False\" ]]; then"},{"line_number":831,"context_line":"        sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} osd pool create \\"},{"line_number":832,"context_line":"            ${NOVA_CEPH_POOL} ${NOVA_CEPH_POOL_PG} ${NOVA_CEPH_POOL_PGP}"},{"line_number":833,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"f4762578_56f867f4","line":830,"range":{"start_line":830,"start_character":29,"end_line":830,"end_character":34},"in_reply_to":"d16412dc_2153b614","updated":"2021-02-25 16:17:50.000000000","message":"if $REMOTE_CEPH is False, it means the deployment is local, which means you can run the ceph osd pool create command. If you rely on remote ceph ($REMOTE_CEPH \u003d\u003d True), you can\u0027t do that.","commit_id":"c3738e8b232f395f7d604f8083989535fa88a85d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"75423fe3b609646b92cd950cf8e0bf843f93f0da","unresolved":true,"context_lines":[{"line_number":827,"context_line":"function configure_ceph_nova {"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    # Skip pool creation when using a remote ceph cluster"},{"line_number":830,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d\u003d \"False\" ]]; then"},{"line_number":831,"context_line":"        sudo $DOCKER_EXEC ceph -c ${CEPH_CONF_FILE} osd pool create \\"},{"line_number":832,"context_line":"            ${NOVA_CEPH_POOL} ${NOVA_CEPH_POOL_PG} ${NOVA_CEPH_POOL_PGP}"},{"line_number":833,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ee93e98a_77a9bfb9","line":830,"range":{"start_line":830,"start_character":29,"end_line":830,"end_character":34},"in_reply_to":"f4762578_56f867f4","updated":"2021-03-08 14:23:03.000000000","message":"I actually did this as when REMTOE_CEPH\u003dTrue the pool has already been created by the devstack run on the controller. I can call this out in a comment.","commit_id":"c3738e8b232f395f7d604f8083989535fa88a85d"}]}