)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~765659","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Ib758a2326bcd43470502457e1b69b955638de5fc","project":"openstack/devstack-plugin-ceph","branch":"master","hashtags":[],"change_id":"Ib758a2326bcd43470502457e1b69b955638de5fc","subject":"Allow non-default Ceph cluster name","status":"ABANDONED","created":"2020-12-05 15:08:59.000000000","updated":"2021-02-11 13:16:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"22ed95f542a27a6062abd7e6bfae9e68f581fe25","_number":765659,"virtual_id_number":765659,"owner":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-07 22:42:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":-1,"date":"2020-12-08 11:08:28.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-05 16:27:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-05 16:55:55.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"CC"}],"messages":[{"id":"988648ff660a5c20859e78075807ffd33b1db304","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-12-05 15:08:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"810f68b46f83d130c5a509a1f3b353f695a7112b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-05 16:27:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/6442e65da6f942cc9c85388a4c0f1bfa : SUCCESS in 1h 05m 08s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/21e54e73d6fc4d9f857e433ab20b60b3 : SUCCESS in 1h 08m 25s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/233fff52103042af9de4f2fe6ede1473 : FAILURE in 1h 04m 52s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/5eaad7db30e44a08b86d7baaec3c59af : SUCCESS in 1h 12m 46s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7e221c4ceddc4a008226eaa7ccc5dd72 : SUCCESS in 4m 01s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/39f0b5ea4929480785163dfbe9065c90 : SUCCESS in 2m 13s","accounts_in_message":[],"_revision_number":1},{"id":"ec2828f5dd2620646e0e1a0572f0acd0a532696a","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-12-05 16:55:55.000000000","message":"Patch Set 1:\n\nmore like CEPH_CONF_FILE to me... ceph fsid is closer to ceph cluster name","accounts_in_message":[],"_revision_number":1},{"id":"730bc110aa55a96b159ac50545be39dcc2e68795","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-12-05 19:33:19.000000000","message":"Patch Set 1: Workflow-1\n\nif we change this other stuff has to change too","accounts_in_message":[],"_revision_number":1},{"id":"076d9e780dfdab6b082fd58e88f8a45ce97f2242","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-12-07 21:22:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9f6c7eb591ea8281affe950de4713f57d4d55c12","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-07 22:42:15.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/77a8eb146ce54b0aa1c357a438929881 : FAILURE in 1h 09m 37s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/900484f19ba747eb96b4c1e9fe06f734 : SUCCESS in 58m 10s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/f65bc4e116ec49e0837772f495a358ab : FAILURE in 51m 32s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/5003a0357fde45a2801dea4a86d48628 : SUCCESS in 1h 15m 27s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d87a66312c8c4e18b87635a2df3130c3 : SUCCESS in 5m 31s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/03357dcb72a64608afe527aabd735d84 : SUCCESS in 3m 49s","accounts_in_message":[],"_revision_number":2},{"id":"264c25942c5caf36f48db5c3bb976d428c747ed4","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-12-08 11:08:28.000000000","message":"Patch Set 2: Workflow-1\n\nNot clear if it\u0027s worth getting this to actually work but it\u0027s helping me debug some customer issues when the cluster name was changed ....","accounts_in_message":[],"_revision_number":2},{"id":"22ed95f542a27a6062abd7e6bfae9e68f581fe25","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-02-11 13:16:08.000000000","message":"Abandoned\n\nIt\u0027s not really the Ceph community\u0027s intention to support alternate cluster names.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dab0d04a8a750acc3eadb2be6baf23b0ab0223d0","revisions":{"2370ac5119b89ed536b2eda86a8a39c4711c1cab":{"kind":"REWORK","_number":1,"created":"2020-12-05 15:08:59.000000000","uploader":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"ref":"refs/changes/59/765659/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/59/765659/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/1"}}},"commit":{"parents":[{"commit":"0c73ea30173c6130e425207595ba5963702bdfe3","subject":"Merge \"zuul: Add devstack-plugin-ceph-compute-local-ephemeral job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/0c73ea30173c6130e425207595ba5963702bdfe3"}]}],"author":{"name":"Tom Barron","email":"tpb@dyncloud.net","date":"2020-12-05 15:08:30.000000000","tz":-300},"committer":{"name":"Tom Barron","email":"tpb@dyncloud.net","date":"2020-12-05 15:08:58.000000000","tz":-300},"subject":"Allow non-default Ceph cluster name","message":"Allow non-default Ceph cluster name\n\nChange-Id: Ib758a2326bcd43470502457e1b69b955638de5fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/2370ac5119b89ed536b2eda86a8a39c4711c1cab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/2370ac5119b89ed536b2eda86a8a39c4711c1cab"}]},"branch":"refs/heads/master"},"dab0d04a8a750acc3eadb2be6baf23b0ab0223d0":{"kind":"REWORK","_number":2,"created":"2020-12-07 21:22:04.000000000","uploader":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"ref":"refs/changes/59/765659/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/59/765659/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/59/765659/2"}}},"commit":{"parents":[{"commit":"336b9c3a4c91db5023aca78b782632455c67cc33","subject":"Clean up CEPH_DATA_DIR when unstacking","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/336b9c3a4c91db5023aca78b782632455c67cc33"}]}],"author":{"name":"Tom Barron","email":"tpb@dyncloud.net","date":"2020-12-05 15:08:30.000000000","tz":-300},"committer":{"name":"Tom Barron","email":"tpb@dyncloud.net","date":"2020-12-07 21:20:21.000000000","tz":-300},"subject":"Allow non-default Ceph cluster name","message":"Allow non-default Ceph cluster name\n\nAlthough use of Ceph cluster names other than \u0027ceph\u0027\nhas been deprecated [1] [2], it is still common for\ndeployments to have paths for ceph configuration that\ndo not end with \u0027ceph.conf\u0027 and to use client keys that\nare not of the form \u0027ceph.client.\u003cservice.keyname\u0027 (i.e., they\ndon\u0027t start with \u0027ceph\u0027.  We see this with ceph-ansible\ndeployed clusters and need to handle customer bugs\nfrom such deployments.\n\nHere we add a \u0027CEPH_CLUSTER\u0027 parameter, which defaults\nto \u0027ceph\u0027, but if set otherwise the ceph configuration,\nkeys, and other keypaths and systemd units are adjusted\naccordingly.  This should allow of upstream reproduction\nof issues seen with some ceph-ansible deployments but with\ndefault settings nothing in the devstack-plugin will change.\n\n[1] http://lists.ceph.com/pipermail/ceph-users-ceph.com/2017-June/018497.html\n[2] https://docs.ceph.com/en/latest/rados/configuration/common/\n\nChange-Id: Ib758a2326bcd43470502457e1b69b955638de5fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/dab0d04a8a750acc3eadb2be6baf23b0ab0223d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/dab0d04a8a750acc3eadb2be6baf23b0ab0223d0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}