)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2140121b6d73e0976408834871dc6109449dcf6d","unresolved":true,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"    # Clean up CEPH_DATA_DIR"},{"line_number":1179,"context_line":"    sudo umount ${CEPH_DATA_DIR}"},{"line_number":1180,"context_line":"    grep -v \"${CEPH_DATA_DIR}\" /etc/fstab | sudo tee /tmp/fstab"},{"line_number":1181,"context_line":"    sudo mv /tmp/fstab /etc/fstab"},{"line_number":1182,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6e5d3016_d652eb17","line":1181,"range":{"start_line":1180,"start_character":4,"end_line":1181,"end_character":33},"updated":"2020-12-08 05:01:40.000000000","message":"We don\u0027t explicitly add anything to fstab, what entries persist here?","commit_id":"336b9c3a4c91db5023aca78b782632455c67cc33"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7b3d36189767f78429b516f43544c47bbf0a38d8","unresolved":true,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"    # Clean up CEPH_DATA_DIR"},{"line_number":1179,"context_line":"    sudo umount ${CEPH_DATA_DIR}"},{"line_number":1180,"context_line":"    grep -v \"${CEPH_DATA_DIR}\" /etc/fstab | sudo tee /tmp/fstab"},{"line_number":1181,"context_line":"    sudo mv /tmp/fstab /etc/fstab"},{"line_number":1182,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cd133f53_80f816f3","line":1181,"range":{"start_line":1180,"start_character":4,"end_line":1181,"end_character":33},"in_reply_to":"6e5d3016_d652eb17","updated":"2020-12-08 07:58:36.000000000","message":"Wondering too. Also - mv is not really selinux friendly if we ever care about that.","commit_id":"336b9c3a4c91db5023aca78b782632455c67cc33"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff592ceb53273de5ca2b4aca4000a4235d11782e","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"    # Clean up CEPH_DATA_DIR"},{"line_number":1179,"context_line":"    sudo umount ${CEPH_DATA_DIR}"},{"line_number":1180,"context_line":"    grep -v \"${CEPH_DATA_DIR}\" /etc/fstab | sudo tee /tmp/fstab"},{"line_number":1181,"context_line":"    sudo mv /tmp/fstab /etc/fstab"},{"line_number":1182,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8f67f54f_fc54f2b6","line":1181,"range":{"start_line":1180,"start_character":4,"end_line":1181,"end_character":33},"in_reply_to":"90c8e0f0_b72a20ba","updated":"2020-12-08 17:20:46.000000000","message":"Great, thanks for the pointer and for the fix, Tom","commit_id":"336b9c3a4c91db5023aca78b782632455c67cc33"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4874bb523c95b7d02551a380418de3c03fa83ab9","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"    # Clean up CEPH_DATA_DIR"},{"line_number":1179,"context_line":"    sudo umount ${CEPH_DATA_DIR}"},{"line_number":1180,"context_line":"    grep -v \"${CEPH_DATA_DIR}\" /etc/fstab | sudo tee /tmp/fstab"},{"line_number":1181,"context_line":"    sudo mv /tmp/fstab /etc/fstab"},{"line_number":1182,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"90c8e0f0_b72a20ba","line":1181,"range":{"start_line":1180,"start_character":4,"end_line":1181,"end_character":33},"in_reply_to":"cd133f53_80f816f3","updated":"2020-12-08 12:37:44.000000000","message":"@Goutham: the devstack create_disk function at ~line 385 adds a line like the following to /etc/fstab:\n\n  /var/lib/ceph/drives/images/ceph.img /var/lib/ceph xfs loop,noatime,nodiratime,logbufs\u003d8,comment\u003ddevstack-ar/lib/ceph/drives/images/ceph.img 0 0\n\nIt\u0027s supposed to remove this line if re-run but I\u0027m ending up with a series of these lines in fstab when I unstack and restack several times.\n\n@Radoslaw -- good point on the \u0027mv\u0027 command, let me see if I can do it in place with \u0027sed\u0027.","commit_id":"336b9c3a4c91db5023aca78b782632455c67cc33"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bfb913e3733e4818f5d7f746ae4bac0ce87715be","unresolved":true,"context_lines":[{"line_number":1193,"context_line":"    pattern\u003d$(echo $CEPH_DATA_DIR | sed \u0027s_/_\\\\/_g\u0027)"},{"line_number":1194,"context_line":"    sudo sed -i \"/$pattern/d\" /etc/fstab"},{"line_number":1195,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"}"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"65a0a792_af004a21","line":1196,"updated":"2020-12-08 12:00:53.000000000","message":"nit: extra line","commit_id":"1b9692dee12444d1908f0f5997b331cdbfb8af1a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"17e470f8dce7aa9eaec4a2f477717b34d7b8cbea","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"    pattern\u003d$(echo $CEPH_DATA_DIR | sed \u0027s_/_\\\\/_g\u0027)"},{"line_number":1194,"context_line":"    sudo sed -i \"/$pattern/d\" /etc/fstab"},{"line_number":1195,"context_line":"    sudo rm -rf ${CEPH_DATA_DIR}/*"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"}"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"69638dc2_31a32324","line":1196,"in_reply_to":"65a0a792_af004a21","updated":"2020-12-08 12:44:46.000000000","message":"I\u0027ll remove it, thanks.","commit_id":"1b9692dee12444d1908f0f5997b331cdbfb8af1a"}]}