)]}'
{".zuul.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4bff4e3311b022a8c10c06875ca346f400410600","unresolved":true,"context_lines":[{"line_number":215,"context_line":"          CINDER_CEPH_UUID: d531d2d4-3937-429c-b0c2-658fe41e82aa"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest-py3"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"59a00b88_b7dc1a2e","line":218,"updated":"2021-04-07 21:41:35.000000000","message":"for new jobs, can we  avoid the -py3 suffix? That was kind of transitional, now everything is py3 by default.","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e1ea69d87081806be317965f7a66127a64a65fa1","unresolved":true,"context_lines":[{"line_number":215,"context_line":"          CINDER_CEPH_UUID: d531d2d4-3937-429c-b0c2-658fe41e82aa"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest-py3"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a1578406_3cd7afb5","line":218,"in_reply_to":"59a00b88_b7dc1a2e","updated":"2021-04-08 14:41:39.000000000","message":"+1","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ac7f1beef31e84e9b420d3253c2d5d06b2f8a59d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"          CINDER_CEPH_UUID: d531d2d4-3937-429c-b0c2-658fe41e82aa"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest-py3"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"40dcfd4a_fd358283","line":218,"in_reply_to":"a1578406_3cd7afb5","updated":"2021-04-08 21:22:04.000000000","message":"Ack","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4bff4e3311b022a8c10c06875ca346f400410600","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"},{"line_number":222,"context_line":"      using Ceph master as the backend."},{"line_number":223,"context_line":"    branches: master"},{"line_number":224,"context_line":"    vars:"},{"line_number":225,"context_line":"      devstack_localrc:"},{"line_number":226,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5deeea9d_c864d412","line":223,"updated":"2021-04-07 21:41:35.000000000","message":"isn\u0027t this the default anyway?","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e1ea69d87081806be317965f7a66127a64a65fa1","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"},{"line_number":222,"context_line":"      using Ceph master as the backend."},{"line_number":223,"context_line":"    branches: master"},{"line_number":224,"context_line":"    vars:"},{"line_number":225,"context_line":"      devstack_localrc:"},{"line_number":226,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f8c41fc3_133318a8","line":223,"in_reply_to":"5deeea9d_c864d412","updated":"2021-04-08 14:41:39.000000000","message":"FWIW I like it explicit.","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ac7f1beef31e84e9b420d3253c2d5d06b2f8a59d","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin and py3"},{"line_number":222,"context_line":"      using Ceph master as the backend."},{"line_number":223,"context_line":"    branches: master"},{"line_number":224,"context_line":"    vars:"},{"line_number":225,"context_line":"      devstack_localrc:"},{"line_number":226,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1b5eefb2_098a3a48","line":223,"in_reply_to":"f8c41fc3_133318a8","updated":"2021-04-08 21:22:04.000000000","message":"I saw other jobs using this. I rather have it explicit as well.","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dcde890fc96db1f4d2fc7d6ebc030566c1c1150e","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        - openstack-tox-bashate"},{"line_number":259,"context_line":"    experimental:"},{"line_number":260,"context_line":"      jobs:"},{"line_number":261,"context_line":"        - devstack-plugin-ceph-tempest-victoria"},{"line_number":262,"context_line":"        - devstack-plugin-ceph-tempest-ussuri"},{"line_number":263,"context_line":"        - devstack-plugin-ceph-tempest-train"},{"line_number":264,"context_line":"        - devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"2f9dacb5_5fcd1dc2","line":261,"updated":"2021-04-09 11:45:11.000000000","message":"You are inadvertently undoing Luigi\"s change to run these in the check queue\n\nhttps://review.opendev.org/c/openstack/devstack-plugin-ceph/+/783844","commit_id":"9f6c1f8f40ff4264e0a3510b0a67cf6ff5940af7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"45efb17a37849cc890007263f51c4e82222cae1c","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        - openstack-tox-bashate"},{"line_number":259,"context_line":"    experimental:"},{"line_number":260,"context_line":"      jobs:"},{"line_number":261,"context_line":"        - devstack-plugin-ceph-tempest-victoria"},{"line_number":262,"context_line":"        - devstack-plugin-ceph-tempest-ussuri"},{"line_number":263,"context_line":"        - devstack-plugin-ceph-tempest-train"},{"line_number":264,"context_line":"        - devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d9f2a9d2_79b64fbe","line":261,"in_reply_to":"2f9dacb5_5fcd1dc2","updated":"2021-04-09 11:47:38.000000000","message":"Good catch... bad rebase, fixing this","commit_id":"9f6c1f8f40ff4264e0a3510b0a67cf6ff5940af7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8a6e4147a8da25d404b9a272e160e8e1bd6717f","unresolved":true,"context_lines":[{"line_number":104,"context_line":"      - stable/rocky"},{"line_number":105,"context_line":"    vars:"},{"line_number":106,"context_line":"      devstack_localrc:"},{"line_number":107,"context_line":"        CEPH_RELEASE: \"luminous\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- job:"},{"line_number":110,"context_line":"    name: devstack-plugin-ceph-tempest-py3"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d0756b96_e40dee9f","line":107,"updated":"2021-04-14 08:55:34.000000000","message":"... while older branches are happy to consume 3.3. I am guessing they do not, however.","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"49183af56e224b397199a4bc7018c775b011eed8","unresolved":true,"context_lines":[{"line_number":104,"context_line":"      - stable/rocky"},{"line_number":105,"context_line":"    vars:"},{"line_number":106,"context_line":"      devstack_localrc:"},{"line_number":107,"context_line":"        CEPH_RELEASE: \"luminous\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- job:"},{"line_number":110,"context_line":"    name: devstack-plugin-ceph-tempest-py3"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"8660acf5_ca0697b8","line":107,"in_reply_to":"d0756b96_e40dee9f","updated":"2021-04-14 13:20:32.000000000","message":"OIC it\u0027s odd indeed. We get ganesha only for manila. I\u0027d need to check the stable branches for manila and see how we are getting the ganesha version there. Seems it is overwritting for some reason. I\u0027ll submit a follow up patch with this fix.","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"673fcdfd009cdb4eda36b9b199277dacb8927b99","unresolved":true,"context_lines":[{"line_number":120,"context_line":"      devstack_localrc:"},{"line_number":121,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":122,"context_line":"        CEPH_RELEASE: \"nautilus\""},{"line_number":123,"context_line":"        GANESHA_RELEASE: \"V2.8-stable\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- job:"},{"line_number":126,"context_line":"    name: devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"e50138a3_49a57252","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":38},"updated":"2021-04-09 14:45:30.000000000","message":"related but not part of this change - I find it interesting that it tests newer Ganesha on older branches and pins it to older for current...","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"49183af56e224b397199a4bc7018c775b011eed8","unresolved":true,"context_lines":[{"line_number":120,"context_line":"      devstack_localrc:"},{"line_number":121,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":122,"context_line":"        CEPH_RELEASE: \"nautilus\""},{"line_number":123,"context_line":"        GANESHA_RELEASE: \"V2.8-stable\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- job:"},{"line_number":126,"context_line":"    name: devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"f5446cab_7e2507a2","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":38},"in_reply_to":"0e80e4b9_8c9d741f","updated":"2021-04-14 13:20:32.000000000","message":"I see, good catch","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8a6e4147a8da25d404b9a272e160e8e1bd6717f","unresolved":true,"context_lines":[{"line_number":120,"context_line":"      devstack_localrc:"},{"line_number":121,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":122,"context_line":"        CEPH_RELEASE: \"nautilus\""},{"line_number":123,"context_line":"        GANESHA_RELEASE: \"V2.8-stable\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- job:"},{"line_number":126,"context_line":"    name: devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"0e80e4b9_8c9d741f","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":38},"in_reply_to":"930f493e_dd9f6c6a","updated":"2021-04-14 08:55:34.000000000","message":"Yes, I am referring to that one and this line. This line overrides it to 2.8...","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"06fa61bd6b939d8e1e676ff6b425c03496aaa5af","unresolved":true,"context_lines":[{"line_number":120,"context_line":"      devstack_localrc:"},{"line_number":121,"context_line":"        ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":122,"context_line":"        CEPH_RELEASE: \"nautilus\""},{"line_number":123,"context_line":"        GANESHA_RELEASE: \"V2.8-stable\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- job:"},{"line_number":126,"context_line":"    name: devstack-plugin-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"930f493e_dd9f6c6a","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":38},"in_reply_to":"e50138a3_49a57252","updated":"2021-04-13 21:10:58.000000000","message":"Current is pinning to v3.3 https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/lib/ceph#L31. Or are you referring to something else?","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"673fcdfd009cdb4eda36b9b199277dacb8927b99","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":222,"context_line":"      using Ceph master as the backend."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"02f0dbc8_7cd7df4b","line":219,"range":{"start_line":219,"start_character":45,"end_line":219,"end_character":49},"updated":"2021-04-09 14:45:30.000000000","message":"base does not test multiattach","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"06fa61bd6b939d8e1e676ff6b425c03496aaa5af","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":222,"context_line":"      using Ceph master as the backend."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"810ffa24_175b61a4","line":219,"range":{"start_line":219,"start_character":45,"end_line":219,"end_character":49},"in_reply_to":"02f0dbc8_7cd7df4b","updated":"2021-04-13 21:10:58.000000000","message":"I\u0027m not entirely sure why we have separate jobs for multiattach and non-multiattach. Should we do separate jobs with master as well? This is a question for Cinder experts.","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"49183af56e224b397199a4bc7018c775b011eed8","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":222,"context_line":"      using Ceph master as the backend."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6f95d8fe_e8d4307f","line":219,"range":{"start_line":219,"start_character":45,"end_line":219,"end_character":49},"in_reply_to":"42211a91_903842bf","updated":"2021-04-14 13:20:32.000000000","message":"We can do a follow up once we branch out then","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8a6e4147a8da25d404b9a272e160e8e1bd6717f","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"- job:"},{"line_number":218,"context_line":"    name: devstack-plugin-ceph-master-tempest"},{"line_number":219,"context_line":"    parent: devstack-plugin-ceph-tempest-py3-base"},{"line_number":220,"context_line":"    description: |"},{"line_number":221,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":222,"context_line":"      using Ceph master as the backend."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"42211a91_903842bf","line":219,"range":{"start_line":219,"start_character":45,"end_line":219,"end_character":49},"in_reply_to":"810ffa24_175b61a4","updated":"2021-04-14 08:55:34.000000000","message":"The comment above suggests it should just be enabled stein+. I guess there is some technical debt to pay while we can. It should be easier once we branch.","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"}],"devstack/lib/ceph":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c3d2c7bf066a62871a6bd62378baf0b1a1740ae","unresolved":true,"context_lines":[{"line_number":425,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"osd pool default size\" \"${CEPH_REPLICAS}\""},{"line_number":426,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} global \"rbd default features\" \"${CEPH_RBD_DEFAULT_FEATURES}\""},{"line_number":427,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_client\" \"10\""},{"line_number":428,"context_line":"    iniset -sudo ${CEPH_CONF_FILE} client \"debug_ms\" \"1\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    local gigs"},{"line_number":431,"context_line":"    gigs\u003d$(echo $CEPH_LOOPBACK_DISK_SIZE | grep -o \u0027^[0-9]*\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"aef61a92_0eba570c","side":"PARENT","line":428,"updated":"2021-02-20 15:00:12.000000000","message":"Orthogonal to the change.","commit_id":"14370639a36f8db776467045c69d2927d6aad429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c3d2c7bf066a62871a6bd62378baf0b1a1740ae","unresolved":true,"context_lines":[{"line_number":26,"context_line":"# Defaults"},{"line_number":27,"context_line":"# --------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"TEST_MASTER\u003d$(trueorfalse True TEST_MASTER)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-nautilus}"},{"line_number":32,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"fa3ae671_809b95d8","line":29,"range":{"start_line":29,"start_character":26,"end_line":29,"end_character":31},"updated":"2021-02-20 15:00:12.000000000","message":"This is for testing I presume? Or do we want to test with master on master? I have no idea how stable ceph\u0027s master really is.","commit_id":"75391fd97790d3f53f420ecb75e625f97b013e6d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c3d2c7bf066a62871a6bd62378baf0b1a1740ae","unresolved":true,"context_lines":[{"line_number":971,"context_line":"    if  is_ubuntu; then"},{"line_number":972,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":973,"context_line":"            install_package jq"},{"line_number":974,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":975,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/search/?project\u003dceph\u0026status\u003dready\u0026distros\u003dubuntu/focal\u0026ref\u003dpacific\u0026sha1\u003dlatest\" | \\"},{"line_number":976,"context_line":"                   jq \u0027.[0] | .chacra_url\u0027 | tr -d \u0027\"\u0027 | awk \u0027{print $1\"repo\"}\u0027)"},{"line_number":977,"context_line":"            curl -L $repo | sudo tee ${repo_file_name}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3cf7f666_c7cc4020","line":974,"range":{"start_line":974,"start_character":12,"end_line":974,"end_character":26},"updated":"2021-02-20 15:00:12.000000000","message":"needs a `local` declaration","commit_id":"75391fd97790d3f53f420ecb75e625f97b013e6d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c3d2c7bf066a62871a6bd62378baf0b1a1740ae","unresolved":true,"context_lines":[{"line_number":972,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":973,"context_line":"            install_package jq"},{"line_number":974,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":975,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/search/?project\u003dceph\u0026status\u003dready\u0026distros\u003dubuntu/focal\u0026ref\u003dpacific\u0026sha1\u003dlatest\" | \\"},{"line_number":976,"context_line":"                   jq \u0027.[0] | .chacra_url\u0027 | tr -d \u0027\"\u0027 | awk \u0027{print $1\"repo\"}\u0027)"},{"line_number":977,"context_line":"            curl -L $repo | sudo tee ${repo_file_name}"},{"line_number":978,"context_line":"            sudo ${package_manager} -y update"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9c48f586_99e85c12","line":975,"range":{"start_line":975,"start_character":12,"end_line":975,"end_character":16},"updated":"2021-02-20 15:00:12.000000000","message":"ditto","commit_id":"75391fd97790d3f53f420ecb75e625f97b013e6d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fd80b9bea1efd0f3382f158c8772bb198f8ca7e1","unresolved":true,"context_lines":[{"line_number":972,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":973,"context_line":"            install_package jq"},{"line_number":974,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":975,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/search/?project\u003dceph\u0026status\u003dready\u0026distros\u003dubuntu/focal\u0026ref\u003dpacific\u0026sha1\u003dlatest\" | \\"},{"line_number":976,"context_line":"                   jq \u0027.[0] | .chacra_url\u0027 | tr -d \u0027\"\u0027 | awk \u0027{print $1\"repo\"}\u0027)"},{"line_number":977,"context_line":"            curl -L $repo | sudo tee ${repo_file_name}"},{"line_number":978,"context_line":"            sudo ${package_manager} -y update"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"8b7a17a9_e7147b5f","line":975,"range":{"start_line":975,"start_character":12,"end_line":975,"end_character":16},"in_reply_to":"9c48f586_99e85c12","updated":"2021-03-08 21:14:20.000000000","message":"it looks like we can also use:\n\nhttps://shaman.ceph.com/api/repos/ceph/master/latest/ubuntu/focal/flavors/default/repo\n\nand/or\n\nhttps://shaman.ceph.com/api/repos/ceph/master/latest/centos/8/flavors/default/repo\n\ndirectly","commit_id":"75391fd97790d3f53f420ecb75e625f97b013e6d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c3d2c7bf066a62871a6bd62378baf0b1a1740ae","unresolved":true,"context_lines":[{"line_number":975,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/search/?project\u003dceph\u0026status\u003dready\u0026distros\u003dubuntu/focal\u0026ref\u003dpacific\u0026sha1\u003dlatest\" | \\"},{"line_number":976,"context_line":"                   jq \u0027.[0] | .chacra_url\u0027 | tr -d \u0027\"\u0027 | awk \u0027{print $1\"repo\"}\u0027)"},{"line_number":977,"context_line":"            curl -L $repo | sudo tee ${repo_file_name}"},{"line_number":978,"context_line":"            sudo ${package_manager} -y update"},{"line_number":979,"context_line":"        else"},{"line_number":980,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":981,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/debian-${ceph_release}/ ${distro_release} main\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"b3756c97_8b30dc0b","line":978,"range":{"start_line":978,"start_character":12,"end_line":978,"end_character":45},"updated":"2021-02-20 15:00:12.000000000","message":"This should be outside the \u0027if\u0027.","commit_id":"75391fd97790d3f53f420ecb75e625f97b013e6d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7726310d9b44b69362055684b6133a1ad601a948","unresolved":true,"context_lines":[{"line_number":974,"context_line":"            sudo ${package_manager} -y update"},{"line_number":975,"context_line":"        else"},{"line_number":976,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":977,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/debian-${ceph_release}/ ${distro_release} main\""},{"line_number":978,"context_line":"        fi"},{"line_number":979,"context_line":"    elif is_fedora; then"},{"line_number":980,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"272fdd0a_b83951cf","line":977,"updated":"2021-03-30 10:28:46.000000000","message":"still need to \u0027sudo ${package_manager} -y update\u0027 here, right?","commit_id":"375be2d32f9baf5ae4b48e074eb7ed108d8014d8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"57bade2172a6ab754686399522d029d3c30e0fb5","unresolved":true,"context_lines":[{"line_number":970,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":971,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":972,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/repos/ceph/master/latest/ubuntu/${distro_release}/flavors/default/repo\")"},{"line_number":973,"context_line":"            curl -L $repo -o ${repo_file_name}"},{"line_number":974,"context_line":"        else"},{"line_number":975,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":976,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/debian-${ceph_release}/ ${distro_release} main\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"0cbd34cb_f0f98c05","line":973,"updated":"2021-03-31 11:12:03.000000000","message":"Don\u0027t we want to append $repo onto $repo_file_name, maybe with \u0027echo $reo | sudo tee -a ...\u0027?","commit_id":"88c46174c0cd831b72aed30dc24af3c3e33fe2db"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"758b8cfde4565f33f0459218ce4ef536dd0ebad5","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":971,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":972,"context_line":"            repo\u003d$(curl -L \"https://shaman.ceph.com/api/repos/ceph/master/latest/ubuntu/${distro_release}/flavors/default/repo\")"},{"line_number":973,"context_line":"            curl -L $repo -o ${repo_file_name}"},{"line_number":974,"context_line":"        else"},{"line_number":975,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":976,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/debian-${ceph_release}/ ${distro_release} main\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"109e2258_c0cf16c2","line":973,"in_reply_to":"0cbd34cb_f0f98c05","updated":"2021-03-31 14:16:07.000000000","message":"Ack","commit_id":"88c46174c0cd831b72aed30dc24af3c3e33fe2db"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"021f24a483a0b193850ee7086fea48ff334c54e0","unresolved":true,"context_lines":[{"line_number":978,"context_line":"        sudo ${package_manager} -y update"},{"line_number":979,"context_line":"    elif is_fedora; then"},{"line_number":980,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":981,"context_line":"            curl -L \"https://shaman.ceph.com/api/repos/ceph/master/latest/centos/${distro_release}/flavors/default/repo\" | sudo tee ceph-master.repo"},{"line_number":982,"context_line":"            sudo dnf config-manager --add-repo ceph-master.repo"},{"line_number":983,"context_line":"        else"},{"line_number":984,"context_line":"            dnf_add_repository_ceph ${ceph_release} ${distro_release}"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"c500fab5_349cc99d","line":981,"updated":"2021-03-31 17:02:18.000000000","message":"Just a nit, but it\u0027s a bit funny to use the temp variable \u0027repo\u0027 at 972 and skip the temp variable here in the is_fedora branch.","commit_id":"c2c1a2675146b86923fcfec46ae1e185d8dd3834"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c4ad499ad67e9d82ce0392c0ba8f14d7571429c8","unresolved":true,"context_lines":[{"line_number":978,"context_line":"        sudo ${package_manager} -y update"},{"line_number":979,"context_line":"    elif is_fedora; then"},{"line_number":980,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":981,"context_line":"            curl -L \"https://shaman.ceph.com/api/repos/ceph/master/latest/centos/${distro_release}/flavors/default/repo\" | sudo tee ceph-master.repo"},{"line_number":982,"context_line":"            sudo dnf config-manager --add-repo ceph-master.repo"},{"line_number":983,"context_line":"        else"},{"line_number":984,"context_line":"            dnf_add_repository_ceph ${ceph_release} ${distro_release}"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"b685bee3_9e33bf00","line":981,"in_reply_to":"c500fab5_349cc99d","updated":"2021-03-31 22:30:39.000000000","message":"You are right, it\u0027s a bit confusing. I\u0027m fixing this on the follow up patch","commit_id":"c2c1a2675146b86923fcfec46ae1e185d8dd3834"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2d839f7eff4d731395d31eb63e327bde548d45e5","unresolved":false,"context_lines":[{"line_number":969,"context_line":"    if  is_ubuntu; then"},{"line_number":970,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":971,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph.list\""},{"line_number":972,"context_line":"            curl -L \"https://shaman.ceph.com/api/repos/ceph/master/latest/ubuntu/${distro_release}/flavors/default/repo\") | sudo tee ${repo_file_name}"},{"line_number":973,"context_line":"        else"},{"line_number":974,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"},{"line_number":975,"context_line":"            sudo apt-add-repository -y \"deb https://download.ceph.com/debian-${ceph_release}/ ${distro_release} main\""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"17b31f92_027ec91b","line":972,"updated":"2021-04-01 14:47:57.000000000","message":"there is the closing ) to remove indeed","commit_id":"1683e1e11571186928643bf971beafcc1ac71e12"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d05f0d2ca9f0af64c427efe4fc3809bf06cf1c80","unresolved":true,"context_lines":[{"line_number":968,"context_line":""},{"line_number":969,"context_line":"    if  is_ubuntu; then"},{"line_number":970,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":971,"context_line":"            repo_file_name\u003d\"/etc/apt/sources.list.d/ceph-master.list\""},{"line_number":972,"context_line":"            wget -c \"https://shaman.ceph.com/api/repos/ceph/master/latest/ubuntu/${distro_release}/flavors/default/repo\" -O ${repo_file_name}"},{"line_number":973,"context_line":"        else"},{"line_number":974,"context_line":"            wget -q -O- \u0027https://download.ceph.com/keys/release.asc\u0027 | sudo apt-key add -"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5648c28e_2d7d5a62","line":971,"updated":"2021-04-01 18:57:30.000000000","message":"sudo","commit_id":"6c76ebee4d78eb674e0c1f5292a62744bed93c2f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d05f0d2ca9f0af64c427efe4fc3809bf06cf1c80","unresolved":true,"context_lines":[{"line_number":978,"context_line":"    elif is_fedora; then"},{"line_number":979,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":980,"context_line":"            repo_file_name\u003d\"/etc/yum.repos.d/ceph-master.repo\""},{"line_number":981,"context_line":"            wget -c \"https://shaman.ceph.com/api/repos/ceph/master/latest/centos/${distro_release}/flavors/default/repo\" -O ${repo_file_name}"},{"line_number":982,"context_line":"            sudo dnf config-manager --add-repo ${repo_file_name}"},{"line_number":983,"context_line":"        else"},{"line_number":984,"context_line":"            dnf_add_repository_ceph ${ceph_release} ${distro_release}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"6befca6b_75e5dd2f","line":981,"updated":"2021-04-01 18:57:30.000000000","message":"sudo","commit_id":"6c76ebee4d78eb674e0c1f5292a62744bed93c2f"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4bff4e3311b022a8c10c06875ca346f400410600","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# --------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"TEST_MASTER\u003d$(trueorfalse False TEST_MASTER)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-octopus}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-V3.3-stable}"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"5af02d24_b34307eb","line":30,"updated":"2021-04-07 21:41:35.000000000","message":"A bit late, but wouldn\u0027t it make sense to (re)use CEPH_RELEASE for this?","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e1ea69d87081806be317965f7a66127a64a65fa1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# --------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"TEST_MASTER\u003d$(trueorfalse False TEST_MASTER)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CEPH_RELEASE\u003d${CEPH_RELEASE:-octopus}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-V3.3-stable}"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"5c29dd35_8b324483","line":30,"in_reply_to":"5af02d24_b34307eb","updated":"2021-04-08 14:41:39.000000000","message":"Might make sense to do this but the development branch isn\u0027t exactly the same thing as a release.  Not objecting though.","commit_id":"bc8b353a2c0239abd3016c2ce0e7176572f894c7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"673fcdfd009cdb4eda36b9b199277dacb8927b99","unresolved":true,"context_lines":[{"line_number":983,"context_line":"        if [[ \"${TEST_MASTER}\" \u003d\u003d \"True\" ]]; then"},{"line_number":984,"context_line":"            repo_file_name\u003d\"/etc/yum.repos.d/ceph-master.repo\""},{"line_number":985,"context_line":"            sudo wget -c \"https://shaman.ceph.com/api/repos/ceph/master/latest/centos/${distro_release}/flavors/default/repo\" -O ${repo_file_name}"},{"line_number":986,"context_line":"            sudo dnf config-manager --add-repo ${repo_file_name}"},{"line_number":987,"context_line":"        else"},{"line_number":988,"context_line":"            dnf_add_repository_ceph ${ceph_release} ${distro_release}"},{"line_number":989,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"35e5dd87_1c81cd78","line":986,"range":{"start_line":986,"start_character":12,"end_line":986,"end_character":64},"updated":"2021-04-09 14:45:30.000000000","message":"you have already added it by saving into yum.repos.d","commit_id":"bd1316be9034681d7b4600d033a49a32afd088ab"}]}