)]}'
{"devstack/lib/ceph":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c9ec201d6221ea47fcdcb66e4bbcc9277b6f3ac6","unresolved":true,"context_lines":[{"line_number":409,"context_line":"    if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":410,"context_line":"        # exclusive locks must be enabled by default"},{"line_number":411,"context_line":"        # for images being exported for ceph iscsi"},{"line_number":412,"context_line":"        CEPH_RBD_DEFAULT_FEATURES\u003d$(($CEPH_RBD_DEFAULT_FEATURES + 4))"},{"line_number":413,"context_line":"    fi"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    # create a default ceph configuration file"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c5ce6785_d34b64d6","line":412,"updated":"2021-03-12 16:26:19.000000000","message":"I think the value is assumed to be numeric, so this is going to break if that value is a string.\n\nThe question is: does the \"rbd default features\" option accept both numbers and strings?","commit_id":"001aac00058442cab71b76948755e1f91afb2abb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6994bcf48a75690452f12a5a2f3d84cccb2f6b6d","unresolved":true,"context_lines":[{"line_number":409,"context_line":"    if [ \"$ENABLE_CEPH_ISCSI\" \u003d \"True\" ]; then"},{"line_number":410,"context_line":"        # exclusive locks must be enabled by default"},{"line_number":411,"context_line":"        # for images being exported for ceph iscsi"},{"line_number":412,"context_line":"        CEPH_RBD_DEFAULT_FEATURES\u003d$(($CEPH_RBD_DEFAULT_FEATURES + 4))"},{"line_number":413,"context_line":"    fi"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    # create a default ceph configuration file"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"59572e13_fac2fc2a","line":412,"in_reply_to":"c5ce6785_d34b64d6","updated":"2021-03-12 17:10:04.000000000","message":"Ehh, this code is wrong already, it just happens to work in the case where\nCEPH_RBD_DEFAULT_FEATURES\u003d1.\n\nIf you started with CEPH_RBD_DEFAULT_FEATURES\u003d4, this would set it to 8, which would disable exclusive locks...","commit_id":"001aac00058442cab71b76948755e1f91afb2abb"}]}