)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~778960","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Idad98cfebf5e3b265316f2b6a3c201b472faa32c","project":"openstack/devstack-plugin-ceph","branch":"master","hashtags":[],"change_id":"Idad98cfebf5e3b265316f2b6a3c201b472faa32c","subject":"Set rbd default features in ceph.conf","status":"MERGED","created":"2021-03-05 15:15:23.000000000","updated":"2021-03-16 22:43:24.000000000","submitted":"2021-03-16 22:42:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"778960","meta_rev_id":"51211cb807b3e38a6bfad9d3f942be1781e530c7","_number":778960,"virtual_id_number":778960,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-16 22:42:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2021-03-12 18:04:09.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-03-16 14:14:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":2,"date":"2021-03-16 21:03:56.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":1,"date":"2021-03-16 21:03:56.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-05 17:36:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-12 16:26:19.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2021-03-12 18:04:09.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2021-03-16 14:14:51.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"REVIEWER"},{"updated":"2021-03-16 21:03:56.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"}],"messages":[{"id":"f9ce6ecf891a6a4c50ca550a7f62579e2a7fa24f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2021-03-05 15:15:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a0e5e6795dbe0d063ec5fdbd90e5298b6bd795d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2021-03-05 15:15:58.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"58b41d0c9e5462ab43a9b0edfa8dc38995111b6c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 17:36:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/5945ef5973804e839c37c7f5bbdbe4f5 : SUCCESS in 1h 37m 49s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/97f7261c1a71453b98afb0ae2df2f731 : SUCCESS in 1h 06m 06s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/bd122a44b6a54037a378b2d9d302f772 : FAILURE in 1h 16m 20s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/4124db7fdce14303938ead5904d83cdb : SUCCESS in 1h 16m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/26671ded1614422491ebe112242c1b2f : SUCCESS in 10m 18s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/caaff8611c754a2faf0f895980afde48 : SUCCESS in 3m 46s","accounts_in_message":[],"_revision_number":1},{"id":"8772e557e72ebb5dd32362e2d2ec4d191bdab931","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2021-03-05 21:17:28.000000000","message":"Patch Set 1: -Workflow\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"366d1e3d32b34cc8ab0a4fd6ce222f0f1b11ee57","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 23:37:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/250f73d2ac81406d91eeb41b2f9dc639 : SUCCESS in 1h 17m 37s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/4708a7ff2383401181fe808f0e6e3d14 : SUCCESS in 1h 15m 35s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/79825916fa654bec97833df9a01bf154 : SUCCESS in 1h 34m 44s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/48b0f73052984b86804a335c87926f67 : SUCCESS in 2h 04m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a5dcd9ad556640d184df0728c2585032 : SUCCESS in 7m 28s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/2c543d2bd09845af9364a6cb35a01990 : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":1},{"id":"c9ec201d6221ea47fcdcb66e4bbcc9277b6f3ac6","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-12 16:26:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6994bcf48a75690452f12a5a2f3d84cccb2f6b6d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2021-03-12 17:10:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e350e073a0bf5ae251e0c1f356e048cdb32239d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2021-03-12 17:21:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2f46d798633ca5ed99ea62d91e9d40c5d4ed9fbd","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-03-12 18:04:09.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"faaa5879d8814849af8a22657e928e699c21c518","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-12 20:06:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/8f193fcf8a5643349471882f47afa8d4 : SUCCESS in 1h 16m 35s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/0104403c27b9400aabecd811aed01979 : SUCCESS in 1h 04m 12s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/51018d0109894463b9f3a9f71719f081 : FAILURE in 1h 28m 03s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/ccade9419a7d40ba9d07866bab594f1b : SUCCESS in 1h 19m 23s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f59923f7e840491a9e98e956f54f4687 : SUCCESS in 6m 24s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/034e8bb923814729a75f7fb25ab7e373 : SUCCESS in 5m 10s","accounts_in_message":[],"_revision_number":2},{"id":"fff482cbddfe8cd130ddc999dec085448fad9a29","author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"date":"2021-03-16 14:14:51.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good to me!","accounts_in_message":[],"_revision_number":2},{"id":"89ae976e4168acdd3db2d0fc55fdb18c0de6fea8","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-03-16 21:03:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLooks good, thanks Eric!","accounts_in_message":[],"_revision_number":2},{"id":"6daa9838502503edc8a10b6a38bd29ff1bcb1176","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 21:04:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4cb16568f2543725113a3fd58961a9a90211de23","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 22:42:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/7fb06de4cf0f4170a09788337c9734b1 : SUCCESS in 1h 31m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5929a01d4be94c9ab3d4cdd2f7711012 : SUCCESS in 4m 54s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/27bb8472c2e5488d83550a9fee7ffe74 : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":2},{"id":"c2bab53a36b90dff895f652861adfd36a450ee02","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 22:42:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"51211cb807b3e38a6bfad9d3f942be1781e530c7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 22:43:24.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15618fb25fab4ab78175c180702ad572 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"467b4295f2a26c94ae43fda08e7da47f3278664f","revisions":{"001aac00058442cab71b76948755e1f91afb2abb":{"kind":"REWORK","_number":1,"created":"2021-03-05 15:15:23.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/60/778960/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/60/778960/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/1"}}},"commit":{"parents":[{"commit":"57b5ab1520f98ee75499210308d78910d339f033","subject":"Merge \"Update override-defaults to support ceph_iscsi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/57b5ab1520f98ee75499210308d78910d339f033"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2021-03-05 15:13:29.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2021-03-05 15:15:02.000000000","tz":-300},"subject":"Set rbd default features in ceph.conf","message":"Set rbd default features in ceph.conf\n\nThe typical Cinder deployment should have\nmore than just \"layering\" enabled.\n\nEnable fast-diff, which requires exclusive-lock\nand object-map.\n\nChange-Id: Idad98cfebf5e3b265316f2b6a3c201b472faa32c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/001aac00058442cab71b76948755e1f91afb2abb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/001aac00058442cab71b76948755e1f91afb2abb"}]},"branch":"refs/heads/master"},"467b4295f2a26c94ae43fda08e7da47f3278664f":{"kind":"REWORK","_number":2,"created":"2021-03-12 17:21:55.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/60/778960/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/60/778960/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/60/778960/2"}}},"commit":{"parents":[{"commit":"57b5ab1520f98ee75499210308d78910d339f033","subject":"Merge \"Update override-defaults to support ceph_iscsi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/57b5ab1520f98ee75499210308d78910d339f033"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2021-03-05 15:13:29.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2021-03-12 17:18:49.000000000","tz":-300},"subject":"Set rbd default features in ceph.conf","message":"Set rbd default features in ceph.conf\n\nThe typical Cinder deployment should have\nmore than just \"layering\" enabled.\n\nEnable fast-diff, which requires exclusive-lock\nand object-map.\n\nPreviously, there was code that tried to enable\nexclusive-lock when CEPH_ISCSI is enabled, but this\ncode would not work reliably, since it was doing\naddition instead of bitwise-or.  Just remove it\nsince exclusive-lock will be enabled by default.\n\nChange-Id: Idad98cfebf5e3b265316f2b6a3c201b472faa32c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/467b4295f2a26c94ae43fda08e7da47f3278664f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/467b4295f2a26c94ae43fda08e7da47f3278664f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}