)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ce894051862aabcef8b4728bed2d8fdfc005638e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes to the RBD driver leverage the RBD trash functionality to allow"},{"line_number":10,"context_line":"Cinder users to delete snapshots that are still in a dependency chain."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This requires that the RBD trash namespace be emptied."},{"line_number":13,"context_line":"In addition to this patch, the user must enable the RBD Trash Purge"},{"line_number":14,"context_line":"scheduling feature. In this way, the Ceph backend will delete RBD images"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"78c64cd2_3832a823","line":11,"updated":"2022-05-05 14:37:10.000000000","message":"This all discusses Cinder specifics that may be better to not try to restate here -- it\u0027s pretty complex to get all of the relevant details here.  (i.e. even without the trash purging stuff, we still gain benefits by setting the minimum client version to mimic.)\n\nIt might be better to just state that we want to support this configuration in Cinder, and this patch helps test that.","commit_id":"c5eb6adcb0eacfb2c158a5d6dbdb361316a34c5d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"89fa7ffde1538fe30520c97e58e2d1f32b2afff1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes to the RBD driver leverage the RBD trash functionality to allow"},{"line_number":10,"context_line":"Cinder users to delete snapshots that are still in a dependency chain."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This requires that the RBD trash namespace be emptied."},{"line_number":13,"context_line":"In addition to this patch, the user must enable the RBD Trash Purge"},{"line_number":14,"context_line":"scheduling feature. In this way, the Ceph backend will delete RBD images"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"cf8b8a77_00200d50","line":11,"in_reply_to":"78c64cd2_3832a823","updated":"2022-05-10 14:09:45.000000000","message":"Ack","commit_id":"c5eb6adcb0eacfb2c158a5d6dbdb361316a34c5d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ce894051862aabcef8b4728bed2d8fdfc005638e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"that are no longer in use."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The goal of this patch is to add a variable to set the ceph minimal"},{"line_number":18,"context_line":"client. Defaulting to Mimic and additional check to avoid old"},{"line_number":19,"context_line":"versions \u003e 13."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Id8e581893ee4b373b268acc7c59b670985cedc2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"b116b788_e44bd597","line":19,"range":{"start_line":18,"start_character":32,"end_line":19,"end_character":14},"updated":"2022-05-05 14:37:10.000000000","message":"This check has been removed in the current patchset.","commit_id":"c5eb6adcb0eacfb2c158a5d6dbdb361316a34c5d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"89fa7ffde1538fe30520c97e58e2d1f32b2afff1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"that are no longer in use."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The goal of this patch is to add a variable to set the ceph minimal"},{"line_number":18,"context_line":"client. Defaulting to Mimic and additional check to avoid old"},{"line_number":19,"context_line":"versions \u003e 13."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Id8e581893ee4b373b268acc7c59b670985cedc2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"a2d2e86d_86a3b853","line":19,"range":{"start_line":18,"start_character":32,"end_line":19,"end_character":14},"in_reply_to":"b116b788_e44bd597","updated":"2022-05-10 14:09:45.000000000","message":"Done","commit_id":"c5eb6adcb0eacfb2c158a5d6dbdb361316a34c5d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"45dc93db139849971578b9df3bd95e36c3c5587c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d7319a04_1e22a73f","updated":"2021-10-11 19:41:18.000000000","message":"recheck","commit_id":"9f7cd6957aa598bfed97f7d5fa6262bfa4a20958"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d67a329236419b42387d3099c7c931d6ef3f1bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cc7ab3ac_f9b0ef6e","updated":"2022-01-06 20:03:14.000000000","message":"Looks like devstack-plugin-ceph-cephfs-* are broken apart from this work. Waiting for more reviews but I think It\u0027s ready for +2","commit_id":"ff1d8967fe574a7ac117f4206cd17e873ab63d9b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f4ae3cb5788d35a9b50e0937c6bfaed97a69cf0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9575fd42_b5894cfd","updated":"2022-03-25 14:57:11.000000000","message":"Luigi is going to create a variable for this +1","commit_id":"ff1d8967fe574a7ac117f4206cd17e873ab63d9b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0e6b0c00d32841dabd6381ccda10128397234ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"df9b72e3_9ef7b8e1","updated":"2022-01-24 15:55:55.000000000","message":"is this patch going to be affected by the migration to cephadm? ","commit_id":"ff1d8967fe574a7ac117f4206cd17e873ab63d9b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"3fe4c439be99393269253b98e4a9fedfbbd620a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"338c9967_b21d2f8c","in_reply_to":"df9b72e3_9ef7b8e1","updated":"2022-03-25 14:54:00.000000000","message":"I don\u0027t know, but it\u0027s the new code that should be adapted. \n\nGiven the fact this change has proven to be problematic, maybe it should be under a condition, so we don\u0027t break anyone else.","commit_id":"ff1d8967fe574a7ac117f4206cd17e873ab63d9b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a2ea6da930fd8bd6aa925f000d21953c72ca4808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8e502eaf_b5d76a98","updated":"2022-05-17 12:10:12.000000000","message":"devstack-plugin-ceph-multinode-tempest-py3 Job fails with \n```\n    tempest.lib.exceptions.BadRequest: Bad request\nDetails: {\u0027code\u0027: 400, \u0027message\u0027: \u0027ubuntu-focal-iweb-mtl01-0029663181 is not on local storage: Block migration can not be used with shared storage.\u0027}\n```\n\nIt\u0027s not related with this work","commit_id":"b99cb9643a0e395757ad8f3b8910df69614adb3a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3b8088f80cbe0c09d1ab1a43e6a728fd66658b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5ac90710_ed7893bd","updated":"2022-05-16 17:10:33.000000000","message":"recheck\n\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/841815 landed","commit_id":"b99cb9643a0e395757ad8f3b8910df69614adb3a"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0082e3e1942e0e183744a321b3b3a3901a9cb8d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fc9bee1a_04f4e73e","updated":"2022-05-10 17:28:29.000000000","message":"recheck devstack-plugin-ceph-cephfs-nfs","commit_id":"b99cb9643a0e395757ad8f3b8910df69614adb3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4d5ff4e4cc138eaa1639b18dd24041d0a8497cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b8ed9aee_ec52a658","updated":"2022-06-23 17:35:15.000000000","message":"LGTM, thank you","commit_id":"05a656434d796ac8c4c82d7d17d75e874b46c371"}],"devstack/lib/ceph":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"350a44420ab7a3129682d50817019111599f0c2c","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Enables new features such as Clone v2 API, which allows proper handling of"},{"line_number":137,"context_line":"# deleting snapshots with child clone images."},{"line_number":138,"context_line":"CEPH_SET_MIN_CLIENT_TO_MIMIC\u003d$(trueorfalse False CEPH_SET_MIN_CLIENT_TO_MIMIC)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Connect to an existing Ceph cluster"},{"line_number":141,"context_line":"REMOTE_CEPH\u003d$(trueorfalse False REMOTE_CEPH)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"d9c24c99_462b862b","line":138,"updated":"2022-05-03 13:53:57.000000000","message":"We should allow this to be set to values other than mimic -- should be more like\n\nCEPH_MIN_CLIENT_VERSION\u003d$(:-mimic)\n\nand only call set-require-min-compat if it is not blank.","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9a4063a71f3d941a300fb97fde59ae9de886a842","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Enables new features such as Clone v2 API, which allows proper handling of"},{"line_number":137,"context_line":"# deleting snapshots with child clone images."},{"line_number":138,"context_line":"CEPH_SET_MIN_CLIENT_TO_MIMIC\u003d$(trueorfalse False CEPH_SET_MIN_CLIENT_TO_MIMIC)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Connect to an existing Ceph cluster"},{"line_number":141,"context_line":"REMOTE_CEPH\u003d$(trueorfalse False REMOTE_CEPH)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"f7dc38b8_031f7045","line":138,"in_reply_to":"570f8af1_cb914ca6","updated":"2022-05-03 19:10:32.000000000","message":"Agreed. You can also call it with \u0027luminous\u0027 if you do not want to enable the v2 clone. However, if the default value should be set to \u0027mimic\u0027, there will be no blank.","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d57a7a3fbce1accd21ff5345285750a602f5baa8","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Enables new features such as Clone v2 API, which allows proper handling of"},{"line_number":137,"context_line":"# deleting snapshots with child clone images."},{"line_number":138,"context_line":"CEPH_SET_MIN_CLIENT_TO_MIMIC\u003d$(trueorfalse False CEPH_SET_MIN_CLIENT_TO_MIMIC)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Connect to an existing Ceph cluster"},{"line_number":141,"context_line":"REMOTE_CEPH\u003d$(trueorfalse False REMOTE_CEPH)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"570f8af1_cb914ca6","line":138,"in_reply_to":"d9c24c99_462b862b","updated":"2022-05-03 15:28:34.000000000","message":"Then things become much more complicated, because the subsequent condition explicitly check for the mimic version.","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8cd322494abf5a8c5b3a09f3ba7e53c6bb2d0ca2","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Enables new features such as Clone v2 API, which allows proper handling of"},{"line_number":137,"context_line":"# deleting snapshots with child clone images."},{"line_number":138,"context_line":"CEPH_SET_MIN_CLIENT_TO_MIMIC\u003d$(trueorfalse False CEPH_SET_MIN_CLIENT_TO_MIMIC)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Connect to an existing Ceph cluster"},{"line_number":141,"context_line":"REMOTE_CEPH\u003d$(trueorfalse False REMOTE_CEPH)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"e6786885_b5ff8bd1","line":138,"in_reply_to":"f7dc38b8_031f7045","updated":"2022-05-05 13:20:36.000000000","message":"Done","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d57a7a3fbce1accd21ff5345285750a602f5baa8","unresolved":true,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    if is_ceph_enabled_for_service cinder; then"},{"line_number":492,"context_line":"        if CEPH_SET_MIN_CLIENT_TO_MIMIC \u003d\u003d \u0027True\u0027; then"},{"line_number":493,"context_line":"            if vercmp \"$ceph_version\" \"\u003e\u003d\" \"13.0\"; then"},{"line_number":494,"context_line":"                sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":495,"context_line":"                    osd set-require-min-compat-client mimic"},{"line_number":496,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"d22835f9_6502b072","line":493,"updated":"2022-05-03 15:28:34.000000000","message":"So maybe the condition should be dropped entirely and leave it to the code (and the people) setting the value to ensure everything is correct?","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8cd322494abf5a8c5b3a09f3ba7e53c6bb2d0ca2","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    if is_ceph_enabled_for_service cinder; then"},{"line_number":492,"context_line":"        if CEPH_SET_MIN_CLIENT_TO_MIMIC \u003d\u003d \u0027True\u0027; then"},{"line_number":493,"context_line":"            if vercmp \"$ceph_version\" \"\u003e\u003d\" \"13.0\"; then"},{"line_number":494,"context_line":"                sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":495,"context_line":"                    osd set-require-min-compat-client mimic"},{"line_number":496,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"82483fc0_72eb5714","line":493,"in_reply_to":"d22835f9_6502b072","updated":"2022-05-05 13:20:36.000000000","message":"Done","commit_id":"a6c0192283612e21f17c7524903999027bf70adc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5a46af3c4586df10cc81c7e4cf62b02ec25a4faa","unresolved":true,"context_lines":[{"line_number":488,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":489,"context_line":"    done"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    if is_ceph_enabled_for_service cinder; then"},{"line_number":492,"context_line":"        if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":493,"context_line":"            sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":494,"context_line":"                osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"a69aea76_5a32e788","line":491,"range":{"start_line":491,"start_character":7,"end_line":491,"end_character":41},"updated":"2022-06-23 15:45:44.000000000","message":"Why check if Cinder is enabled for this operation?\n\nPresumably some other services may also want this behavior, and it may affect them too.  This also means that the minimum client version used in a Manila/Glance/Nova test job is dependent on whether Cinder is installed in that devstack run, which seems likely to confuse people.\n\nAny reason we shouldn\u0027t just set the minimum version always?","commit_id":"b99cb9643a0e395757ad8f3b8910df69614adb3a"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c92f9b85073c5e0ddf25a97c496ab7f04bef4c08","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":489,"context_line":"    done"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    if is_ceph_enabled_for_service cinder; then"},{"line_number":492,"context_line":"        if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":493,"context_line":"            sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":494,"context_line":"                osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"7d81af54_c499559b","line":491,"range":{"start_line":491,"start_character":7,"end_line":491,"end_character":41},"in_reply_to":"a69aea76_5a32e788","updated":"2022-06-23 16:46:56.000000000","message":"True, i\u0027ll set it unconditionally","commit_id":"b99cb9643a0e395757ad8f3b8910df69614adb3a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ad6e0607ebc42aed3f6b468538dc35b9b532d4ac","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":488,"context_line":"    done"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":491,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":492,"context_line":"            osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"},{"line_number":493,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"51b93fed_ab5208fd","line":490,"updated":"2022-06-23 19:19:50.000000000","message":"I think this is never true because the VAR has a default; it would be nice to actually skip this block when VAR is unset, mainly to see if we test/pass CI with the Ceph defaults ... in pacific this is not enforced by default, still","commit_id":"05a656434d796ac8c4c82d7d17d75e874b46c371"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5cbcbff0f0cd1752ab9b7d0844a52da94530d2f8","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":488,"context_line":"    done"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":491,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":492,"context_line":"            osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"},{"line_number":493,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"6c3a1602_dab21729","line":490,"in_reply_to":"51b93fed_ab5208fd","updated":"2022-06-23 22:00:09.000000000","message":"OK, so cinder is going to need a new CI job to test this.","commit_id":"05a656434d796ac8c4c82d7d17d75e874b46c371"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0d706889aa6732554f261369a3195a009c35319a","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":488,"context_line":"    done"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":491,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":492,"context_line":"            osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"},{"line_number":493,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"96a6b6d0_ad731a7f","line":490,"in_reply_to":"6c3a1602_dab21729","updated":"2022-06-24 07:42:18.000000000","message":"if you mean to test with mimic, then I guess a config change in the existing job would also do","commit_id":"05a656434d796ac8c4c82d7d17d75e874b46c371"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"732a77c2ce9c9ae65703a55baf8a4447cb1f7be9","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        sudo systemctl enable ceph-osd@${OSD_ID}"},{"line_number":488,"context_line":"    done"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ ! -z \"$CEPH_MIN_CLIENT_VERSION\" ]; then"},{"line_number":491,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} \\"},{"line_number":492,"context_line":"            osd set-require-min-compat-client ${CEPH_MIN_CLIENT_VERSION}"},{"line_number":493,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"e56b8423_db13b4d2","line":490,"in_reply_to":"96a6b6d0_ad731a7f","updated":"2022-06-24 12:56:34.000000000","message":"+1; merging this now since, we know it works with mimic, and Sofia can pursue adding the configuration to one or more jobs in a different patch.","commit_id":"05a656434d796ac8c4c82d7d17d75e874b46c371"}]}