)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~782855","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~Icfd973fd2829fee8e3e611ad1e23031a4afc4151","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"bp/update-cephfs-drivers","hashtags":[],"change_id":"Icfd973fd2829fee8e3e611ad1e23031a4afc4151","subject":"Fix auth ID caps for manila with ceph-mgr","status":"ABANDONED","created":"2021-03-24 20:23:48.000000000","updated":"2023-05-17 17:53:03.000000000","total_comment_count":5,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"f816c328760e939b16f9cde698913acc63dd329c","_number":782855,"virtual_id_number":782855,"owner":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-04-22 18:10:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"date":"2021-04-28 09:34:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2021-04-22 18:43:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"REVIEWER":[{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-24 21:37:40.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"CC"},{"updated":"2021-03-24 21:57:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-24 23:02:06.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2021-04-08 22:35:44.000000000","updated_by":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"reviewer":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"state":"CC"},{"updated":"2021-04-09 15:23:49.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"CC"},{"updated":"2021-04-23 06:36:26.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2021-12-30 14:38:21.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REMOVED"}],"messages":[{"id":"c33be4da19faf42c97e1882ccb835165aceb078c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-03-24 20:23:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1bedef4b12bf9b226d715ea64b634fb30ff15b61","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-03-24 21:37:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ee7a92b5874b80128fb44cbf6c9bafe6332647f6","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-03-24 21:49:07.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"15e3c089324db9393fc32544357792770d750026","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-24 21:57:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/7f543f36d49b472c972609f0ef9dfa42 : SUCCESS in 57m 28s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/6d4b1be686ee4686a9c8339a2fd571a2 : FAILURE in 40m 06s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/0ddc52e4936c40c39278d0408d126276 : FAILURE in 59m 05s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/43064105bacc498db781e7ac463691d9 : SUCCESS in 1h 14m 09s (non-voting)\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/200b011394a84354b091474ae88f0e5a : SUCCESS in 1h 31m 59s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e79ab8e266464ba38ca1e7fe55537832 : SUCCESS in 5m 06s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/9efc12ed469c49d692b6f26e09399d78 : SUCCESS in 4m 15s","accounts_in_message":[],"_revision_number":1},{"id":"0008398f95687d1f4ed8cb13ddddaf9aaddcfac9","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-03-25 16:46:19.000000000","message":"Patch Set 1: Code-Review-1\n\nThis review [1] tests the auth change here in combination with the ceph create-from-volume change.  There we see authorization problems for \u0027ceph fs subvolume create ...\u0027 [2].\n\n@Ramana - would you double check the caps?  They are set here in the job cited [3].\n\n\n[1] https://review.opendev.org/c/openstack/manila/+/782954\n\n[2] https://zuul.opendev.org/t/openstack/build/898b67c20f6d4a37933732993e48feac/log/controller/logs/screen-m-shr.txt#358-366\n\n[3] https://zuul.opendev.org/t/openstack/build/898b67c20f6d4a37933732993e48feac/log/controller/logs/devstacklog.txt#16867","accounts_in_message":[],"_revision_number":1},{"id":"d37acf927a1e5fedd2d807c97567f131354b2080","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-03-29 22:32:15.000000000","message":"Patch Set 1:\n\nThanks for checking this Tom! Seems we need to tweak those a bit.\n\nIn any case, wanted to follow us on this. How much benefit do we see on testing with this caps? The older caps are more permissive, so they will work with the new implementation. If we want to test this caps, we would need to implement a check on the manila version that is being used.\n\nWhat do you think?","accounts_in_message":[],"_revision_number":1},{"id":"c3e52a231efb116fceb826e2a1ece4fedcde95f0","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-03-29 22:32:21.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"2f9b1dcc35c5234d2e1d35e5202883c08ec1ebd5","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-03-29 23:06:42.000000000","message":"Patch Set 1:\n\n@vicky - Well I think this review will be very helpful so that we can figure out exactly what CAPS are right and we can document it.  Then when we know what is right, we can see if doing version checking and using two different CAPS in CI makes sense.\n\nThanks for testing it in this review!","accounts_in_message":[],"_revision_number":1},{"id":"4edbe53fbf6d34bf184a29584d3670abb032fc14","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-06 19:00:48.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"c7dfed6320eba708f880babdae62b05393772c25","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-06 21:02:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/6488754ee81f44b08a3f4e6e1cd7982b : SUCCESS in 1h 23m 40s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/945bf6c868dd4bcfb749b5baa5cfcf9f : FAILURE in 50m 05s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/7a9abe18ded24abab08499834586e97e : FAILURE in 54m 30s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/f01e54ebf4c942cabd2b7bb285111f37 : SUCCESS in 1h 24m 39s (non-voting)\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/85cf35a10d7248689bbc6b69a04a24aa : SUCCESS in 1h 54m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e835a86c40d40c0906bb99c0566f878 : SUCCESS in 6m 27s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/5c54a7526e3e4f4c8ddab0a559ed7d73 : SUCCESS in 3m 00s","accounts_in_message":[],"_revision_number":1},{"id":"4cde66ea7b8151247c21a7f2a3db9ae0f7ee4264","author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"date":"2021-04-08 22:35:44.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e This review [1] tests the auth change here in combination with the ceph create-from-volume change.  There we see authorization problems for \u0027ceph fs subvolume create ...\u0027 [2].\n\u003e \n\u003e @Ramana - would you double check the caps?  They are set here in the job cited [3].\n\u003e \n\u003e \n\u003e [1] https://review.opendev.org/c/openstack/manila/+/782954\n\u003e \n\u003e [2] https://zuul.opendev.org/t/openstack/build/898b67c20f6d4a37933732993e48feac/log/controller/logs/screen-m-shr.txt#358-366\n\u003e \n\u003e [3] https://zuul.opendev.org/t/openstack/build/898b67c20f6d4a37933732993e48feac/log/controller/logs/devstacklog.txt#16867\n\nThanks, Tom. I\u0027d to change MON caps from \u0027allow r\u0027 to \u0027allow rw\u0027 to make the current manila driver code. This is not what we want. I\u0027d to make the following simple change in the driver code that works with this patch,\n\ndiff --git a/manila/share/drivers/cephfs/driver.py b/manila/share/drivers/cephfs/driver.py\nindex dd430553..1cc83ebb 100644\n--- a/manila/share/drivers/cephfs/driver.py\n+++ b/manila/share/drivers/cephfs/driver.py\n@@ -149,7 +149,8 @@ class RadosError(Exception):\n     pass\n \n \n-def rados_command(rados_client, prefix\u003dNone, args\u003dNone, json_obj\u003dFalse):\n+def rados_command(rados_client, prefix\u003dNone, args\u003dNone, json_obj\u003dFalse,\n+                  target\u003d(\u0027mon-mgr\u0027, )):\n     \"\"\"Safer wrapper for ceph_argparse.json_command\n \n     Raises error exception instead of relying on caller to check return\n@@ -172,12 +173,13 @@ def rados_command(rados_client, prefix\u003dNone, args\u003dNone, json_obj\u003dFalse):\n     argdict[\u0027format\u0027] \u003d \u0027json\u0027\n \n     LOG.debug(\"Invoking ceph_argparse.json_command - rados_client\u003d%(cl)s, \"\n-              \"prefix\u003d\u0027%(pf)s\u0027, argdict\u003d%(ad)s, timeout\u003d%(to)s.\",\n-              {\"cl\": rados_client, \"pf\": prefix, \"ad\": argdict,\n+              \"target\u003d%(tg)s, prefix\u003d\u0027%(pf)s\u0027, argdict\u003d%(ad)s, timeout\u003d%(to)s.\",\n+              {\"cl\": rados_client, \"tg\": target, \"pf\": prefix, \"ad\": argdict,\n                \"to\": RADOS_TIMEOUT})\n \n     try:\n         ret, outbuf, outs \u003d json_command(rados_client,\n+                                         target\u003dtarget,\n                                          prefix\u003dprefix,\n                                          argdict\u003dargdict,\n                                          timeout\u003dRADOS_TIMEOUT)\n@@ -712,7 +714,8 @@ class NativeProtocolHelper(ganesha.NASHelperBase):\n \n     def get_mon_addrs(self):\n         result \u003d []\n-        mon_map \u003d rados_command(self.rados_client, \"mon dump\", json_obj\u003dTrue)\n+        mon_map \u003d rados_command(self.rados_client, \"mon dump\", json_obj\u003dTrue,\n+                                target\u003d(\u0027mon\u0027, ))\n         for mon in mon_map[\u0027mons\u0027]:\n             ip_port \u003d mon[\u0027addr\u0027].split(\"/\")[0]\n             result.append(ip_port)\n\n\nWe want the above change to go into manila cephfs driver code ASAP.","accounts_in_message":[],"_revision_number":1},{"id":"53888272a81588552dbd8675f228f687d245a363","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-09 11:23:41.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"517c6ff9362f25d786025ab340382ddfb2215f09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-09 11:26:42.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"758e836d2023295e12b15516d298d34ebdb81776","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-04-09 11:58:56.000000000","message":"Patch Set 2:\n\nAwesome!  Thanks, Ramana!","accounts_in_message":[],"_revision_number":2},{"id":"57eb876e80ee1c056908a08d188c817fb1b3d610","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 13:14:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/4f130cdef64e42c8ab7a40e7f92a56a5 : SUCCESS in 1h 22m 51s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/440567676d224f63abdc93e32ba2b372 : FAILURE in 1h 05m 02s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/8dc9673ededf460c99a94958a7482ca6 : SUCCESS in 1h 41m 18s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/ef31a63ddc3747078e331e596cffa49a : SUCCESS in 1h 18m 56s (non-voting)\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/31071432fe284f508dc8d60e73696d06 : SUCCESS in 1h 39m 02s (non-voting)\n- devstack-plugin-ceph-tempest-victoria https://zuul.opendev.org/t/openstack/build/935c9b509e384715a798c6201d2d7687 : SUCCESS in 1h 20m 12s\n- devstack-plugin-ceph-tempest-ussuri https://zuul.opendev.org/t/openstack/build/e625e1bc52904da58ea169a3c86d43ed : SUCCESS in 1h 20m 05s\n- devstack-plugin-ceph-tempest-train https://zuul.opendev.org/t/openstack/build/d17aab5bf60245a1a117a45035e70284 : SUCCESS in 1h 24m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b7e534949194fd78e38115e0bd02117 : SUCCESS in 6m 33s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/d1163bb3296f4c6caa3f4fb15ae95ed4 : SUCCESS in 3m 06s","accounts_in_message":[],"_revision_number":2},{"id":"917bb1f0ec5c498c1f372ee17fc186eb388fb97b","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-04-09 13:46:37.000000000","message":"Patch Set 2: Code-Review+2\n\nThis is working with https://review.opendev.org/c/openstack/manila/+/785623 -- there are a couple of failures in the native CephFS job but I don\u0027t see any cases where the driver can\u0027t interact properly with the back end for lack of caps.","accounts_in_message":[],"_revision_number":2},{"id":"273f9efe17ba11d836690643142dc878759fdfc6","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-09 14:16:46.000000000","message":"Patch Set 2:\n\nWhat about previous stable branches Tom?","accounts_in_message":[],"_revision_number":2},{"id":"efc2832859bda0a9df8310f69e4e4beed66f6550","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-04-09 14:22:33.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e What about previous stable branches Tom?\n\nGood point, I was being too enthusiastic :D  Are you planning to make the change specific to Wallaby and after?","accounts_in_message":[],"_revision_number":2},{"id":"441200300fcdc6995bfde9ddf9331ce2a8a6ca42","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-04-09 15:23:49.000000000","message":"Patch Set 2:\n\nThe QA team will discuss whether it makes more sense to just branch devstack-plugin-ceph. The containers plugin is branching to avoid this headache of \"do we have the older branches covered\", so we can do the same for ceph. These are our two major plugins so it makes sense to branch them with DevStack IMHO. Please let us know your thoughts too.","accounts_in_message":[],"_revision_number":2},{"id":"f8ec2f5dd1602f70cb5ca622323348adc1c55fbc","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-04-09 15:46:53.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e The QA team will discuss whether it makes more sense to just branch devstack-plugin-ceph. The containers plugin is branching to avoid this headache of \"do we have the older branches covered\", so we can do the same for ceph. These are our two major plugins so it makes sense to branch them with DevStack IMHO. Please let us know your thoughts too.\n\nOffhand, I think branching makes lots of sense.  We could make the plugin code itself cleaner and even make more fundamental changes with e.g. a development branch to take advantage of new Ceph features without so much concern about fitting them into the legacy structure of the plugin.","accounts_in_message":[],"_revision_number":2},{"id":"54a584008aae9dcb3e44297a42125a46d616cb78","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-09 16:11:34.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e The QA team will discuss whether it makes more sense to just branch devstack-plugin-ceph. The containers plugin is branching to avoid this headache of \"do we have the older branches covered\", so we can do the same for ceph. These are our two major plugins so it makes sense to branch them with DevStack IMHO. Please let us know your thoughts too.\n\u003e \n\u003e Offhand, I think branching makes lots of sense.  We could make the plugin code itself cleaner and even make more fundamental changes with e.g. a development branch to take advantage of new Ceph features without so much concern about fitting them into the legacy structure of the plugin.\n\nMakes a lot of sense to me too. I\u0027m not familiar with the reasoning behind not branching this plugin. It would be awesome to bring this discussion with the QA team. Thanks Radoslaw!","accounts_in_message":[],"_revision_number":2},{"id":"a463562cccdef5482f32733476cf0092f539ca7f","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-22 16:16:00.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"14ef3ce4eaca2fe22bf30706d8126e0c5949604e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-22 18:10:49.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/5c1fd7f5ef034792b54c77331bc21c34 : SUCCESS in 1h 30m 56s\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/eb8800e850ee4100a5c3f321b318f4c6 : SUCCESS in 57m 21s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/a54137573f5649449db61f5f6ef86842 : SUCCESS in 1h 37m 35s (non-voting)\n- devstack-plugin-ceph-tempest-fedora-latest https://zuul.opendev.org/t/openstack/build/102b79cbd40b492b972c61c5fd5fdf74 : SUCCESS in 1h 04m 01s (non-voting)\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/83b122605fbf4b95889d0b72c9e81e2d : FAILURE in 1h 37m 54s (non-voting)\n- devstack-plugin-ceph-tempest-victoria https://zuul.opendev.org/t/openstack/build/8b7edb21de7640d4aba6a77d56e8f072 : FAILURE in 1h 20m 56s\n- devstack-plugin-ceph-tempest-ussuri https://zuul.opendev.org/t/openstack/build/3228e1efc41b4800b65d644c59ae39e0 : SUCCESS in 1h 21m 46s\n- devstack-plugin-ceph-tempest-train https://zuul.opendev.org/t/openstack/build/998f317d1fac4ead9f4bda0c5c2ddc1b : SUCCESS in 1h 21m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/595381ad6f104e489535be08c640577d : SUCCESS in 7m 49s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/892549ae120f417a875b482e4ef23418 : SUCCESS in 2m 59s","accounts_in_message":[],"_revision_number":2},{"id":"0b77f9625bd1b818a141547f00b47f983dbd79df","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2021-04-22 18:43:57.000000000","message":"Patch Set 2: Code-Review+1\n\nI\u0027m ready to +2 this when you s/Fix/Reduce/ in the commit message as you planned.\n\nThe devstack-plugin-ceph-tempest-victoria job failure is an unrelated shelve test case in nova, probably intermittent.","accounts_in_message":[],"_revision_number":2},{"id":"89a5b5ba8ed6c9beae561a882decbb066604aa43","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-23 06:36:26.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"53e95c6e068017d673940e65cf08b7a9fc35d2cc","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-04-23 12:26:33.000000000","message":"Patch Set 2:\n\nThanks for the review Dmitriy! MDS caps shouldn\u0027t be needed for manila in either case. API and scenario tempest tests are passing for both cephfs native and cephfs nfs with the proposed caps. Have you seen an error with this caps in some env?","accounts_in_message":[],"_revision_number":2},{"id":"153a302905aef601a667818962b0bd3901b684ea","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-23 13:06:25.000000000","message":"Removed Code-Review-1 by Dmitriy Rabotyagov \u003cnoonedeadpunk@ya.ru\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"5b222fad76323b48fc15ef5f9fc27060b86dee1d","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-23 13:14:48.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Thanks for the review Dmitriy! MDS caps shouldn\u0027t be needed for manila in either case. API and scenario tempest tests are passing for both cephfs native and cephfs nfs with the proposed caps. Have you seen an error with this caps in some env?\n\nHm... But I mean for native case something should create and mount CephFS share? And a new client should be created for each project or smth like that?\nBut I think I missed another release note, which would be related to https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/cephfs/driver.py#L94-L101","accounts_in_message":[],"_revision_number":2},{"id":"763955c33a57fa77da5b7fd56e15a80bbc642779","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-04-27 23:04:03.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e Thanks for the review Dmitriy! MDS caps shouldn\u0027t be needed for manila in either case. API and scenario tempest tests are passing for both cephfs native and cephfs nfs with the proposed caps. Have you seen an error with this caps in some env?\n\u003e \n\u003e Hm... But I mean for native case something should create and mount CephFS share? And a new client should be created for each project or smth like that?\n\u003e But I think I missed another release note, which would be related to https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/cephfs/driver.py#L94-L101\n\nNope, you don\u0027t need to create the /volumes directory by hand (or with automation) - you needn\u0027t do it even previously. \"/volumes\" was a top level directory that the driver automatically created in the past where it would place all the manila share groups and shares under. Previously the manila CephFS driver would create subdirectories under this top level directory and export them as shares/share groups. However, Ceph now internalized this concept of exporting subdirectories on a filesystem as \"Subvolumes\". So, Manila shares are now analogous to \n\"CephFS subvolumes\" - a concept that\u0027s got growing support in Ceph itself. The top level directory if any is still abstracted away from you as the end user (or the deployer) - you needn\u0027t worry about it. \n\nIs there any place in openstack-ansible where you were creating this top level \"/volumes\" directory?","accounts_in_message":[],"_revision_number":2},{"id":"f73d419a187b9230234f9179fc669dd36cf2507c","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-28 09:34:32.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 2:\n\u003e \u003e \u003e \n\u003e \u003e \u003e Thanks for the review Dmitriy! MDS caps shouldn\u0027t be needed for manila in either case. API and scenario tempest tests are passing for both cephfs native and cephfs nfs with the proposed caps. Have you seen an error with this caps in some env?\n\u003e \u003e \n\u003e \u003e Hm... But I mean for native case something should create and mount CephFS share? And a new client should be created for each project or smth like that?\n\u003e \u003e But I think I missed another release note, which would be related to https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/cephfs/driver.py#L94-L101\n\u003e \n\u003e Nope, you don\u0027t need to create the /volumes directory by hand (or with automation) - you needn\u0027t do it even previously. \"/volumes\" was a top level directory that the driver automatically created in the past where it would place all the manila share groups and shares under. Previously the manila CephFS driver would create subdirectories under this top level directory and export them as shares/share groups. However, Ceph now internalized this concept of exporting subdirectories on a filesystem as \"Subvolumes\". So, Manila shares are now analogous to \n\u003e \"CephFS subvolumes\" - a concept that\u0027s got growing support in Ceph itself. The top level directory if any is still abstracted away from you as the end user (or the deployer) - you needn\u0027t worry about it. \n\u003e \n\u003e Is there any place in openstack-ansible where you were creating this top level \"/volumes\" directory?\n\nYeah, there was as otherwise tempest test was failing back then https://opendev.org/openstack/openstack-ansible-os_manila/src/branch/master/tasks/manila_backend_cephfs.yml#L27-L31. I think it\u0027s fixed at the moment anyway, so already suggested patch to drop it","accounts_in_message":[],"_revision_number":2},{"id":"ea5489e290d93065be36ca418c1b99d9a8b52fd5","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-12-30 14:38:21.000000000","message":"Removed reviewer Radosław Piliszek.","accounts_in_message":[],"_revision_number":2},{"id":"f816c328760e939b16f9cde698913acc63dd329c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2023-05-17 17:53:03.000000000","message":"Abandoned\n\nNot relevant anymore","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"234d2d333fc6ff1470be915b119206273da3bc46","revisions":{"403763e59ca9a5287c62ca9c5deff3f12816356a":{"kind":"REWORK","_number":1,"created":"2021-03-24 20:23:48.000000000","uploader":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"ref":"refs/changes/55/782855/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/55/782855/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/1"}}},"commit":{"parents":[{"commit":"60ae7c53c7ef78fd36e96b82dd65b65ea2484fb4","subject":"Merge \"tempest: Use a more appropriate name for the skip list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/60ae7c53c7ef78fd36e96b82dd65b65ea2484fb4"}]}],"author":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-03-24 20:21:10.000000000","tz":0},"committer":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-03-24 20:21:10.000000000","tz":0},"subject":"Fix auth ID caps for manila with ceph-mgr","message":"Fix auth ID caps for manila with ceph-mgr\n\nNow that we issue mgr/volume commands and rados\nget/put on pool with \"ganesha_rados_store_pool_name\"\nname via a rados client, the auth ID used by the\ndriver/rados client would need different capabilities.\n\nThe auth ID will now require:\n\nmon \u0027allow r\u0027\nmgr \u0027allow rw\u0027\nosd \u0027allow rw pool\u003d\u003cganesha_rados_store_pool_name\u003e\"\n\nThe driver\u0027s auth ID does not need any MDS capability,\nrequires reduced MON and OSD capability, and extra write\ncapability for MGR.\n\nPartially-Implements: bp update-cephfs-drivers\n\nCo-Authored-By: Victoria Martinez de la Cruz \u003cvictoria@redhat.com\u003e\nCo-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e\nCo-Authored-By: Tom Barron \u003ctpb@dyncloud.net\u003e\nChange-Id: Icfd973fd2829fee8e3e611ad1e23031a4afc4151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/403763e59ca9a5287c62ca9c5deff3f12816356a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/403763e59ca9a5287c62ca9c5deff3f12816356a"}]},"branch":"refs/heads/master"},"234d2d333fc6ff1470be915b119206273da3bc46":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-04-09 11:26:42.000000000","uploader":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"ref":"refs/changes/55/782855/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/55/782855/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/55/782855/2"}}},"commit":{"parents":[{"commit":"60ae7c53c7ef78fd36e96b82dd65b65ea2484fb4","subject":"Merge \"tempest: Use a more appropriate name for the skip list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/60ae7c53c7ef78fd36e96b82dd65b65ea2484fb4"}]}],"author":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-03-24 20:21:10.000000000","tz":0},"committer":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-04-09 11:23:25.000000000","tz":0},"subject":"Fix auth ID caps for manila with ceph-mgr","message":"Fix auth ID caps for manila with ceph-mgr\n\nNow that we issue mgr/volume commands and rados\nget/put on pool with \"ganesha_rados_store_pool_name\"\nname via a rados client, the auth ID used by the\ndriver/rados client would need different capabilities.\n\nThe auth ID will now require:\n\nmon \u0027allow r\u0027\nmgr \u0027allow rw\u0027\nosd \u0027allow rw pool\u003d\u003cganesha_rados_store_pool_name\u003e\"\n\nThe driver\u0027s auth ID does not need any MDS capability,\nrequires reduced MON and OSD capability, and extra write\ncapability for MGR.\n\nDepends-On: https://review.opendev.org/c/openstack/manila/+/785623\n\nPartially-Implements: bp update-cephfs-drivers\n\nCo-Authored-By: Victoria Martinez de la Cruz \u003cvictoria@redhat.com\u003e\nCo-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e\nCo-Authored-By: Tom Barron \u003ctpb@dyncloud.net\u003e\nChange-Id: Icfd973fd2829fee8e3e611ad1e23031a4afc4151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/234d2d333fc6ff1470be915b119206273da3bc46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/234d2d333fc6ff1470be915b119206273da3bc46"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}