)]}'
{".zuul.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea76568e622ba9b16bb3118cabe7035df546f1a","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    description: |"},{"line_number":123,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":124,"context_line":"      using Ceph master as the backend."},{"line_number":125,"context_line":"    branches: master"},{"line_number":126,"context_line":"    vars:"},{"line_number":127,"context_line":"      devstack_localrc:"},{"line_number":128,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"623fd66e_55c07803","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":20},"updated":"2021-09-29 00:09:27.000000000","message":"no need for this, i think?","commit_id":"bf07abf7a9af586b280914fe0f8c00b130ac1b65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"188e11fd4272ec1a628c4e6b047fbb8ea671fc44","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    description: |"},{"line_number":123,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":124,"context_line":"      using Ceph master as the backend."},{"line_number":125,"context_line":"    branches: master"},{"line_number":126,"context_line":"    vars:"},{"line_number":127,"context_line":"      devstack_localrc:"},{"line_number":128,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e8e8fc10_ff949f99","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":20},"in_reply_to":"61734516_7221ade8","updated":"2021-09-29 05:21:17.000000000","message":"Yes - it\u0027s only meant for the trunk branch - isn\u0027t needed on xena - thanks for taking it out of https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811348/","commit_id":"bf07abf7a9af586b280914fe0f8c00b130ac1b65"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fad4e1ed6c05ad5692cce8be345a93215baf465b","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    description: |"},{"line_number":123,"context_line":"      Integration tests that runs with the ceph devstack plugin"},{"line_number":124,"context_line":"      using Ceph master as the backend."},{"line_number":125,"context_line":"    branches: master"},{"line_number":126,"context_line":"    vars:"},{"line_number":127,"context_line":"      devstack_localrc:"},{"line_number":128,"context_line":"        TEST_MASTER: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"61734516_7221ade8","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":20},"in_reply_to":"623fd66e_55c07803","updated":"2021-09-29 00:34:25.000000000","message":"This is right as you do not want to run this job on a stable branch. If I understand correctly this test with ceph from source and only meant for master gate, right?\n\nIf so, then \u0027branches: master\u0027 is good guard for that in case we forget to remove this while new stable branches are cut. and if it exists in stable too then also I do not think it will cause any issue.\n\nIf we remove this branch variant then yes you should make sure you remove it from stable branch to avoid it running there.","commit_id":"bf07abf7a9af586b280914fe0f8c00b130ac1b65"}],"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea76568e622ba9b16bb3118cabe7035df546f1a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"- https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/786311"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"But we did not cleanup the master version of job definition so that we"},{"line_number":18,"context_line":"do not need to do it for future stable branches. When stable/xena is cut"},{"line_number":19,"context_line":"from master the ./.zuul.yaml version of jobs in stable/xena has the stable"},{"line_number":20,"context_line":"branches variant which is being picked up by zuul for stable branch gate"},{"line_number":21,"context_line":"instead of their own version defined in their stable branch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- https://zuul.opendev.org/t/openstack/build/bc088154e50440fe9a2cacf52426748a/log/zuul-info/inventory.yaml#241"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"And it started failing ceph job when ceph version was update for master and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"c5f6cc8c_79f00a20","line":22,"range":{"start_line":18,"start_character":49,"end_line":22,"end_character":0},"updated":"2021-09-29 00:09:27.000000000","message":"Knew we were running into a problem; thanks for fixing this up, Ghanshyam!","commit_id":"bf07abf7a9af586b280914fe0f8c00b130ac1b65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea76568e622ba9b16bb3118cabe7035df546f1a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"same is being picked by stable branch testin so due to above branch matching"},{"line_number":27,"context_line":"logic."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"To avoid this in future when we will have stable/yoga or so we need to cleanup"},{"line_number":30,"context_line":"this in master. Master repo will only keep the master version of jobs and no"},{"line_number":31,"context_line":"stable branch jobs."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Other stable/rocky and older jobs will be moved to stable/stein so that we have"},{"line_number":34,"context_line":"them there if anyone cut the branch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cb314784_96f612a6","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":19},"updated":"2021-09-29 00:09:27.000000000","message":"+++","commit_id":"bf07abf7a9af586b280914fe0f8c00b130ac1b65"}]}
