)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af753e02ae8572435246d9a43c8e9f581bad6d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4aa38efe_fe62a166","updated":"2023-03-22 15:43:35.000000000","message":"I\u0027ll follow up post PTG and clean this up some more... i\u0027m hoping to stop using this package based installation script for manila jobs at some time during the bobcat cycle 🤞","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"794a2702282850357383ff43b4e5579227e54d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ee499613_a5383783","updated":"2023-03-16 13:21:52.000000000","message":"Looking good, thank you for working on these enhancements","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0c9387653627b1e0b5913b0bff53fbf0f3578fdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6954cbf6_239051f4","updated":"2023-03-22 09:39:20.000000000","message":"Nice work, thanks Goutham.\n\nSome of the concerns marked in the reviews can be addressed in a follow up change.\n\nLet\u0027s get this one in now and reenable the Ceph jobs.","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0541b19a2489e9fbf004ad3f6f28c99a94bfdcf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"da6f6c02_d02464ce","updated":"2023-03-16 17:47:12.000000000","message":"Thanks for the reviews Francesco and Carlos.. responses inline","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"}],"devstack/lib/ceph":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"872ce2573582efa9c67096bbd6b5f4f918797454","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-\u0027unspecified\u0027}"},{"line_number":34,"context_line":"# Remove \"v\" and \"-stable\" prefix/suffix tags"},{"line_number":35,"context_line":"GANESHA_RELEASE\u003d$(echo $GANESHA_RELEASE | sed -e \"s/^v//\" -e \"s/-stable$//\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$MANILA_CEPH_DRIVER\" \u003d\u003d \"cephfsnfs\" \u0026\u0026 \"$GANESHA_RELEASE\" \u003d\u003d \"unspecified\" ]]; then"},{"line_number":38,"context_line":"    # default ganesha release based on ceph release"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"c825ab92_d5145e83","line":35,"updated":"2023-03-16 10:10:18.000000000","message":"is this needed here?\nif Manila_ceph_driver is cephfs, you\u0027re going to set the ganesha_relase in any case, and you only need to choose which version you need according to CEPH_RELEASE.\nNot that this is a blocking thing, but we can optimize this block later.","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0541b19a2489e9fbf004ad3f6f28c99a94bfdcf5","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-\u0027unspecified\u0027}"},{"line_number":34,"context_line":"# Remove \"v\" and \"-stable\" prefix/suffix tags"},{"line_number":35,"context_line":"GANESHA_RELEASE\u003d$(echo $GANESHA_RELEASE | sed -e \"s/^v//\" -e \"s/-stable$//\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$MANILA_CEPH_DRIVER\" \u003d\u003d \"cephfsnfs\" \u0026\u0026 \"$GANESHA_RELEASE\" \u003d\u003d \"unspecified\" ]]; then"},{"line_number":38,"context_line":"    # default ganesha release based on ceph release"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"c21701fd_2427b39a","line":35,"in_reply_to":"22c20c11_51b1ac5f","updated":"2023-03-16 17:47:12.000000000","message":"Prior to this change, people could specify the versions with this format:\n\n  \"v3.5-stable\"\n\nThis was how the builds were tagged by the ceph community on download.ceph.com; I just wanted to make sure we don\u0027t break people using such an override on their local.conf files... so this line provides backwards compatibility while also ignoring their specific directive --- builds with those tags won\u0027t exist on the ubuntu ppa or centos storage sig..\n\nthe code below hardcodes versions per ceph release so developers don\u0027t need to know what version works best with a given ceph release... so if they weren\u0027t setting GANESHA_RELEASE in their local.conf, we\u0027ll just figure out the appropriate version to use as default.","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af753e02ae8572435246d9a43c8e9f581bad6d29","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-\u0027unspecified\u0027}"},{"line_number":34,"context_line":"# Remove \"v\" and \"-stable\" prefix/suffix tags"},{"line_number":35,"context_line":"GANESHA_RELEASE\u003d$(echo $GANESHA_RELEASE | sed -e \"s/^v//\" -e \"s/-stable$//\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$MANILA_CEPH_DRIVER\" \u003d\u003d \"cephfsnfs\" \u0026\u0026 \"$GANESHA_RELEASE\" \u003d\u003d \"unspecified\" ]]; then"},{"line_number":38,"context_line":"    # default ganesha release based on ceph release"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5d195a78_145c906b","line":35,"in_reply_to":"2c5c997a_07994f6f","updated":"2023-03-22 15:43:35.000000000","message":"ack, ty Victoria!","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0c9387653627b1e0b5913b0bff53fbf0f3578fdc","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-\u0027unspecified\u0027}"},{"line_number":34,"context_line":"# Remove \"v\" and \"-stable\" prefix/suffix tags"},{"line_number":35,"context_line":"GANESHA_RELEASE\u003d$(echo $GANESHA_RELEASE | sed -e \"s/^v//\" -e \"s/-stable$//\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$MANILA_CEPH_DRIVER\" \u003d\u003d \"cephfsnfs\" \u0026\u0026 \"$GANESHA_RELEASE\" \u003d\u003d \"unspecified\" ]]; then"},{"line_number":38,"context_line":"    # default ganesha release based on ceph release"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"2c5c997a_07994f6f","line":35,"in_reply_to":"c21701fd_2427b39a","updated":"2023-03-22 09:39:20.000000000","message":"+1 Maybe you can issue a deprecation warning here and add a bug tracker to remove this logic in the next cycle (C release probably).","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"794a2702282850357383ff43b4e5579227e54d54","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GANESHA_RELEASE\u003d${GANESHA_RELEASE:-\u0027unspecified\u0027}"},{"line_number":34,"context_line":"# Remove \"v\" and \"-stable\" prefix/suffix tags"},{"line_number":35,"context_line":"GANESHA_RELEASE\u003d$(echo $GANESHA_RELEASE | sed -e \"s/^v//\" -e \"s/-stable$//\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$MANILA_CEPH_DRIVER\" \u003d\u003d \"cephfsnfs\" \u0026\u0026 \"$GANESHA_RELEASE\" \u003d\u003d \"unspecified\" ]]; then"},{"line_number":38,"context_line":"    # default ganesha release based on ceph release"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"22c20c11_51b1ac5f","line":35,"in_reply_to":"c825ab92_d5145e83","updated":"2023-03-16 13:21:52.000000000","message":"+1\nI\u0027m okay with this being addressed as a follow-up item","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"794a2702282850357383ff43b4e5579227e54d54","unresolved":true,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":287,"context_line":"function check_os_support_ceph {"},{"line_number":288,"context_line":"    if [[ ! ${DISTRO} \u003d~ (jammy|focal|bionic|xenial|f31|f32|f33|f34|rhel8|rhel9) ]]; then"},{"line_number":289,"context_line":"        echo \"WARNING: devstack-plugin-ceph hasn\u0027t been tested with $DISTRO. \\"},{"line_number":290,"context_line":"        Set FORCE_CEPH_INSTALL\u003dyes in your local.conf if you\u0027d like to \\"},{"line_number":291,"context_line":"        attempt installation anyway.\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"6048325e_44d3289d","line":288,"range":{"start_line":288,"start_character":26,"end_line":288,"end_character":79},"updated":"2023-03-16 13:21:52.000000000","message":"even though this adds some sort of maintenance required for the future, I can\u0027t think of other way around for this, so I\u0027d say it\u0027s okay, and we will need to remember to update this list again in the future.","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0541b19a2489e9fbf004ad3f6f28c99a94bfdcf5","unresolved":true,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":287,"context_line":"function check_os_support_ceph {"},{"line_number":288,"context_line":"    if [[ ! ${DISTRO} \u003d~ (jammy|focal|bionic|xenial|f31|f32|f33|f34|rhel8|rhel9) ]]; then"},{"line_number":289,"context_line":"        echo \"WARNING: devstack-plugin-ceph hasn\u0027t been tested with $DISTRO. \\"},{"line_number":290,"context_line":"        Set FORCE_CEPH_INSTALL\u003dyes in your local.conf if you\u0027d like to \\"},{"line_number":291,"context_line":"        attempt installation anyway.\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"e25abdf1_e4bcefeb","line":288,"range":{"start_line":288,"start_character":26,"end_line":288,"end_character":79},"in_reply_to":"6048325e_44d3289d","updated":"2023-03-16 17:47:12.000000000","message":"i don\u0027t like this too :) \ni for one see that we accept EOL fedora releases, and there\u0027s a mismatch between this list for fedora here, and line 1098 :| \n\nI don\u0027t use fedora for devstack locally.. but i\u0027ll try to clean this up in a separate patch. \n\nWe can similarly remove bionic, xenial too.. and likely rhel8...","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0c9387653627b1e0b5913b0bff53fbf0f3578fdc","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":287,"context_line":"function check_os_support_ceph {"},{"line_number":288,"context_line":"    if [[ ! ${DISTRO} \u003d~ (jammy|focal|bionic|xenial|f31|f32|f33|f34|rhel8|rhel9) ]]; then"},{"line_number":289,"context_line":"        echo \"WARNING: devstack-plugin-ceph hasn\u0027t been tested with $DISTRO. \\"},{"line_number":290,"context_line":"        Set FORCE_CEPH_INSTALL\u003dyes in your local.conf if you\u0027d like to \\"},{"line_number":291,"context_line":"        attempt installation anyway.\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"d7e86975_d72b8fdf","line":288,"range":{"start_line":288,"start_character":26,"end_line":288,"end_character":79},"in_reply_to":"cc722a53_08e7e842","updated":"2023-03-22 09:39:20.000000000","message":"Agree that this needs some cleaning up. Maybe we should stick to a subset of the supported distros for Devstack (see https://opendev.org/openstack/devstack/src/branch/master/stack.sh#L232) to make maintenance easier.\n\nAnd I just see L1098. Seems that was missed in previous updates for the supported versions 😕","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af753e02ae8572435246d9a43c8e9f581bad6d29","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":287,"context_line":"function check_os_support_ceph {"},{"line_number":288,"context_line":"    if [[ ! ${DISTRO} \u003d~ (jammy|focal|bionic|xenial|f31|f32|f33|f34|rhel8|rhel9) ]]; then"},{"line_number":289,"context_line":"        echo \"WARNING: devstack-plugin-ceph hasn\u0027t been tested with $DISTRO. \\"},{"line_number":290,"context_line":"        Set FORCE_CEPH_INSTALL\u003dyes in your local.conf if you\u0027d like to \\"},{"line_number":291,"context_line":"        attempt installation anyway.\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"870b8fc0_0c2ef9a6","line":288,"range":{"start_line":288,"start_character":26,"end_line":288,"end_character":79},"in_reply_to":"d7e86975_d72b8fdf","updated":"2023-03-22 15:43:35.000000000","message":"Thanks for the pointer Victoria!","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a966923df549bf090f39cac1b4b1a173e03b97f3","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# check_os_support_ceph() - Check if the OS provides a decent version of Ceph"},{"line_number":287,"context_line":"function check_os_support_ceph {"},{"line_number":288,"context_line":"    if [[ ! ${DISTRO} \u003d~ (jammy|focal|bionic|xenial|f31|f32|f33|f34|rhel8|rhel9) ]]; then"},{"line_number":289,"context_line":"        echo \"WARNING: devstack-plugin-ceph hasn\u0027t been tested with $DISTRO. \\"},{"line_number":290,"context_line":"        Set FORCE_CEPH_INSTALL\u003dyes in your local.conf if you\u0027d like to \\"},{"line_number":291,"context_line":"        attempt installation anyway.\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"cc722a53_08e7e842","line":288,"range":{"start_line":288,"start_character":26,"end_line":288,"end_character":79},"in_reply_to":"e25abdf1_e4bcefeb","updated":"2023-03-20 15:44:39.000000000","message":"\u003e I don\u0027t use fedora for devstack locally.. but i\u0027ll try to clean this up in a separate patch. \nAck, thanks!","commit_id":"563cb5deeb21815ce0c62fa30249e85e886c783a"}]}