)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~885374","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~I1067d52b7a435fcef7996eea6479d598be842dca","project":"openstack/devstack-plugin-ceph","branch":"master","topic":"only-cinder","attention_set":{},"removed_from_attention_set":{"9535":{"account":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"last_update":"2024-05-13 21:31:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1067d52b7a435fcef7996eea6479d598be842dca","subject":"Add service secret to libvirt when cinder enabled","status":"MERGED","created":"2023-06-06 16:38:08.000000000","updated":"2024-05-13 21:32:42.000000000","submitted":"2024-05-13 21:31:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"885374-only-cinder","meta_rev_id":"30078a9ed168c3cc92f68c85e274161b896073f4","_number":885374,"virtual_id_number":885374,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-05-13 21:31:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":2,"date":"2024-05-13 19:32:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":1,"date":"2023-06-16 14:04:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},{"value":2,"date":"2024-05-13 18:27:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":1,"date":"2024-05-13 19:32:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-06 18:30:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-16 14:04:01.000000000","updated_by":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"reviewer":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"state":"REVIEWER"},{"updated":"2024-05-13 18:27:54.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2024-05-13 19:32:21.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"}],"messages":[{"id":"31208d5db390d85117bfec4f6c3ba3d29039413d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2023-06-06 16:38:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8caf5a0d7b72ca3b9601ae0411933678ac5022df","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-06 18:30:07.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/2b41bdad879a48789475ae29f1e5df4a\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/759ae3755e6e4b5da748ad52e451eb99 : SUCCESS in 1h 45m 31s\n- devstack-plugin-ceph-tempest-ubuntu https://zuul.opendev.org/t/openstack/build/a872cfcdb6084ce78158cab81d41dad6 : SUCCESS in 1h 36m 43s (non-voting)\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/b0a0b09892804ad2b9dd117ba44b0850 : FAILURE in 25m 31s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/d0dcce91c7c3479c9691425f4741c43d : SUCCESS in 1h 05m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dbb1e450e74648ff80cdef1ef0fe4c83 : SUCCESS in 4m 50s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/b9fa72e7b0f2491ea861b91f60044254 : FAILURE in 2m 12s","accounts_in_message":[],"_revision_number":1},{"id":"9bb1d47009ec6a91bf34327314683569c0d6a8f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2023-06-07 15:55:53.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"6b9ffeeebf758a6bb1507f359c75325dc6889449","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-07 17:46:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3c5220e5a1ba4d1891a194e7a0a2fe42\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/34bc80fa172e4ec383e213f9034a5f70 : SUCCESS in 1h 33m 29s\n- devstack-plugin-ceph-tempest-ubuntu https://zuul.opendev.org/t/openstack/build/26c0a46167da44aaa15a4454d9e11bfc : SUCCESS in 1h 48m 46s (non-voting)\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/467107da0d764577a83201a243a1d547 : SUCCESS in 47m 35s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs https://zuul.opendev.org/t/openstack/build/a1f72c28f760497da2e326c84f2d8c62 : SUCCESS in 1h 00m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6666ee35a8fb45e08f3564c483093c63 : SUCCESS in 3m 51s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/bf406c94af7b48929ad05c5c09c07f5f : SUCCESS in 2m 12s","accounts_in_message":[],"_revision_number":2},{"id":"fe4b1e788f8ea01ac0fe97a6a20a2db1b9b05398","author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"date":"2023-06-16 14:04:01.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7bd0249a63e6d5ac79c84c59c97b1f17dce9ff8","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2024-05-13 18:27:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"63e6f2c820b4906b7300452a4fefe6fa1742a197","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2024-05-13 19:32:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"815e50254a11b62de79f565aca4bfae70ef64d81","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-13 19:32:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"bc7ef53b277d2d1add15f53283e8cabd809151de","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-13 21:31:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fd4d594beed24ab7894d0d2802a69305\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/1a7373c64721491089ba2a6dc624df4b : SUCCESS in 1h 57m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f23b254dae0d411d87a8aa82e2d6014f : SUCCESS in 4m 41s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/8f85b3f301e64090b76af91da7fdaf83 : SUCCESS in 1m 56s","accounts_in_message":[],"_revision_number":2},{"id":"cdabfb095877fd9548b827f4f15bce3ba5a0aec4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-13 21:31:47.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"30078a9ed168c3cc92f68c85e274161b896073f4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-13 21:32:42.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/30764a563c8e40c6a811691f0546d758\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f473766b32c24e89b58b43a7f14b5cdc : SUCCESS in 36s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a89fb90b6385ed0331ce994e46f0ebd9f9a02b48","revisions":{"bc0d9698851218bb887d5db26babcecccfc526e7":{"kind":"REWORK","_number":1,"created":"2023-06-06 16:38:08.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/74/885374/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/74/885374/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/1"}}},"commit":{"parents":[{"commit":"bf4598d923bebe9ba31e6651a07596017208b37e","subject":"Enable validation and disable block-migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/bf4598d923bebe9ba31e6651a07596017208b37e"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-06-06 16:32:56.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-06-06 16:37:43.000000000","tz":120},"subject":"Add service secret to libvirt when cinder enabled","message":"Add service secret to libvirt when cinder enabled\n\nThe current code only adds the service secret to libvirt when Ceph has\nbeen enabled in Nova, but it should also be enabled if it has only been\nenabled in Cinder.\n\nThis patch changes devstack/plugin.sh to write the service secret to\nlibvirt whenever Nova or Cinder is using Ceph.\n\nThis would be the counterpart of the code we already have in\n_undefine_virsh_secret where we are already checking if it\u0027s enabled in\neither of the services to remove the secret.\n\nChange-Id: I1067d52b7a435fcef7996eea6479d598be842dca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/bc0d9698851218bb887d5db26babcecccfc526e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/bc0d9698851218bb887d5db26babcecccfc526e7"}]},"branch":"refs/heads/master"},"a89fb90b6385ed0331ce994e46f0ebd9f9a02b48":{"kind":"REWORK","_number":2,"created":"2023-06-07 15:55:53.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/74/885374/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/74/885374/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/74/885374/2"}}},"commit":{"parents":[{"commit":"bf4598d923bebe9ba31e6651a07596017208b37e","subject":"Enable validation and disable block-migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/bf4598d923bebe9ba31e6651a07596017208b37e"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-06-06 16:32:56.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2023-06-07 15:51:50.000000000","tz":120},"subject":"Add service secret to libvirt when cinder enabled","message":"Add service secret to libvirt when cinder enabled\n\nThe current code only adds the service secret to libvirt when Ceph has\nbeen enabled in Nova, but it should also be enabled if it has only been\nenabled in Cinder.\n\nThis patch changes devstack/plugin.sh to write the service secret to\nlibvirt whenever Nova or Cinder is using Ceph.\n\nThis would be the counterpart of the code we already have in\n_undefine_virsh_secret where we are already checking if it\u0027s enabled in\neither of the services to remove the secret.\n\nChange-Id: I1067d52b7a435fcef7996eea6479d598be842dca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/a89fb90b6385ed0331ce994e46f0ebd9f9a02b48"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/a89fb90b6385ed0331ce994e46f0ebd9f9a02b48"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}