)]}'
{".zuul.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9bef2dbd917bc84b3f068fec76cdb779a343d24","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    parent: manila-tempest-plugin-cephfs-nfs"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- job:"},{"line_number":98,"context_line":"    name: devatck-plugin-ceph-multinode-cephfs-nfs-cephadm"},{"line_number":99,"context_line":"    parent: manila-tempest-plugin-multinode-cephfs-nfs-cephadm"},{"line_number":100,"context_line":"    description: Test CephFS NFS (DHSS\u003dFalse) in a Multinode devstack env"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d4525195_6aeff699","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":17},"updated":"2024-01-20 01:38:19.000000000","message":"devstack","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9bef2dbd917bc84b3f068fec76cdb779a343d24","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    parent: manila-tempest-plugin-cephfs-nfs"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- job:"},{"line_number":98,"context_line":"    name: devatck-plugin-ceph-multinode-cephfs-nfs-cephadm"},{"line_number":99,"context_line":"    parent: manila-tempest-plugin-multinode-cephfs-nfs-cephadm"},{"line_number":100,"context_line":"    description: Test CephFS NFS (DHSS\u003dFalse) in a Multinode devstack env"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"70499948_9638abdc","line":98,"updated":"2024-01-20 01:38:19.000000000","message":"you\u0027re not enabling this job... shouldn\u0027t you?","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"699a4a92d19a01105cfe42aff9a5af682e2be3af","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    parent: manila-tempest-plugin-cephfs-nfs"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- job:"},{"line_number":98,"context_line":"    name: devatck-plugin-ceph-multinode-cephfs-nfs-cephadm"},{"line_number":99,"context_line":"    parent: manila-tempest-plugin-multinode-cephfs-nfs-cephadm"},{"line_number":100,"context_line":"    description: Test CephFS NFS (DHSS\u003dFalse) in a Multinode devstack env"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"be499b9a_80a0884d","line":98,"in_reply_to":"70499948_9638abdc","updated":"2024-02-01 15:26:19.000000000","message":"Done","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"699a4a92d19a01105cfe42aff9a5af682e2be3af","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    parent: manila-tempest-plugin-cephfs-nfs"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- job:"},{"line_number":98,"context_line":"    name: devatck-plugin-ceph-multinode-cephfs-nfs-cephadm"},{"line_number":99,"context_line":"    parent: manila-tempest-plugin-multinode-cephfs-nfs-cephadm"},{"line_number":100,"context_line":"    description: Test CephFS NFS (DHSS\u003dFalse) in a Multinode devstack env"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"be07e1a4_8077092b","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":17},"in_reply_to":"d4525195_6aeff699","updated":"2024-02-01 15:26:19.000000000","message":"Done","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b4d02e21d0fd6b9a51e2aab9edbb0207fbed4d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7580a88b_3d764c6e","updated":"2023-11-15 17:00:54.000000000","message":"recheck","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9b616a5a3f5fcb69b6589031785c21b0d8384cee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"50399610_68549e4e","updated":"2024-01-10 20:27:01.000000000","message":"recheck old logs","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7484c6e36ec46378f6249dc6fda5139336c80582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bf9259ee_37133cb3","updated":"2024-02-01 23:40:10.000000000","message":"Thanks Ashley,\n\nPlease see comment inline.. \nAre you planning to push a change to update the cephadm image to Reef so we can see the ingress service deployment work?","commit_id":"034d81b4498c6a88e79e824fc123068c73664c68"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"930cb6ba1dab4220a0815c7e281439a20aa521e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8851225f_f05bb10f","updated":"2024-02-06 18:06:25.000000000","message":"LGTM, thank you for working on this change!","commit_id":"a42ee1269b6d33094156690836d4600c9b7705ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c5e10d098225e45f06ec82d3b752f03ecde8f98d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"84268b18_d52d7153","updated":"2024-02-02 21:53:45.000000000","message":"My concerns were addressed; LGTM... the timeouts seem unrelated, the code change doesn\u0027t affect the jobs that timed out.","commit_id":"a42ee1269b6d33094156690836d4600c9b7705ee"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"a8eef99f462f0bacd2e8b51b77190eeb556d887a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bdb07ce9_81550992","updated":"2024-02-02 20:56:20.000000000","message":"recheck","commit_id":"a42ee1269b6d33094156690836d4600c9b7705ee"}],"devstack/lib/cephadm":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6725f0d68c9f25f6aca7874af40bed341eb68c0e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"CEPHFS_CLIENT_NAME\u003d\"client.$MANILA_CEPH_USER\""},{"line_number":73,"context_line":"CEPHFS_CLIENT_LOG\u003d\"/var/log/ceph-$CEPHFS_CLIENT_NAME.log\""},{"line_number":74,"context_line":"CEPHFS_MULTIPLE_FILESYSTEMS\u003d${CEPHFS_MULTIPLE_FILESYSTEMS:-False}"},{"line_number":75,"context_line":"VIP\u003d192.168.10.10"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# GLANCE DEFAULTS"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"26df5ff6_66a7a88f","line":75,"updated":"2023-11-16 08:57:10.000000000","message":"Should we try to set this to:\n\n```\nVIP\u003d${VIP:-$HOST_IP}\n```","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"fbeddef73aa2136bf84e23a31a3ea4105f42b9c9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"CEPHFS_CLIENT_NAME\u003d\"client.$MANILA_CEPH_USER\""},{"line_number":73,"context_line":"CEPHFS_CLIENT_LOG\u003d\"/var/log/ceph-$CEPHFS_CLIENT_NAME.log\""},{"line_number":74,"context_line":"CEPHFS_MULTIPLE_FILESYSTEMS\u003d${CEPHFS_MULTIPLE_FILESYSTEMS:-False}"},{"line_number":75,"context_line":"VIP\u003d192.168.10.10"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# GLANCE DEFAULTS"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"05ef429a_3a1f21ab","line":75,"in_reply_to":"26df5ff6_66a7a88f","updated":"2023-12-04 16:40:07.000000000","message":"Done","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6725f0d68c9f25f6aca7874af40bed341eb68c0e","unresolved":true,"context_lines":[{"line_number":315,"context_line":"}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"# Get Ceph version"},{"line_number":318,"context_line":"function _get_ceph_version {"},{"line_number":319,"context_line":"    local ceph_version_str"},{"line_number":320,"context_line":"    local mon_started"},{"line_number":321,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d676de32_15a520e4","line":318,"updated":"2023-11-16 08:57:10.000000000","message":"I think here we\u0027re just lucky enough that the client version is consistent with the container you run, but in theory if I\u0027m not wrong `ceph version` !\u003d `ceph versions`:\n\n```\nceph versions\n{\n    \"mon\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 1\n    },\n    \"mgr\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 1\n    },\n    \"osd\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 1\n    },\n    \"mds\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 1\n    },\n    \"rgw\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 1\n    },\n    \"overall\": {\n        \"ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\": 5\n    }\n}\n\n# ceph version\nceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)\n```\n\nGiven we\u0027re checking the server version, I think a way to check the version is either query Ceph like I did in the example above, or run something like the following:\n\n```\n\u003e podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027\n18.2.0\n```","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"fbeddef73aa2136bf84e23a31a3ea4105f42b9c9","unresolved":false,"context_lines":[{"line_number":315,"context_line":"}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"# Get Ceph version"},{"line_number":318,"context_line":"function _get_ceph_version {"},{"line_number":319,"context_line":"    local ceph_version_str"},{"line_number":320,"context_line":"    local mon_started"},{"line_number":321,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d880180b_8feaca5d","line":318,"in_reply_to":"d676de32_15a520e4","updated":"2023-12-04 16:40:07.000000000","message":"Done","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6725f0d68c9f25f6aca7874af40bed341eb68c0e","unresolved":true,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"# Install ceph: add NFS"},{"line_number":346,"context_line":"function ceph_nfs_config {"},{"line_number":347,"context_line":"    # (fpantano) TODO: Build an ingress daemon on top of this"},{"line_number":348,"context_line":"    local ceph_version"},{"line_number":349,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":350,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f58022c9_4692148e","line":347,"updated":"2023-11-16 08:57:10.000000000","message":"Remove comment on L347","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"fbeddef73aa2136bf84e23a31a3ea4105f42b9c9","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"# Install ceph: add NFS"},{"line_number":346,"context_line":"function ceph_nfs_config {"},{"line_number":347,"context_line":"    # (fpantano) TODO: Build an ingress daemon on top of this"},{"line_number":348,"context_line":"    local ceph_version"},{"line_number":349,"context_line":"    ceph_version\u003d$(_get_ceph_version mon)"},{"line_number":350,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"669b0d86_7136823c","line":347,"in_reply_to":"f58022c9_4692148e","updated":"2023-12-04 16:40:07.000000000","message":"Done","commit_id":"51d8d91c6f5566a2dfbb7a7d1ba741a5bdc0c411"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9bef2dbd917bc84b3f068fec76cdb779a343d24","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# DEFAULT OPTIONS"},{"line_number":31,"context_line":"ATTEMPTS\u003d30"},{"line_number":32,"context_line":"CONTAINER_IMAGE\u003d${CONTAINER_IMAGE:-\u0027quay.io/ceph/ceph:v18.2\u0027}"},{"line_number":33,"context_line":"DEVICES\u003d()"},{"line_number":34,"context_line":"if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"},{"line_number":35,"context_line":"    FSID\u003d$(uuidgen)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"05e1e1f9_b25b029b","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":61},"updated":"2024-01-20 01:38:19.000000000","message":"please make this bump in a separate change","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"699a4a92d19a01105cfe42aff9a5af682e2be3af","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# DEFAULT OPTIONS"},{"line_number":31,"context_line":"ATTEMPTS\u003d30"},{"line_number":32,"context_line":"CONTAINER_IMAGE\u003d${CONTAINER_IMAGE:-\u0027quay.io/ceph/ceph:v18.2\u0027}"},{"line_number":33,"context_line":"DEVICES\u003d()"},{"line_number":34,"context_line":"if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"},{"line_number":35,"context_line":"    FSID\u003d$(uuidgen)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"f9faede5_c10481a7","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":61},"in_reply_to":"05e1e1f9_b25b029b","updated":"2024-02-01 15:26:19.000000000","message":"Acknowledged","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9bef2dbd917bc84b3f068fec76cdb779a343d24","unresolved":true,"context_lines":[{"line_number":335,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT --ingress \\"},{"line_number":336,"context_line":"            --ingress-mode haproxy-protocol --virtual_ip $HOST_IP"},{"line_number":337,"context_line":"    else"},{"line_number":338,"context_line":"        echo \"[CEPHADM] Client restrictions will not work. To mount \\"},{"line_number":339,"context_line":"        manila shares, access must be provided to 0.0.0.0/0\""},{"line_number":340,"context_line":"        $SUDO \"$CEPHADM\" shell --fsid $FSID --config $CEPH_CONFIG \\"},{"line_number":341,"context_line":"            --keyring $CEPH_KEYRING -- ceph nfs cluster create \\"},{"line_number":342,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"55a69710_2fa316f9","line":339,"range":{"start_line":338,"start_character":0,"end_line":339,"end_character":60},"updated":"2024-01-20 01:38:19.000000000","message":"client restriction _will_ work when:\n\n- there\u0027s no ingress, or\n- ingress is deployed with \"haproxy_protocol\" as the ingress mode\n \n\nMaybe you mean to say that ingress service won\u0027t be deployed in this case so that we can preserve the ability to apply client restrictions... which would be the right thing to do","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"699a4a92d19a01105cfe42aff9a5af682e2be3af","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT --ingress \\"},{"line_number":336,"context_line":"            --ingress-mode haproxy-protocol --virtual_ip $HOST_IP"},{"line_number":337,"context_line":"    else"},{"line_number":338,"context_line":"        echo \"[CEPHADM] Client restrictions will not work. To mount \\"},{"line_number":339,"context_line":"        manila shares, access must be provided to 0.0.0.0/0\""},{"line_number":340,"context_line":"        $SUDO \"$CEPHADM\" shell --fsid $FSID --config $CEPH_CONFIG \\"},{"line_number":341,"context_line":"            --keyring $CEPH_KEYRING -- ceph nfs cluster create \\"},{"line_number":342,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"02098496_eb9b4869","line":339,"range":{"start_line":338,"start_character":0,"end_line":339,"end_character":60},"in_reply_to":"55a69710_2fa316f9","updated":"2024-02-01 15:26:19.000000000","message":"Acknowledged","commit_id":"7a30f23d7ff73b46147457b797b0826efdd4b770"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"68bb2b0218d7bf7d400d000b77f46c611123d4d7","unresolved":true,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    echo $ceph_version_str"},{"line_number":324,"context_line":"}"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"# Install ceph: add NFS"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"f435c1c5_86cb53b3","line":323,"updated":"2024-01-31 22:56:28.000000000","message":"https://zuul.opendev.org/t/openstack/build/3d4e8ce1a58342b7802cf86d79e70776/log/controller/logs/devstacklog.txt#13136-13153\n\nthis is failing silently\n\nYou need \"sudo\" to run podman, or to use rootless container, install additional packages (uidmap, slirp4netns). I\u0027d just set sudo and try","commit_id":"ae3c4cb32bc86528ff93cad6b33bab734d548067"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"699a4a92d19a01105cfe42aff9a5af682e2be3af","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    echo $ceph_version_str"},{"line_number":324,"context_line":"}"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"# Install ceph: add NFS"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"14d711c3_2587b436","line":323,"in_reply_to":"f435c1c5_86cb53b3","updated":"2024-02-01 15:26:19.000000000","message":"Acknowledged","commit_id":"ae3c4cb32bc86528ff93cad6b33bab734d548067"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"57f1a3df9623997804ad42775127d63abe27c05b","unresolved":true,"context_lines":[{"line_number":318,"context_line":"function _get_ceph_version {"},{"line_number":319,"context_line":"    local ceph_version_str"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    sudo podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    echo $ceph_version_str"},{"line_number":324,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"2001a220_cce2d612","line":321,"updated":"2024-02-01 15:53:57.000000000","message":"Doesn\u0027t this need to assign to ceph_version_str?","commit_id":"b3264a222b76de0380828dd23874ba48702d909f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"aac80ceaa237fcceb5417f5eebd6d4697248ba67","unresolved":false,"context_lines":[{"line_number":318,"context_line":"function _get_ceph_version {"},{"line_number":319,"context_line":"    local ceph_version_str"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    sudo podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    echo $ceph_version_str"},{"line_number":324,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"585fa32c_c7832b46","line":321,"in_reply_to":"2001a220_cce2d612","updated":"2024-02-01 21:05:37.000000000","message":"right you are, thanks for catching that Eric","commit_id":"b3264a222b76de0380828dd23874ba48702d909f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d50ab7549a48ad030f9f3dddce24748c11b0b68","unresolved":false,"context_lines":[{"line_number":318,"context_line":"function _get_ceph_version {"},{"line_number":319,"context_line":"    local ceph_version_str"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    sudo podman run --rm --entrypoint ceph $CONTAINER_IMAGE --version | awk \u0027{ print $3 }\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    echo $ceph_version_str"},{"line_number":324,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1e7a2868_a7baec88","line":321,"in_reply_to":"585fa32c_c7832b46","updated":"2024-02-01 21:45:40.000000000","message":"it works the same way without assigning.. :)\nbut explicit is better than implicit.","commit_id":"b3264a222b76de0380828dd23874ba48702d909f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7484c6e36ec46378f6249dc6fda5139336c80582","unresolved":true,"context_lines":[{"line_number":330,"context_line":"    ceph_version\u003d$(_get_ceph_version)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    echo \"[CEPHADM] Deploy nfs.$FSNAME backend\""},{"line_number":333,"context_line":"    if [\"$ceph_version\" -gt \"18.0\"]; then"},{"line_number":334,"context_line":"        $SUDO \"$CEPHADM\" shell --fsid $FSID --config $CEPH_CONFIG \\"},{"line_number":335,"context_line":"            --keyring $CEPH_KEYRING -- ceph nfs cluster create \\"},{"line_number":336,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT --ingress \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"6e300ed4_03a491c8","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":41},"updated":"2024-02-01 23:40:10.000000000","message":"https://zuul.opendev.org/t/openstack/build/2dab659a894c49e58f79db19568bab4e/log/controller/logs/devstacklog.txt#13158-13160\n\n\nBash can\u0027t perform floating point comparisons like this.. do we just care about this being greater than reef?\n\n```\n  if [ \"${ceph_version%%\\.*}\" -ge 18 ]; then\n\n```\n\nshould do the trick","commit_id":"034d81b4498c6a88e79e824fc123068c73664c68"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c1f66bf28347df60f71c198cdd37e20af665e89d","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    ceph_version\u003d$(_get_ceph_version)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    echo \"[CEPHADM] Deploy nfs.$FSNAME backend\""},{"line_number":333,"context_line":"    if [\"$ceph_version\" -gt \"18.0\"]; then"},{"line_number":334,"context_line":"        $SUDO \"$CEPHADM\" shell --fsid $FSID --config $CEPH_CONFIG \\"},{"line_number":335,"context_line":"            --keyring $CEPH_KEYRING -- ceph nfs cluster create \\"},{"line_number":336,"context_line":"            \"$FSNAME\" \"$HOSTNAME\" --port $NFS_PORT --ingress \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9abf0203_1329160b","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":41},"in_reply_to":"6e300ed4_03a491c8","updated":"2024-02-06 17:50:28.000000000","message":"Done","commit_id":"034d81b4498c6a88e79e824fc123068c73664c68"}]}