)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0beb07e94a85d349a793303289194d4697070a69","unresolved":true,"context_lines":[{"line_number":14,"context_line":"of scope for the deployment script."},{"line_number":15,"context_line":"This work aims to support [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/948768"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1a66c244b9be33b6df63e6504500c77d59a1b9d"},{"line_number":20,"context_line":"Signed-off-by: Francesco Pantano \u003cfpantano@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ccfddfe_8d240a8e","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":72},"updated":"2025-05-05 22:29:51.000000000","message":"This is the same change?","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"87b6eda4edda57ab72b0e0b1be48f0bb0a62b86d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"of scope for the deployment script."},{"line_number":15,"context_line":"This work aims to support [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/948768"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1a66c244b9be33b6df63e6504500c77d59a1b9d"},{"line_number":20,"context_line":"Signed-off-by: Francesco Pantano \u003cfpantano@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d6cf9d48_86e2f51e","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":72},"in_reply_to":"1ccfddfe_8d240a8e","updated":"2025-05-06 07:48:21.000000000","message":"sorry, fixing it 😄","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1b9dd8d33a8545e6603bd4326ac5e87fcaa6650","unresolved":false,"context_lines":[{"line_number":14,"context_line":"of scope for the deployment script."},{"line_number":15,"context_line":"This work aims to support [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/948768"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1a66c244b9be33b6df63e6504500c77d59a1b9d"},{"line_number":20,"context_line":"Signed-off-by: Francesco Pantano \u003cfpantano@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5dce8f48_aaf08fac","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":72},"in_reply_to":"d6cf9d48_86e2f51e","updated":"2025-05-06 21:14:25.000000000","message":"Done","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbece4bcd4c5580e50e8d292e127cef4442a956f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad62e656_bf5ad097","updated":"2025-06-06 09:45:17.000000000","message":"Although i haven\u0027t tested this change, it looks pretty straightforward and the step is also documented in my replication doc[1] (which at least I\u0027ve tested) so LGTM.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/950859/5/doc/source/admin/replication-in-openstack.rst#46","commit_id":"1b3afd66c4452751c206749dbd61981221496961"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1b9dd8d33a8545e6603bd4326ac5e87fcaa6650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"538c965c_690ad592","updated":"2025-05-06 21:14:25.000000000","message":"LGTM; thanks Failures are unrelated.. i\u0027m fixing up the manila jobs [1], but am unsure if the rest are broken due to regressions\n\n[1] https://review.opendev.org/c/openstack/manila/+/948491","commit_id":"1b3afd66c4452751c206749dbd61981221496961"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"699a5c50e530424a5832b62ef6ef5cbf74f7cbfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46211489_4344b50c","updated":"2025-05-15 08:06:46.000000000","message":"Thanks Francesco\nLGTM","commit_id":"1b3afd66c4452751c206749dbd61981221496961"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3cac6337e6b8bcccac6b853526aa5177e3403cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ac77b0d_da3d5251","updated":"2025-05-09 08:24:49.000000000","message":"recheck","commit_id":"1b3afd66c4452751c206749dbd61981221496961"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8fa4fe7d446e6f9846904658587d2b1f04bec105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7abbeb28_baad1fc9","updated":"2025-05-15 08:01:46.000000000","message":"recheck","commit_id":"1b3afd66c4452751c206749dbd61981221496961"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4f29f5dc8c72d386e8923bd1e9ab6461acbd7d52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c84cfcc0_2f9a9fc2","updated":"2025-06-06 07:23:19.000000000","message":"recheck","commit_id":"1b3afd66c4452751c206749dbd61981221496961"}],"devstack/lib/cephadm":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0beb07e94a85d349a793303289194d4697070a69","unresolved":true,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    [ \"$ENABLE_CEPH_RGW\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rgw\u0027)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    [ \"$ENABLE_CEPH_RBD_MIRROR\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rbdmirror\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    enable_services"},{"line_number":764,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c71bff06_a973e210","line":761,"range":{"start_line":761,"start_character":0,"end_line":761,"end_character":70},"updated":"2025-05-05 22:29:51.000000000","message":"For discoverability, i\u0027d add this option and its default to the `settings` file, and to `override-defaults` if necessary","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b349511d2c97db79dcb1a26ff97b5149e782e88b","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    [ \"$ENABLE_CEPH_RGW\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rgw\u0027)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    [ \"$ENABLE_CEPH_RBD_MIRROR\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rbdmirror\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    enable_services"},{"line_number":764,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"44a2cb2d_3fc60716","line":761,"range":{"start_line":761,"start_character":0,"end_line":761,"end_character":70},"in_reply_to":"0ff9f3e3_9fc335d1","updated":"2025-05-09 08:25:03.000000000","message":"Done","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"87b6eda4edda57ab72b0e0b1be48f0bb0a62b86d","unresolved":true,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    [ \"$ENABLE_CEPH_RGW\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rgw\u0027)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    [ \"$ENABLE_CEPH_RBD_MIRROR\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rbdmirror\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    enable_services"},{"line_number":764,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f151078f_da242c6f","line":761,"range":{"start_line":761,"start_character":0,"end_line":761,"end_character":70},"in_reply_to":"c71bff06_a973e210","updated":"2025-05-06 07:48:21.000000000","message":"makes sense, let me add it!","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"304877cf9483e842e21548b9f7f81b7de3fe520f","unresolved":true,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    [ \"$ENABLE_CEPH_RGW\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rgw\u0027)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    [ \"$ENABLE_CEPH_RBD_MIRROR\" \u003d\u003d \"True\" ] \u0026\u0026 SERVICES+\u003d(\u0027rbdmirror\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    enable_services"},{"line_number":764,"context_line":"    if [[ \"$REMOTE_CEPH\" \u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"0ff9f3e3_9fc335d1","line":761,"range":{"start_line":761,"start_character":0,"end_line":761,"end_character":70},"in_reply_to":"f151078f_da242c6f","updated":"2025-05-06 07:56:00.000000000","message":"Added in override-defaults, but not in settings, as I don\u0027t see most of the variables there. Is that ok or we simply missed to define all the available settings in the `settings` file?","commit_id":"d58c5ca42f5bccae35726d06fe4fbe7eb9437b8d"}]}