)]}'
{"id":"openstack%2Fdevstack-plugin-ceph~956419","triplet_id":"openstack%2Fdevstack-plugin-ceph~master~I193c2c2e713388a0e05c1238b7414f600851f9f1","project":"openstack/devstack-plugin-ceph","branch":"master","attention_set":{"38153":{"account":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"last_update":"2025-08-02 03:50:50.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I193c2c2e713388a0e05c1238b7414f600851f9f1","subject":"Fix applying Rados Gateway config","status":"NEW","created":"2025-08-02 02:08:35.000000000","updated":"2025-11-03 10:05:45.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c1c4e31227fab9a43796b994c83eacf362b922d","_number":956419,"virtual_id_number":956419,"owner":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-08-02 18:37:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-11-03 10:05:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-02 03:50:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-03 10:05:45.000000000","updated_by":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"reviewer":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"state":"REVIEWER"}],"messages":[{"id":"8d0a7e195974c395fcd91f8f62ed6d4eb70c4e3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"date":"2025-08-02 02:08:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf52c9743ca8acc05105820ed8df34ff441f7ca7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-02 03:50:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/3ca47f44d1ee4c3891dfdb4dc921e1d5\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/a811a7cc82d8426fb781b9d5fb9c8d63 : SUCCESS in 1h 11m 34s\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/4f1de98d39a143e5963ebee58bd32317 : RETRY_LIMIT in 3m 41s\n- devstack-plugin-ceph-multinode-cephfs-nfs-cephadm https://zuul.opendev.org/t/openstack/build/0c10f85a486a43a28fde497b6fa7c210 : SUCCESS in 1h 21m 40s (non-voting)\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/373468bb761440799ea41149ebb2d9dc : SUCCESS in 57m 04s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs-standalone https://zuul.opendev.org/t/openstack/build/ee1474cff36d4f2891fcbb9bfb5d24eb : SUCCESS in 1h 11m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c067c5072e80403cae962e690469d378 : SUCCESS in 3m 19s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/8b487084657d49ba827078c2e73020eb : SUCCESS in 2m 05s","accounts_in_message":[],"_revision_number":1},{"id":"50194776422b766a0c90b9619f3978b4c4a57a4c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"date":"2025-08-02 16:07:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"8d89e688eea4d84442308c019c1cd8b8e7731e22","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-02 18:37:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d038ddaac888431e82ff42a356f56900\n\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/72048eaecebb4d678ff65dae123b9dc9 : SUCCESS in 1h 33m 39s\n- devstack-plugin-ceph-multinode-tempest-py3 https://zuul.opendev.org/t/openstack/build/388e0c65255244a1874dde7fef2a6989 : SUCCESS in 2h 25m 15s\n- devstack-plugin-ceph-multinode-cephfs-nfs-cephadm https://zuul.opendev.org/t/openstack/build/f369aa10198d4f848b86a0a7a4dc1782 : SUCCESS in 1h 12m 34s (non-voting)\n- devstack-plugin-ceph-cephfs-native https://zuul.opendev.org/t/openstack/build/580cfbde2ba043219c6cf177b20249ec : SUCCESS in 57m 37s (non-voting)\n- devstack-plugin-ceph-cephfs-nfs-standalone https://zuul.opendev.org/t/openstack/build/61ec9c19203b4e20b81d4ab423134553 : SUCCESS in 1h 20m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f96fb9dfb3c74a52b02160e0d33dae42 : SUCCESS in 5m 20s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/ae46e0b9fa4840848371c62de8c0d122 : SUCCESS in 3m 38s","accounts_in_message":[],"_revision_number":2},{"id":"7c1c4e31227fab9a43796b994c83eacf362b922d","author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"date":"2025-11-03 10:05:45.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"45774745325328f1d2f74423b16c03ac6aba425d","revisions":{"a8a39460602389f06ac527c9bed292921ce9e8ce":{"kind":"REWORK","_number":1,"created":"2025-08-02 02:08:35.000000000","uploader":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"ref":"refs/changes/19/956419/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/19/956419/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/1"}}},"commit":{"parents":[{"commit":"efec5b63e51bd60b628cf20c0a1d01041f3a98a4","subject":"Fix swift_endpoint","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/efec5b63e51bd60b628cf20c0a1d01041f3a98a4"}]}],"author":{"name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","date":"2025-08-02 00:19:03.000000000","tz":120},"committer":{"name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","date":"2025-08-02 01:37:05.000000000","tz":120},"subject":"Fix applying Rados Gateway config","message":"Fix applying Rados Gateway config\n\nThe Rados Gateway config was not applied properly. Although one could\nobserve the rgw_* config values with sudo ceph config dump, they did not\nhave any effect. Swift operations that require authorization would fail\nwith HTTP status 401. One can confirm with\nceph config set client.rgw debug_rgw 20/20\nin /var/log/ceph/*/ceph-client.rgw.default.*.*.log\nthat the DefaultStrategy is trying in order the TempURLEngine, the\nSignedTokenEngine and finally the SwiftAnonymousEngine.\nHowever the Keystone TokenEngine should also be tried, because we have\nconfigured `rgw_keystone_url`.\nSee https://github.com/ceph/ceph/blob/407e9b7521bda0b9b3a25589599ff76263bb9231/src/rgw/rgw_swift_auth.h#L290-L311\nThis means that our rgw_keystone_url configuration does not apply.\n\nThis change properly applies the configuration such that authentication\nwith the KeystoneTokenEngine succeeds. The configuration is not applied\nin the rgw function anymore. Instead it is now added in bootstrap_config\nguarded by if [[ \"$ENABLE_CEPH_RGW\" \u003d \"True\" ]]. There were various\nineffective changes:\n\nThe variables passed to and used by set_config_key were not wrapped in\ndouble quotes. For example, rgw_keystone_accepted_roles was assigned the\nvalue \"member,\" instead of \"member, _member_, Member, admin\".\nAdditionally replacing \"global\" in set_config_key \"global\" [..] with\n\"client.rgw\" or \"rgw\" does not work.\n\nAdding the rgw configuration to the bootstrap_config under the [rgw]\nsection instead of the [client.rgw] section does not work.\n\nChange-Id: I193c2c2e713388a0e05c1238b7414f600851f9f1\nSigned-off-by: Tobias Haslop \u003ctobiashaslop+ubuntuone@hotmail.de\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/a8a39460602389f06ac527c9bed292921ce9e8ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/a8a39460602389f06ac527c9bed292921ce9e8ce"}]},"branch":"refs/heads/master"},"45774745325328f1d2f74423b16c03ac6aba425d":{"kind":"REWORK","_number":2,"created":"2025-08-02 16:07:54.000000000","uploader":{"_account_id":38153,"name":"Tobias Haslop","display_name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","username":"tobias-haslop"},"ref":"refs/changes/19/956419/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-plugin-ceph","ref":"refs/changes/19/956419/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-plugin-ceph refs/changes/19/956419/2"}}},"commit":{"parents":[{"commit":"7e10d611dbc7f56c5ef685bf1324370a0e6d82f3","subject":"Fix swift_endpoint","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/7e10d611dbc7f56c5ef685bf1324370a0e6d82f3"}]}],"author":{"name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","date":"2025-08-02 00:19:03.000000000","tz":120},"committer":{"name":"Tobias Haslop","email":"tobiashaslop+ubuntuone@hotmail.de","date":"2025-08-02 15:06:21.000000000","tz":120},"subject":"Fix applying Rados Gateway config","message":"Fix applying Rados Gateway config\n\nThe Rados Gateway config was not applied properly. Although one could\nobserve the rgw_* config values with sudo ceph config dump, they did not\nhave any effect. Swift operations that require authorization would fail\nwith HTTP status 401. One can confirm with\nceph config set client.rgw debug_rgw 20/20\nin /var/log/ceph/*/ceph-client.rgw.default.*.*.log\nthat the DefaultStrategy is trying in order the TempURLEngine, the\nSignedTokenEngine and finally the SwiftAnonymousEngine.\nHowever the Keystone TokenEngine should also be tried, because we have\nconfigured `rgw_keystone_url`.\nSee https://github.com/ceph/ceph/blob/407e9b7521bda0b9b3a25589599ff76263bb9231/src/rgw/rgw_swift_auth.h#L290-L311\nThis means that our rgw_keystone_url configuration does not apply.\n\nThis change properly applies the configuration such that authentication\nwith the KeystoneTokenEngine succeeds. The configuration is not applied\nin the rgw function anymore. Instead it is now added in bootstrap_config\nguarded by if [[ \"$ENABLE_CEPH_RGW\" \u003d \"True\" ]]. There were various\nineffective changes:\n\nThe variables passed to and used by set_config_key were not wrapped in\ndouble quotes. For example, rgw_keystone_accepted_roles was assigned the\nvalue \"member,\" instead of \"member, _member_, Member, admin\".\nAdditionally replacing \"global\" in set_config_key \"global\" [..] with\n\"client.rgw\" or \"rgw\" does not work.\n\nAdding the rgw configuration to the bootstrap_config under the [rgw]\nsection instead of the [client.rgw] section does not work.\n\nChange-Id: I193c2c2e713388a0e05c1238b7414f600851f9f1\nSigned-off-by: Tobias Haslop \u003ctobiashaslop+ubuntuone@hotmail.de\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/45774745325328f1d2f74423b16c03ac6aba425d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-plugin-ceph/commit/45774745325328f1d2f74423b16c03ac6aba425d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}