)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b97bf786209a4a3daf57161011f01829e81c9ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"42835208_b1f73f11","updated":"2026-05-19 15:25:12.000000000","message":"Looks good, it does configures ec pool correctly for glance.","commit_id":"45bb04f4457fc85fe9ddffc3d5f1f4554f308641"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d9d5264d7486c2ce3bc9cdf32567b5033ef4fd71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b326eb66_91c4852b","updated":"2026-05-19 17:57:23.000000000","message":"Looks like it will need additional changes, I am working on local deployment. Will comment out as soon as I have something.","commit_id":"45bb04f4457fc85fe9ddffc3d5f1f4554f308641"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ae9e38c062a7b29f64c8a658073b701c93742934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a178f841_aa4ac2b0","updated":"2026-08-19 18:52:58.000000000","message":"I was wondering if we needed to wait on cinder folks to get this in.. but, cinder\u0027s pools (volumes, backups) go into POOLS_REPLICATED and are created replicated with the rbd app, exactly as before the refactor. \n\nEC is opt-in (*_EC_ENABLE default False) and only touches Glance/Manila so i\u0027m comfortable getting this in as a sole reviewer. \n\nReady the trout if you\u0027d like to revert/change parts of it.. i\u0027d rather save your bandwidth at this busy feature-freeze time","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1a0ca3538a36289f392bfd78b5f4638753cc2786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5aeb2ca3_0fd9bfad","updated":"2026-08-19 10:50:53.000000000","message":"Testing it here https://review.opendev.org/c/openstack/glance_store/+/988421","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4677b5454ecfa6eb2804368a8937886a14dcc9cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"57d12d45_f9a075f0","updated":"2026-08-19 13:05:33.000000000","message":"Tests for glance look good, I assume we can move forward with this","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c5ac91da6118ab9fb9f8828afd8b6c7bbb6917e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2cd4d1f9_a131bb19","updated":"2026-08-19 14:47:20.000000000","message":"Working fine, good to go!!","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"1fca8e2ad0b6561468f04b58331afb9a6dc872bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d70b72d_ea2a54ec","updated":"2026-08-19 22:16:53.000000000","message":"recheck","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c8c1e301ba7319c76ffd2bc5b1c15e5f07f77f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a944f639_c86be891","updated":"2026-08-20 10:41:57.000000000","message":"recheck","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49e41a91b2a953f92ff58b9401036af643a14846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"011fc6fc_22e20f36","updated":"2026-08-19 19:19:52.000000000","message":"recheck\n\nfailed to upload glance image","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bc9c3ff0ba77d4fcb0077e0130a3975b62bd2fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3061564f_73583922","updated":"2026-08-19 19:20:06.000000000","message":"recheck\n\nparent re-enqueued","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a7fa766f97e2a34edd829b5dcd6b990457008b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04ab20aa_4758d980","updated":"2026-08-20 05:37:20.000000000","message":"recheck failing to connect to the cluster, not related to this change.","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"59f02f56c159b2793a95b2c717b9635ac1861e8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fe36391f_cf713349","updated":"2026-08-19 10:46:44.000000000","message":"thanks Abhishek for rebasing! let\u0027s see how tests go and we can move forward with this I guess!","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"}],"devstack/lib/cephadm":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1783f3555388ee4a30971496c8fc6cd77bdc8fd1","unresolved":true,"context_lines":[{"line_number":74,"context_line":"# we\u0027ll deploy a \"standalone\" NFS Ganesha instead, not managed by cephadm."},{"line_number":75,"context_line":"CEPHADM_DEPLOY_NFS\u003d${CEPHADM_DEPLOY_NFS:-True}"},{"line_number":76,"context_line":"# Clustered NFS Options"},{"line_number":77,"context_line":"FSNAME\u003d${FSNAME:-\u0027cephfs\u0027}"},{"line_number":78,"context_line":"NFS_PORT\u003d2049"},{"line_number":79,"context_line":"CEPHFS_CLIENT\u003d0"},{"line_number":80,"context_line":"CEPHFS_CLIENT_NAME\u003d\"client.$MANILA_CEPH_USER\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"20026b2c_df7aca6b","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":26},"updated":"2026-04-20 04:31:33.000000000","message":"should move this above to use as default for MANILA_EC_DATA_POOL","commit_id":"18f019dc37405452ae11c7371ea23f80251b7657"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e0b4de132667ea0a2439610cd432e8a79950263a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# we\u0027ll deploy a \"standalone\" NFS Ganesha instead, not managed by cephadm."},{"line_number":75,"context_line":"CEPHADM_DEPLOY_NFS\u003d${CEPHADM_DEPLOY_NFS:-True}"},{"line_number":76,"context_line":"# Clustered NFS Options"},{"line_number":77,"context_line":"FSNAME\u003d${FSNAME:-\u0027cephfs\u0027}"},{"line_number":78,"context_line":"NFS_PORT\u003d2049"},{"line_number":79,"context_line":"CEPHFS_CLIENT\u003d0"},{"line_number":80,"context_line":"CEPHFS_CLIENT_NAME\u003d\"client.$MANILA_CEPH_USER\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"b068d987_42dec63c","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":26},"in_reply_to":"20026b2c_df7aca6b","updated":"2026-04-20 07:39:44.000000000","message":"yes, makes sense.","commit_id":"18f019dc37405452ae11c7371ea23f80251b7657"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1783f3555388ee4a30971496c8fc6cd77bdc8fd1","unresolved":true,"context_lines":[{"line_number":335,"context_line":"    local osd_caps"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    # In case of EC mode we always need at least a replicated pool to store"},{"line_number":338,"context_line":"    # metadata, so this condition is still sufficient to check which osd_capps"},{"line_number":339,"context_line":"    # are needed"},{"line_number":340,"context_line":"    if [ \"${#POOLS_REPLICATED[@]}\" -eq 0 ]; then"},{"line_number":341,"context_line":"        osd_caps\u003d\"allow *\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"78e34033_843b1931","line":338,"range":{"start_line":338,"start_character":69,"end_line":338,"end_character":78},"updated":"2026-04-20 04:31:33.000000000","message":"nit: typo","commit_id":"18f019dc37405452ae11c7371ea23f80251b7657"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e0b4de132667ea0a2439610cd432e8a79950263a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    local osd_caps"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    # In case of EC mode we always need at least a replicated pool to store"},{"line_number":338,"context_line":"    # metadata, so this condition is still sufficient to check which osd_capps"},{"line_number":339,"context_line":"    # are needed"},{"line_number":340,"context_line":"    if [ \"${#POOLS_REPLICATED[@]}\" -eq 0 ]; then"},{"line_number":341,"context_line":"        osd_caps\u003d\"allow *\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d86554a1_1d7d333c","line":338,"range":{"start_line":338,"start_character":69,"end_line":338,"end_character":78},"in_reply_to":"78e34033_843b1931","updated":"2026-04-20 07:39:44.000000000","message":"Done","commit_id":"18f019dc37405452ae11c7371ea23f80251b7657"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0d498d600d5447516d99e4b254e931ab4d342db1","unresolved":true,"context_lines":[{"line_number":801,"context_line":"        add_pools POOLS_EC \"erasure\""},{"line_number":802,"context_line":"        create_keys"},{"line_number":803,"context_line":"    fi"},{"line_number":804,"context_line":"    enable_services"},{"line_number":805,"context_line":"    client_config"},{"line_number":806,"context_line":"    import_libvirt_secret_ceph"},{"line_number":807,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"946616ce_71896c48","line":804,"updated":"2026-04-17 11:52:07.000000000","message":"note: make sure pools exist before enabling services. This allows to set existing pools to service that need them to exist before the deployment.","commit_id":"18f019dc37405452ae11c7371ea23f80251b7657"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"620fbba4b7c52a4ade6fd3288222a97641103073","unresolved":true,"context_lines":[{"line_number":958,"context_line":"        SERVICES+\u003d(\u0027cephfs\u0027)"},{"line_number":959,"context_line":"        KEYS+\u003d(\"client.$MANILA_CEPH_USER\")"},{"line_number":960,"context_line":"        if [[ \"$MANILA_EC_ENABLE\" \u003d\u003d \"True\" ]]; then"},{"line_number":961,"context_line":"            POOLS_EC+\u003d($MANILA_EC_DATA_POOL)"},{"line_number":962,"context_line":"        fi"},{"line_number":963,"context_line":"    fi"},{"line_number":964,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"806b4432_cced3772","line":961,"updated":"2026-08-19 18:32:29.000000000","message":"Let\u0027s follow up on this: this pool ends up in add_pools \"erasure\", which sets the `rbd` application on it (way up in L433), but it\u0027s a cephfs data pool. Should be marked as `cephfs` instead - I don\u0027t know the impact of this, but seems correct enough to pursue. I\u0027ll fix this in a separate change.","commit_id":"f5ca9050baf795546e3001a5001517d8c5130904"}]}