)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d31a20d285386933936b85110e66f73a96ed22fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c32eaeb7_0c305c24","updated":"2026-10-20 13:23:26.000000000","message":"that makes sense to me","commit_id":"c6e4f14b62cafa082d9c5801c9eb1dd5a439ddfc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"e8fbb7f0885dfbfbecc914286498d8819322ba86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1071f025_0bad21b4","updated":"2026-10-23 07:23:07.000000000","message":"Thank you!","commit_id":"266a5cfa885dbc6286efc7858db4a611e2fba9fc"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"2e308f548c86c1f9938034df98df7e9a3d499980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"55a8cbc8_f7414166","updated":"2026-10-22 11:33:38.000000000","message":"The job in Nova finished correctly after the latest change. Sean, Takashi, are you ok with this patch?","commit_id":"266a5cfa885dbc6286efc7858db4a611e2fba9fc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"342211e8f6a595014f821feb273db09a2e7c968c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"95bce9a4_f0f05eef","updated":"2026-10-22 13:35:04.000000000","message":"yep looks good to me ill go review the nova change now","commit_id":"266a5cfa885dbc6286efc7858db4a611e2fba9fc"}],"devstack/lib/jaeger":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6249002d7675aa4e75e69929c7f6ac0ba0179b81","unresolved":true,"context_lines":[{"line_number":55,"context_line":"# pulled in by the services themselves, so without this any service with"},{"line_number":56,"context_line":"# [oslo_middleware_tracing] enabled\u003dtrue fails to start."},{"line_number":57,"context_line":"function install_tracing_exporter {"},{"line_number":58,"context_line":"    pip_install \"oslo.middleware[$(_oslo_tracing_exporter_extra)]\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"function init_jaeger {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"40d17241_435652ad","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":32},"updated":"2026-10-21 15:08:30.000000000","message":"This always install oslo.middleware from pypi but we likely need the logic to install it from source.\n\nCheck the existing plugin and usage of `if use_library_from_git` there.","commit_id":"799209f81584f833867e29b1405aa1307306f538"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"7fcaac918b826ec4a964e76067f521e6410bef9a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# pulled in by the services themselves, so without this any service with"},{"line_number":56,"context_line":"# [oslo_middleware_tracing] enabled\u003dtrue fails to start."},{"line_number":57,"context_line":"function install_tracing_exporter {"},{"line_number":58,"context_line":"    pip_install \"oslo.middleware[$(_oslo_tracing_exporter_extra)]\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"function init_jaeger {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"05990bba_23d0fb6b","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":32},"in_reply_to":"3b883af6_f18c0eb6","updated":"2026-10-22 07:37:34.000000000","message":"Thank you very much!","commit_id":"799209f81584f833867e29b1405aa1307306f538"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c51250f6f69da2973d67cd9d5efec7a6930ac79","unresolved":true,"context_lines":[{"line_number":55,"context_line":"# pulled in by the services themselves, so without this any service with"},{"line_number":56,"context_line":"# [oslo_middleware_tracing] enabled\u003dtrue fails to start."},{"line_number":57,"context_line":"function install_tracing_exporter {"},{"line_number":58,"context_line":"    pip_install \"oslo.middleware[$(_oslo_tracing_exporter_extra)]\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"function init_jaeger {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9c3a99bd_166499ec","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":32},"in_reply_to":"40d17241_435652ad","updated":"2026-10-21 16:31:08.000000000","message":"so i knew this handed passing uc for you automaticlly and installing into the venv or system wide as requried\nhttps://github.com/openstack/devstack/blob/75939cdc664d956ecc7b2cae4a9fd5877fdcbb4f/inc/python#L145-L220\n\nbut i tought i also did the libs_form_git check as well but i guess not.\n\nthat woudl be needed if we want depend on to work which is perhaps reasonable to test future changes to oslo middleware related to this.\n\ndevstack has two helpser for this\nhttps://github.com/openstack/devstack/blob/75939cdc664d956ecc7b2cae4a9fd5877fdcbb4f/inc/python#L263-L291\n\nuse_library_from_git and lib_installed_from_git\n\nwe should be using the former `use_library_from_git` as you noted\nand we should proably call setup_dev_lib instead of implemnting that again here\n\nhttps://github.com/openstack/devstack/blob/75939cdc664d956ecc7b2cae4a9fd5877fdcbb4f/inc/python#L303-L321\n\nhere is an example for glance\n\nhttps://opendev.org/openstack/devstack/src/branch/master/lib/glance#L561-L571\n\nthat you can adapt.","commit_id":"799209f81584f833867e29b1405aa1307306f538"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"02ff2169416caa6d3bdb68539eb8771d7e7f7637","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# pulled in by the services themselves, so without this any service with"},{"line_number":56,"context_line":"# [oslo_middleware_tracing] enabled\u003dtrue fails to start."},{"line_number":57,"context_line":"function install_tracing_exporter {"},{"line_number":58,"context_line":"    pip_install \"oslo.middleware[$(_oslo_tracing_exporter_extra)]\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"function init_jaeger {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3b883af6_f18c0eb6","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":32},"in_reply_to":"9c3a99bd_166499ec","updated":"2026-10-22 07:34:05.000000000","message":"Done","commit_id":"799209f81584f833867e29b1405aa1307306f538"}],"devstack/plugin.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"321c93194f157f8a6493d5a66f894477014d8e5f","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        echo_summary \"Give jaeger time to come up\""},{"line_number":33,"context_line":"        wait_for_data"},{"line_number":34,"context_line":"        check_data_jaeger"},{"line_number":35,"context_line":"        # Enable tracing on services BEFORE they start (satisfies R3: no restart)."},{"line_number":36,"context_line":"        # No-op unless OSLO_TRACING_SERVICES is set."},{"line_number":37,"context_line":"        echo_summary \"Configuring oslo.middleware tracing for services\""},{"line_number":38,"context_line":"        configure_oslo_tracing"}],"source_content_type":"text/x-sh","patch_set":3,"id":"d0986e67_d85421c8","line":35,"range":{"start_line":35,"start_character":56,"end_line":35,"end_character":81},"updated":"2026-10-21 14:37:37.000000000","message":"this feels like the llm keeping notes by the way.\n\nyou shoudl proably drop this before meging.\n\notherwise this looks fien.","commit_id":"65515a4d8b2ac4a66c9de1fe3702ae5d2bba07ae"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"aa35737d27fa3b8d1c815908ded8ffdab3883a20","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        echo_summary \"Give jaeger time to come up\""},{"line_number":33,"context_line":"        wait_for_data"},{"line_number":34,"context_line":"        check_data_jaeger"},{"line_number":35,"context_line":"        # Enable tracing on services BEFORE they start (satisfies R3: no restart)."},{"line_number":36,"context_line":"        # No-op unless OSLO_TRACING_SERVICES is set."},{"line_number":37,"context_line":"        echo_summary \"Configuring oslo.middleware tracing for services\""},{"line_number":38,"context_line":"        configure_oslo_tracing"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dfcd1037_82cfd551","line":35,"range":{"start_line":35,"start_character":56,"end_line":35,"end_character":81},"in_reply_to":"d0986e67_d85421c8","updated":"2026-10-21 14:52:15.000000000","message":"Done","commit_id":"65515a4d8b2ac4a66c9de1fe3702ae5d2bba07ae"}]}