)]}'
{"devstack/override-defaults":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8681a10258aae954209a0a7c218ac0158bb1b7c3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a95cdbc_286b19b8","line":5,"updated":"2016-10-10 17:29:42.000000000","message":"Does this still need to append \"nfs:nfs\" if $CINDER_ENABLED_BACKENDS was passed in with some other value?","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"0de9cc9987f10cf26ab23ee5e1c286c290287738","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a95cdbc_685441c9","line":5,"in_reply_to":"1a95cdbc_286b19b8","updated":"2016-10-10 17:35:09.000000000","message":"Yes, the idea is exactly that. The CINDER_ENABLED_BACKENDS will came with other plugins, and we want to be able to append nfs:nfs to that list. If not, only nfs:nfs will be configured.","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2cfa1f358e6364c2e07581e8d859195bdbcc794c","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa6399be_340c3794","line":5,"in_reply_to":"1a95cdbc_483dc529","updated":"2016-10-15 09:56:41.000000000","message":"So consider the case where CINDER_ENABLED_BACKENDS is set and is not null but does not yet contain the nfs backend.  \nWhen we get to https://github.com/openstack-dev/devstack/blob/master/lib/cinder#L114 we\u0027ll fail to source cinder_backends/nfs.\n\nPerhaps you can add a check whether CINDER_ENABLED_BACKENDS contains \u0027nfs:nfs\u0027 and if not add it: CINDER_ENABLED_BACKENDS+\u003d,nfs:nfs ?","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"452b979d1692275fdbc3ded07797cb565d1d46cf","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a95cdbc_68f0c1c9","line":5,"in_reply_to":"1a95cdbc_685441c9","updated":"2016-10-10 17:39:13.000000000","message":"But this code doesn\u0027t do that.  It will only change it \"nfs:nfs\" if the var was empty, otherwise it reuses the original value.","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4263ccfc1dceadcdc71d3721ea10152f2d27db91","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a95cdbc_483dc529","line":5,"in_reply_to":"1a95cdbc_68f0c1c9","updated":"2016-10-10 17:46:02.000000000","message":"Hummm, sorry, bad explanation of mine. We need CINDER_ENABLED_BACKENDS to be whatever its passed to to script. If nothing is passed, then it defaults to nfs:nfs. No need to append.\n\nThe way it is it always overrides CINDER_ENABLED_BACKENDS.","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"933fcff5a42fb3051a9f48980aece7451ea6f24d","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ $ENABLE_NFS_CINDER \u003d\u003d \"True\" ]]; then"},{"line_number":4,"context_line":"    CINDER_DRIVER\u003dnfs"},{"line_number":5,"context_line":"    CINDER_ENABLED_BACKENDS\u003d${CINDER_ENABLED_BACKENDS:-nfs:nfs}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    TEMPEST_STORAGE_PROTOCOL\u003dnfs"},{"line_number":8,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_4eb917ec","line":5,"in_reply_to":"fa6399be_340c3794","updated":"2016-11-21 20:29:16.000000000","message":"Done","commit_id":"dbe402810103d0e13d86fb09acbe4d7114b539a4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3bc106498d36a2c9b1ad66946bcb261635174aae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    # Always make sure that once the plugin is enabled, the backend will be"},{"line_number":10,"context_line":"    # properly activated."},{"line_number":11,"context_line":"    if ! echo $CINDER_ENABLED_BACKENDS | grep -q \u0027nfs:nfs\u0027; then"},{"line_number":12,"context_line":"        echo \"Adding nfs\""},{"line_number":13,"context_line":"        CINDER_ENABLED_BACKENDS+\u003d\u0027,nfs:nfs\u0027"},{"line_number":14,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a74a57a_794d1a99","line":11,"updated":"2016-11-28 16:58:32.000000000","message":"This should be tested using \u003d~ (I think) rather than calling out to grep.","commit_id":"606c0be3f8fe23916d385226c4b148065858a308"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3bc106498d36a2c9b1ad66946bcb261635174aae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    # Always make sure that once the plugin is enabled, the backend will be"},{"line_number":10,"context_line":"    # properly activated."},{"line_number":11,"context_line":"    if ! echo $CINDER_ENABLED_BACKENDS | grep -q \u0027nfs:nfs\u0027; then"},{"line_number":12,"context_line":"        echo \"Adding nfs\""},{"line_number":13,"context_line":"        CINDER_ENABLED_BACKENDS+\u003d\u0027,nfs:nfs\u0027"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"    echo $CINDER_ENABLED_BACKENDS"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a74a57a_5953fe38","line":12,"updated":"2016-11-28 16:58:32.000000000","message":"This shouldn\u0027t be needed since this is always run w/ -x.","commit_id":"606c0be3f8fe23916d385226c4b148065858a308"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"56ee3690feeeb1adfb08efa278f18043ce0f9772","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    # Always make sure that once the plugin is enabled, the backend will be"},{"line_number":10,"context_line":"    # properly activated."},{"line_number":11,"context_line":"    if [[ ! $CINDER_ENABLED_BACKENDS \u003d\u003d *nfs:nfs* ]]; then"},{"line_number":12,"context_line":"        CINDER_ENABLED_BACKENDS+\u003d\u0027,nfs:nfs\u0027"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5a74a57a_7b3a6a9a","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":58},"updated":"2016-11-28 19:09:16.000000000","message":"This is probably OK as long as we follow conventions for backends and backend names in devstack (e.g. don\u0027t use \u0027pnfs:nfs\u0027) and making the regex totally bullet-proof in\nbash is likely not worth it.","commit_id":"fade5da51ba5002a234729d37ffc329aa695bbca"}]}