)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"400ea984297a9671e31ec8021558c691180c2593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"920d7413_48ccb966","updated":"2021-11-25 14:30:26.000000000","message":"the jobs should be working again after we merge this https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/777078 .. so if this is still valid you may want to rebase ","commit_id":"7c9b02823273572c88cb0850f8293e267bf53ffa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f75d89b68228b560be91cbe2ebd8dc478239fd43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8699114f_23bb02f8","updated":"2022-03-30 13:37:00.000000000","message":"I think you should say why it\u0027s being restricted to train or earlier somewhere, either in the commit message or a comment in the code.","commit_id":"5595c4be5450bb792c4e255a6632776aff12cc39"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b4578edefb334de91be259f535bcda7533a3e403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ed0c24f_12d2be61","updated":"2022-03-22 08:47:55.000000000","message":"Ping?","commit_id":"5595c4be5450bb792c4e255a6632776aff12cc39"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f5435029bfbdff382524efc4d444f8084db2a750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfe565d5_b851f48e","updated":"2022-02-14 20:19:50.000000000","message":"lgtm, someone more familiar with the project, please confirm and we can move this forward","commit_id":"5595c4be5450bb792c4e255a6632776aff12cc39"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"79c15668396c82516e6f9d6301dcc23ace84ac68","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba1beb09_5bef9102","in_reply_to":"7490418d_093726eb","updated":"2022-04-04 17:25:33.000000000","message":"Maybe because when we started train was the oldest place where it made sense to fix this. \n\nWe can reevalute it, but the point is that the generic volume revert workflow should work.\n\nWe may have failures though until the fix is not merged. But on the other hand, the jobs which use devstack-plugin-nfs are used, apart from this repository, in cinder (non-voting), os-brick (non-voting), nova (experimental, so non voting). Probably not a big concern.","commit_id":"5595c4be5450bb792c4e255a6632776aff12cc39"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9a94f709d6b1029b323b0bd87812ea87e91473b0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7490418d_093726eb","in_reply_to":"8699114f_23bb02f8","updated":"2022-03-31 12:54:04.000000000","message":"I can\u0027t fully remember why I picked these stable releases but as far as I could tell, the NFS revert to snapshot is broken in most stable branches so it only makes sense to run this on master.\nMaybe Luigi would remember :)","commit_id":"5595c4be5450bb792c4e255a6632776aff12cc39"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71f25c48cd3eb77e766c3a6b9663128f2ea0cbd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f74f1472_72277481","updated":"2022-04-12 15:48:00.000000000","message":"LGTM","commit_id":"5d731a49a95aca16c6f3f34b368d24580f5ae399"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"549bc05859df5b2d8ab5cf53af3c689621e04cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a394fa30_f0480475","updated":"2022-04-12 13:48:44.000000000","message":"This makes sense to do but I\u0027m unsure how helpful this is with the current state of our NFS job. The devstack-plugin-nfs-tempest-full job (using this plugin) on cinder side doesn\u0027t run cinder tempest plugin where our revert to snapshot tests reside[1]. This is useful but just want to make sure we\u0027re using this tempest config somewhere.\n\n[1] https://github.com/openstack/cinder-tempest-plugin/blob/c70f27ca61261dc8176375275d3fd16792d8d57c/cinder_tempest_plugin/api/volume/test_volume_revert.py#L52-L67","commit_id":"5d731a49a95aca16c6f3f34b368d24580f5ae399"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5d37fe0f7aa7ffa2fd46183ba52ad19b7184c4d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5bfd413_0fe24c75","updated":"2022-04-12 09:50:00.000000000","message":"makes sense, is it ready to be merged?","commit_id":"5d731a49a95aca16c6f3f34b368d24580f5ae399"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"92c8fb2424238ae3dab4fed8098ef4358588ed23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c07b66d5_f7c576b1","in_reply_to":"a394fa30_f0480475","updated":"2022-04-12 14:20:52.000000000","message":"With this option we can easily create a job which uses tests from cinder-tempest-plugin and the option will be enabled automatically.","commit_id":"5d731a49a95aca16c6f3f34b368d24580f5ae399"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71f25c48cd3eb77e766c3a6b9663128f2ea0cbd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e5e28ae_1b4c2a95","in_reply_to":"c07b66d5_f7c576b1","updated":"2022-04-12 15:48:00.000000000","message":"Ack, that\u0027s the assurance i needed. :)","commit_id":"5d731a49a95aca16c6f3f34b368d24580f5ae399"}],"devstack/plugin.sh":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f33d2c3252bf4ddd9dd3733221193f7e7ce44c59","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled backup False"},{"line_number":82,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled clone True"},{"line_number":83,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled manage_snapshot False"},{"line_number":84,"context_line":"    # Volume revert to snapshot support for rbd was introduced in Ussuri by"},{"line_number":85,"context_line":"    # If8a5eb3a03e18f9043ff29f7648234c9b46376a0"},{"line_number":86,"context_line":"    if [[ \"$TARGET_BRANCH\" \u003d~ stable/(ocata|pike|queens|rocky|stein|train) ]]; then"},{"line_number":87,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled volume_revert True"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3761360f_9f18e953","line":84,"updated":"2021-12-13 10:08:52.000000000","message":"I think this comment only applies to rbd, not NFS","commit_id":"a0a6eade130871747d923994dd5541cdcb95c403"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9a94f709d6b1029b323b0bd87812ea87e91473b0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled backup False"},{"line_number":82,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled clone True"},{"line_number":83,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled manage_snapshot False"},{"line_number":84,"context_line":"    # Volume revert to snapshot support for rbd was introduced in Ussuri by"},{"line_number":85,"context_line":"    # If8a5eb3a03e18f9043ff29f7648234c9b46376a0"},{"line_number":86,"context_line":"    if [[ \"$TARGET_BRANCH\" \u003d~ stable/(ocata|pike|queens|rocky|stein|train) ]]; then"},{"line_number":87,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled volume_revert True"}],"source_content_type":"text/x-sh","patch_set":3,"id":"db97d0f1_7003081e","line":84,"in_reply_to":"3761360f_9f18e953","updated":"2022-03-31 12:54:04.000000000","message":"Done","commit_id":"a0a6eade130871747d923994dd5541cdcb95c403"}]}