)]}'
{".zuul.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    check:"},{"line_number":3,"context_line":"      jobs:"},{"line_number":4,"context_line":"        - openstack-tox-bashate"},{"line_number":5,"context_line":"    gate:"},{"line_number":6,"context_line":"      jobs:"},{"line_number":7,"context_line":"        - openstack-tox-bashate"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d8d96ac7_2b1c9f64","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2025-01-24 19:56:46.000000000","message":"if we use pre-commit or similar later perhaps we shoud use the generic \n\nopenstack-tox-linters job instead.\n\nthis is ok to start with but it would be nice to add the relevant subset of \n\nhttps://github.com/openstack/watcher/blob/master/.pre-commit-config.yaml","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c3f7353527bb4049b67f41be759897fb5b6de91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    check:"},{"line_number":3,"context_line":"      jobs:"},{"line_number":4,"context_line":"        - openstack-tox-bashate"},{"line_number":5,"context_line":"    gate:"},{"line_number":6,"context_line":"      jobs:"},{"line_number":7,"context_line":"        - openstack-tox-bashate"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7bd701b9_0ae7ba86","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"a4d83abd_faaa8c86","updated":"2025-01-27 17:39:08.000000000","message":"Acknowledged","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    check:"},{"line_number":3,"context_line":"      jobs:"},{"line_number":4,"context_line":"        - openstack-tox-bashate"},{"line_number":5,"context_line":"    gate:"},{"line_number":6,"context_line":"      jobs:"},{"line_number":7,"context_line":"        - openstack-tox-bashate"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4d83abd_faaa8c86","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"d8d96ac7_2b1c9f64","updated":"2025-01-27 05:37:08.000000000","message":"Renamed the current job with linters job. \n\nGood idea to add pre-commit job as a follow up.","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80a90228f650ef9929cae7bd713315d970025806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4068de53_eaaac5cd","updated":"2025-01-27 17:21:33.000000000","message":"lgtm","commit_id":"f384126bdccd4eb9bb5ec514f00148c7bfa2c3fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c3f7353527bb4049b67f41be759897fb5b6de91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5f62a1e_4a2f212b","updated":"2025-01-27 17:39:08.000000000","message":"we can adjust the bash8 warning when we add pre-commit since i think its conflicting with the other rules we normally enforce so we probably should skip it","commit_id":"f384126bdccd4eb9bb5ec514f00148c7bfa2c3fe"}],"README.rst":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"123cf588dffad4058635429cb88757c0010d458a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"-  To get started quickly, just enable the plugin in your"},{"line_number":13,"context_line":"   ``local.conf``:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"   ``enable_plugin devstack-plugin-ceph https://opendev.org/openstack/devstack-plugin-ceph``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2c8f4412_9b9d7200","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":39},"updated":"2025-01-24 10:02:38.000000000","message":"```suggestion\n   ``enable_plugin devstack-plugin-prometheus https://opendev.org/openstack/devstack-plugin-prometheus``\n```","commit_id":"1e2882a718ac392ad110fcad1c70afe791a328aa"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8265c1a23cf585d6437f749107cb127384a0241e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"-  To get started quickly, just enable the plugin in your"},{"line_number":13,"context_line":"   ``local.conf``:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"   ``enable_plugin devstack-plugin-ceph https://opendev.org/openstack/devstack-plugin-ceph``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8e28e6e7_a455b0da","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":39},"in_reply_to":"2c8f4412_9b9d7200","updated":"2025-01-24 11:17:56.000000000","message":"Done","commit_id":"1e2882a718ac392ad110fcad1c70afe791a328aa"}],"devstack/lib/prometheus":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"pre_install_prometheus() {"},{"line_number":4,"context_line":"    # Install OS packages if necessary with \"install_package ...\"."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7dd84189_9e284d56","line":1,"updated":"2025-01-24 19:56:46.000000000","message":"this is sourced by devstack and should not havea #! line","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"pre_install_prometheus() {"},{"line_number":4,"context_line":"    # Install OS packages if necessary with \"install_package ...\"."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b95042ab_0154c60c","line":1,"in_reply_to":"7dd84189_9e284d56","updated":"2025-01-27 05:37:08.000000000","message":"Done","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Tell emacs to use shell-script-mode"},{"line_number":29,"context_line":"## Local variables:"},{"line_number":30,"context_line":"## mode: shell-script"},{"line_number":31,"context_line":"## End:"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"01ea3d4a_9350b859","line":28,"updated":"2025-01-24 19:56:46.000000000","message":"we shoudl avoid editor markers.\n\ni some times use emacs but we should not add things like this.","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Tell emacs to use shell-script-mode"},{"line_number":29,"context_line":"## Local variables:"},{"line_number":30,"context_line":"## mode: shell-script"},{"line_number":31,"context_line":"## End:"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ad50eb48_0ad8bc25","line":28,"in_reply_to":"01ea3d4a_9350b859","updated":"2025-01-27 05:37:08.000000000","message":"Done","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"}],"devstack/plugin.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5dd63b32_9972202c","updated":"2025-01-24 19:56:46.000000000","message":"this is sourced so it shoudl not be marked as executable","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c97968a_45f0a0f7","in_reply_to":"5dd63b32_9972202c","updated":"2025-01-27 05:37:08.000000000","message":"Done","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"}],"devstack/settings":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[{"line_number":1,"context_line":"enable_service prometheus"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"cfb0482a_3a06f23f","line":1,"updated":"2025-01-24 19:56:46.000000000","message":"the setting file should not invoke functions to enable a service.\n\nit should just define the variables exported by the plugin.","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"enable_service prometheus"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"6fe885c0_192aa164","line":1,"in_reply_to":"cfb0482a_3a06f23f","updated":"2025-01-27 05:37:08.000000000","message":"Done","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4032e416725e0900044b8901533d299313cc6942","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d bashate"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1778e8f7_89346843","line":1,"updated":"2025-01-24 19:56:46.000000000","message":"this is ok but i would like ot also add pre-commit in a follow up.\n\nso we might move the","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dda917f2ed3efe39519ef119193f74d8fd720de1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d bashate"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3db7efc9_6f0f6ae6","line":1,"in_reply_to":"1778e8f7_89346843","updated":"2025-01-27 05:37:08.000000000","message":"Sure!","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c3f7353527bb4049b67f41be759897fb5b6de91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d bashate"}],"source_content_type":"text/x-properties","patch_set":3,"id":"a11994cd_40b2b616","line":1,"in_reply_to":"3db7efc9_6f0f6ae6","updated":"2025-01-27 17:39:08.000000000","message":"Acknowledged","commit_id":"960120ff1c9c7b2dea370867727f1c6532875e58"}]}