)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df7dbca23e06901c2ada84546ba905130a572cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"539825e0_6a1d59bd","updated":"2025-01-30 18:35:13.000000000","message":"I think we should some job to verify these installation/config otherwise it is hard to know if those working fine or not. job can be just enable, install, and configure prometheus","commit_id":"9acb1bb9648e5960f27b8228cc37ae7d45e93eb2"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ba4f7df5f2f6ea6ca66890c12d2836de1b8a971d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"780f335a_0c3b2d8e","in_reply_to":"46b233cb_c2aa7e1d","updated":"2025-02-13 11:32:38.000000000","message":"@gmann@ghanshyammann.com Thank you for the review, Final job is passing now https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/940497, this review series is good to go from myside. Please take a look when free. thank you!","commit_id":"9acb1bb9648e5960f27b8228cc37ae7d45e93eb2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f0a036154f831bcc293ee264da927c00a05d4c0d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc50aac5_81e6aed9","in_reply_to":"539825e0_6a1d59bd","updated":"2025-01-30 18:39:32.000000000","message":"I see that you are enabling them in https://review.opendev.org/c/openstack/watcher/+/939515\n\nso those job we can add here also but not in this change as this need to be merged before job update in watcher.\n\nCan you add a change on top of this change and depends-on 939515 to add/run watcher-prometheus-integration job in this plugin gate. It will help to make sure we test this plugin code in thsis repo gate itself.","commit_id":"9acb1bb9648e5960f27b8228cc37ae7d45e93eb2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15645054a6f37765f56a45afd096ede8385b2897","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46b233cb_c2aa7e1d","in_reply_to":"59b13c5a_cd63732b","updated":"2025-01-31 18:00:32.000000000","message":"thanks, looks good, let\u0027 wait for  watcher-prometheus-integration \n job to pass in follow-up change so that we can know nothing change is needed here and all works fine. I am putting soft -1 here in case we \naccidentally merge it - https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/940497/1","commit_id":"9acb1bb9648e5960f27b8228cc37ae7d45e93eb2"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c7ea107e2ce145c711e446ee8044fa866f52ed69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"59b13c5a_cd63732b","in_reply_to":"dc50aac5_81e6aed9","updated":"2025-01-31 08:56:10.000000000","message":"Good idea, Added the watcher-prometheus-integration job here https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/940497","commit_id":"9acb1bb9648e5960f27b8228cc37ae7d45e93eb2"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a411ee1b502be4c4186417983171290b4072bfb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"339cfd68_dc0b0307","updated":"2025-02-12 05:37:34.000000000","message":"Setting worklfow -1 till watcher prometheus integration job passes.","commit_id":"328318b99ff1d25b5bc3dbb7265b51cbe605b3e0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bed21b287d33f028ae8b17ea6d72fdb0e4d44fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2fd5ee4f_0930dca8","updated":"2025-02-17 19:32:35.000000000","message":"lgtm, this is tested in https://zuul.opendev.org/t/openstack/build/fe453a46c8e341138bd4ee2f8b05457c","commit_id":"a0e5374c747f7ebc4d5895b3b4cc65ab020bb94f"}],"devstack/lib/prometheus":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"71e102b04438986f395c646acb9d8a271894afa4","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    sleep 60"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"function check_data {"},{"line_number":98,"context_line":"    if curl -s --head  --request  GET \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\" | grep \"200 OK\" \u003e /dev/null; then"},{"line_number":99,"context_line":"        echo \"#### Metrics data ####\""},{"line_number":100,"context_line":"        curl \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"953bee1c_43e88474","line":97,"updated":"2025-02-17 11:02:56.000000000","message":"I have a question about this function. What data is it supposed to check? The /metrics endpoint just exposes Prometheus\u0027s own metrics for further scraping for example with a self scraping target as can be seen here https://github.com/openstack-k8s-operators/sg-core/blob/main/devstack/prometheus-files/scrape_configs/prometheus . I guess you could check that Prometheus is running this way. If this is the purpose of the function, then it\u0027s OK.\n\nBut if you want to check the metrics stored inside Prometheus (for example because you want to know that Prometheus is scraping something), I think you should take a look at the Prometheus HTTP API instead https://prometheus.io/docs/prometheus/latest/querying/api/ . The /api/v1/series could be interesting or /api/v1/label/\\_\\_name\\_\\_/values for getting list of metric names.","commit_id":"a0e5374c747f7ebc4d5895b3b4cc65ab020bb94f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f170bb805992613a65548e95d11814933424a126","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    sleep 60"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"function check_data {"},{"line_number":98,"context_line":"    if curl -s --head  --request  GET \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\" | grep \"200 OK\" \u003e /dev/null; then"},{"line_number":99,"context_line":"        echo \"#### Metrics data ####\""},{"line_number":100,"context_line":"        curl \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"92fbb904_e05f5ed4","line":97,"in_reply_to":"0636d24c_b9c8eb24","updated":"2025-02-18 07:50:39.000000000","message":"Since this review got votes. I thought to let it as merge as it is. I have added a seperate cr https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/942053 to use prometheus HTTP API to qurey for metrics. \n\nPlease have a look and let us know. thank you!","commit_id":"a0e5374c747f7ebc4d5895b3b4cc65ab020bb94f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2b09020f435c16283fd0d7861f2d7bd93ac732db","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    sleep 60"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"function check_data {"},{"line_number":98,"context_line":"    if curl -s --head  --request  GET \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\" | grep \"200 OK\" \u003e /dev/null; then"},{"line_number":99,"context_line":"        echo \"#### Metrics data ####\""},{"line_number":100,"context_line":"        curl \"http://$HOST_IP:$PROMETHEUS_PORT/metrics\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"0636d24c_b9c8eb24","line":97,"in_reply_to":"953bee1c_43e88474","updated":"2025-02-17 13:53:20.000000000","message":"@jcoufal@redhat.com Yes correct! this purpose of this function is to check whether prometheus is running properly or not.\n\nThank you for the link. I will update this function to check for metric stored inside prometheus.","commit_id":"a0e5374c747f7ebc4d5895b3b4cc65ab020bb94f"}]}