)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9cb03353ca60cf6a19259d6ddd51322a8de1acff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1c42d34_0326a492","updated":"2025-01-30 18:35:36.000000000","message":"ditto, we should have a job which can enable, install, and configure prometheus","commit_id":"a49cc649f1f461ed7e28fd65e17c5ba9d6a91c3d"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"59d2c2634d6dd76bf7d80150cd76610bcfc642fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4d49ee25_153b4a6b","updated":"2025-02-17 11:17:52.000000000","message":"I\u0027m wondering what\u0027s going on with the errors in the logs https://4edc993961e8be7ed954-f833862f6fa359097814ed1d3103e043.ssl.cf2.rackcdn.com/939515/23/check/watcher-prometheus-integration/ff3c7af/controller/logs/screen-node-exporter.txt","commit_id":"c0c05ea8ebddd26867a0f65af21c7e0f6c98249a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9e5631a603ff37de5c083eed19f16d7f305735b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"79bb3f32_e7848b7a","updated":"2025-02-17 19:33:05.000000000","message":"lgtm","commit_id":"c0c05ea8ebddd26867a0f65af21c7e0f6c98249a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4fc50e4dcf0d74efc27578a018c319fe8b94ee19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d86d63b2_d7d0f7f4","in_reply_to":"4d49ee25_153b4a6b","updated":"2025-02-17 13:55:34.000000000","message":"The same error is coming in local environment also. But the node_exporter is working fine with watcher in CI job. So we decided to ignore it.\n\nBased on https://github.com/prometheus/node_exporter/issues/2387, it might be a network issue. Not sure.","commit_id":"c0c05ea8ebddd26867a0f65af21c7e0f6c98249a"}],"devstack/lib/node_exporter":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"fa23400122ff1758d9e2c50bdffce422cec36886","unresolved":true,"context_lines":[{"line_number":7,"context_line":"}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"function install_node_exporter {"},{"line_number":10,"context_line":"    # Download Prometheus"},{"line_number":11,"context_line":"    wget https://github.com/prometheus/node_exporter/releases/download/v${NODE_EXPORTER_VERSION}/node_exporter-${NODE_EXPORTER_VERSION}.linux-amd64.tar.gz"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Extract the tarball"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"80785234_188cf841","line":10,"updated":"2025-01-31 08:45:11.000000000","message":"```suggestion\n    # Download Node Exporter\n```","commit_id":"1b656bbea861b120e47ee78672d53a536614879e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4fc50e4dcf0d74efc27578a018c319fe8b94ee19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"function install_node_exporter {"},{"line_number":10,"context_line":"    # Download Prometheus"},{"line_number":11,"context_line":"    wget https://github.com/prometheus/node_exporter/releases/download/v${NODE_EXPORTER_VERSION}/node_exporter-${NODE_EXPORTER_VERSION}.linux-amd64.tar.gz"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Extract the tarball"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"f6918870_29437267","line":10,"in_reply_to":"80785234_188cf841","updated":"2025-02-17 13:55:34.000000000","message":"Done","commit_id":"1b656bbea861b120e47ee78672d53a536614879e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"053774c09fe49bb855012bd1d821db2d4d2c5b0a","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function install_node_exporter {"},{"line_number":18,"context_line":"    # Download node_exporter"},{"line_number":19,"context_line":"    wget https://github.com/prometheus/node_exporter/releases/download/v${NODE_EXPORTER_VERSION}/node_exporter-${NODE_EXPORTER_VERSION}.linux-amd64.tar.gz"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # Extract the tarball"},{"line_number":22,"context_line":"    tar -xvf node_exporter-${NODE_EXPORTER_VERSION}.linux-amd64.tar.gz"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9fa6502c_8f299d35","line":19,"updated":"2025-02-19 00:05:47.000000000","message":"lookign at this again ther eare other issues with the plugin\n\nthis plugin is intened to be installing prometusue and node exporter from system packages\n\nwe also shoudl not be directly getting packagaes from Git Hub in the job.\n\nthis is ok for the short term but we shoud refactor this in the next few weeks\n\nsupport upstream release for local testing is ok but it shoudl not be the default in our ci.","commit_id":"c0c05ea8ebddd26867a0f65af21c7e0f6c98249a"}],"devstack/settings":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"adef91558312ff99226d06b6c521ba810ef13c71","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# DevStack settings"},{"line_number":2,"context_line":"define_plugin prometheus node_exporter"},{"line_number":3,"context_line":"enable_service prometheus"},{"line_number":4,"context_line":"enable_service node_exporter"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"## Variables related to prometheus"},{"line_number":7,"context_line":"PROMETHEUS_VERSION\u003d3.1.0"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"f867caae_81ab005b","line":4,"range":{"start_line":1,"start_character":2,"end_line":4,"end_character":28},"updated":"2025-02-18 23:54:55.000000000","message":"i tought i left this feedback on the intiall plugin patch but we shodu not invoke enable_service in devstack/settings\n\nservice provided by a devstack plugin should not be ensbled by default just be importing it they shoudl enabled explictly in the lcoal.conf and or job configuration.","commit_id":"c0c05ea8ebddd26867a0f65af21c7e0f6c98249a"}]}