)]}'
{"id":"openstack%2Fdevstack-tools~438989","triplet_id":"openstack%2Fdevstack-tools~master~Ifaa1176e9fdfbc4fdb43192ed2f85e7306823848","project":"openstack/devstack-tools","branch":"master","hashtags":[],"change_id":"Ifaa1176e9fdfbc4fdb43192ed2f85e7306823848","subject":"Insert the right content at end of files","status":"MERGED","created":"2017-02-28 14:54:31.000000000","updated":"2017-02-28 15:37:29.000000000","submitted":"2017-02-28 15:37:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3909de5e3c3abc82838ffba1d9bdd2b8e2a60f48","_number":438989,"virtual_id_number":438989,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-02-28 15:37:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-02-28 15:29:56.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2017-02-28 15:31:28.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":1,"date":"2017-02-28 15:31:28.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-28 15:29:56.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2017-02-28 15:37:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a1b85d281e078d94590604095d3ee11caa82ecc1","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-02-28 14:54:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43f756e5c0b126ec038d189db771ddb0336ce925","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-28 15:00:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-devstack-tools-python35 http://logs.openstack.org/89/438989/1/check/gate-devstack-tools-python35/79ba9ae/ : FAILURE in 2m 46s\n- gate-devstack-tools-pep8-ubuntu-xenial http://logs.openstack.org/89/438989/1/check/gate-devstack-tools-pep8-ubuntu-xenial/c5994da/ : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":1},{"id":"6ebadb2e7c519ed612dca38803f5488c2f70174c","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-02-28 15:11:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"699b6045bc4b3bc0ad7d229130b8c4cdf96fe30e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-28 15:16:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-devstack-tools-python35 http://logs.openstack.org/89/438989/2/check/gate-devstack-tools-python35/5ec83d0/ : SUCCESS in 2m 57s\n- gate-devstack-tools-pep8-ubuntu-xenial http://logs.openstack.org/89/438989/2/check/gate-devstack-tools-pep8-ubuntu-xenial/7b21817/ : SUCCESS in 3m 19s","accounts_in_message":[],"_revision_number":2},{"id":"1a66ac5fa33c7febad6bc9cf39272082daa2659b","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-02-28 15:27:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"22d86090272ee959224dffc379a03ca424a6d98a","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-02-28 15:28:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"735045e1c4452a35b316161a951f52bc6156b132","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2017-02-28 15:29:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"105fc461d665e2f204120f66527e220542ec3db3","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-02-28 15:31:28.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"402642dfae41e034135f2c08105f25f4743a3b84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-28 15:34:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-devstack-tools-python35 http://logs.openstack.org/89/438989/3/check/gate-devstack-tools-python35/4bba3c7/ : SUCCESS in 3m 01s\n- gate-devstack-tools-pep8-ubuntu-xenial http://logs.openstack.org/89/438989/3/check/gate-devstack-tools-pep8-ubuntu-xenial/773bdc5/ : SUCCESS in 2m 03s","accounts_in_message":[],"_revision_number":3},{"id":"299a0c645d62211e674a56069b191cb7f8ce93e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-28 15:34:42.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"129d11adf5ff15fe72bdd333c2a05185ed4a2eb5","date":"2017-02-28 15:37:29.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"3909de5e3c3abc82838ffba1d9bdd2b8e2a60f48","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-28 15:37:29.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-devstack-tools-python35 http://logs.openstack.org/89/438989/3/gate/gate-devstack-tools-python35/3d513e9/ : SUCCESS in 2m 28s\n- gate-devstack-tools-pep8-ubuntu-xenial http://logs.openstack.org/89/438989/3/gate/gate-devstack-tools-pep8-ubuntu-xenial/d692c18/ : SUCCESS in 2m 04s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8a9057a4e2a854f77f8bee2ea3ed1e006fb0a45a","revisions":{"084af1ec84fd019c6715ee92770d82fd0a82e680":{"kind":"REWORK","_number":1,"created":"2017-02-28 14:54:31.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/89/438989/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-tools","ref":"refs/changes/89/438989/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/1"}}},"commit":{"parents":[{"commit":"c5626f3b4bef206c704f4be871526f1907a6a39a","subject":"support local.conf files with no [[local]] section yet","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/c5626f3b4bef206c704f4be871526f1907a6a39a"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 14:52:40.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 14:52:40.000000000","tz":-300},"subject":"Insert the right content at end of files","message":"Insert the right content at end of files\n\nPreviously the logic around hitting the end of the file without having\nfound the insertion point didn\u0027t account for the fact that you might\nbe in roughly the right area, and would not need to duplicate the meta\nsection or section headers.\n\nThis takes that into account during the else phase. It will help with\nthe neutron functional jobs that merge a lot of snippets together.\n\nChange-Id: Ifaa1176e9fdfbc4fdb43192ed2f85e7306823848\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/084af1ec84fd019c6715ee92770d82fd0a82e680"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/084af1ec84fd019c6715ee92770d82fd0a82e680"}]},"branch":"refs/heads/master"},"9b3d2ed1be626400838a68e23aa22c7a372f9a9a":{"kind":"REWORK","_number":2,"created":"2017-02-28 15:11:22.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/89/438989/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-tools","ref":"refs/changes/89/438989/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/2"}}},"commit":{"parents":[{"commit":"c5626f3b4bef206c704f4be871526f1907a6a39a","subject":"support local.conf files with no [[local]] section yet","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/c5626f3b4bef206c704f4be871526f1907a6a39a"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 14:52:40.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 15:11:17.000000000","tz":-300},"subject":"Insert the right content at end of files","message":"Insert the right content at end of files\n\nPreviously the logic around hitting the end of the file without having\nfound the insertion point didn\u0027t account for the fact that you might\nbe in roughly the right area, and would not need to duplicate the meta\nsection or section headers.\n\nThis takes that into account during the else phase. It will help with\nthe neutron functional jobs that merge a lot of snippets together.\n\nChange-Id: Ifaa1176e9fdfbc4fdb43192ed2f85e7306823848\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/9b3d2ed1be626400838a68e23aa22c7a372f9a9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/9b3d2ed1be626400838a68e23aa22c7a372f9a9a"}]},"branch":"refs/heads/master"},"8a9057a4e2a854f77f8bee2ea3ed1e006fb0a45a":{"kind":"REWORK","_number":3,"created":"2017-02-28 15:28:06.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/89/438989/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-tools","ref":"refs/changes/89/438989/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-tools refs/changes/89/438989/3"}}},"commit":{"parents":[{"commit":"c5626f3b4bef206c704f4be871526f1907a6a39a","subject":"support local.conf files with no [[local]] section yet","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/c5626f3b4bef206c704f4be871526f1907a6a39a"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 14:52:40.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2017-02-28 15:25:17.000000000","tz":-300},"subject":"Insert the right content at end of files","message":"Insert the right content at end of files\n\nPreviously the logic around hitting the end of the file without having\nfound the insertion point didn\u0027t account for the fact that you might\nbe in roughly the right area, and would not need to duplicate the meta\nsection or section headers.\n\nThis takes that into account during the else phase. It will help with\nthe neutron functional jobs that merge a lot of snippets together.\n\nChange-Id: Ifaa1176e9fdfbc4fdb43192ed2f85e7306823848\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/8a9057a4e2a854f77f8bee2ea3ed1e006fb0a45a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-tools/commit/8a9057a4e2a854f77f8bee2ea3ed1e006fb0a45a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}