)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93334b589d169392dd589fc9c2fcefff7a428af2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"transport and format that nova.conf uses."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated-By: Claude Opus 5.5"},{"line_number":20,"context_line":"Co-Authored-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e"},{"line_number":21,"context_line":"Change-Id: Icb8f9fbcbc1aa6997371b2bd66c674b24d0a2a0f"},{"line_number":22,"context_line":"Signed-off-by: Simon Zhou \u003ctd@fivetime.ltd\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d555e300_db03730e","line":20,"range":{"start_line":20,"start_character":1,"end_line":20,"end_character":14},"updated":"2026-10-17 17:45:24.000000000","message":"Please read https://openinfra.org/legal/ai-policy when you contribute AI generated content.\n\nAI can\u0027t author a commit. Drop this.","commit_id":"e1ff050d857c0f3f50b4f58691a2dfdb30757334"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"145d51983942a8db38d879415651e168a4d02e79","unresolved":false,"context_lines":[{"line_number":17,"context_line":"transport and format that nova.conf uses."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated-By: Claude Opus 5.5"},{"line_number":20,"context_line":"Co-Authored-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e"},{"line_number":21,"context_line":"Change-Id: Icb8f9fbcbc1aa6997371b2bd66c674b24d0a2a0f"},{"line_number":22,"context_line":"Signed-off-by: Simon Zhou \u003ctd@fivetime.ltd\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f4969a47_14c6b7b9","line":20,"in_reply_to":"d555e300_db03730e","updated":"2026-10-20 07:42:31.000000000","message":"Done in patch set 2: dropped Co-Authored-By and kept only Generated-By.","commit_id":"e1ff050d857c0f3f50b4f58691a2dfdb30757334"}],"lib/nova":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93334b589d169392dd589fc9c2fcefff7a428af2","unresolved":true,"context_lines":[{"line_number":595,"context_line":"            iniset $conf database connection `database_connection_url nova_cell${i}`"},{"line_number":596,"context_line":"            iniset $conf conductor workers \"$API_WORKERS\""},{"line_number":597,"context_line":"            iniset $conf DEFAULT debug \"$ENABLE_DEBUG_LOG_LEVEL\""},{"line_number":598,"context_line":"            # The cell conductor reads only this file, so without these it"},{"line_number":599,"context_line":"            # uses the noop notification driver and drops the notifications"},{"line_number":600,"context_line":"            # it sends, such as compute_task build failures."},{"line_number":601,"context_line":"            iniset $conf oslo_messaging_notifications driver \"messagingv2\""},{"line_number":602,"context_line":"            iniset $conf oslo_messaging_notifications transport_url $(get_notification_url)"},{"line_number":603,"context_line":"            iniset $conf notifications notification_format \"$NOVA_NOTIFICATION_FORMAT\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1b3bfe99_8165293b","line":600,"range":{"start_line":598,"start_character":0,"end_line":600,"end_character":60},"updated":"2026-10-17 17:45:24.000000000","message":"This feels too much context kept in code, because basically it\u0027s not specific to notifications that you have to configure all options for cell conductor. I\u0027d drop this or reduce the content to:\n\n```suggestion\n            # Enable notifications in cell conductor, following the settings\n            # in base nova.conf\n```\n\nMaybe we want a common utility method to apply notification options and use it here and in base nova.conf, but that can be left for follow-up.","commit_id":"e1ff050d857c0f3f50b4f58691a2dfdb30757334"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"145d51983942a8db38d879415651e168a4d02e79","unresolved":false,"context_lines":[{"line_number":597,"context_line":"            iniset $conf DEFAULT debug \"$ENABLE_DEBUG_LOG_LEVEL\""},{"line_number":598,"context_line":"            # The cell conductor reads only this file, so without these it"},{"line_number":599,"context_line":"            # uses the noop notification driver and drops the notifications"},{"line_number":600,"context_line":"            # it sends, such as compute_task build failures."},{"line_number":601,"context_line":"            iniset $conf oslo_messaging_notifications driver \"messagingv2\""},{"line_number":602,"context_line":"            iniset $conf oslo_messaging_notifications transport_url $(get_notification_url)"},{"line_number":603,"context_line":"            iniset $conf notifications notification_format \"$NOVA_NOTIFICATION_FORMAT\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a787ce1_eaabdee7","line":600,"in_reply_to":"1b3bfe99_8165293b","updated":"2026-10-20 07:42:31.000000000","message":"Done in patch set 2, using your wording. Agreed that a common helper for the notification options can come as a follow-up.","commit_id":"e1ff050d857c0f3f50b4f58691a2dfdb30757334"}]}
