)]}'
{"README.md":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5060fe30d487d69451b2ad4a52eaeb8f7ecfb422","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Apache web server can be enabled for wsgi services that support being deployed"},{"line_number":137,"context_line":"under HTTPD + mod_wsgi. Globally to disable all deployment of all services"},{"line_number":138,"context_line":"under HTTPD + mod_wsgi (provided there is an alternative deployment method)"},{"line_number":139,"context_line":"set ``ENABLE_HTTPD_MOD_WSGI_SERVICES`` to ``0`` in your ``localrc``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Each service that can be run under HTTPD + mod_wsgi has a toggle available."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":3,"id":"1ae5cdf2_b5b0e7dc","line":139,"updated":"2014-06-21 03:07:07.000000000","message":"use ``local.conf`` here now rather than localrc","commit_id":"3a7a21db7e5ebd7a88cbd6973e8e23da17f19c19"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0f7698242f32596e5f3e1241b2ab12195f712dcd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Apache web server can be enabled for wsgi services that support being deployed"},{"line_number":137,"context_line":"under HTTPD + mod_wsgi. Globally to disable all deployment of all services"},{"line_number":138,"context_line":"under HTTPD + mod_wsgi (provided there is an alternative deployment method)"},{"line_number":139,"context_line":"set ``ENABLE_HTTPD_MOD_WSGI_SERVICES`` to ``0`` in your ``localrc``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Each service that can be run under HTTPD + mod_wsgi has a toggle available."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":3,"id":"1ae5cdf2_2d380b9f","line":139,"in_reply_to":"1ae5cdf2_b5b0e7dc","updated":"2014-06-21 18:31:40.000000000","message":"Done in next patch","commit_id":"3a7a21db7e5ebd7a88cbd6973e8e23da17f19c19"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0ca36f5cbe1163a6a10e24545c2cc825ccde8d16","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Apache web server can be enabled for wsgi services that support being deployed"},{"line_number":137,"context_line":"under HTTPD + mod_wsgi. To globally run all services that default deployment"},{"line_number":138,"context_line":"under HTTPD + mod_wsgi to use the alternate method (e.g. eventlet), if"},{"line_number":139,"context_line":"available, set ``ENABLE_HTTPD_MOD_WSGI_SERVICES`` to ``False`` in your"},{"line_number":140,"context_line":"``local.conf``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":7,"id":"1ae5cdf2_1c5a682a","line":138,"updated":"2014-06-24 04:01:30.000000000","message":"I think this sentence is missing parts","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f84093fd3441c86451ce9e64c298cd8d36d3025a","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Apache web server can be enabled for wsgi services that support being deployed"},{"line_number":137,"context_line":"under HTTPD + mod_wsgi. To globally run all services that default deployment"},{"line_number":138,"context_line":"under HTTPD + mod_wsgi to use the alternate method (e.g. eventlet), if"},{"line_number":139,"context_line":"available, set ``ENABLE_HTTPD_MOD_WSGI_SERVICES`` to ``False`` in your"},{"line_number":140,"context_line":"``local.conf``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":7,"id":"1ae5cdf2_37481f2e","line":138,"in_reply_to":"1ae5cdf2_1c5a682a","updated":"2014-06-24 05:18:42.000000000","message":"Wow.. how did this get mangled lik ethis.","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0da8bbfe647dc201d09b4aedd562614b65ae9de8","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Each service that can be run under HTTPD + mod_wsgi has a toggle available."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Example(Keystone):"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    KEYSTONE_USE_MOD_WSGI\u003d\"True\""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":7,"id":"1ae5cdf2_578f6b2e","line":144,"updated":"2014-06-24 05:26:13.000000000","message":"oh also, add a space between Example and ()\nso it matches lines 126 and 130","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"}],"lib/apache":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5060fe30d487d69451b2ad4a52eaeb8f7ecfb422","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        [[ ,${APACHE_ENABLED_SERVICES}, \u003d~ ,${service}, ]] \u0026\u0026 return 0"},{"line_number":58,"context_line":"    done"},{"line_number":59,"context_line":"    return 1"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# install_apache_wsgi() - Install Apache server and wsgi module"},{"line_number":63,"context_line":"function install_apache_wsgi {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_957f6b16","side":"PARENT","line":60,"updated":"2014-06-21 03:07:07.000000000","message":"I think the xxx_use_mod_wsgi() functions in keystone and swift can be combined here into a single function like so:\n\n  function use_mod_wsgi {\n      local service_mod_wsgi\u003d$1\n      # Defensively test against the default values\n      [[ \"$service_mod_wsgi\" !\u003d \"False\" \u0026\u0026 \"${ENABLE_HTTPD_MOD_WSGI_SERVICES}\" \u003d \"True\" ]]\n  }\n\nThen call like:\n\n  if use_mod_wsgi $KEYSTONE_USE_MOD_WSGI; then\n      # set up mod_wsgi\n      # [...]\n  fi","commit_id":"cab1eb12c667d218a4de76ef5e546bfc05efcd97"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0f7698242f32596e5f3e1241b2ab12195f712dcd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        [[ ,${APACHE_ENABLED_SERVICES}, \u003d~ ,${service}, ]] \u0026\u0026 return 0"},{"line_number":58,"context_line":"    done"},{"line_number":59,"context_line":"    return 1"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# install_apache_wsgi() - Install Apache server and wsgi module"},{"line_number":63,"context_line":"function install_apache_wsgi {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_4d3b979b","side":"PARENT","line":60,"in_reply_to":"1ae5cdf2_957f6b16","updated":"2014-06-21 18:31:40.000000000","message":"Done in next patch.","commit_id":"cab1eb12c667d218a4de76ef5e546bfc05efcd97"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0ca36f5cbe1163a6a10e24545c2cc825ccde8d16","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# lib/apache exports the following functions:"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# - allow_apache_enabled_services"},{"line_number":12,"context_line":"# - install_apache_wsgi"},{"line_number":13,"context_line":"# - config_apache_wsgi"},{"line_number":14,"context_line":"# - apache_site_config_for"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_1c7188a8","line":11,"updated":"2014-06-24 04:01:30.000000000","message":"this is no longer valid?","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f84093fd3441c86451ce9e64c298cd8d36d3025a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# lib/apache exports the following functions:"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# - allow_apache_enabled_services"},{"line_number":12,"context_line":"# - install_apache_wsgi"},{"line_number":13,"context_line":"# - config_apache_wsgi"},{"line_number":14,"context_line":"# - apache_site_config_for"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_974f3334","line":11,"in_reply_to":"1ae5cdf2_1c7188a8","updated":"2014-06-24 05:18:42.000000000","message":"Good catch, should be removed.","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"}],"stackrc":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5060fe30d487d69451b2ad4a52eaeb8f7ecfb422","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Global toggle for HTTPD + mod_wsgi deployable services"},{"line_number":50,"context_line":"# If this is set to 0, all services capable of being deployed under an"},{"line_number":51,"context_line":"# alternative to HTTPD + mod_wsgi will be (e.g. eventlet)"},{"line_number":52,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES\u003d1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Tell Tempest which services are available.  The default is set here as"},{"line_number":55,"context_line":"# Tempest falls late in the configuration sequence.  This differs from"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_b5ab8786","line":52,"updated":"2014-06-21 03:07:07.000000000","message":"I\u0027d suggest using True here as we\u0027ve standardized on the Python form (\u0027True\u0027 and \u0027False\u0027) and use the trueorfalse() function to normalize.  In fact, it would probably be better to move this below the localrc source below and use trueorfalse() directly.  It would look a lot like the DATABASE_QUERY_LOGGING setting.","commit_id":"3a7a21db7e5ebd7a88cbd6973e8e23da17f19c19"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0f7698242f32596e5f3e1241b2ab12195f712dcd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Global toggle for HTTPD + mod_wsgi deployable services"},{"line_number":50,"context_line":"# If this is set to 0, all services capable of being deployed under an"},{"line_number":51,"context_line":"# alternative to HTTPD + mod_wsgi will be (e.g. eventlet)"},{"line_number":52,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES\u003d1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Tell Tempest which services are available.  The default is set here as"},{"line_number":55,"context_line":"# Tempest falls late in the configuration sequence.  This differs from"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_6d3e938c","line":52,"in_reply_to":"1ae5cdf2_b5ab8786","updated":"2014-06-21 18:31:40.000000000","message":"Done in next patch.","commit_id":"3a7a21db7e5ebd7a88cbd6973e8e23da17f19c19"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0ca36f5cbe1163a6a10e24545c2cc825ccde8d16","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Global toggle for enabling services under mod_wsgi. If this is set to"},{"line_number":50,"context_line":"# ``True`` all services that use HTTPD + mod_wsgi as the preferred method of"},{"line_number":51,"context_line":"# deployment, will be deployed under apache. If this is set to ``False`` all"},{"line_number":52,"context_line":"# services will rely on the local toggle variable (e.g. ``KEYSTONE_USE_MOD_WSGI``)"},{"line_number":53,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES\u003dTrue"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_bc9894cd","line":51,"updated":"2014-06-24 04:01:30.000000000","message":"nit: s/apache/Apache","commit_id":"bf680d10e1b2d217ebcfe037e5ee12c3c7db8c46"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"44ae03d893f6a028253502d13909efc7d5cc76e2","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Keystone override to indicate deployment under mod_wsgi, by default deploy"},{"line_number":158,"context_line":"# under eventlet"},{"line_number":159,"context_line":"KEYSTONE_USE_MOD_WSGI\u003dFalse"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# python keystone client library to nova that horizon uses"},{"line_number":162,"context_line":"KEYSTONECLIENT_REPO\u003d${KEYSTONECLIENT_REPO:-${GIT_BASE}/openstack/python-keystoneclient.git}"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1ae5cdf2_a1101fac","line":159,"updated":"2014-06-25 20:44:37.000000000","message":"I think this fits better in lib/keystone with the rest of the Keystone-specific configuration","commit_id":"7f578d13df9c14275a58aa4a746aa6c6727de9f2"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"44ae03d893f6a028253502d13909efc7d5cc76e2","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# SWIFT can be deployed under HTTPD + mod_wsgi, but it is not the default"},{"line_number":236,"context_line":"# deployment method."},{"line_number":237,"context_line":"SWIFT_USE_MOD_WSGI\u003dFalse"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# python swift client library"},{"line_number":240,"context_line":"SWIFTCLIENT_REPO\u003d${SWIFTCLIENT_REPO:-${GIT_BASE}/openstack/python-swiftclient.git}"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1ae5cdf2_e10a2778","line":237,"updated":"2014-06-25 20:44:37.000000000","message":"Ditto here for Swift","commit_id":"7f578d13df9c14275a58aa4a746aa6c6727de9f2"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"61b6bab66d95d0df835c39598d7c4a0f67d1a720","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# ``True`` all services that use HTTPD + mod_wsgi as the preferred method of"},{"line_number":51,"context_line":"# deployment, will be deployed under Apache. If this is set to ``False`` all"},{"line_number":52,"context_line":"# services will rely on the local toggle variable (e.g. ``KEYSTONE_USE_MOD_WSGI``)"},{"line_number":53,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES\u003dTrue"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Tell Tempest which services are available.  The default is set here as"},{"line_number":56,"context_line":"# Tempest falls late in the configuration sequence.  This differs from"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baada198_cc506f61","line":53,"updated":"2014-06-30 16:06:16.000000000","message":"This doesn\u0027t appear to be used anymore?","commit_id":"e369f8ecb11d8d1de7b3ac8c7646302467edf241"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bbec59c5e77c26c01e9b6e820588731167dc58f1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# ``True`` all services that use HTTPD + mod_wsgi as the preferred method of"},{"line_number":51,"context_line":"# deployment, will be deployed under Apache. If this is set to ``False`` all"},{"line_number":52,"context_line":"# services will rely on the local toggle variable (e.g. ``KEYSTONE_USE_MOD_WSGI``)"},{"line_number":53,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES\u003dTrue"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Tell Tempest which services are available.  The default is set here as"},{"line_number":56,"context_line":"# Tempest falls late in the configuration sequence.  This differs from"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baada198_d953bd6a","line":53,"in_reply_to":"baada198_cc506f61","updated":"2014-07-01 01:42:23.000000000","message":"This is not used at the moment, it is here for the next patch that will use it for Keystone. It is documented as the way to set services to run under apache that prefer to be deployed in that manner.\n\nKeystone can\u0027t be deployed under apache (bug that needs to be fixed in HEAD requests returning differing values from GET requests). I figured the best way to handle that change was make it a 1-line change to flip keystone to apache deploy by default (in lib/keystone)","commit_id":"e369f8ecb11d8d1de7b3ac8c7646302467edf241"}]}