)]}'
{"lib/opendaylight":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9a423952fbd52d02a36b14f247dc724199088ebc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # FIXME add to ``files/apts/neutron``, but don\u0027t install if not needed!"},{"line_number":130,"context_line":"    if is_ubuntu; then"},{"line_number":131,"context_line":"        kernel_major_minor\u003d`echo $kernel_version | cut -d. -f1-2`"},{"line_number":132,"context_line":"        ovs_packages\u003d\"make fakeroot dkms openvswitch-switch linux-headers-$kernel_version\""},{"line_number":133,"context_line":"        if [ `vercmp_numbers \"$kernel_major_minor\" \"3.13\"` -lt \"0\" ]; then"},{"line_number":134,"context_line":"            ovs_packages\u003d\"$ovs_packages openvswitch-datapath-dkms\""},{"line_number":135,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_f2d869f2","line":132,"updated":"2014-06-24 18:14:03.000000000","message":"$kernel_version is used here so you can\u0027t remove it\u0027s creation from the previous line.","commit_id":"3528bbfffe4f5227baa95eaa5b07e29eb1e2242c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"3d18efe259473270f6954d05cd66af64ff1a9140","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # FIXME add to ``files/apts/neutron``, but don\u0027t install if not needed!"},{"line_number":130,"context_line":"    if is_ubuntu; then"},{"line_number":131,"context_line":"        kernel_major_minor\u003d`echo $kernel_version | cut -d. -f1-2`"},{"line_number":132,"context_line":"        ovs_packages\u003d\"make fakeroot dkms openvswitch-switch linux-headers-$kernel_version\""},{"line_number":133,"context_line":"        if [ `vercmp_numbers \"$kernel_major_minor\" \"3.13\"` -lt \"0\" ]; then"},{"line_number":134,"context_line":"            ovs_packages\u003d\"$ovs_packages openvswitch-datapath-dkms\""},{"line_number":135,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_708c51d8","line":132,"in_reply_to":"1ae5cdf2_f2d869f2","updated":"2014-06-24 19:06:09.000000000","message":"Nice catch.","commit_id":"3528bbfffe4f5227baa95eaa5b07e29eb1e2242c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"39bbe037c8520a31897d1aa4aeaaa84f2d4baf26","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if is_ubuntu; then"},{"line_number":130,"context_line":"        kernel_version\u003d`cat /proc/version | cut -d \" \" -f3`"},{"line_number":131,"context_line":"        kernel_major_minor\u003d`echo $kernel_version | cut -d. -f1-2`"},{"line_number":132,"context_line":"        # We leave linux-headers here because we need to get the version using"},{"line_number":133,"context_line":"        # a runtime check. The DKMS modules are also dependent on a kernel"},{"line_number":134,"context_line":"        # version check, so those remain here as well."},{"line_number":135,"context_line":"        ovs_packages\u003d\"linux-headers-$kernel_version\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_28fdfd08","line":132,"updated":"2014-06-24 21:19:32.000000000","message":"Nit : outside the context of this change \"leave\" is a bit confusing; I think it should read \"we get linux-headers here rather than via get_packages() ...\"","commit_id":"daaae61cb58aa9b7d865784db17ef015048556f9"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"b214295a964c43e538e059da4e6ff84233bcdff0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if is_ubuntu; then"},{"line_number":130,"context_line":"        kernel_version\u003d`cat /proc/version | cut -d \" \" -f3`"},{"line_number":131,"context_line":"        kernel_major_minor\u003d`echo $kernel_version | cut -d. -f1-2`"},{"line_number":132,"context_line":"        # We leave linux-headers here because we need to get the version using"},{"line_number":133,"context_line":"        # a runtime check. The DKMS modules are also dependent on a kernel"},{"line_number":134,"context_line":"        # version check, so those remain here as well."},{"line_number":135,"context_line":"        ovs_packages\u003d\"linux-headers-$kernel_version\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_883c51e3","line":132,"in_reply_to":"1ae5cdf2_28fdfd08","updated":"2014-06-24 21:40:49.000000000","message":"Agreed, will update with the next patch.","commit_id":"daaae61cb58aa9b7d865784db17ef015048556f9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b610e0f0f98badbaa4a1d3ea3ae88298b7e4f886","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if [ `vercmp_numbers \"$kernel_major_minor\" \"3.13\"` -lt \"0\" ]; then"},{"line_number":138,"context_line":"            ovs_packages\u003d\"$ovs_packages dkms openvswitch-datapath-dkms\""},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":"        install_package $(get_packages \"opendaylight\") $ovs_packages"},{"line_number":141,"context_line":"    elif is_fedora; then"},{"line_number":142,"context_line":"        install_package $(get_packages \"opendaylight\")"},{"line_number":143,"context_line":"        # Ensure that the service is started"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_0fd2ec5a","line":140,"updated":"2014-06-25 14:19:37.000000000","message":"The \u0027install_package $(get_package ...)\u0027 bits happen automatically for every service listed in ENABLED_SERVICES.  If your file was named files/*/odl-server it would be included by stack.sh automatically whenever odl-server was enabled.","commit_id":"2bc5d9e482fb6b6d2b2d29cc5b786ad8f1b5ab3b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e1872fa2d933209afcf256277c12c88df88d4f9f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if [ `vercmp_numbers \"$kernel_major_minor\" \"3.13\"` -lt \"0\" ]; then"},{"line_number":138,"context_line":"            ovs_packages\u003d\"$ovs_packages dkms openvswitch-datapath-dkms\""},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":"        install_package $(get_packages \"opendaylight\") $ovs_packages"},{"line_number":141,"context_line":"    elif is_fedora; then"},{"line_number":142,"context_line":"        install_package $(get_packages \"opendaylight\")"},{"line_number":143,"context_line":"        # Ensure that the service is started"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_6f660b57","line":140,"in_reply_to":"1ae5cdf2_0fd2ec5a","updated":"2014-06-25 16:03:20.000000000","message":"Dean, can you look at patch #6? OpenVSwitch packages are needed by both OpenDayLight and the Neutron OVS agent.","commit_id":"2bc5d9e482fb6b6d2b2d29cc5b786ad8f1b5ab3b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b610e0f0f98badbaa4a1d3ea3ae88298b7e4f886","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":"        install_package $(get_packages \"opendaylight\") $ovs_packages"},{"line_number":141,"context_line":"    elif is_fedora; then"},{"line_number":142,"context_line":"        install_package $(get_packages \"opendaylight\")"},{"line_number":143,"context_line":"        # Ensure that the service is started"},{"line_number":144,"context_line":"        restart_service openvswitch"},{"line_number":145,"context_line":"    elif is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_4fccf4bb","line":142,"updated":"2014-06-25 14:19:37.000000000","message":"Same as above","commit_id":"2bc5d9e482fb6b6d2b2d29cc5b786ad8f1b5ab3b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b610e0f0f98badbaa4a1d3ea3ae88298b7e4f886","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # Ensure that the service is started"},{"line_number":144,"context_line":"        restart_service openvswitch"},{"line_number":145,"context_line":"    elif is_suse; then"},{"line_number":146,"context_line":"        install_package $(get_packages \"opendaylight\")"},{"line_number":147,"context_line":"        # Ensure that the service is started"},{"line_number":148,"context_line":"        restart_service openvswitch-switch"},{"line_number":149,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_6fc29087","line":146,"updated":"2014-06-25 14:19:37.000000000","message":"Same as above","commit_id":"2bc5d9e482fb6b6d2b2d29cc5b786ad8f1b5ab3b"}]}
