)]}'
{"lib/apache":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6c9a37298aa8ed5bf7861865cd2aba72cc2258be","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# This function is used to determine the Apache version installed. There are"},{"line_number":66,"context_line":"# various differences between Apache 2.2 and 2.4 that warrant special handling."},{"line_number":67,"context_line":"function get_apache_version {"},{"line_number":68,"context_line":"    local version_str\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_e76a5a80","line":68,"updated":"2014-07-17 11:28:59.000000000","message":"that apache2ctl is debian/ubuntu specifics, right?\n\nWhat about something else (nb: i tested the sed regexp not the rest):\n\nif is_fedora;then\n  apache_bin\u003dhttpd\nelse\n  apache_bin\u003dapache2\nfi\n${apache_bin} -v|sed -n \u0027/Server version/ { s/.*\\/\\(...\\).*/\\1/;p}\u0027","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"cd033b976d68e1023ec1b55a169e8e131efdb9b9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# This function is used to determine the Apache version installed. There are"},{"line_number":66,"context_line":"# various differences between Apache 2.2 and 2.4 that warrant special handling."},{"line_number":67,"context_line":"function get_apache_version {"},{"line_number":68,"context_line":"    local version_str\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_ebe1392b","line":68,"in_reply_to":"baada198_e76a5a80","updated":"2014-07-17 15:58:37.000000000","message":"Yes this should be ubuntu only. Let me make sure we guard against this.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"change_message_id":"7769bf00e729ce73a62c3002b63c390b3dfc0e9f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"function get_apache_version {"},{"line_number":68,"context_line":"    local version_str\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_f3443cb9","line":70,"updated":"2014-07-28 21:22:42.000000000","message":"Maybe log what you\u0027re checking here as well as the version?","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6bceb4b0ff862ac018ea5a7eb03c1319e47c3c22","unresolved":false,"context_lines":[{"line_number":67,"context_line":"function get_apache_version {"},{"line_number":68,"context_line":"    local version_str\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_4069ffbc","line":70,"in_reply_to":"baada198_1b917453","updated":"2014-08-27 23:31:02.000000000","message":"Xtrace is on, it should be logged.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4aa9faaef8fc276b034b80b341f4de10c23ef0b1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"function get_apache_version {"},{"line_number":68,"context_line":"    local version_str\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_1b917453","line":70,"in_reply_to":"baada198_f3443cb9","updated":"2014-08-06 23:36:09.000000000","message":"Done in next patch.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"change_message_id":"7769bf00e729ce73a62c3002b63c390b3dfc0e9f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"},{"line_number":74,"context_line":"        exit_distro_not_supported \"apache version not supported\""},{"line_number":75,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_1340d0a0","line":72,"updated":"2014-07-28 21:22:42.000000000","message":"Same thing here.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4aa9faaef8fc276b034b80b341f4de10c23ef0b1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"},{"line_number":74,"context_line":"        exit_distro_not_supported \"apache version not supported\""},{"line_number":75,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_5b9bec72","line":72,"in_reply_to":"baada198_1340d0a0","updated":"2014-08-06 23:36:09.000000000","message":"Same","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6bceb4b0ff862ac018ea5a7eb03c1319e47c3c22","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    if [[ \"$version_str\" \u003d~ ^2\\.2\\. ]]; then"},{"line_number":70,"context_line":"        echo \"2.2\""},{"line_number":71,"context_line":"    elif [[ \"$version_str\" \u003d~ ^2\\.4\\. ]]; then"},{"line_number":72,"context_line":"        echo \"2.4\""},{"line_number":73,"context_line":"    else"},{"line_number":74,"context_line":"        exit_distro_not_supported \"apache version not supported\""},{"line_number":75,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_805f970e","line":72,"in_reply_to":"baada198_5b9bec72","updated":"2014-08-27 23:31:02.000000000","message":"same as above","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"change_message_id":"7769bf00e729ce73a62c3002b63c390b3dfc0e9f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            # Ubuntu 12.04 - Apache 2.2"},{"line_number":107,"context_line":"            echo $APACHE_CONF_DIR/${site}"},{"line_number":108,"context_line":"        else"},{"line_number":109,"context_line":"            # Ubuntu 14.04 - Apache 2.4"},{"line_number":110,"context_line":"            echo $APACHE_CONF_DIR/${site}.conf"},{"line_number":111,"context_line":"        fi"},{"line_number":112,"context_line":"    elif is_fedora || is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_331234b4","line":109,"updated":"2014-07-28 21:22:42.000000000","message":"While you\u0027re here, this should probably be a check for 2.4 rather than just a blanket assumption since there will be apache versions in the future.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4aa9faaef8fc276b034b80b341f4de10c23ef0b1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            # Ubuntu 12.04 - Apache 2.2"},{"line_number":107,"context_line":"            echo $APACHE_CONF_DIR/${site}"},{"line_number":108,"context_line":"        else"},{"line_number":109,"context_line":"            # Ubuntu 14.04 - Apache 2.4"},{"line_number":110,"context_line":"            echo $APACHE_CONF_DIR/${site}.conf"},{"line_number":111,"context_line":"        fi"},{"line_number":112,"context_line":"    elif is_fedora || is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_fbaa0083","line":109,"in_reply_to":"baada198_331234b4","updated":"2014-08-06 23:36:09.000000000","message":"What should occur if we\u0027re beyond 2.4? I also do not think they will remove the log formatter in newer apache releases.","commit_id":"8443063808d95c5f989e63925a6e4efcc28af5ce"},{"author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"change_message_id":"1f4f28e019b69b455f78fa9a548ffead03fa2354","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            # Ubuntu 12.04 - Apache 2.2"},{"line_number":115,"context_line":"            echo $APACHE_CONF_DIR/${site}"},{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # Ubuntu 14.04 - Apache 2.4"},{"line_number":118,"context_line":"            echo $APACHE_CONF_DIR/${site}.conf"},{"line_number":119,"context_line":"        fi"},{"line_number":120,"context_line":"    elif is_fedora || is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1abeadc6_3f48795b","line":117,"updated":"2014-08-28 19:30:16.000000000","message":"It might be good to change this to check for 2.4 and bail if not for futureproofing, but it\u0027s not imperative since the version check guarantees only the two.","commit_id":"d074dc7f7e37c8ff1ce781f0bbc7f88196567f00"}],"lib/keystone":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cdd265622915b287886703055f1cd74e97fb4ec1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    local keystone_apache_conf\u003d$(apache_site_config_for keystone)"},{"line_number":126,"context_line":"    local apache_version\u003d$(get_apache_version)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if [[ \"$apache_version\" \u003d\u003d \"2.4\" ]]; then"},{"line_number":129,"context_line":"        # Apache 2.4 supports custom error log formats"},{"line_number":130,"context_line":"        # this should mirror the original log formatting."},{"line_number":131,"context_line":"        local errorlogformat\u003d\u0027ErrorLogFormat \"%{cu}t %M\"\u0027"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_9bbb810e","line":128,"updated":"2014-08-28 04:32:23.000000000","message":"I\u0027d rather see this future-proofed.\n\nif [[ $(echo $apache_version | cut -d \".\" -f 2-) -ge 4 ]]; then ... ?","commit_id":"451892f221f36717c8966d4f9e0731c76ef2d929"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4e900c0fc0d133d9a1bc8d2d76f5195986e99e2a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    local keystone_apache_conf\u003d$(apache_site_config_for keystone)"},{"line_number":126,"context_line":"    local apache_version\u003d$(get_apache_version)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if [[ \"$apache_version\" \u003d\u003d \"2.4\" ]]; then"},{"line_number":129,"context_line":"        # Apache 2.4 supports custom error log formats"},{"line_number":130,"context_line":"        # this should mirror the original log formatting."},{"line_number":131,"context_line":"        local errorlogformat\u003d\u0027ErrorLogFormat \"%{cu}t %M\"\u0027"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_db909945","line":128,"in_reply_to":"1abeadc6_9bbb810e","updated":"2014-08-28 04:46:49.000000000","message":"Done in next.","commit_id":"451892f221f36717c8966d4f9e0731c76ef2d929"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"eaeb9b181eb1f6814b251992d9651372933ae6c7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    local keystone_apache_conf\u003d$(apache_site_config_for keystone)"},{"line_number":126,"context_line":"    local apache_version\u003d$(get_apache_version)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if [[ \"$apache_version\" \u003d\u003d \"2.4\" ]]; then"},{"line_number":129,"context_line":"        # Apache 2.4 supports custom error log formats"},{"line_number":130,"context_line":"        # this should mirror the original log formatting."},{"line_number":131,"context_line":"        local errorlogformat\u003d\u0027ErrorLogFormat \"%{cu}t %M\"\u0027"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_beb82b12","line":128,"in_reply_to":"1abeadc6_9bbb810e","updated":"2014-08-28 05:18:59.000000000","message":"Or even simpler:\n\n if [[ ${apache_version#*\\.} -ge 4 ]]; then ...","commit_id":"451892f221f36717c8966d4f9e0731c76ef2d929"}]}