)]}'
{"lib/neutron":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"66c96cf80163a50b17f7bf1e9a0ffb169b3621a8","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        neutron_ovs_base_cleanup"},{"line_number":573,"context_line":"    fi"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    # delete all namespaces created by neutron"},{"line_number":576,"context_line":"    for ns in $(sudo ip netns list | grep -o -E \u0027(qdhcp|qrouter|qlbaas)-[0-9a-f-]*\u0027); do"},{"line_number":577,"context_line":"        sudo ip netns delete ${ns}"},{"line_number":578,"context_line":"    done"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_9fab9b1d","line":575,"updated":"2014-07-10 15:29:52.000000000","message":"Need to include the snat- and fip- namespaces in the cleanup of neutron.  The cleanup_neutron function is called during unstack.sh.","commit_id":"5c23ed380465e502df94dd4c492da8a27b48e675"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"40f2e48cf769adc45e2eae8765af5261cfe3f2a1","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"function _configure_dvr {"},{"line_number":755,"context_line":"    iniset $NEUTRON_CONF DEFAULT router_distributed True"},{"line_number":756,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT agent_mode dvr_snat"},{"line_number":757,"context_line":"}"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_f2613ed4","line":756,"updated":"2014-07-10 06:31:55.000000000","message":"I think agent_mode should be configurable to allow compute node be set to dvr instead of dvr_snat?","commit_id":"5c23ed380465e502df94dd4c492da8a27b48e675"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"e4b8c1aef4118af5476c139c602cd4de26d47269","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"function _configure_dvr {"},{"line_number":755,"context_line":"    iniset $NEUTRON_CONF DEFAULT router_distributed True"},{"line_number":756,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT agent_mode dvr_snat"},{"line_number":757,"context_line":"}"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_7ee88c7c","line":756,"in_reply_to":"baada198_687c56ec","updated":"2014-07-10 14:41:21.000000000","message":"These changes are not necessary.  The settings of these parameters can be done  in local.conf.  There is no need to add code.  For example, in my local.conf file:\n\n [[local|localrc]]\n\n... Items in localrc goes here.\n\n [[post-config|$NEUTRON_CONF]] \n [DEFAULT]\n router_distributed \u003d True\n\n [[post-config|$Q_L3_CONF_FILE]]\n [DEFAULT]\n router_delete_namespaces \u003d True\n agent_mode \u003d dvr_snat\n\n\n...","commit_id":"5c23ed380465e502df94dd4c492da8a27b48e675"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"521cdca6ff97b501a0979d4d3fd99e386f84261f","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"function _configure_dvr {"},{"line_number":755,"context_line":"    iniset $NEUTRON_CONF DEFAULT router_distributed True"},{"line_number":756,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT agent_mode dvr_snat"},{"line_number":757,"context_line":"}"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_dc46014f","line":756,"in_reply_to":"baada198_7ee88c7c","updated":"2014-07-10 14:44:49.000000000","message":"Also in my local.conf file (forgot to add them) to my previous comment:\n\n [[post-config|/$Q_PLUGIN_CONF_FILE]]\n [ovs]\n local_ip\u003d10.133.10.179\n\n [agent]\n l2_population\u003dTrue\n tunnel_types\u003dvxlan\n enable_distributed_routing\u003dTrue","commit_id":"5c23ed380465e502df94dd4c492da8a27b48e675"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ac182f110684da59686c64f6777054d888d61b48","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"function _configure_dvr {"},{"line_number":755,"context_line":"    iniset $NEUTRON_CONF DEFAULT router_distributed True"},{"line_number":756,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT agent_mode dvr_snat"},{"line_number":757,"context_line":"}"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_687c56ec","line":756,"in_reply_to":"baada198_f2613ed4","updated":"2014-07-10 13:45:33.000000000","message":"Yes, this was just a first draft to hardcode things for single node. Will be doing changes for multinode in next patch.","commit_id":"5c23ed380465e502df94dd4c492da8a27b48e675"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"8f78c8626a1e4c16f845b140934c4f8dd7a63a44","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        neutron_ovs_base_cleanup"},{"line_number":579,"context_line":"    fi"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    # delete all namespaces created by neutron"},{"line_number":582,"context_line":"    for ns in $(sudo ip netns list | grep -o -E \u0027(qdhcp|qrouter|qlbaas)-[0-9a-f-]*\u0027); do"},{"line_number":583,"context_line":"        sudo ip netns delete ${ns}"},{"line_number":584,"context_line":"    done"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"baada198_71027670","line":581,"updated":"2014-07-11 04:26:04.000000000","message":"The change made here in PS9 is gone. To repeat, the snat and fip namespaces needs to be deleted also during cleanup.","commit_id":"7b6e727b9aea8ddbacc6798fc587fe258d9461ed"}],"stackrc":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d583b3592b71c7a13d1c4ea150e4fd0a32c37c1a","unresolved":false,"context_lines":[{"line_number":404,"context_line":"NEUTRON_BRANCH\u003d\"master\""},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"TEMPEST_REPO\u003d\"http://review.openstack.org/p/openstack/tempest.git\""},{"line_number":407,"context_line":"TEMPEST_BRANCH\u003d\"ee1e578bf3fa1ba16fe3d9d321f6de6ca8ac766d\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"baada198_bc1c10c3","line":407,"updated":"2014-07-09 19:04:08.000000000","message":"A fresh clone doesn\u0027t have this commit.  However, if I put refs/changes/35/98235/1 here instead of the raw commit id then devstack figures out that it should request it and it works.\n\nSo, change this to refs/changes/35/98235/1","commit_id":"7d6c7f33da2bcc448bef2ab99e98fb846dc7df5e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8383184481a58769c1715fd1e2e6553db9ae8fd3","unresolved":false,"context_lines":[{"line_number":435,"context_line":"# mode: shell-script"},{"line_number":436,"context_line":"# End:"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"NEUTRON_REPO\u003d\"https://github.com/ecbaldwin/neutron-dvr.git\""},{"line_number":439,"context_line":"NEUTRON_BRANCH\u003d\"master\""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"TEMPEST_REPO\u003d\"http://review.openstack.org/p/openstack/tempest.git\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baada198_12f7dc5a","line":438,"updated":"2014-07-15 18:56:46.000000000","message":"Is it a bit premature to remove this?  I think some might still find this useful until the dvr code merges.","commit_id":"891bc106304c5994992ccc387b8e76a9df6a1226"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"98ef1f97f4b74c3693fd081f7aa5f88fc12fd676","unresolved":false,"context_lines":[{"line_number":435,"context_line":"# mode: shell-script"},{"line_number":436,"context_line":"# End:"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"NEUTRON_REPO\u003d\"https://github.com/ecbaldwin/neutron-dvr.git\""},{"line_number":439,"context_line":"NEUTRON_BRANCH\u003d\"master\""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"TEMPEST_REPO\u003d\"http://review.openstack.org/p/openstack/tempest.git\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baada198_bf6518e4","line":438,"in_reply_to":"baada198_12f7dc5a","updated":"2014-07-15 19:00:45.000000000","message":"fair point,I wonder whether we should add this on dependent patch and leave this clean and free to merge","commit_id":"891bc106304c5994992ccc387b8e76a9df6a1226"}]}