)]}'
{"lib/trove":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ff416e6cedf5c8f9b5c8021d6a2a4a1460a45c69","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    [ -z \"$TROVE_GUEST_IMAGE_URL\"] \u0026\u0026 return 0"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # Find the glance id for the trove-guest image"},{"line_number":209,"context_line":"    GUEST_IMAGE_NAME\u003d$(basename \"$TROVE_GUEST_IMAGE_URL\")"},{"line_number":210,"context_line":"    GUEST_IMAGE_NAME\u003d${GUEST_IMAGE_NAME%.*}"},{"line_number":211,"context_line":"    TROVE_GUEST_IMAGE_ID\u003d$(glance --os-auth-token $TOKEN image-list | grep \"${GUEST_IMAGE_NAME}\" | get_field 1)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_48da19ea","line":208,"updated":"2014-07-18 00:48:06.000000000","message":"it might be nice to point out that it was uploaded as part of the other image uploads, just for clarity","commit_id":"7e0f0e0a861fbb9c133f7020265655a377760445"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"a73fef2d72cacb5ef69ed486e75e0bcb905ba563","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # Initialize the trove database"},{"line_number":204,"context_line":"    $TROVE_BIN_DIR/trove-manage db_sync"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    [ -z \"$TROVE_GUEST_IMAGE_URL\"] \u0026\u0026 return 0"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # Find the glance id for the trove-guest image"},{"line_number":209,"context_line":"    GUEST_IMAGE_NAME\u003d$(basename \"$TROVE_GUEST_IMAGE_URL\")"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_c7532f6a","line":206,"updated":"2014-07-21 08:48:57.000000000","message":"If function return here then lines 217-223 will never executed. Is this ok?","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"e5ffcaa861ab20faf760ef979d493e8b4540b5e0","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # Initialize the trove database"},{"line_number":204,"context_line":"    $TROVE_BIN_DIR/trove-manage db_sync"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    [ -z \"$TROVE_GUEST_IMAGE_URL\"] \u0026\u0026 return 0"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # Find the glance id for the trove-guest image"},{"line_number":209,"context_line":"    GUEST_IMAGE_NAME\u003d$(basename \"$TROVE_GUEST_IMAGE_URL\")"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_60d30601","line":206,"in_reply_to":"baada198_c7532f6a","updated":"2014-07-22 13:59:13.000000000","message":"That\u0027s correct. The steps we are skipping below depend on there being a trove guest image in glance. Here I\u0027m assuming that if TROVE_GUEST_IMAGE_URL is not set we just skip those steps and move on.","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"350109b13a435eee61f57e964ccbb2a6f27cba4a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    # Find the glance id for the trove-guest image"},{"line_number":209,"context_line":"    GUEST_IMAGE_NAME\u003d$(basename \"$TROVE_GUEST_IMAGE_URL\")"},{"line_number":210,"context_line":"    GUEST_IMAGE_NAME\u003d${GUEST_IMAGE_NAME%.*}"},{"line_number":211,"context_line":"    TROVE_GUEST_IMAGE_ID\u003d$(glance --os-auth-token $TOKEN image-list | grep \"${GUEST_IMAGE_NAME}\" | get_field 1)"},{"line_number":212,"context_line":"    if [ -z \"$TROVE_GUEST_IMAGE_ID\" ]; then"},{"line_number":213,"context_line":"        echo \"Datastore ${TROVE_DATASTORE_TYPE} will not be created: guest image ${GUEST_IMAGE_NAME} not found.\""},{"line_number":214,"context_line":"        return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_b9b8c976","line":211,"updated":"2014-07-22 14:08:16.000000000","message":"If you use --os-auth-token you should also use --os-image-url here","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"a73fef2d72cacb5ef69ed486e75e0bcb905ba563","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    TROVE_GUEST_IMAGE_ID\u003d$(glance --os-auth-token $TOKEN image-list | grep \"${GUEST_IMAGE_NAME}\" | get_field 1)"},{"line_number":212,"context_line":"    if [ -z \"$TROVE_GUEST_IMAGE_ID\" ]; then"},{"line_number":213,"context_line":"        echo \"Datastore ${TROVE_DATASTORE_TYPE} will not be created: guest image ${GUEST_IMAGE_NAME} not found.\""},{"line_number":214,"context_line":"        return 1"},{"line_number":215,"context_line":"    fi"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # Initialize appropriate datastores / datastore versions"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_074a87ac","line":214,"updated":"2014-07-21 08:48:57.000000000","message":"Same here.","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"350109b13a435eee61f57e964ccbb2a6f27cba4a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    TROVE_GUEST_IMAGE_ID\u003d$(glance --os-auth-token $TOKEN image-list | grep \"${GUEST_IMAGE_NAME}\" | get_field 1)"},{"line_number":212,"context_line":"    if [ -z \"$TROVE_GUEST_IMAGE_ID\" ]; then"},{"line_number":213,"context_line":"        echo \"Datastore ${TROVE_DATASTORE_TYPE} will not be created: guest image ${GUEST_IMAGE_NAME} not found.\""},{"line_number":214,"context_line":"        return 1"},{"line_number":215,"context_line":"    fi"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # Initialize appropriate datastores / datastore versions"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_7965511c","line":214,"in_reply_to":"baada198_00f96a7f","updated":"2014-07-22 14:08:16.000000000","message":"Thanks Greg, I wondered the same thing.  A comment below would be helpful so I don\u0027t try to \u0027fix\u0027 it later...","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"e5ffcaa861ab20faf760ef979d493e8b4540b5e0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    TROVE_GUEST_IMAGE_ID\u003d$(glance --os-auth-token $TOKEN image-list | grep \"${GUEST_IMAGE_NAME}\" | get_field 1)"},{"line_number":212,"context_line":"    if [ -z \"$TROVE_GUEST_IMAGE_ID\" ]; then"},{"line_number":213,"context_line":"        echo \"Datastore ${TROVE_DATASTORE_TYPE} will not be created: guest image ${GUEST_IMAGE_NAME} not found.\""},{"line_number":214,"context_line":"        return 1"},{"line_number":215,"context_line":"    fi"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # Initialize appropriate datastores / datastore versions"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_00f96a7f","line":214,"in_reply_to":"baada198_074a87ac","updated":"2014-07-22 13:59:13.000000000","message":"Same as above, this is intentional. The skipped lines would fail without a guest image glance id.","commit_id":"e2a53545f5de8d4b0cc1430531b8981128c3e77c"}]}