)]}'
{"lib/neutron":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c66b92bdd8346552c262a5dcb3863eb1e2865ab5","unresolved":false,"context_lines":[{"line_number":797,"context_line":"    # ensure that an agent\u0027s configuration can override the default"},{"line_number":798,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE agent root_helper \"$Q_RR_COMMAND\""},{"line_number":799,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" !\u003d \"False\" ]]; then"},{"line_number":800,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE  agent use_rootwrap_daemon \"True\""},{"line_number":801,"context_line":"    fi"},{"line_number":802,"context_line":"    iniset $NEUTRON_CONF DEFAULT verbose True"},{"line_number":803,"context_line":"    iniset $NEUTRON_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_aea08843","line":800,"updated":"2014-07-29 10:25:17.000000000","message":"all those agents probably read /etc/neutron/neutron.conf, so why not setting it once there?","commit_id":"d6230e84420c40873c23697315ba587de0682e45"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"eca47c0b224a7659168870d964c207d0544f4bd2","unresolved":false,"context_lines":[{"line_number":797,"context_line":"    # ensure that an agent\u0027s configuration can override the default"},{"line_number":798,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE agent root_helper \"$Q_RR_COMMAND\""},{"line_number":799,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" !\u003d \"False\" ]]; then"},{"line_number":800,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE  agent use_rootwrap_daemon \"True\""},{"line_number":801,"context_line":"    fi"},{"line_number":802,"context_line":"    iniset $NEUTRON_CONF DEFAULT verbose True"},{"line_number":803,"context_line":"    iniset $NEUTRON_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_04b5d331","line":800,"in_reply_to":"baada198_aea08843","updated":"2014-07-29 11:09:34.000000000","message":"All other config variable are set separately for every agent. I decided to follow this approach. We probably can save some space by ensuring all those options are set in the neutron.conf but I think it\u0027s a matter for a separate change.","commit_id":"d6230e84420c40873c23697315ba587de0682e45"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c66b92bdd8346552c262a5dcb3863eb1e2865ab5","unresolved":false,"context_lines":[{"line_number":906,"context_line":"    # Update the root_helper"},{"line_number":907,"context_line":"    iniset $NEUTRON_CONF agent root_helper \"$Q_RR_COMMAND\""},{"line_number":908,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" !\u003d \"False\" ]]; then"},{"line_number":909,"context_line":"        iniset $NEUTRON_CONF agent use_rootwrap_daemon \"True\""},{"line_number":910,"context_line":"    fi"},{"line_number":911,"context_line":"}"},{"line_number":912,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_0ea6d454","line":909,"updated":"2014-07-29 10:25:17.000000000","message":"this is probably enough for all agents to catch the setting?","commit_id":"d6230e84420c40873c23697315ba587de0682e45"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"325a36471db7574412bad85c8c3279953ceca764","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"    sudo chmod 0644 $Q_RR_CONF_FILE"},{"line_number":1127,"context_line":"    # Specify ``rootwrap.conf`` as first parameter to neutron-rootwrap"},{"line_number":1128,"context_line":"    ROOTWRAP_SUDOER_CMD\u003d\"$NEUTRON_ROOTWRAP $Q_RR_CONF_FILE *\""},{"line_number":1129,"context_line":"    ROOTWRAP_DAEMON_SUDOER_CMD\u003d\"$NEUTRON_ROOTWRAP-daemon $Q_RR_CONF_FILE *\""},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"    # Set up the rootwrap sudoers for neutron"},{"line_number":1132,"context_line":"    TEMPFILE\u003d`mktemp`"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a80dd14_06390141","line":1129,"updated":"2015-03-12 16:06:23.000000000","message":"I don\u0027t think this should not have the trailing *","commit_id":"d91d0e840dae3cfd1f148aeea99822900137299e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68dbd2a465dc2f468c3430d99463c9451fd32dc8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"# RHEL\u0027s support for namespaces requires using veths with ovs"},{"line_number":154,"context_line":"Q_OVS_USE_VETH\u003d${Q_OVS_USE_VETH:-False}"},{"line_number":155,"context_line":"Q_USE_ROOTWRAP\u003d${Q_USE_ROOTWRAP:-True}"},{"line_number":156,"context_line":"Q_USE_ROOTWRAP_DAEMON\u003d${Q_USE_ROOTWRAP_DAEMON:-True}"},{"line_number":157,"context_line":"# Meta data IP"},{"line_number":158,"context_line":"Q_META_DATA_IP\u003d${Q_META_DATA_IP:-$SERVICE_HOST}"},{"line_number":159,"context_line":"# Allow Overlapping IP among subnets"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a80dd14_1a67fcb8","line":156,"updated":"2015-03-16 21:40:56.000000000","message":"use trueorfalse for easier setting","commit_id":"3805bda8ef27f1bdb57a71790ab06f26ef2bd323"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"390fc786a6a62dd07961e21c2deec6990f3bdbac","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Q_RR_CONF_FILE\u003d$NEUTRON_CONF_DIR/rootwrap.conf"},{"line_number":225,"context_line":"Q_RR_DAEMON_COMMAND\u003d\"\""},{"line_number":226,"context_line":"if [[ \"$Q_USE_ROOTWRAP\" \u003d\u003d \"False\" ]]; then"},{"line_number":227,"context_line":"    Q_RR_COMMAND\u003d\"sudo\""},{"line_number":228,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a80dd14_a73c34e2","line":225,"updated":"2015-03-16 14:45:00.000000000","message":"(nit) This line isn\u0027t necessary.","commit_id":"3805bda8ef27f1bdb57a71790ab06f26ef2bd323"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68dbd2a465dc2f468c3430d99463c9451fd32dc8","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Q_RR_CONF_FILE\u003d$NEUTRON_CONF_DIR/rootwrap.conf"},{"line_number":225,"context_line":"Q_RR_DAEMON_COMMAND\u003d\"\""},{"line_number":226,"context_line":"if [[ \"$Q_USE_ROOTWRAP\" \u003d\u003d \"False\" ]]; then"},{"line_number":227,"context_line":"    Q_RR_COMMAND\u003d\"sudo\""},{"line_number":228,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a80dd14_5a9ed4b9","line":225,"updated":"2015-03-16 21:40:56.000000000","message":"please remove, it can\u0027t be used uninitialised","commit_id":"3805bda8ef27f1bdb57a71790ab06f26ef2bd323"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"42ff694165289293b2705e9be3249d4b7979870b","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Q_RR_CONF_FILE\u003d$NEUTRON_CONF_DIR/rootwrap.conf"},{"line_number":225,"context_line":"Q_RR_DAEMON_COMMAND\u003d\"\""},{"line_number":226,"context_line":"if [[ \"$Q_USE_ROOTWRAP\" \u003d\u003d \"False\" ]]; then"},{"line_number":227,"context_line":"    Q_RR_COMMAND\u003d\"sudo\""},{"line_number":228,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a80dd14_0a4ee037","line":225,"in_reply_to":"9a80dd14_a73c34e2","updated":"2015-03-16 16:01:24.000000000","message":"Yeah, it isn\u0027t. I just don\u0027t like usage of uninitialized variables :)","commit_id":"3805bda8ef27f1bdb57a71790ab06f26ef2bd323"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68dbd2a465dc2f468c3430d99463c9451fd32dc8","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    iniset $NEUTRON_TEST_CONFIG_FILE DEFAULT debug False"},{"line_number":902,"context_line":"    iniset $NEUTRON_TEST_CONFIG_FILE DEFAULT use_namespaces $Q_USE_NAMESPACE"},{"line_number":903,"context_line":"    iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper \"$Q_RR_COMMAND\""},{"line_number":904,"context_line":"    if [[ \"$Q_USE_ROOTWRAP_DAEMON\" !\u003d \"False\" ]]; then"},{"line_number":905,"context_line":"        iniset $NEUTRON_TEST_CONFIG_FILE agent root_helper_daemon \"$Q_RR_DAEMON_COMMAND\""},{"line_number":906,"context_line":"    fi"},{"line_number":907,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a80dd14_7a3f1888","line":904,"updated":"2015-03-16 21:40:56.000000000","message":"nit, but please make this and other instances \"\u003d\u003d True\" ... it reads clearer than \"not False\" and reliable with trueorfalse","commit_id":"3805bda8ef27f1bdb57a71790ab06f26ef2bd323"}]}