)]}'
{"lib/neutron":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"026152bd5baf89b51ea12440de8ec185ad35fdd6","unresolved":false,"context_lines":[{"line_number":457,"context_line":"function create_neutron_accounts {"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    local service_tenant\u003d$(openstack project list | awk \"/ $SERVICE_TENANT_NAME / { print \\$2 }\")"},{"line_number":460,"context_line":"    local admin_role\u003d$(openstack role list | awk \"/ service / { print \\$2 }\")"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \"q-svc\" ]]; then"},{"line_number":463,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_cf175da2","line":460,"updated":"2014-09-30 04:37:18.000000000","message":"The variable name \"admin_role\" is not correct for service role.","commit_id":"636f9fa36299bdfdb4505683e234090c3cd038c2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5ac6eea932ce24bcd91d556c4aff13c8bc40a655","unresolved":false,"context_lines":[{"line_number":457,"context_line":"function create_neutron_accounts {"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    local service_tenant\u003d$(openstack project list | awk \"/ $SERVICE_TENANT_NAME / { print \\$2 }\")"},{"line_number":460,"context_line":"    local admin_role\u003d$(openstack role list | awk \"/ service / { print \\$2 }\")"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \"q-svc\" ]]; then"},{"line_number":463,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_6f4e71c3","line":460,"in_reply_to":"baa201ad_cf175da2","updated":"2014-09-30 04:48:45.000000000","message":"I can rename this.","commit_id":"636f9fa36299bdfdb4505683e234090c3cd038c2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"026152bd5baf89b51ea12440de8ec185ad35fdd6","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    cp $NEUTRON_DIR/etc/policy.json $Q_POLICY_FILE"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    # allow service role to administer neutron to match neutron account"},{"line_number":893,"context_line":"    sed -i \u0027s/\"context_is_admin\":  \"role:admin\"/\"context_is_admin\":  \"role:admin or role:service\"/g\u0027 $Q_POLICY_FILE"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    # Update either configuration file with plugin"},{"line_number":896,"context_line":"    iniset $NEUTRON_CONF DEFAULT core_plugin $Q_PLUGIN_CLASS"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_cf659d46","line":893,"updated":"2014-09-30 04:37:18.000000000","message":"You should not add role:service to context_is_admin because the service role is not admin.","commit_id":"636f9fa36299bdfdb4505683e234090c3cd038c2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5ac6eea932ce24bcd91d556c4aff13c8bc40a655","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    cp $NEUTRON_DIR/etc/policy.json $Q_POLICY_FILE"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    # allow service role to administer neutron to match neutron account"},{"line_number":893,"context_line":"    sed -i \u0027s/\"context_is_admin\":  \"role:admin\"/\"context_is_admin\":  \"role:admin or role:service\"/g\u0027 $Q_POLICY_FILE"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    # Update either configuration file with plugin"},{"line_number":896,"context_line":"    iniset $NEUTRON_CONF DEFAULT core_plugin $Q_PLUGIN_CLASS"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_0fd7a5c2","line":893,"in_reply_to":"baa201ad_cf659d46","updated":"2014-09-30 04:48:45.000000000","message":"This \u0027context_is_admin\u0027 is used to determine who is allowed to administer neutron. In this case the service role is an admin. Perhaps I should be more explicit and match the neutron user directly.","commit_id":"636f9fa36299bdfdb4505683e234090c3cd038c2"}]}