)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exercise quantum v2 api without namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added quantum_v2.sh for quantum v2 api exerise."},{"line_number":10,"context_line":"Implements blueprint test-agent"},{"line_number":11,"context_line":"Note quantum will run non-namespace mode by defualt"},{"line_number":12,"context_line":"Please set Q_USE_NAMESPACE\u003dTrue if you want use namespace"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAALH%2F%2FqYs%3D","line":9,"updated":"2012-08-22 07:34:07.000000000","message":"typo","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Exercise quantum v2 api without namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added quantum_v2.sh for quantum v2 api exerise."},{"line_number":10,"context_line":"Implements blueprint test-agent"},{"line_number":11,"context_line":"Note quantum will run non-namespace mode by defualt"},{"line_number":12,"context_line":"Please set Q_USE_NAMESPACE\u003dTrue if you want use namespace"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAALH%2F%2FqYo%3D","line":10,"updated":"2012-08-22 07:34:07.000000000","message":"this diff no longer has test-agent.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added quantum_v2.sh for quantum v2 api exerise."},{"line_number":10,"context_line":"Implements blueprint test-agent"},{"line_number":11,"context_line":"Note quantum will run non-namespace mode by defualt"},{"line_number":12,"context_line":"Please set Q_USE_NAMESPACE\u003dTrue if you want use namespace"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5767f94c94187a4ca0fd189244fa6f5781519ab4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAALH%2F%2FqYk%3D","line":12,"updated":"2012-08-22 07:34:07.000000000","message":"this seems to be the opposite of what the code does.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"}],"exercises/quantum.sh":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"64dc04642c8b5372a66e9dfe37e00359734d21ef","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# Time to wait between boots to avoid overwhelming small systems"},{"line_number":69,"context_line":"INTER_BOOT_PAUSE\u003d${INTER_BOOT_PAUSE:-10}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Max time to wait while vm goes from build to active state"},{"line_number":72,"context_line":"ACTIVE_TIMEOUT\u003d${ACTIVE_TIMEOUT:-30}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Max time till the vm is bootable"}],"source_content_type":"text/x-sh","patch_set":4,"id":"AAAALH%2F%2F1Jo%3D","line":71,"updated":"2012-08-09 03:24:08.000000000","message":"sorry one last nit; lets remove these variables that are already set in exerciserc since we can\u0027t even set their value here.","commit_id":"b2d68b6cf426011ab23ad9240fa7d95612f9d961"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# If quantum is not enabled we exit with exitcode 55 which mean"},{"line_number":59,"context_line":"# exercise is skipped."},{"line_number":60,"context_line":"is_service_enabled quantum || exit 55"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#------------------------------------------------------------------------------"},{"line_number":63,"context_line":"# Test settings for quantum"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2Fqdg%3D","line":60,"updated":"2012-08-22 07:34:07.000000000","message":"script now probably depends on q-agt, and q-dhcp as well.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"PUBLIC_NET1_GATEWAY\u003d\"200.0.0.1\""},{"line_number":83,"context_line":"DEMO1_NET1_GATEWAY\u003d\"190.0.0.1\""},{"line_number":84,"context_line":"DEMO2_NET1_GATEWAY\u003d\"191.0.0.1\""},{"line_number":85,"context_line":"DEMO2_NET2_GATEWAY\u003d\"191.0.1.1\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"PUBLIC_NUM_VM\u003d1"},{"line_number":88,"context_line":"DEMO1_NUM_VM\u003d1"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2FqmU%3D","line":85,"updated":"2012-08-22 07:34:07.000000000","message":"these are all default, so there\u0027s not need to specify them, but it doesn\u0027t hurt.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        $NIC \\"},{"line_number":291,"context_line":"        $TENANT-server$NUM | grep \u0027 id \u0027 | cut -d\"|\" -f3 | sed \u0027s/ //g\u0027`"},{"line_number":292,"context_line":"    die_if_not_set VM_UUID \"Failure launching $TENANT-server$NUM\" VM_UUID"},{"line_number":293,"context_line":"    sleep $BOOT_TIMEOUT"},{"line_number":294,"context_line":"    confirm_server_active $VM_UUID"},{"line_number":295,"context_line":"}"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2Fqdw%3D","line":293,"updated":"2012-08-22 07:34:07.000000000","message":"I don\u0027t see a need for a static boot sleep, if we can also specify how long we wat for the server to become active, and also how long we wait for the ping to succeed.  Both of those sleeps will short-circuit when successful, which seems much better.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"function ping_ip {"},{"line_number":302,"context_line":"   # Test agent connection"},{"line_number":303,"context_line":"   #TODO(nati) Now namesapce supprot is merged. We can\u0027t ping to the server without test-agent."},{"line_number":304,"context_line":"   local VM_NAME\u003d$1"},{"line_number":305,"context_line":"   nova  --no_cache show $VM_NAME | grep \u0027network\u0027 | awk \u0027{print $5}\u0027 | xargs -I% ping -c 1 -w 1  %"},{"line_number":306,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2FqfM%3D","line":303,"updated":"2012-08-22 07:34:07.000000000","message":"this comment isn\u0027t correct, assuming devstack is run with Q_USE_NAMESPACE\u003dFalse","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"   # Test agent connection"},{"line_number":303,"context_line":"   #TODO(nati) Now namesapce supprot is merged. We can\u0027t ping to the server without test-agent."},{"line_number":304,"context_line":"   local VM_NAME\u003d$1"},{"line_number":305,"context_line":"   nova  --no_cache show $VM_NAME | grep \u0027network\u0027 | awk \u0027{print $5}\u0027 | xargs -I% ping -c 1 -w 1  %"},{"line_number":306,"context_line":"}"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"function check_vm {"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2Fqd4%3D","line":305,"updated":"2012-08-22 07:34:07.000000000","message":"we should ping in a timeout loop, as we do in the old version of the script.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":308,"context_line":"function check_vm {"},{"line_number":309,"context_line":"    local TENANT\u003d$1"},{"line_number":310,"context_line":"    local NUM\u003d$2"},{"line_number":311,"context_line":"    local VM_NAME\u003d\"$TENANT-server$NUM\""},{"line_number":312,"context_line":"    ping_ip $VM_NAME"},{"line_number":313,"context_line":"    # TODO (nati) test ssh connection"},{"line_number":314,"context_line":"    # TODO (nati) test inter connection between vm"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2FqY4%3D","line":311,"updated":"2012-08-22 07:34:07.000000000","message":"we need to source creds here, in case the check if running standalone.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"function delete_networks {"},{"line_number":351,"context_line":"   foreach_tenant \u0027delete_network ${%TENANT%_NAME}\u0027"},{"line_number":352,"context_line":"   #TODO(nati) add secuirty group check after it is implemented"},{"line_number":353,"context_line":"   # source $TOP_DIR/openrc demo1 demo1"},{"line_number":354,"context_line":"   # nova secgroup-delete-rule default icmp -1 -1 0.0.0.0/0"},{"line_number":355,"context_line":"   # source $TOP_DIR/openrc demo2 demo2"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2FqmQ%3D","line":352,"updated":"2012-08-22 07:34:07.000000000","message":"this is really more of a testing thing, as we are planning on using nova security groups during Folsom, since quantum security groups won\u0027t be merged yet.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"}],"exercises/quantum/quantumtester/test-agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"efbc5b07041652f4aea7524ed8494871a31c0059","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def is_success(self):"},{"line_number":77,"context_line":"        return not self.fault"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def ping(self, network_id, ip_address):"},{"line_number":80,"context_line":"        #TODO (nati)_nampespace support"},{"line_number":81,"context_line":"        ret \u003d os.system(\u0027ping -c 1 %s\u0027 % ip_address)"},{"line_number":82,"context_line":"        if ret !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzU8%3D","line":79,"updated":"2012-08-10 20:53:07.000000000","message":"I would have this function take a timeout.","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4a63cbe45b650f6cfdf38b0a82da84326a8785ab","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def is_success(self):"},{"line_number":77,"context_line":"        return not self.fault"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def ping(self, network_id, ip_address):"},{"line_number":80,"context_line":"        #TODO (nati)_nampespace support"},{"line_number":81,"context_line":"        ret \u003d os.system(\u0027ping -c 1 %s\u0027 % ip_address)"},{"line_number":82,"context_line":"        if ret !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzNQ%3D","line":79,"in_reply_to":"AAAALH%2F%2FzU8%3D","updated":"2012-08-10 22:18:11.000000000","message":"I got it","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"efbc5b07041652f4aea7524ed8494871a31c0059","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return not self.fault"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def ping(self, network_id, ip_address):"},{"line_number":80,"context_line":"        #TODO (nati)_nampespace support"},{"line_number":81,"context_line":"        ret \u003d os.system(\u0027ping -c 1 %s\u0027 % ip_address)"},{"line_number":82,"context_line":"        if ret !\u003d 0:"},{"line_number":83,"context_line":"            self.fault \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzU4%3D","line":80,"updated":"2012-08-10 20:53:07.000000000","message":"mark\u0027s branch has now merged, so you should be able to put this in now (in fact, it will be necessary for things to work, I believe).","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4a63cbe45b650f6cfdf38b0a82da84326a8785ab","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return not self.fault"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def ping(self, network_id, ip_address):"},{"line_number":80,"context_line":"        #TODO (nati)_nampespace support"},{"line_number":81,"context_line":"        ret \u003d os.system(\u0027ping -c 1 %s\u0027 % ip_address)"},{"line_number":82,"context_line":"        if ret !\u003d 0:"},{"line_number":83,"context_line":"            self.fault \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzNU%3D","line":80,"in_reply_to":"AAAALH%2F%2FzU4%3D","updated":"2012-08-10 22:18:11.000000000","message":"I got it","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"efbc5b07041652f4aea7524ed8494871a31c0059","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_connection_all_network(self):"},{"line_number":100,"context_line":"        for network_in_db in self.db.networks.all():"},{"line_number":101,"context_line":"            network \u003d AugmentingWrapper("},{"line_number":102,"context_line":"                self.db.networks.filter_by(id\u003dnetwork_in_db.id).one(),"},{"line_number":103,"context_line":"                self.db"},{"line_number":104,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzVY%3D","line":101,"updated":"2012-08-10 20:53:07.000000000","message":"this code should just use the quantum API to grab all networks, that way you don\u0027t need to use the DB at all, and can get rid of all of the AugmentingWrapper stuff.","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4a63cbe45b650f6cfdf38b0a82da84326a8785ab","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_connection_all_network(self):"},{"line_number":100,"context_line":"        for network_in_db in self.db.networks.all():"},{"line_number":101,"context_line":"            network \u003d AugmentingWrapper("},{"line_number":102,"context_line":"                self.db.networks.filter_by(id\u003dnetwork_in_db.id).one(),"},{"line_number":103,"context_line":"                self.db"},{"line_number":104,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzNY%3D","line":101,"in_reply_to":"AAAALH%2F%2FzVY%3D","updated":"2012-08-10 22:18:11.000000000","message":"Unfortunately, If we wanna use BridgeDriver in dhcp-gent, we should to that.","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"efbc5b07041652f4aea7524ed8494871a31c0059","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _create_port(self, network):"},{"line_number":130,"context_line":"        # todo (mark): reimplement using RPC"},{"line_number":131,"context_line":"        # Usage of client lib is a temporary measure."},{"line_number":132,"context_line":"        quantum \u003d self.get_quantum_client()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        body \u003d dict(port\u003ddict("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzVU%3D","line":131,"updated":"2012-08-10 20:53:07.000000000","message":"i\u0027d remove this comment.  Using API here is the right solution in my opinion.","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"efbc5b07041652f4aea7524ed8494871a31c0059","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return port"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class AugmentingWrapper(object):"},{"line_number":150,"context_line":"    \"\"\"A wrapper that augments Sqlsoup results so that they look like the"},{"line_number":151,"context_line":"    base v2 db model."},{"line_number":152,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FzVM%3D","line":149,"updated":"2012-08-10 20:53:07.000000000","message":"this class can be removed, I think, given my above comment.","commit_id":"f8dd57c00473e920456bfc982c358f5b4ff892e1"}],"exercises/quantum_v2.sh":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"ecbb5d65b0fea1a4591549f807e29f50bbadf121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# **quantum.sh**"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# We will use this test to perform integration testing of nova and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1YQ%3D","line":3,"updated":"2012-08-08 20:34:24.000000000","message":"now that we have removed v1 support, can you rename this so that it replaces the original quantum.sh script?","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# **quantum.sh**"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# We will use this test to perform integration testing of nova and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1ME%3D","line":3,"in_reply_to":"AAAALH%2F%2F1YQ%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"ecbb5d65b0fea1a4591549f807e29f50bbadf121","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    local r\u003d$?"},{"line_number":20,"context_line":"    set +o errtrace"},{"line_number":21,"context_line":"    set +o xtrace"},{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1YI%3D","line":22,"updated":"2012-08-08 20:34:24.000000000","message":"Failed","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    local r\u003d$?"},{"line_number":20,"context_line":"    set +o errtrace"},{"line_number":21,"context_line":"    set +o xtrace"},{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1MA%3D","line":22,"in_reply_to":"AAAALH%2F%2F1YI%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"ecbb5d65b0fea1a4591549f807e29f50bbadf121","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    set +o errtrace"},{"line_number":21,"context_line":"    set +o xtrace"},{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""},{"line_number":26,"context_line":"    exit $r"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1YM%3D","line":23,"updated":"2012-08-08 20:34:24.000000000","message":"Starting","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    set +o errtrace"},{"line_number":21,"context_line":"    set +o xtrace"},{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""},{"line_number":26,"context_line":"    exit $r"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1L8%3D","line":23,"in_reply_to":"AAAALH%2F%2F1YM%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"ecbb5d65b0fea1a4591549f807e29f50bbadf121","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""},{"line_number":26,"context_line":"    exit $r"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1YE%3D","line":25,"updated":"2012-08-08 20:34:24.000000000","message":"Finished","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    echo \"Faild to execute\""},{"line_number":23,"context_line":"    echo \"Staring cleanup...\""},{"line_number":24,"context_line":"    delete_all"},{"line_number":25,"context_line":"    echo \"Finish cleanup\""},{"line_number":26,"context_line":"    exit $r"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1L4%3D","line":25,"in_reply_to":"AAAALH%2F%2F1YE%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"67bc66b2b38c27be6c1f144b13cbeb4308c3c2cc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#------------------------------------------------------------------------------"},{"line_number":95,"context_line":"# Nova settings."},{"line_number":96,"context_line":"#------------------------------------------------------------------------------"},{"line_number":97,"context_line":"NOVA_MANAGE\u003d/opt/stack/nova/bin/nova-manage"},{"line_number":98,"context_line":"NOVA\u003d/usr/local/bin/nova"},{"line_number":99,"context_line":"NOVA_CONF\u003d/etc/nova/nova.conf"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1WE%3D","line":97,"updated":"2012-08-09 00:19:32.000000000","message":"I believe in the previous comments it was mentioned to remove all these alias and use nova* directly.","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#------------------------------------------------------------------------------"},{"line_number":95,"context_line":"# Nova settings."},{"line_number":96,"context_line":"#------------------------------------------------------------------------------"},{"line_number":97,"context_line":"NOVA_MANAGE\u003d/opt/stack/nova/bin/nova-manage"},{"line_number":98,"context_line":"NOVA\u003d/usr/local/bin/nova"},{"line_number":99,"context_line":"NOVA_CONF\u003d/etc/nova/nova.conf"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1Lw%3D","line":97,"in_reply_to":"AAAALH%2F%2F1Mc%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#------------------------------------------------------------------------------"},{"line_number":95,"context_line":"# Nova settings."},{"line_number":96,"context_line":"#------------------------------------------------------------------------------"},{"line_number":97,"context_line":"NOVA_MANAGE\u003d/opt/stack/nova/bin/nova-manage"},{"line_number":98,"context_line":"NOVA\u003d/usr/local/bin/nova"},{"line_number":99,"context_line":"NOVA_CONF\u003d/etc/nova/nova.conf"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1L0%3D","line":97,"in_reply_to":"AAAALH%2F%2F1WE%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"7e555794ab66c42d1fcecd73130fb421ddc7fd52","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#------------------------------------------------------------------------------"},{"line_number":95,"context_line":"# Nova settings."},{"line_number":96,"context_line":"#------------------------------------------------------------------------------"},{"line_number":97,"context_line":"NOVA_MANAGE\u003d/opt/stack/nova/bin/nova-manage"},{"line_number":98,"context_line":"NOVA\u003d/usr/local/bin/nova"},{"line_number":99,"context_line":"NOVA_CONF\u003d/etc/nova/nova.conf"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1Mc%3D","line":97,"in_reply_to":"AAAALH%2F%2F1WE%3D","updated":"2012-08-09 00:20:53.000000000","message":"also... nova-manage is no longer used, so this can be removed.","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"67bc66b2b38c27be6c1f144b13cbeb4308c3c2cc","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    local NET_ID\u003d$(get_network_id $TENANT)"},{"line_number":279,"context_line":"    #TODO (nati) Add multi-nic test"},{"line_number":280,"context_line":"    #TODO (nati) Add public-net test"},{"line_number":281,"context_line":"    local VM_UUID\u003d`$NOVA boot --flavor $(get_flavor_id m1.tiny) \\"},{"line_number":282,"context_line":"        --image $(get_image_id) \\"},{"line_number":283,"context_line":"        --nic net-id\u003d$NET_ID \\"},{"line_number":284,"context_line":"        $TENANT-server$NUM | grep \u0027 id \u0027 | cut -d\"|\" -f3 | sed \u0027s/ //g\u0027`"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1WA%3D","line":281,"updated":"2012-08-09 00:19:32.000000000","message":"s/$NOVA/nova","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    local NET_ID\u003d$(get_network_id $TENANT)"},{"line_number":279,"context_line":"    #TODO (nati) Add multi-nic test"},{"line_number":280,"context_line":"    #TODO (nati) Add public-net test"},{"line_number":281,"context_line":"    local VM_UUID\u003d`$NOVA boot --flavor $(get_flavor_id m1.tiny) \\"},{"line_number":282,"context_line":"        --image $(get_image_id) \\"},{"line_number":283,"context_line":"        --nic net-id\u003d$NET_ID \\"},{"line_number":284,"context_line":"        $TENANT-server$NUM | grep \u0027 id \u0027 | cut -d\"|\" -f3 | sed \u0027s/ //g\u0027`"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1Ls%3D","line":281,"in_reply_to":"AAAALH%2F%2F1WA%3D","updated":"2012-08-09 00:56:55.000000000","message":"Done","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"67bc66b2b38c27be6c1f144b13cbeb4308c3c2cc","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    local IP\u003d$1"},{"line_number":297,"context_line":"    if ! timeout $BOOT_TIMEOUT sh -c \"while ! ping -c1 -w1 $IP; do sleep 1; done\"; then"},{"line_number":298,"context_line":"        echo \"Couldn\u0027t ping server\""},{"line_number":299,"context_line":"        exit 1"},{"line_number":300,"context_line":"    fi"},{"line_number":301,"context_line":"}"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1NI%3D","line":299,"updated":"2012-08-09 00:19:32.000000000","message":"I don\u0027t think we should exit here. I would rather this continue on so at the end of the script it undoes everything that it did.","commit_id":"2d800787429389bb5d50569c787810e22c926f52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"52ceebaeb735abd775ebec3765ebc447dc96a336","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    local IP\u003d$1"},{"line_number":297,"context_line":"    if ! timeout $BOOT_TIMEOUT sh -c \"while ! ping -c1 -w1 $IP; do sleep 1; done\"; then"},{"line_number":298,"context_line":"        echo \"Couldn\u0027t ping server\""},{"line_number":299,"context_line":"        exit 1"},{"line_number":300,"context_line":"    fi"},{"line_number":301,"context_line":"}"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAALH%2F%2F1Lo%3D","line":299,"in_reply_to":"AAAALH%2F%2F1NI%3D","updated":"2012-08-09 00:56:55.000000000","message":"Exception case is handled 18. So we can exit failed test.","commit_id":"2d800787429389bb5d50569c787810e22c926f52"}],"stack.sh":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":855,"context_line":"    else"},{"line_number":856,"context_line":"        # Set rsyslog to send to remote host"},{"line_number":857,"context_line":"        cat \u003c\u003cEOF \u003e/tmp/90-stack-s.conf"},{"line_number":858,"context_line":"*.*    :omrelp:$SYSLOG_HOST:$SYSLOG_PORT"},{"line_number":859,"context_line":"EOF"},{"line_number":860,"context_line":"        sudo mv /tmp/90-stack-s.conf /etc/rsyslog.d"},{"line_number":861,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2Fqf8%3D","line":858,"updated":"2012-08-22 07:34:07.000000000","message":"this seems unrelated, and if it needs to be fixed, should probably be fixed in a separate patch.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    # Update either configuration file with plugin"},{"line_number":1162,"context_line":"    iniset $Q_CONF_FILE DEFAULT core_plugin $Q_PLUGIN_CLASS"},{"line_number":1163,"context_line":"    iniset $Q_CONF_FILE DEFAULT core_plugin $Q_PLUGIN_CLASS"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"    iniset $Q_CONF_FILE DEFAULT auth_strategy $Q_AUTH_STRATEGY"},{"line_number":1166,"context_line":"    iniset $Q_API_PASTE_FILE filter:authtoken auth_host $KEYSTONE_SERVICE_HOST"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2FqY0%3D","line":1163,"updated":"2012-08-22 07:34:07.000000000","message":"why is this here twice?  seems like a bug.","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"8f787ab927834d5e862c3351450c51722bd6ec2f","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"        DISK_FORMAT\u003d\"\""},{"line_number":2187,"context_line":"        CONTAINER_FORMAT\u003d\"\""},{"line_number":2188,"context_line":"        UNPACK\u003d\"\""},{"line_number":2189,"context_line":""},{"line_number":2190,"context_line":"        case \"$IMAGE_FNAME\" in"},{"line_number":2191,"context_line":"            *.tar.gz|*.tgz)"},{"line_number":2192,"context_line":"                # Extract ami and aki files"}],"source_content_type":"text/x-sh","patch_set":12,"id":"AAAALH%2F%2Fqfw%3D","line":2189,"updated":"2012-08-22 07:34:07.000000000","message":"what is change here?  Just whitespace?","commit_id":"fefa33156bea6bba11265404b0dd1f07de8b4154"}]}