)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"65543da852b3a2a5f4e907df2705c975cb5abb44","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    mv ${tmpfile} ${policy_file}"},{"line_number":723,"context_line":"}"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"# Gets or creates user"},{"line_number":726,"context_line":"# Usage: get_or_create_user \u003cusername\u003e \u003cpassword\u003e \u003cproject\u003e \u003cemail\u003e"},{"line_number":727,"context_line":"function get_or_create_user {"},{"line_number":728,"context_line":"    # Gets user id"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_61f4e854","line":725,"updated":"2014-07-22 00:47:58.000000000","message":"please [\u003cemail\u003e] and note that it\u0027s optional","commit_id":"0e65bcebfd0e0d26f5a3c31f5266c144b9abe9c7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"65543da852b3a2a5f4e907df2705c975cb5abb44","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            $1 \\"},{"line_number":735,"context_line":"            --password \"$2\" \\"},{"line_number":736,"context_line":"            --project $3 \\"},{"line_number":737,"context_line":"            --email ${4:-\"\"} \\"},{"line_number":738,"context_line":"            -f value -c id"},{"line_number":739,"context_line":"    )"},{"line_number":740,"context_line":"    echo $USER_ID"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_c1413464","line":737,"updated":"2014-07-22 00:47:58.000000000","message":"Rather than setting this to the empty string, I think it would be better to check this and create a $EMAIL var that is either blank or has --email\u003d\"foo\".  I don\u0027t think empty string has any special semantics, but best to just keep it clean IMO","commit_id":"0e65bcebfd0e0d26f5a3c31f5266c144b9abe9c7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6b579e05a25c465cce4408977b28277f84651d5c","unresolved":false,"context_lines":[{"line_number":726,"context_line":"# Usage: get_or_create_user \u003cusername\u003e \u003cpassword\u003e \u003cproject\u003e [\u003cemail\u003e]"},{"line_number":727,"context_line":"function get_or_create_user {"},{"line_number":728,"context_line":"    if [[ ! -z \"$4\" ]]; then"},{"line_number":729,"context_line":"        EMAIL\u003d\"--email\u003d$4\""},{"line_number":730,"context_line":"    else"},{"line_number":731,"context_line":"        EMAIL\u003d\"\""},{"line_number":732,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_0a9312a5","line":729,"updated":"2014-07-22 15:13:28.000000000","message":"Would you mind using a local variable ? especially for such a common variable name.","commit_id":"8ec43eb8881cd76c2d0615b617a3f945c8680a19"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"33d4806c5a42e5172a8d5ed7ac6c18b462e326ef","unresolved":false,"context_lines":[{"line_number":723,"context_line":"}"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"# Gets or creates user"},{"line_number":726,"context_line":"# Usage: get_or_create_user \u003cusername\u003e \u003cpassword\u003e \u003cproject\u003e [\u003cemail\u003e]"},{"line_number":727,"context_line":"function get_or_create_user {"},{"line_number":728,"context_line":"    if [[ ! -z \"$4\" ]]; then"},{"line_number":729,"context_line":"        local EMAIL\u003d\"--email\u003d$4\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_b507ba17","line":726,"updated":"2014-07-23 08:20:28.000000000","message":"do we still need the \u003cemail\u003e since this not being used anywhere anymore with your patch?","commit_id":"6dd8a8bee402a6be683075e0669a010a279950ae"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"d86c6f2d00c935fbf8fd07b25bcc104d98ee1c55","unresolved":false,"context_lines":[{"line_number":723,"context_line":"}"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"# Gets or creates user"},{"line_number":726,"context_line":"# Usage: get_or_create_user \u003cusername\u003e \u003cpassword\u003e \u003cproject\u003e [\u003cemail\u003e]"},{"line_number":727,"context_line":"function get_or_create_user {"},{"line_number":728,"context_line":"    if [[ ! -z \"$4\" ]]; then"},{"line_number":729,"context_line":"        local EMAIL\u003d\"--email\u003d$4\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_8a5e1478","line":726,"in_reply_to":"baada198_b507ba17","updated":"2014-07-23 09:19:56.000000000","message":"This patch is just allowing users services to be created without email. For other user (like demo), they could have email during their creation.","commit_id":"6dd8a8bee402a6be683075e0669a010a279950ae"}]}