)]}'
{"lib/trove":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"8be3a0950c962fded0b46822fed98376cf4bacdc","unresolved":false,"context_lines":[{"line_number":237,"context_line":"function setup_trove_with_neutron {"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if is_service_enabled neutron; then"},{"line_number":240,"context_line":"        management_network_id\u003d$(neutron net-list | awk \u0027/private/ {print $2}\u0027)"},{"line_number":241,"context_line":"        management_subnet\u003d$(neutron net-list | awk \u0027/private/ {print $7}\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT network_label_regex .*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_f28db336","line":240,"updated":"2014-07-23 17:11:52.000000000","message":"You can use PRIVATE_NETWORK_NAME here.","commit_id":"0e85111eb942efe8ab629c78d38ee0fca79a173c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"8be3a0950c962fded0b46822fed98376cf4bacdc","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if is_service_enabled neutron; then"},{"line_number":240,"context_line":"        management_network_id\u003d$(neutron net-list | awk \u0027/private/ {print $2}\u0027)"},{"line_number":241,"context_line":"        management_subnet\u003d$(neutron net-list | awk \u0027/private/ {print $7}\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT network_label_regex .*"},{"line_number":244,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT ip_regex .*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_32980b75","line":241,"updated":"2014-07-23 17:11:52.000000000","message":"You can use PRIVATE_SUBNET_NAME here.","commit_id":"0e85111eb942efe8ab629c78d38ee0fca79a173c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"08f8bd785643dc081f07181d3d9987126fd60ae7","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if is_service_enabled neutron; then"},{"line_number":240,"context_line":"        management_network_id\u003d$(neutron net-list | awk \u0027/private/ {print $2}\u0027)"},{"line_number":241,"context_line":"        management_subnet\u003d$(neutron net-list | awk \u0027/private/ {print $7}\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT network_label_regex .*"},{"line_number":244,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT ip_regex .*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_913d4a2f","line":241,"in_reply_to":"baada198_32980b75","updated":"2014-07-24 09:13:54.000000000","message":"The management network id and subnet, are only needed for the Trove functional tests, so these should be created and set by the test code. Doesn\u0027t seem like this should be part of devstack.","commit_id":"0e85111eb942efe8ab629c78d38ee0fca79a173c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"95fa58f766ec6b4cecec4299571683eaadcefcff","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if is_service_enabled neutron; then"},{"line_number":240,"context_line":"        management_network_id\u003d$(neutron net-list | awk \u0027/private/ {print $2}\u0027)"},{"line_number":241,"context_line":"        management_subnet\u003d$(neutron net-list | awk \u0027/private/ {print $7}\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT network_label_regex .*"},{"line_number":244,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT ip_regex .*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_15111504","line":241,"in_reply_to":"baada198_913d4a2f","updated":"2014-07-24 10:58:14.000000000","message":"Disagree, once developers should be able to setup environment with enabled Neutron. \n\nJust wanted to raise an issue because there\u0027s no way to run Trove with enabled Neutron inside DevStack. And this code has nothing common with Trove integration testing. It\u0027s all about the variety of OpenStack deployments in the degree of Trove integration into it.\n\nFYI, there were lots of complains, raised issues related to missing abilities to run Trove with Neutron managed networks instead of Novas` networks.","commit_id":"0e85111eb942efe8ab629c78d38ee0fca79a173c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"08f8bd785643dc081f07181d3d9987126fd60ae7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT default_neutron_networks $management_network_id"},{"line_number":247,"context_line":"        iniset $TROVE_CONF_DIR/trove.conf DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":248,"context_line":"        iniset $TROVE_CONF_DIR/trove-taskmanager.conf DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":249,"context_line":"        iniset $TROVE_CONF_DIR/trove-taskmanager.conf mysql tcp_ports 22,3306"},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_fd556dfa","line":249,"updated":"2014-07-24 09:13:54.000000000","message":"Again, most of these values are needed only for running the functional/integration tests. No reason to set them all in devstack - since that would just be code bloat.","commit_id":"0e85111eb942efe8ab629c78d38ee0fca79a173c"}]}